Showing 5 of 6 total issues
File helpers.py
has 273 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
import json
from django import VERSION as DJANGO_VERSION
from django.contrib.gis.db.models.functions import Distance, LineLocatePoint
Function get_linestring
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
def get_linestring(self):
if self.routes:
way = MultiLineString(*[GEOSGeometry(route['geometry'])
for route in self.routes if isinstance(GEOSGeometry(route['geometry']),
LineString)])
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function wrapper
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def wrapper(self, from_point, to_point, *args, **kwargs):
Function update_topology
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def update_topology(cls, layer, features=None, tolerance=app_settings.GEOSTORE_ROUTING_TOLERANCE, clean=False):
Function route
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def route(self, request, pk=None):
layer = self.get_object()
data = request.data
serializer = self.serializer_class(data=data)
response_status = status.HTTP_200_OK
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"