Sign upLogin

TheSharpieOne/angular-validation-match

View on GitHub
Star

Showing 7 of 7 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    describe('not-match validation', function() {

      describe('behavior:', function() {
        var validTemplate = '<input ng-model="confirmation" match="original" not-match="true"></input>';
Severity: Major
Found in test/angular-input-match.spec.js and 2 other locations - About 4 days to fix
test/angular-input-match.spec.js on lines 113..191
test/angular-input-match.spec.js on lines 273..351

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 732.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    describe('caseless validation', function() {

      describe('behavior:', function() {
        var validTemplate = '<input ng-model="confirmation" match="original" match-caseless="true"></input>';
Severity: Major
Found in test/angular-input-match.spec.js and 2 other locations - About 4 days to fix
test/angular-input-match.spec.js on lines 193..271
test/angular-input-match.spec.js on lines 273..351

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 732.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    describe('not-match with caseless validation', function() {

      describe('behavior:', function() {
        var validTemplate = '<input ng-model="confirmation" match="original" match-caseless="true" not-match="true"></input>';
Severity: Major
Found in test/angular-input-match.spec.js and 2 other locations - About 4 days to fix
test/angular-input-match.spec.js on lines 113..191
test/angular-input-match.spec.js on lines 193..271

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 732.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File angular-input-match.spec.js has 336 lines of code (exceeds 250 allowed). Consider refactoring.
Open

describe('Directives: validation - match', function() {

    var $scope,
    $compile,
    compiled;
Severity: Minor
Found in test/angular-input-match.spec.js - About 4 hrs to fix

    Function match has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    function match ($parse) {
    return {
        require: '?ngModel',
        restrict: 'A',
        link: function(scope, elem, attrs, ctrl) {
    Severity: Minor
    Found in src/angular-validation-match.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function match has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function match ($parse) {
    return {
        require: '?ngModel',
        restrict: 'A',
        link: function(scope, elem, attrs, ctrl) {
    Severity: Minor
    Found in src/angular-validation-match.js - About 1 hr to fix

      Function link has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              link: function(scope, elem, attrs, ctrl) {
            if(!ctrl || !attrs.match) {
                return;
            }
      Severity: Minor
      Found in src/angular-validation-match.js - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language