TheSharpieOne/angular-validation-match

View on GitHub

Showing 4 of 7 total issues

File angular-input-match.spec.js has 336 lines of code (exceeds 250 allowed). Consider refactoring.
Open

describe('Directives: validation - match', function() {

    var $scope,
    $compile,
    compiled;
Severity: Minor
Found in test/angular-input-match.spec.js - About 4 hrs to fix

    Function match has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    function match ($parse) {
        return {
            require: '?ngModel',
            restrict: 'A',
            link: function(scope, elem, attrs, ctrl) {
    Severity: Minor
    Found in src/angular-validation-match.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function match has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function match ($parse) {
        return {
            require: '?ngModel',
            restrict: 'A',
            link: function(scope, elem, attrs, ctrl) {
    Severity: Minor
    Found in src/angular-validation-match.js - About 1 hr to fix

      Function link has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              link: function(scope, elem, attrs, ctrl) {
                  if(!ctrl || !attrs.match) {
                      return;
                  }
      
      
      Severity: Minor
      Found in src/angular-validation-match.js - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language