TryGhost/Ghost

View on GitHub
ghost/admin/app/validators/post.js

Summary

Maintainability
D
1 day
Test Coverage

Function publishedAtBlogDate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    publishedAtBlogDate(model) {
        let publishedAtBlogDate = model.publishedAtBlogDate;
        let publishedAtBlogTime = model.publishedAtBlogTime;

        if (!this._shouldValidatePublishedAtBlog(model)) {
Severity: Minor
Found in ghost/admin/app/validators/post.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    ogTitle(model) {
        if (!validator.isLength(model.ogTitle || '', 0, 300)) {
            model.errors.add('ogTitle', 'Facebook Title cannot be longer than 300 characters.');
            this.invalidate();
        }
Severity: Major
Found in ghost/admin/app/validators/post.js and 11 other locations - About 1 hr to fix
ghost/admin/app/validators/member.js on lines 8..13
ghost/admin/app/validators/offer.js on lines 57..62
ghost/admin/app/validators/post.js on lines 87..92
ghost/admin/app/validators/post.js on lines 94..99
ghost/admin/app/validators/post.js on lines 101..106
ghost/admin/app/validators/post.js on lines 108..113
ghost/admin/app/validators/post.js on lines 122..127
ghost/admin/app/validators/post.js on lines 129..134
ghost/admin/app/validators/post.js on lines 136..141
ghost/admin/app/validators/post.js on lines 143..148
ghost/admin/app/validators/post.js on lines 207..212

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    twitterTitle(model) {
        if (!validator.isLength(model.twitterTitle || '', 0, 300)) {
            model.errors.add('twitterTitle', 'Twitter Title cannot be longer than 300 characters.');
            this.invalidate();
        }
Severity: Major
Found in ghost/admin/app/validators/post.js and 11 other locations - About 1 hr to fix
ghost/admin/app/validators/member.js on lines 8..13
ghost/admin/app/validators/offer.js on lines 57..62
ghost/admin/app/validators/post.js on lines 87..92
ghost/admin/app/validators/post.js on lines 94..99
ghost/admin/app/validators/post.js on lines 101..106
ghost/admin/app/validators/post.js on lines 108..113
ghost/admin/app/validators/post.js on lines 115..120
ghost/admin/app/validators/post.js on lines 122..127
ghost/admin/app/validators/post.js on lines 136..141
ghost/admin/app/validators/post.js on lines 143..148
ghost/admin/app/validators/post.js on lines 207..212

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    codeinjectionFoot(model) {
        if (!validator.isLength(model.codeinjectionFoot || '', 0, 65535)) {
            model.errors.add('codeinjectionFoot', 'Footer code cannot be longer than 65535 characters.');
            this.invalidate();
        }
Severity: Major
Found in ghost/admin/app/validators/post.js and 11 other locations - About 1 hr to fix
ghost/admin/app/validators/member.js on lines 8..13
ghost/admin/app/validators/offer.js on lines 57..62
ghost/admin/app/validators/post.js on lines 94..99
ghost/admin/app/validators/post.js on lines 101..106
ghost/admin/app/validators/post.js on lines 108..113
ghost/admin/app/validators/post.js on lines 115..120
ghost/admin/app/validators/post.js on lines 122..127
ghost/admin/app/validators/post.js on lines 129..134
ghost/admin/app/validators/post.js on lines 136..141
ghost/admin/app/validators/post.js on lines 143..148
ghost/admin/app/validators/post.js on lines 207..212

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    codeinjectionHead(model) {
        if (!validator.isLength(model.codeinjectionHead || '', 0, 65535)) {
            model.errors.add('codeinjectionHead', 'Header code cannot be longer than 65535 characters.');
            this.invalidate();
        }
Severity: Major
Found in ghost/admin/app/validators/post.js and 11 other locations - About 1 hr to fix
ghost/admin/app/validators/member.js on lines 8..13
ghost/admin/app/validators/offer.js on lines 57..62
ghost/admin/app/validators/post.js on lines 87..92
ghost/admin/app/validators/post.js on lines 101..106
ghost/admin/app/validators/post.js on lines 108..113
ghost/admin/app/validators/post.js on lines 115..120
ghost/admin/app/validators/post.js on lines 122..127
ghost/admin/app/validators/post.js on lines 129..134
ghost/admin/app/validators/post.js on lines 136..141
ghost/admin/app/validators/post.js on lines 143..148
ghost/admin/app/validators/post.js on lines 207..212

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    metaTitle(model) {
        if (!validator.isLength(model.metaTitle || '', 0, 300)) {
            model.errors.add('metaTitle', 'Meta Title cannot be longer than 300 characters.');
            this.invalidate();
        }
Severity: Major
Found in ghost/admin/app/validators/post.js and 11 other locations - About 1 hr to fix
ghost/admin/app/validators/member.js on lines 8..13
ghost/admin/app/validators/offer.js on lines 57..62
ghost/admin/app/validators/post.js on lines 87..92
ghost/admin/app/validators/post.js on lines 94..99
ghost/admin/app/validators/post.js on lines 108..113
ghost/admin/app/validators/post.js on lines 115..120
ghost/admin/app/validators/post.js on lines 122..127
ghost/admin/app/validators/post.js on lines 129..134
ghost/admin/app/validators/post.js on lines 136..141
ghost/admin/app/validators/post.js on lines 143..148
ghost/admin/app/validators/post.js on lines 207..212

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    metaDescription(model) {
        if (!validator.isLength(model.metaDescription || '', 0, 500)) {
            model.errors.add('metaDescription', 'Meta Description cannot be longer than 500 characters.');
            this.invalidate();
        }
Severity: Major
Found in ghost/admin/app/validators/post.js and 11 other locations - About 1 hr to fix
ghost/admin/app/validators/member.js on lines 8..13
ghost/admin/app/validators/offer.js on lines 57..62
ghost/admin/app/validators/post.js on lines 87..92
ghost/admin/app/validators/post.js on lines 94..99
ghost/admin/app/validators/post.js on lines 101..106
ghost/admin/app/validators/post.js on lines 115..120
ghost/admin/app/validators/post.js on lines 122..127
ghost/admin/app/validators/post.js on lines 129..134
ghost/admin/app/validators/post.js on lines 136..141
ghost/admin/app/validators/post.js on lines 143..148
ghost/admin/app/validators/post.js on lines 207..212

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    emailSubject(model) {
        if (!validator.isLength(model.emailSubject || '', 0, 300)) {
            model.errors.add('emailSubject', 'Email Subject cannot be longer than 300 characters.');
            this.invalidate();
        }
Severity: Major
Found in ghost/admin/app/validators/post.js and 11 other locations - About 1 hr to fix
ghost/admin/app/validators/member.js on lines 8..13
ghost/admin/app/validators/offer.js on lines 57..62
ghost/admin/app/validators/post.js on lines 87..92
ghost/admin/app/validators/post.js on lines 94..99
ghost/admin/app/validators/post.js on lines 101..106
ghost/admin/app/validators/post.js on lines 108..113
ghost/admin/app/validators/post.js on lines 115..120
ghost/admin/app/validators/post.js on lines 122..127
ghost/admin/app/validators/post.js on lines 129..134
ghost/admin/app/validators/post.js on lines 136..141
ghost/admin/app/validators/post.js on lines 207..212

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    ogDescription(model) {
        if (!validator.isLength(model.ogDescription || '', 0, 500)) {
            model.errors.add('ogDescription', 'Facebook Description cannot be longer than 500 characters.');
            this.invalidate();
        }
Severity: Major
Found in ghost/admin/app/validators/post.js and 11 other locations - About 1 hr to fix
ghost/admin/app/validators/member.js on lines 8..13
ghost/admin/app/validators/offer.js on lines 57..62
ghost/admin/app/validators/post.js on lines 87..92
ghost/admin/app/validators/post.js on lines 94..99
ghost/admin/app/validators/post.js on lines 101..106
ghost/admin/app/validators/post.js on lines 108..113
ghost/admin/app/validators/post.js on lines 115..120
ghost/admin/app/validators/post.js on lines 129..134
ghost/admin/app/validators/post.js on lines 136..141
ghost/admin/app/validators/post.js on lines 143..148
ghost/admin/app/validators/post.js on lines 207..212

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    twitterDescription(model) {
        if (!validator.isLength(model.twitterDescription || '', 0, 500)) {
            model.errors.add('twitterDescription', 'Twitter Description cannot be longer than 500 characters.');
            this.invalidate();
        }
Severity: Major
Found in ghost/admin/app/validators/post.js and 11 other locations - About 1 hr to fix
ghost/admin/app/validators/member.js on lines 8..13
ghost/admin/app/validators/offer.js on lines 57..62
ghost/admin/app/validators/post.js on lines 87..92
ghost/admin/app/validators/post.js on lines 94..99
ghost/admin/app/validators/post.js on lines 101..106
ghost/admin/app/validators/post.js on lines 108..113
ghost/admin/app/validators/post.js on lines 115..120
ghost/admin/app/validators/post.js on lines 122..127
ghost/admin/app/validators/post.js on lines 129..134
ghost/admin/app/validators/post.js on lines 143..148
ghost/admin/app/validators/post.js on lines 207..212

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    featureImageAlt(model) {
        if (!validator.isLength(model.featureImageAlt || '', 0, 125)) {
            model.errors.add('featureImageAlt', 'Feature image alt text cannot be longer than 125 characters.');
            this.invalidate();
        }
Severity: Major
Found in ghost/admin/app/validators/post.js and 11 other locations - About 1 hr to fix
ghost/admin/app/validators/member.js on lines 8..13
ghost/admin/app/validators/offer.js on lines 57..62
ghost/admin/app/validators/post.js on lines 87..92
ghost/admin/app/validators/post.js on lines 94..99
ghost/admin/app/validators/post.js on lines 101..106
ghost/admin/app/validators/post.js on lines 108..113
ghost/admin/app/validators/post.js on lines 115..120
ghost/admin/app/validators/post.js on lines 122..127
ghost/admin/app/validators/post.js on lines 129..134
ghost/admin/app/validators/post.js on lines 136..141
ghost/admin/app/validators/post.js on lines 143..148

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status