Unbabel/OpenKiwi

View on GitHub
kiwi/cli/models/linear.py

Summary

Maintainability
B
6 hrs
Test Coverage
C
78%

File linear.py has 266 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#  OpenKiwi: Open-Source Machine Translation Quality Estimation
#  Copyright (C) 2019 Unbabel <openkiwi@unbabel.com>
#
#  This program is free software: you can redistribute it and/or modify
#  it under the terms of the GNU Affero General Public License as published
Severity: Minor
Found in kiwi/cli/models/linear.py - About 2 hrs to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    def parser_for_pipeline(pipeline):
        if pipeline == 'train':
            return ModelParser(
                'linear',
                'train',
    Severity: Major
    Found in kiwi/cli/models/linear.py and 3 other locations - About 3 hrs to fix
    kiwi/cli/models/nuqe.py on lines 120..138
    kiwi/cli/models/predictor_estimator.py on lines 522..540
    kiwi/cli/models/quetch.py on lines 360..378

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 69.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status