Unbabel/OpenKiwi

View on GitHub
kiwi/models/linear_word_qe_classifier.py

Summary

Maintainability
D
1 day
Test Coverage
B
89%

Function make_parts has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Wontfix

    def make_parts(self, instance):
        """Creates the parts (unigrams and bigrams) for an instance."""
        gold_list = []
        parts = []
        make_gold = True
Severity: Minor
Found in kiwi/models/linear_word_qe_classifier.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File linear_word_qe_classifier.py has 364 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

"""This is the main script for the linear sequential word-based quality
estimator."""
#  OpenKiwi: Open-Source Machine Translation Quality Estimation
#  Copyright (C) 2019 Unbabel <openkiwi@unbabel.com>
#
Severity: Minor
Found in kiwi/models/linear_word_qe_classifier.py - About 4 hrs to fix

    Function evaluate has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Wontfix

        def evaluate(self, instances, predictions, print_scores=True):
            """Evaluates the model's accuracy and F1-BAD score."""
            all_predictions = []
            for word_predictions in predictions:
                labels = [
    Severity: Minor
    Found in kiwi/models/linear_word_qe_classifier.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function create_instances has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Wontfix

        def create_instances(self, dataset):
            instances = []
            num_words = 0
            for example in dataset:
                sentence = LinearWordQESentence()
    Severity: Minor
    Found in kiwi/models/linear_word_qe_classifier.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Wontfix

        def __init__(
    Severity: Major
    Found in kiwi/models/linear_word_qe_classifier.py - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Wontfix

                              if make_gold:
                                  if (
                                      label_id
                                      == instance.sentence_word_labels[word_index]
                                      and previous_label_id
      Severity: Major
      Found in kiwi/models/linear_word_qe_classifier.py - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if num_matched_labels[ok] == 0:
                    f1_ok = 0.0
                else:
                    precision_ok = float(num_matched_labels[ok]) / float(
                        num_predicted_labels[ok]
        Severity: Major
        Found in kiwi/models/linear_word_qe_classifier.py and 1 other location - About 7 hrs to fix
        kiwi/models/linear_word_qe_classifier.py on lines 344..354

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if num_matched_labels[bad] == 0:
                    f1_bad = 0.0
                else:
                    precision_bad = float(num_matched_labels[bad]) / float(
                        num_predicted_labels[bad]
        Severity: Major
        Found in kiwi/models/linear_word_qe_classifier.py and 1 other location - About 7 hrs to fix
        kiwi/models/linear_word_qe_classifier.py on lines 366..375

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (
                            fine_to_coarse[predictions[j]]
                            == fine_to_coarse[instance.sentence_word_labels[j]]
        Severity: Minor
        Found in kiwi/models/linear_word_qe_classifier.py and 1 other location - About 35 mins to fix
        kiwi/models/linear_word_qe_classifier.py on lines 329..331

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 33.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (
                            fine_to_coarse[predictions[j]]
                            == fine_to_coarse[instance.sentence_word_labels[j]]
        Severity: Minor
        Found in kiwi/models/linear_word_qe_classifier.py and 1 other location - About 35 mins to fix
        kiwi/models/linear_word_qe_classifier.py on lines 323..325

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 33.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status