Sign upLogin

Vizzuality/gfw-climate

View on GitHub
Star
app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js

Summary

Maintainability
D
2 days
Test Coverage

File WidgetGridPresenter.js has 367 lines of code (exceeds 250 allowed). Consider refactoring.
Open

define(
  [
    'mps',
    'jquery',
    'underscore',
Severity: Minor
Found in app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js - About 4 hrs to fix

    Function getOptions has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          getOptions: function(widgets, params) {
        var activeWidgets,
          r = {};
        var params = params ? params : this.status.get('options');
        activeWidgets = widgets ? widgets : this.status.get('defaultWidgets');
    Severity: Major
    Found in app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js - About 2 hrs to fix

      Function _onPlaceGo has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            _onPlaceGo: function(params) {
        switch (params.view) {
          case 'national':
            if (params.options) {
              this._loadCustomizedOptions(params);
      Severity: Minor
      Found in app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js - About 1 hr to fix

        Function View/update has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                  'View/update': function(view) {
            var p = {
              view: view
            };
        Severity: Minor
        Found in app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                getJurisdictions: function(params) {
        var jurisdictions = null;

        if (
          params.options.hasOwnProperty('jurisdictions') &&
          Severity: Major
          Found in app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js on lines 339..350

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                getAreas: function(params) {
        var areas = null;

        if (
          params.options.hasOwnProperty('areas') &&
          Severity: Major
          Found in app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js on lines 326..337

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                    case 'areas-interest':
            if (params.areas) {
              _.map(
                params.areas,
                function(a) {
          Severity: Major
          Found in app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js on lines 395..405

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                    case 'subnational':
            if (params.jurisdictions) {
              _.map(
                params.jurisdictions,
                function(j) {
          Severity: Major
          Found in app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js on lines 407..417

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                        this.status.set({
                country: params.country.iso,
                view: params.view,
                areas: null,
                jurisdictions: null,
          Severity: Major
          Found in app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js on lines 175..182

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                        this.status.set({
                country: params.country.iso,
                view: params.view,
                areas: null,
                jurisdictions: null,
          Severity: Major
          Found in app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js on lines 199..206

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  p.options.areas = this.status.get('jurisdictions')
          ? null
          : this.status.get('areas');
          Severity: Minor
          Found in app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js and 1 other location - About 30 mins to fix
          app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js on lines 132..134

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  p.options.jurisdictions = this.status.get('areas')
          ? null
          : this.status.get('jurisdictions');
          Severity: Minor
          Found in app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js and 1 other location - About 30 mins to fix
          app/assets/javascripts/countries/presenters/show/WidgetGridPresenter.js on lines 129..131

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status