XoopsModules25x/about

View on GitHub
include/onuninstall.php

Summary

Maintainability
A
25 mins
Test Coverage

xoops_module_uninstall_about accesses the super-global variable $GLOBALS.
Open

function xoops_module_uninstall_about(\XoopsModule $module)
{
    //    return true;

    require_once dirname(__DIR__) . '/preloads/autoloader.php';
Severity: Minor
Found in include/onuninstall.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Function xoops_module_uninstall_about has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function xoops_module_uninstall_about(\XoopsModule $module)
{
    //    return true;

    require_once dirname(__DIR__) . '/preloads/autoloader.php';
Severity: Minor
Found in include/onuninstall.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing class import via use statement (line '56', column '24').
Open

        $dirInfo = new \SplFileInfo($old_dir);
Severity: Minor
Found in include/onuninstall.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class '\XoopsModules\About\Helper' in method 'xoops_module_uninstall_about'.
Open

    $helper = Helper::getInstance();
Severity: Minor
Found in include/onuninstall.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$module'.
Open

function xoops_module_pre_uninstall_about(\XoopsModule $module)
Severity: Minor
Found in include/onuninstall.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

There must be one USE keyword per declaration
Open

use XoopsModules\About\{
Severity: Minor
Found in include/onuninstall.php by phpcodesniffer

The variable $old_dir is not named in camelCase.
Open

function xoops_module_uninstall_about(\XoopsModule $module)
{
    //    return true;

    require_once dirname(__DIR__) . '/preloads/autoloader.php';
Severity: Minor
Found in include/onuninstall.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $old_dir is not named in camelCase.
Open

function xoops_module_uninstall_about(\XoopsModule $module)
{
    //    return true;

    require_once dirname(__DIR__) . '/preloads/autoloader.php';
Severity: Minor
Found in include/onuninstall.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $old_directories is not named in camelCase.
Open

function xoops_module_uninstall_about(\XoopsModule $module)
{
    //    return true;

    require_once dirname(__DIR__) . '/preloads/autoloader.php';
Severity: Minor
Found in include/onuninstall.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $old_directories is not named in camelCase.
Open

function xoops_module_uninstall_about(\XoopsModule $module)
{
    //    return true;

    require_once dirname(__DIR__) . '/preloads/autoloader.php';
Severity: Minor
Found in include/onuninstall.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $old_dir is not named in camelCase.
Open

function xoops_module_uninstall_about(\XoopsModule $module)
{
    //    return true;

    require_once dirname(__DIR__) . '/preloads/autoloader.php';
Severity: Minor
Found in include/onuninstall.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $old_dir is not named in camelCase.
Open

function xoops_module_uninstall_about(\XoopsModule $module)
{
    //    return true;

    require_once dirname(__DIR__) . '/preloads/autoloader.php';
Severity: Minor
Found in include/onuninstall.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status