Sign upLogin

XoopsModules25x/lexikon

View on GitHub
Star
admin/entry.php

Summary

Maintainability
F
5 days
Test Coverage

File entry.php has 476 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Module: Lexikon - glossary module
 * Author: hsalazar
 * Modifs: Yerres
Severity: Minor
Found in admin/entry.php - About 7 hrs to fix

    Function entrySave has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
    Open

    function entrySave($entryID = '')
{
    global $xoopsUser, $xoopsConfig, $xoopsModule, $xoopsDB;
    $helper  = Helper::getInstance();
    $utility = new Utility();
    Severity: Minor
    Found in admin/entry.php - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method entryEdit has 157 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function entryEdit($entryID = '')
{
    global $xoopsUser, $xoopsConfig, $xoopsDB, $xoopsModule, $init;
    $helper = Helper::getInstance();
    Severity: Major
    Found in admin/entry.php - About 6 hrs to fix

      Method entrySave has 137 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function entrySave($entryID = '')
{
    global $xoopsUser, $xoopsConfig, $xoopsModule, $xoopsDB;
    $helper  = Helper::getInstance();
    $utility = new Utility();
      Severity: Major
      Found in admin/entry.php - About 5 hrs to fix

        Function entryEdit has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
        Open

        function entryEdit($entryID = '')
{
    global $xoopsUser, $xoopsConfig, $xoopsDB, $xoopsModule, $init;
    $helper = Helper::getInstance();
        Severity: Minor
        Found in admin/entry.php - About 5 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method entryDefault has 103 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function entryDefault()
{
    global $xoopsUser, $xoopsConfig, $xoopsDB, $xoopsModule, $entryID, $pathIcon16;
    $helper = Helper::getInstance();
    require_once XOOPS_ROOT_PATH . '/class/xoopslists.php';
        Severity: Major
        Found in admin/entry.php - About 4 hrs to fix

          Function entryDefault has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

          function entryDefault()
{
    global $xoopsUser, $xoopsConfig, $xoopsDB, $xoopsModule, $entryID, $pathIcon16;
    $helper = Helper::getInstance();
    require_once XOOPS_ROOT_PATH . '/class/xoopslists.php';
          Severity: Minor
          Found in admin/entry.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if (!$entryID) { // there's no entryID? Then it's a new entry
        $butt_create = new \XoopsFormButton('', '', _AM_LEXIKON_CREATE, 'submit');
        $butt_create->setExtra('onclick="this.form.elements.op.value=\'addentry\'"');
        $buttonTray->addElement($butt_create);
          Severity: Major
          Found in admin/entry.php and 1 other location - About 6 hrs to fix
          admin/category.php on lines 228..247

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 221.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (is_object($xoopsUser) && empty($entryID)) {
                /** @var \XoopsMemberHandler $memberHandler */
                $memberHandler = xoops_getHandler('member');
                $submitter     = $memberHandler->getUser($uid);
                if (is_object($submitter)) {
          Severity: Major
          Found in admin/entry.php and 1 other location - About 1 hr to fix
          admin/category.php on lines 356..365

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 101.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status