XoopsModules25x/lexikon

View on GitHub
admin/importdictionary.php

Summary

Maintainability
F
3 days
Test Coverage

Function DefinitionImport has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

function DefinitionImport($delete)
{
    global $xoopsConfig, $xoopsDB, $xoopsModule, $myts;
    $sqlQuery = $xoopsDB->query('SELECT count(id) AS count FROM ' . $xoopsDB->prefix('dictionary'));
    [$count] = $xoopsDB->fetchRow($sqlQuery);
Severity: Minor
Found in admin/importdictionary.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method DefinitionImport has 118 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function DefinitionImport($delete)
{
    global $xoopsConfig, $xoopsDB, $xoopsModule, $myts;
    $sqlQuery = $xoopsDB->query('SELECT count(id) AS count FROM ' . $xoopsDB->prefix('dictionary'));
    [$count] = $xoopsDB->fetchRow($sqlQuery);
Severity: Major
Found in admin/importdictionary.php - About 4 hrs to fix

    Method FormImport has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function FormImport()
    {
        global $xoopsConfig, $xoopsDB, $xoopsModule;
        //lx_importMenu(9);
        echo "<strong style='color: #2F5376; margin-top:6px; font-size:medium'>" . _AM_LEXIKON_IMPORT_DICTIONARY . '</strong><br><br>';
    Severity: Minor
    Found in admin/importdictionary.php - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                          if (is_object($submitter)) {
                              $submitter->setVar('posts', $submitter->getVar('posts') + 1);
                              $res = $memberHandler->insertUser($submitter, true);
                              unset($submitter);
                          }
      Severity: Major
      Found in admin/importdictionary.php - About 45 mins to fix

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

            if ($delete) {
                // delete notifications
                xoops_notification_deletebymodule($xoopsModule->getVar('mid'));
                //get all entries
                $result3 = $xoopsDB->query('SELECT entryID FROM ' . $xoopsDB->prefix('lxentries') . ' ');
        Severity: Major
        Found in admin/importdictionary.php and 4 other locations - About 1 day to fix
        admin/importglossaire.php on lines 94..114
        admin/importwiwimod.php on lines 96..116
        admin/importwordbook.php on lines 99..119
        admin/importxwords.php on lines 97..117

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 264.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

        function FormImport()
        {
            global $xoopsConfig, $xoopsDB, $xoopsModule;
            //lx_importMenu(9);
            echo "<strong style='color: #2F5376; margin-top:6px; font-size:medium'>" . _AM_LEXIKON_IMPORT_DICTIONARY . '</strong><br><br>';
        Severity: Major
        Found in admin/importdictionary.php and 4 other locations - About 1 day to fix
        admin/importglossaire.php on lines 199..233
        admin/importwiwimod.php on lines 191..225
        admin/importwordbook.php on lines 277..311
        admin/importxwords.php on lines 256..290

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 254.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 5 locations. Consider refactoring.
        Open

                    if ($ret1) {
                        if ($uid) {
                            /** @var \XoopsMemberHandler $memberHandler */
                            $memberHandler = xoops_getHandler('member');
                            $submitter     = $memberHandler->getUser($uid);
        Severity: Major
        Found in admin/importdictionary.php and 4 other locations - About 40 mins to fix
        admin/importglossaire.php on lines 154..165
        admin/importwiwimod.php on lines 157..168
        admin/importwordbook.php on lines 179..190
        admin/importxwords.php on lines 176..187

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 93.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status