Sign upLogin

XoopsModules25x/news

View on GitHub
Star

Showing 310 of 310 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            if (!empty($this->s_groups) && \is_array($this->s_groups)) {
                foreach ($this->s_groups as $s_g) {
                    $submit_topics = XoopsPerms::getPermitted($this->mid, 'SubmitInTopic', $s_g);
                    $add           = true;
                    foreach ($parent_topics as $p_topic) {
Severity: Major
Found in class/XoopsTopic.php and 2 other locations - About 4 hrs to fix
class/XoopsTopic.php on lines 155..175
class/XoopsTopic.php on lines 196..215

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 166.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

if ($approveprivilege && is_object($xoopsUser) && $xoopsUser->isAdmin($xoopsModule->mid())) {
    if (!isset($newsauthor)) {
        $newsauthor = $xoopsUser->getVar('uid');
    }
    /** @var \XoopsMemberHandler $memberHandler */
Severity: Major
Found in include/storyform.inc.php and 1 other location - About 4 hrs to fix
include/storyform.original.php on lines 83..95

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 165.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

if ($approveprivilege && is_object($xoopsUser) && $xoopsUser->isAdmin($xoopsModule->mid())) {
    if (!isset($newsauthor)) {
        $newsauthor = $xoopsUser->getVar('uid');
    }
    /** @var \XoopsMemberHandler $memberHandler */
Severity: Major
Found in include/storyform.original.php and 1 other location - About 4 hrs to fix
include/storyform.inc.php on lines 78..90

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 165.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function modTopicS has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

function modTopicS(): void
{
    global $xoopsDB, $xoopsModule;
    $helper = Helper::getInstance();
Severity: Minor
Found in admin/index.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method store has 97 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function store($approved = false)
    {
        $myts        = \MyTextSanitizer::getInstance();
        $counter     = $this->counter ?? 0;
        $title       = $GLOBALS['xoopsDB']->escape($myts->censorString($this->title));
Severity: Major
Found in class/NewsStory.php - About 3 hrs to fix

    Method b_news_top_edit has 95 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function b_news_top_edit($options)
{
    global $xoopsDB;
    $tmpstory = new NewsStory();
    $form     = _MB_NEWS_ORDER . "&nbsp;<select name='options[]'>";
    Severity: Major
    Found in blocks/news_top.php - About 3 hrs to fix

      Method render has 95 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function render(?array $block = null): void
    {
        \xoops_load('XoopsFormLoader');
        \xoops_loadLanguage('common', $this->moduleDirNameUpper);
      Severity: Major
      Found in class/Common/Blocksadmin.php - About 3 hrs to fix

        Method store has 94 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function store($approved = false)
    {
        //$newpost = 0;
        $myts     = MyTextSanitizer::getInstance();
        $title    = $myts->censorString($this->title);
        Severity: Major
        Found in class/XoopsStory.php - About 3 hrs to fix

          Method getStats has 94 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getStats($limit)
    {
        $ret = [];
        /** @var \XoopsMySQLDatabase $db */
        $db   = \XoopsDatabaseFactory::getDatabaseConnection();
          Severity: Major
          Found in class/NewsStory.php - About 3 hrs to fix

            Method launchNewsletter has 93 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function launchNewsletter(): void
{
    global $xoopsConfig, $dateformat;
    xoops_cp_header();
    $adminObject = Admin::getInstance();
            Severity: Major
            Found in admin/index.php - About 3 hrs to fix

              File article.php has 321 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php declare(strict_types=1);
/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
              Severity: Minor
              Found in article.php - About 3 hrs to fix

                Method news_search has 90 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function news_search($queryarray, $andor, $limit, $offset, $userid)
{
    global $xoopsDB, $xoopsUser;
    $restricted = News\Utility::getModuleOption('restrictindex');
    $highlight  = false;
                Severity: Major
                Found in include/search.inc.php - About 3 hrs to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      if ($restricted) {
        global $xoopsUser;
        /** @var \XoopsModuleHandler $moduleHandler */
        $moduleHandler = xoops_getHandler('module');
        $newsModule    = $moduleHandler->getByDirname('news');
                  Severity: Major
                  Found in blocks/news_topicsnav.php and 1 other location - About 3 hrs to fix
                  topics_directory.php on lines 44..59

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 154.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  if ($restricted) {
    global $xoopsUser;
    /** @var \XoopsModuleHandler $moduleHandler */
    $moduleHandler = xoops_getHandler('module');
    $newsModule    = $moduleHandler->getByDirname('news');
                  Severity: Major
                  Found in topics_directory.php and 1 other location - About 3 hrs to fix
                  blocks/news_topicsnav.php on lines 42..57

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 154.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method store has 89 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function store()
    {
        $myts   = MyTextSanitizer::getInstance();
        $title  = '';
        $imgurl = '';
                  Severity: Major
                  Found in class/XoopsTopic.php - About 3 hrs to fix

                    Function renderNav has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function renderNav($offset = 4)
    {
        $ret = '';
        if ($this->total <= $this->perpage) {
            return $ret;
                    Severity: Minor
                    Found in class/PageNav.php - About 3 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function renderImageNav has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function renderImageNav($offset = 4)
    {
        if ($this->total < $this->perpage) {
            return null;
        }
                    Severity: Minor
                    Found in class/PageNav.php - About 3 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method launchExport has 80 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function launchExport(): void
{
    xoops_cp_header();
    $adminObject = Admin::getInstance();
    $adminObject->displayNavigation('index.php?op=export');
                    Severity: Major
                    Found in admin/index.php - About 3 hrs to fix

                      Method modTopicS has 80 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      function modTopicS(): void
{
    global $xoopsDB, $xoopsModule;
    $helper = Helper::getInstance();
                      Severity: Major
                      Found in admin/index.php - About 3 hrs to fix

                        Method autoStories has 78 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        function autoStories(): void
{
    global $dateformat, $pathIcon16;

    $start        = Request::getInt('startauto', 0, 'GET');
                        Severity: Major
                        Found in admin/index.php - About 3 hrs to fix
                          Severity
                          Category
                          Status
                          Source
                          Language