XoopsModules25x/rss

View on GitHub

Showing 80 of 101 total issues

Method loadTableFromArrayWithReplace has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function loadTableFromArrayWithReplace(string $table, array $data, string $search, string $replace): int
{
    /** @var \XoopsMySQLDatabase $db */
    $db = \XoopsDatabaseFactory::getDatabaseConnection();

Severity: Minor
Found in testdata/index.php - About 1 hr to fix

    Method grabEntries has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function grabEntries(\XoopsMySQLDatabase $xoopsDB): ?array
        {
            $ret  = null;
            $i    = 0;
            //  The following example code grabs the latest entries from the module
    Severity: Minor
    Found in class/Plugins/Wgsimpleacc.php - About 1 hr to fix

      Method checkPlugin has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function checkPlugin(\XoopsObject $object)
          {
              $ret = null;
              $file = \RSSFIT_ROOT_PATH . 'class/Plugins/' . $object->getVar('rssf_filename');
              if (\is_file($file)) {
      Severity: Minor
      Found in class/PluginHandler.php - About 1 hr to fix

        Method getServerStats has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function getServerStats(): string
            {
                //mb    $wfdownloads = WfdownloadsWfdownloads::getInstance();
                $moduleDirName      = \basename(\dirname(__DIR__, 2));
                $moduleDirNameUpper = mb_strtoupper($moduleDirName);
        Severity: Minor
        Found in class/Common/ServerStats.php - About 1 hr to fix

          Method loadSampleData has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function loadSampleData(): void
          {
              global $xoopsConfig;
              $moduleDirName      = \basename(\dirname(__DIR__));
              $moduleDirNameUpper = mb_strtoupper($moduleDirName);
          Severity: Minor
          Found in testdata/index.php - About 1 hr to fix

            Method grabEntries has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function grabEntries(\XoopsMySQLDatabase $xoopsDB): ?array
                {
                    require_once XOOPS_ROOT_PATH . '/modules/' . $this->dirname . '/class/class.forumposts.php';
                    $myts   = \MyTextSanitizer::getInstance();
                    $ret    = null;
            Severity: Minor
            Found in class/Plugins/Newbb.php - About 1 hr to fix

              Method feedSelectBox has 8 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function feedSelectBox(string $caption = '', $selected = null, int $size = 1, bool $multi = true, bool $none = true, bool $main = true, string $name = 'feeds', string $type = 'id'): \XoopsFormSelect
              Severity: Major
              Found in class/FeedHandler.php - About 1 hr to fix

                Function grabEntries has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function grabEntries(\XoopsMySQLDatabase $xoopsDB):?array
                    {
                        $myts = \MyTextSanitizer::getInstance();
                        $grouppermHandler = \xoops_getHandler('groupperm');
                        $ret = null;
                Severity: Minor
                Found in class/Plugins/legacy/Wfdownloads_podcast.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function rmove has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function rmove(string $src, string $dest): bool
                    {
                        // Only continue if user is a 'global' Admin
                        if (!($GLOBALS['xoopsUser'] instanceof \XoopsUser) || !$GLOBALS['xoopsUser']->isAdmin()) {
                            return false;
                Severity: Minor
                Found in class/Common/FilesManagement.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function recurseCopy has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function recurseCopy(string $src, string $dst): void
                    {
                        $dir = \opendir($src);
                        //        @mkdir($dst);
                        if (!@\mkdir($dst) && !\is_dir($dst)) {
                Severity: Minor
                Found in class/Common/FilesManagement.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function grabEntries has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function grabEntries(\XoopsMySQLDatabase $xoopsDB): ?array
                    {
                        $ret  = null;
                        $i = 0;
                
                
                Severity: Minor
                Found in class/Plugins/Extcal.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function rcopy has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function rcopy(string $src, string $dest): bool
                    {
                        // Only continue if user is a 'global' Admin
                        if (!($GLOBALS['xoopsUser'] instanceof \XoopsUser) || !$GLOBALS['xoopsUser']->isAdmin()) {
                            return false;
                Severity: Minor
                Found in class/Common/FilesManagement.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method getRssFeedAsHtml has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public static function getRssFeedAsHtml(string $feed_url, int $maxItemCount = 10, bool $show_date = true, bool $show_description = true, int $max_words = 0, int $cache_timeout = 7200, string $cache_prefix = XOOPS_VAR_PATH . '/caches/xoops_cache/rss2html-'): string
                Severity: Major
                Found in class/Utility.php - About 50 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          if (!$result = $pluginHandler->insert($p)) {
                                              $err .= $p->getHtmlErrors();
                                          }
                  Severity: Major
                  Found in admin/do_plugins.php - About 45 mins to fix

                    Method rssfGenAnchor has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public static function rssfGenAnchor(?string $url = null, string $text = '', string $target = '', string $title = '', string $class = '', string $id = ''): string
                    Severity: Minor
                    Found in class/Utility.php - About 45 mins to fix

                      Function grabEntries has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function grabEntries(\XoopsMySQLDatabase $xoopsDB): ?array
                          {
                              $ret  = null;
                              //        @require_once XOOPS_ROOT_PATH . '/modules/smartfaq/include/functions.php';
                      
                      
                      Severity: Minor
                      Found in class/Plugins/Smartfaq.php - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Avoid deeply nested control flow statements.
                      Open

                                                  if ($wordsCount == $max_words) {
                                                      break;
                                                  }
                      Severity: Major
                      Found in class/Utility.php - About 45 mins to fix

                        Function grabEntries has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function grabEntries(\XoopsMySQLDatabase $xoopsDB): ?array
                            {
                                $myts = \MyTextSanitizer::getInstance();
                                $ret  = null;
                                require_once XOOPS_ROOT_PATH . '/modules/oledrion/include/common.php';
                        Severity: Minor
                        Found in class/Plugins/Oledrion.php - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Avoid deeply nested control flow statements.
                        Open

                                                    if (is_file($templateFolder . $v)) {
                                                        unlink($templateFolder . $v);
                                                    }
                        Severity: Major
                        Found in include/onupdate.php - About 45 mins to fix

                          Function grabEntries has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                          Severity: Minor
                          Found in class/Plugins/legacy/Buyersguide.php - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language