XoopsModules25x/xfguestbook

View on GitHub

Showing 56 of 1,027 total issues

Function xoops_module_update_xfguestbook has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
Open

function xoops_module_update_xfguestbook(\XoopsModule $module, $previousVersion = null)
{
    global $xoopsDB;
    $moduleDirName      = basename(dirname(__DIR__));
    $moduleDirNameUpper = mb_strtoupper($moduleDirName);
Severity: Minor
Found in include/onupdate.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function truncateHtml has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
Open

    public static function truncateHtml($text, $length = 100, $ending = '...', $exact = false, $considerHtml = true)
    {
        if ($considerHtml) {
            // if the plain text is shorter than the maximum length, return the whole text
            if (mb_strlen(\preg_replace('/<.*?' . '>/', '', $text)) <= $length) {
Severity: Minor
Found in class/Common/SysUtility.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method show has 137 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function show()
{
    global $msgHandler, $xoopsModule, $pathIcon16;
    $pick              = Request::getInt('pick', 0, 'GET');
    $start             = Request::getInt('start', 0, 'GET');
Severity: Major
Found in admin/main.php - About 5 hrs to fix

    Function xfgb_getmsg has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
    Open

    function xfgb_getmsg($msg)
    {
        global $nbmsg, $xoopsModule, $xoopsUser, $xoopsTpl, $xoopsConfig, $options, $opt, $xoopsDB;
        /** @var Helper $helper */
        $helper = Helper::getInstance();
    Severity: Minor
    Found in index.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function show has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

    function show()
    {
        global $msgHandler, $xoopsModule, $pathIcon16;
        $pick              = Request::getInt('pick', 0, 'GET');
        $start             = Request::getInt('start', 0, 'GET');
    Severity: Minor
    Found in admin/main.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File main.php has 315 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    //
    //  ------------------------------------------------------------------------ //
    //             XF Guestbook                                                  //
    // ------------------------------------------------------------------------- //
    Severity: Minor
    Found in admin/main.php - About 3 hrs to fix

      Method insert has 86 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function insert(\XoopsObject $msg, $force = true)
          {
              if (Message::class !== \get_class($msg)) {
                  return false;
              }
      Severity: Major
      Found in class/MessageHandler.php - About 3 hrs to fix

        File country_manager.php has 302 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        //
        //  ------------------------------------------------------------------------ //
        //             XF Guestbook                                                  //
        // ------------------------------------------------------------------------- //
        Severity: Minor
        Found in admin/country_manager.php - About 3 hrs to fix

          File upgrade.php has 300 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          //
          // ------------------------------------------------------------------------- //
          // XF Guestbook for Xoops                                                          //
          // ------------------------------------------------------------------------- //
          Severity: Minor
          Found in admin/upgrade.php - About 3 hrs to fix

            Function checkVerModule has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function checkVerModule($helper, $source = 'github', $default = 'master')
                {
                    $moduleDirName      = \basename(dirname(__DIR__, 2));
                    $moduleDirNameUpper = mb_strtoupper($moduleDirName);
                    $update             = '';
            Severity: Minor
            Found in class/Common/VersionChecks.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function executeSQL has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
            Open

            function executeSQL($sql_file_path)
            {
                global $xoopsModule;
                $error = false;
                // $reservedTables = array('avatar', 'avatar_users_link', 'block_module_link', 'xoopscomments', 'config', 'configcategory', 'configoption', 'image', 'imagebody', 'imagecategory', 'imgset', 'imgset_tplset_link', 'imgsetimg', 'groups','groups_users_link','group_permission', 'online', 'bannerclient', 'banner', 'bannerfinish', 'ranks', 'session', 'smiles', 'users', 'newblocks', 'modules', 'tplfile', 'tplset', 'tplsource', 'xoopsnotifications', 'banner', 'bannerclient', 'bannerfinish');
            Severity: Minor
            Found in include/cp_functions.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            File index.php has 283 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            //
            //  ------------------------------------------------------------------------ //
            //             XF Guestbook                                                  //
            // ------------------------------------------------------------------------- //
            Severity: Minor
            Found in index.php - About 2 hrs to fix

              Method xfgb_getmsg has 65 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function xfgb_getmsg($msg)
              {
                  global $nbmsg, $xoopsModule, $xoopsUser, $xoopsTpl, $xoopsConfig, $options, $opt, $xoopsDB;
                  /** @var Helper $helper */
                  $helper = Helper::getInstance();
              Severity: Major
              Found in index.php - About 2 hrs to fix

                Method truncateHtml has 63 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public static function truncateHtml($text, $length = 100, $ending = '...', $exact = false, $considerHtml = true)
                    {
                        if ($considerHtml) {
                            // if the plain text is shorter than the maximum length, return the whole text
                            if (mb_strlen(\preg_replace('/<.*?' . '>/', '', $text)) <= $length) {
                Severity: Major
                Found in class/Common/SysUtility.php - About 2 hrs to fix

                  Function flagUpload has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function flagUpload($country_code)
                  {
                      global $xoopsModule, $maxsize, $maxwidth, $maxheight, $format;
                      /** @var Helper $helper */
                      $helper = Helper::getInstance();
                  Severity: Minor
                  Found in admin/country_manager.php - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function deleteDirectory has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public static function deleteDirectory($src)
                      {
                          // Only continue if user is a 'global' Admin
                          if (!($GLOBALS['xoopsUser'] instanceof \XoopsUser) || !$GLOBALS['xoopsUser']->isAdmin()) {
                              return false;
                  Severity: Minor
                  Found in class/Common/FilesManagement.php - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method countryShow has 58 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function countryShow()
                  {
                      global $action, $start, $xoopsModule, $pathIcon16;
                      /** @var Helper $helper */
                      $helper = Helper::getInstance();
                  Severity: Major
                  Found in admin/country_manager.php - About 2 hrs to fix

                    Method xoops_module_update_xfguestbook has 56 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function xoops_module_update_xfguestbook(\XoopsModule $module, $previousVersion = null)
                    {
                        global $xoopsDB;
                        $moduleDirName      = basename(dirname(__DIR__));
                        $moduleDirNameUpper = mb_strtoupper($moduleDirName);
                    Severity: Major
                    Found in include/onupdate.php - About 2 hrs to fix

                      Function b_xfguestbook_show has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function b_xfguestbook_show($options)
                      {
                          global $xoopsModule, $xoopsModuleConfig, $xoopsDB;
                          /** @var Helper $helper */
                          $helper = Helper::getInstance();
                      Severity: Minor
                      Found in blocks/xfguestbook_new.php - About 2 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function upload has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public static function upload()
                          {
                              global $xoopsModule, $preview_name, $msgstop;
                              /** @var Helper $helper */
                              $helper = Helper::getInstance();
                      Severity: Minor
                      Found in class/Utility.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language