XoopsModules25x/xoopspoll

View on GitHub
extras/newbb_4x/irmtfan/class/post.php

Summary

Maintainability
F
2 wks
Test Coverage

saveAttachment accesses the super-global variable $GLOBALS.
Open

    public function saveAttachment()
    {
        $attachment_save = '';
        if (is_array($this->attachment_array) && count($this->attachment_array) > 0) {
            $attachment_save = base64_encode(serialize($this->attachment_array));

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

deleteAttachment accesses the super-global variable $GLOBALS.
Open

    public function deleteAttachment($attach_array = null)
    {
        $attach_old = $this->getAttachment();
        if (!is_array($attach_old) || count($attach_old) < 1) {
            return true;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

saveAttachment accesses the super-global variable $GLOBALS.
Open

    public function saveAttachment()
    {
        $attachment_save = '';
        if (is_array($this->attachment_array) && count($this->attachment_array) > 0) {
            $attachment_save = base64_encode(serialize($this->attachment_array));

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

deleteAttachment accesses the super-global variable $GLOBALS.
Open

    public function deleteAttachment($attach_array = null)
    {
        $attach_old = $this->getAttachment();
        if (!is_array($attach_old) || count($attach_old) < 1) {
            return true;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

setPostEdit accesses the super-global variable $GLOBALS.
Open

    public function setPostEdit($poster_name = '', $post_editmsg = '')
    {
        if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])
            || (time() - $this->getVar('post_time')) < $GLOBALS['xoopsModuleConfig']['recordedit_timelimit'] * 60
            || $this->getVar('approved') < 1

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

setPostEdit accesses the super-global variable $GLOBALS.
Open

    public function setPostEdit($poster_name = '', $post_editmsg = '')
    {
        if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])
            || (time() - $this->getVar('post_time')) < $GLOBALS['xoopsModuleConfig']['recordedit_timelimit'] * 60
            || $this->getVar('approved') < 1

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

displayAttachment accesses the super-global variable $GLOBALS.
Open

    public function displayAttachment($asSource = false)
    {
        $post_attachment = '';
        $attachments     = $this->getAttachment();
        if (is_array($attachments) && count($attachments) > 0) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getPostBody accesses the super-global variable $GLOBALS.
Open

    public function &getPostBody()
    {
        global $myts;
        $GLOBALS['xoopsModuleConfig'] = newbb_load_config(); // irmtfan  load all newbb configs - newbb config in blocks activated in some modules like profile
        mod_loadFunctions('user', 'newbb');

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getPostBody accesses the super-global variable $GLOBALS.
Open

    public function &getPostBody()
    {
        global $myts;
        $GLOBALS['xoopsModuleConfig'] = newbb_load_config(); // irmtfan  load all newbb configs - newbb config in blocks activated in some modules like profile
        mod_loadFunctions('user', 'newbb');

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

checkIdentity accesses the super-global variable $GLOBALS.
Open

    public function checkIdentity($uid = -1)
    {
        $uid = ($uid > -1) ? $uid : (($GLOBALS['xoopsUser'] instanceof XoopsUser) ? $GLOBALS['xoopsUser']->getVar('uid') : 0);
        if ($this->getVar('uid') > 0) {
            $user_ok = ($uid === $this->getVar('uid')) ? true : false;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

checkIdentity accesses the super-global variable $GLOBALS.
Open

    public function checkIdentity($uid = -1)
    {
        $uid = ($uid > -1) ? $uid : (($GLOBALS['xoopsUser'] instanceof XoopsUser) ? $GLOBALS['xoopsUser']->getVar('uid') : 0);
        if ($this->getVar('uid') > 0) {
            $user_ok = ($uid === $this->getVar('uid')) ? true : false;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

setPostEdit accesses the super-global variable $GLOBALS.
Open

    public function setPostEdit($poster_name = '', $post_editmsg = '')
    {
        if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])
            || (time() - $this->getVar('post_time')) < $GLOBALS['xoopsModuleConfig']['recordedit_timelimit'] * 60
            || $this->getVar('approved') < 1

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

displayPostEdit accesses the super-global variable $GLOBALS.
Open

    public function displayPostEdit()
    {
        global $myts;

        if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

saveAttachment accesses the super-global variable $GLOBALS.
Open

    public function saveAttachment()
    {
        $attachment_save = '';
        if (is_array($this->attachment_array) && count($this->attachment_array) > 0) {
            $attachment_save = base64_encode(serialize($this->attachment_array));

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

displayAttachment accesses the super-global variable $GLOBALS.
Open

    public function displayAttachment($asSource = false)
    {
        $post_attachment = '';
        $attachments     = $this->getAttachment();
        if (is_array($attachments) && count($attachments) > 0) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

displayAttachment accesses the super-global variable $GLOBALS.
Open

    public function displayAttachment($asSource = false)
    {
        $post_attachment = '';
        $attachments     = $this->getAttachment();
        if (is_array($attachments) && count($attachments) > 0) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

setPostEdit accesses the super-global variable $GLOBALS.
Open

    public function setPostEdit($poster_name = '', $post_editmsg = '')
    {
        if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])
            || (time() - $this->getVar('post_time')) < $GLOBALS['xoopsModuleConfig']['recordedit_timelimit'] * 60
            || $this->getVar('approved') < 1

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getPostBody accesses the super-global variable $GLOBALS.
Open

    public function &getPostBody()
    {
        global $myts;
        $GLOBALS['xoopsModuleConfig'] = newbb_load_config(); // irmtfan  load all newbb configs - newbb config in blocks activated in some modules like profile
        mod_loadFunctions('user', 'newbb');

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

displayPostEdit accesses the super-global variable $GLOBALS.
Open

    public function displayPostEdit()
    {
        global $myts;

        if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getPostBody accesses the super-global variable $GLOBALS.
Open

    public function &getPostBody()
    {
        global $myts;
        $GLOBALS['xoopsModuleConfig'] = newbb_load_config(); // irmtfan  load all newbb configs - newbb config in blocks activated in some modules like profile
        mod_loadFunctions('user', 'newbb');

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

setPostEdit accesses the super-global variable $GLOBALS.
Open

    public function setPostEdit($poster_name = '', $post_editmsg = '')
    {
        if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])
            || (time() - $this->getVar('post_time')) < $GLOBALS['xoopsModuleConfig']['recordedit_timelimit'] * 60
            || $this->getVar('approved') < 1

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

setPostEdit accesses the super-global variable $GLOBALS.
Open

    public function setPostEdit($poster_name = '', $post_editmsg = '')
    {
        if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])
            || (time() - $this->getVar('post_time')) < $GLOBALS['xoopsModuleConfig']['recordedit_timelimit'] * 60
            || $this->getVar('approved') < 1

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $_GET.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

displayAttachment accesses the super-global variable $GLOBALS.
Open

    public function displayAttachment($asSource = false)
    {
        $post_attachment = '';
        $attachments     = $this->getAttachment();
        if (is_array($attachments) && count($attachments) > 0) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

displayAttachment accesses the super-global variable $GLOBALS.
Open

    public function displayAttachment($asSource = false)
    {
        $post_attachment = '';
        $attachments     = $this->getAttachment();
        if (is_array($attachments) && count($attachments) > 0) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $_GET.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $_GET.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getPostBody accesses the super-global variable $GLOBALS.
Open

    public function &getPostBody()
    {
        global $myts;
        $GLOBALS['xoopsModuleConfig'] = newbb_load_config(); // irmtfan  load all newbb configs - newbb config in blocks activated in some modules like profile
        mod_loadFunctions('user', 'newbb');

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

displayAttachment accesses the super-global variable $GLOBALS.
Open

    public function displayAttachment($asSource = false)
    {
        $post_attachment = '';
        $attachments     = $this->getAttachment();
        if (is_array($attachments) && count($attachments) > 0) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getPostBody accesses the super-global variable $GLOBALS.
Open

    public function &getPostBody()
    {
        global $myts;
        $GLOBALS['xoopsModuleConfig'] = newbb_load_config(); // irmtfan  load all newbb configs - newbb config in blocks activated in some modules like profile
        mod_loadFunctions('user', 'newbb');

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

displayAttachment accesses the super-global variable $GLOBALS.
Open

    public function displayAttachment($asSource = false)
    {
        $post_attachment = '';
        $attachments     = $this->getAttachment();
        if (is_array($attachments) && count($attachments) > 0) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

displayAttachment accesses the super-global variable $GLOBALS.
Open

    public function displayAttachment($asSource = false)
    {
        $post_attachment = '';
        $attachments     = $this->getAttachment();
        if (is_array($attachments) && count($attachments) > 0) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

setPostEdit accesses the super-global variable $GLOBALS.
Open

    public function setPostEdit($poster_name = '', $post_editmsg = '')
    {
        if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])
            || (time() - $this->getVar('post_time')) < $GLOBALS['xoopsModuleConfig']['recordedit_timelimit'] * 60
            || $this->getVar('approved') < 1

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

getPostBody accesses the super-global variable $GLOBALS.
Open

    public function &getPostBody()
    {
        global $myts;
        $GLOBALS['xoopsModuleConfig'] = newbb_load_config(); // irmtfan  load all newbb configs - newbb config in blocks activated in some modules like profile
        mod_loadFunctions('user', 'newbb');

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $_GET.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

displayAttachment accesses the super-global variable $GLOBALS.
Open

    public function displayAttachment($asSource = false)
    {
        $post_attachment = '';
        $attachments     = $this->getAttachment();
        if (is_array($attachments) && count($attachments) > 0) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

setPostEdit accesses the super-global variable $GLOBALS.
Open

    public function setPostEdit($poster_name = '', $post_editmsg = '')
    {
        if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])
            || (time() - $this->getVar('post_time')) < $GLOBALS['xoopsModuleConfig']['recordedit_timelimit'] * 60
            || $this->getVar('approved') < 1

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

displayAttachment accesses the super-global variable $GLOBALS.
Open

    public function displayAttachment($asSource = false)
    {
        $post_attachment = '';
        $attachments     = $this->getAttachment();
        if (is_array($attachments) && count($attachments) > 0) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

displayAttachment accesses the super-global variable $GLOBALS.
Open

    public function displayAttachment($asSource = false)
    {
        $post_attachment = '';
        $attachments     = $this->getAttachment();
        if (is_array($attachments) && count($attachments) > 0) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

displayAttachment accesses the super-global variable $GLOBALS.
Open

    public function displayAttachment($asSource = false)
    {
        $post_attachment = '';
        $attachments     = $this->getAttachment();
        if (is_array($attachments) && count($attachments) > 0) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

displayAttachment accesses the super-global variable $GLOBALS.
Open

    public function displayAttachment($asSource = false)
    {
        $post_attachment = '';
        $attachments     = $this->getAttachment();
        if (is_array($attachments) && count($attachments) > 0) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

displayAttachment accesses the super-global variable $GLOBALS.
Open

    public function displayAttachment($asSource = false)
    {
        $post_attachment = '';
        $attachments     = $this->getAttachment();
        if (is_array($attachments) && count($attachments) > 0) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

displayAttachment accesses the super-global variable $GLOBALS.
Open

    public function displayAttachment($asSource = false)
    {
        $post_attachment = '';
        $attachments     = $this->getAttachment();
        if (is_array($attachments) && count($attachments) > 0) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

displayAttachment accesses the super-global variable $GLOBALS.
Open

    public function displayAttachment($asSource = false)
    {
        $post_attachment = '';
        $attachments     = $this->getAttachment();
        if (is_array($attachments) && count($attachments) > 0) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

delete accesses the super-global variable $GLOBALS.
Open

    public function delete($post, $isDeleteOne = true, $force = false)
    {
        $retVal = false;
        if (($post instanceof Post) && ($post->getVar('post_id') > 0)) {
            if ($isDeleteOne) {

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

_delete accesses the super-global variable $GLOBALS.
Open

    private function _delete(&$post, $force = false)
    {
        if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
            return false;
        }

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

_delete accesses the super-global variable $GLOBALS.
Open

    private function _delete(&$post, $force = false)
    {
        if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
            return false;
        }

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

_delete accesses the super-global variable $GLOBALS.
Open

    private function _delete(&$post, $force = false)
    {
        if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
            return false;
        }

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $_GET.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

showPost accesses the super-global variable $GLOBALS.
Open

    public function showPost($isadmin)
    {
        global $myts;
        global $forumUrl, $forumImage;
        global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

_delete accesses the super-global variable $GLOBALS.
Open

    private function _delete(&$post, $force = false)
    {
        if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
            return false;
        }

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

_delete accesses the super-global variable $GLOBALS.
Open

    private function _delete(&$post, $force = false)
    {
        if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
            return false;
        }

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

_delete accesses the super-global variable $GLOBALS.
Open

    private function _delete(&$post, $force = false)
    {
        if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
            return false;
        }

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

_delete accesses the super-global variable $GLOBALS.
Open

    private function _delete(&$post, $force = false)
    {
        if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
            return false;
        }

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

_delete accesses the super-global variable $GLOBALS.
Open

    private function _delete(&$post, $force = false)
    {
        if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
            return false;
        }

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

File post.php has 888 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
//
//  ------------------------------------------------------------------------ //
//                XOOPS - PHP Content Management System                      //
//                  Copyright (c) 2000-2016 XOOPS.org                        //
Severity: Major
Found in extras/newbb_4x/irmtfan/class/post.php - About 2 days to fix

    Function _delete has a Cognitive Complexity of 71 (exceeds 5 allowed). Consider refactoring.
    Open

        private function _delete(&$post, $force = false)
        {
            if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
                return false;
            }
    Severity: Minor
    Found in extras/newbb_4x/irmtfan/class/post.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method showPost has 203 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function showPost($isadmin)
        {
            global $myts;
            global $forumUrl, $forumImage;
            global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;
    Severity: Major
    Found in extras/newbb_4x/irmtfan/class/post.php - About 1 day to fix

      Function showPost has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
      Open

          public function showPost($isadmin)
          {
              global $myts;
              global $forumUrl, $forumImage;
              global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;
      Severity: Minor
      Found in extras/newbb_4x/irmtfan/class/post.php - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function insert has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
      Open

          public function insert(XoopsObject $post, $force = true)
          {
              // Set the post time
              // The time should be 'publish' time. To be adjusted later
              if (!$post->getVar('post_time')) {
      Severity: Minor
      Found in extras/newbb_4x/irmtfan/class/post.php - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method _delete has 95 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function _delete(&$post, $force = false)
          {
              if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
                  return false;
              }
      Severity: Major
      Found in extras/newbb_4x/irmtfan/class/post.php - About 3 hrs to fix

        Method insert has 90 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function insert(XoopsObject $post, $force = true)
            {
                // Set the post time
                // The time should be 'publish' time. To be adjusted later
                if (!$post->getVar('post_time')) {
        Severity: Major
        Found in extras/newbb_4x/irmtfan/class/post.php - About 3 hrs to fix

          The class Post has an overall complexity of 123 which is very high. The configured complexity threshold is 50.
          Open

          class Post extends XoopsObject
          {
              //class Post extends XoopsObject {
              public $attachment_array = array();
          
          

          The class NewbbPostHandler has an overall complexity of 100 which is very high. The configured complexity threshold is 50.
          Open

          class NewbbPostHandler extends XoopsPersistableObjectHandler
          {
              /**
               * @param null|XoopsDatabase $db
               */

          Function delete has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
          Open

              public function delete($post, $isDeleteOne = true, $force = false)
              {
                  $retVal = false;
                  if (($post instanceof Post) && ($post->getVar('post_id') > 0)) {
                      if ($isDeleteOne) {
          Severity: Minor
          Found in extras/newbb_4x/irmtfan/class/post.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function displayAttachment has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
          Open

              public function displayAttachment($asSource = false)
              {
                  $post_attachment = '';
                  $attachments     = $this->getAttachment();
                  if (is_array($attachments) && count($attachments) > 0) {
          Severity: Minor
          Found in extras/newbb_4x/irmtfan/class/post.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method approve has 49 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function approve(&$post, $force = false)
              {
                  if (empty($post)) {
                      return false;
                  }
          Severity: Minor
          Found in extras/newbb_4x/irmtfan/class/post.php - About 1 hr to fix

            Function displayPostEdit has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

                public function displayPostEdit()
                {
                    global $myts;
            
                    if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])) {
            Severity: Minor
            Found in extras/newbb_4x/irmtfan/class/post.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method displayAttachment has 42 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function displayAttachment($asSource = false)
                {
                    $post_attachment = '';
                    $attachments     = $this->getAttachment();
                    if (is_array($attachments) && count($attachments) > 0) {
            Severity: Minor
            Found in extras/newbb_4x/irmtfan/class/post.php - About 1 hr to fix

              Function approve has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function approve(&$post, $force = false)
                  {
                      if (empty($post)) {
                          return false;
                      }
              Severity: Minor
              Found in extras/newbb_4x/irmtfan/class/post.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method getPostBody has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function &getPostBody()
                  {
                      global $myts;
                      $GLOBALS['xoopsModuleConfig'] = newbb_load_config(); // irmtfan  load all newbb configs - newbb config in blocks activated in some modules like profile
                      mod_loadFunctions('user', 'newbb');
              Severity: Minor
              Found in extras/newbb_4x/irmtfan/class/post.php - About 1 hr to fix

                Function getPostBody has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function &getPostBody()
                    {
                        global $myts;
                        $GLOBALS['xoopsModuleConfig'] = newbb_load_config(); // irmtfan  load all newbb configs - newbb config in blocks activated in some modules like profile
                        mod_loadFunctions('user', 'newbb');
                Severity: Minor
                Found in extras/newbb_4x/irmtfan/class/post.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method delete has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function delete($post, $isDeleteOne = true, $force = false)
                    {
                        $retVal = false;
                        if (($post instanceof Post) && ($post->getVar('post_id') > 0)) {
                            if ($isDeleteOne) {
                Severity: Minor
                Found in extras/newbb_4x/irmtfan/class/post.php - About 1 hr to fix

                  Function deleteAttachment has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function deleteAttachment($attach_array = null)
                      {
                          $attach_old = $this->getAttachment();
                          if (!is_array($attach_old) || count($attach_old) < 1) {
                              return true;
                  Severity: Minor
                  Found in extras/newbb_4x/irmtfan/class/post.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method setPostEdit has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function setPostEdit($poster_name = '', $post_editmsg = '')
                      {
                          if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])
                              || (time() - $this->getVar('post_time')) < $GLOBALS['xoopsModuleConfig']['recordedit_timelimit'] * 60
                              || $this->getVar('approved') < 1
                  Severity: Minor
                  Found in extras/newbb_4x/irmtfan/class/post.php - About 1 hr to fix

                    Method displayPostEdit has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function displayPostEdit()
                        {
                            global $myts;
                    
                            if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])) {
                    Severity: Minor
                    Found in extras/newbb_4x/irmtfan/class/post.php - About 1 hr to fix

                      Method deleteAttachment has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function deleteAttachment($attach_array = null)
                          {
                              $attach_old = $this->getAttachment();
                              if (!is_array($attach_old) || count($attach_old) < 1) {
                                  return true;
                      Severity: Minor
                      Found in extras/newbb_4x/irmtfan/class/post.php - About 1 hr to fix

                        Function setPostEdit has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function setPostEdit($poster_name = '', $post_editmsg = '')
                            {
                                if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])
                                    || (time() - $this->getVar('post_time')) < $GLOBALS['xoopsModuleConfig']['recordedit_timelimit'] * 60
                                    || $this->getVar('approved') < 1
                        Severity: Minor
                        Found in extras/newbb_4x/irmtfan/class/post.php - About 55 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Consider simplifying this complex logical expression.
                        Open

                                if ($isadmin || $this->checkIdentity()) {
                                    $post_text       = $this->getVar('post_text');
                                    $post_attachment = $this->displayAttachment();
                                } elseif ($GLOBALS['xoopsModuleConfig']['enable_karma'] && $this->getVar('post_karma') > $user_karma) {
                                    $post_text       = "<div class='karma'>" . sprintf(_MD_KARMA_REQUIREMENT, $user_karma, $this->getVar('post_karma')) . '</div>';
                        Severity: Major
                        Found in extras/newbb_4x/irmtfan/class/post.php - About 40 mins to fix

                          Function getPostsByLimit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function &getPostsByLimit($criteria = null, $limit = 1, $start = 0, $join = null)
                              {
                                  $ret = array();
                                  $sql = 'SELECT p.*, t.* ' . 'FROM ' . $this->db->prefix('bb_posts') . ' AS p ' . 'LEFT JOIN ' . $this->db->prefix('bb_posts_text') . ' AS t ON t.post_id = p.post_id';
                                  if (!empty($join)) {
                          Severity: Minor
                          Found in extras/newbb_4x/irmtfan/class/post.php - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Avoid too many return statements within this method.
                          Open

                                              return false;
                          Severity: Major
                          Found in extras/newbb_4x/irmtfan/class/post.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                            return false;
                            Severity: Major
                            Found in extras/newbb_4x/irmtfan/class/post.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                              return false;
                              Severity: Major
                              Found in extras/newbb_4x/irmtfan/class/post.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                        return $post->getVar('post_id');
                                Severity: Major
                                Found in extras/newbb_4x/irmtfan/class/post.php - About 30 mins to fix

                                  The method insert() has 113 lines of code. Current threshold is set to 100. Avoid really long methods.
                                  Open

                                      public function insert(XoopsObject $post, $force = true)
                                      {
                                          // Set the post time
                                          // The time should be 'publish' time. To be adjusted later
                                          if (!$post->getVar('post_time')) {

                                  The method insert() has an NPath complexity of 1632. The configured NPath complexity threshold is 200.
                                  Open

                                      public function insert(XoopsObject $post, $force = true)
                                      {
                                          // Set the post time
                                          // The time should be 'publish' time. To be adjusted later
                                          if (!$post->getVar('post_time')) {

                                  NPathComplexity

                                  Since: 0.1

                                  The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                  Example

                                  class Foo {
                                      function bar() {
                                          // lots of complicated code
                                      }
                                  }

                                  Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                  The method approve() has an NPath complexity of 1536. The configured NPath complexity threshold is 200.
                                  Open

                                      public function approve(&$post, $force = false)
                                      {
                                          if (empty($post)) {
                                              return false;
                                          }

                                  NPathComplexity

                                  Since: 0.1

                                  The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                  Example

                                  class Foo {
                                      function bar() {
                                          // lots of complicated code
                                      }
                                  }

                                  Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                  The method showPost() has 242 lines of code. Current threshold is set to 100. Avoid really long methods.
                                  Open

                                      public function showPost($isadmin)
                                      {
                                          global $myts;
                                          global $forumUrl, $forumImage;
                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  The method showPost() has an NPath complexity of 79781760. The configured NPath complexity threshold is 200.
                                  Open

                                      public function showPost($isadmin)
                                      {
                                          global $myts;
                                          global $forumUrl, $forumImage;
                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  NPathComplexity

                                  Since: 0.1

                                  The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                  Example

                                  class Foo {
                                      function bar() {
                                          // lots of complicated code
                                      }
                                  }

                                  Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                  The method _delete() has an NPath complexity of 19929. The configured NPath complexity threshold is 200.
                                  Open

                                      private function _delete(&$post, $force = false)
                                      {
                                          if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
                                              return false;
                                          }

                                  NPathComplexity

                                  Since: 0.1

                                  The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                  Example

                                  class Foo {
                                      function bar() {
                                          // lots of complicated code
                                      }
                                  }

                                  Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                  The method _delete() has 120 lines of code. Current threshold is set to 100. Avoid really long methods.
                                  Open

                                      private function _delete(&$post, $force = false)
                                      {
                                          if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
                                              return false;
                                          }

                                  The method displayPostEdit() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
                                  Open

                                      public function displayPostEdit()
                                      {
                                          global $myts;
                                  
                                          if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])) {

                                  CyclomaticComplexity

                                  Since: 0.1

                                  Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                  Example

                                  // Cyclomatic Complexity = 11
                                  class Foo {
                                  1   public function example() {
                                  2       if ($a == $b) {
                                  3           if ($a1 == $b1) {
                                                  fiddle();
                                  4           } elseif ($a2 == $b2) {
                                                  fiddle();
                                              } else {
                                                  fiddle();
                                              }
                                  5       } elseif ($c == $d) {
                                  6           while ($c == $d) {
                                                  fiddle();
                                              }
                                  7        } elseif ($e == $f) {
                                  8           for ($n = 0; $n < $h; $n++) {
                                                  fiddle();
                                              }
                                          } else {
                                              switch ($z) {
                                  9               case 1:
                                                      fiddle();
                                                      break;
                                  10              case 2:
                                                      fiddle();
                                                      break;
                                  11              case 3:
                                                      fiddle();
                                                      break;
                                                  default:
                                                      fiddle();
                                                      break;
                                              }
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                  The method getPostBody() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
                                  Open

                                      public function &getPostBody()
                                      {
                                          global $myts;
                                          $GLOBALS['xoopsModuleConfig'] = newbb_load_config(); // irmtfan  load all newbb configs - newbb config in blocks activated in some modules like profile
                                          mod_loadFunctions('user', 'newbb');

                                  CyclomaticComplexity

                                  Since: 0.1

                                  Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                  Example

                                  // Cyclomatic Complexity = 11
                                  class Foo {
                                  1   public function example() {
                                  2       if ($a == $b) {
                                  3           if ($a1 == $b1) {
                                                  fiddle();
                                  4           } elseif ($a2 == $b2) {
                                                  fiddle();
                                              } else {
                                                  fiddle();
                                              }
                                  5       } elseif ($c == $d) {
                                  6           while ($c == $d) {
                                                  fiddle();
                                              }
                                  7        } elseif ($e == $f) {
                                  8           for ($n = 0; $n < $h; $n++) {
                                                  fiddle();
                                              }
                                          } else {
                                              switch ($z) {
                                  9               case 1:
                                                      fiddle();
                                                      break;
                                  10              case 2:
                                                      fiddle();
                                                      break;
                                  11              case 3:
                                                      fiddle();
                                                      break;
                                                  default:
                                                      fiddle();
                                                      break;
                                              }
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                  The method displayAttachment() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
                                  Open

                                      public function displayAttachment($asSource = false)
                                      {
                                          $post_attachment = '';
                                          $attachments     = $this->getAttachment();
                                          if (is_array($attachments) && count($attachments) > 0) {

                                  CyclomaticComplexity

                                  Since: 0.1

                                  Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                  Example

                                  // Cyclomatic Complexity = 11
                                  class Foo {
                                  1   public function example() {
                                  2       if ($a == $b) {
                                  3           if ($a1 == $b1) {
                                                  fiddle();
                                  4           } elseif ($a2 == $b2) {
                                                  fiddle();
                                              } else {
                                                  fiddle();
                                              }
                                  5       } elseif ($c == $d) {
                                  6           while ($c == $d) {
                                                  fiddle();
                                              }
                                  7        } elseif ($e == $f) {
                                  8           for ($n = 0; $n < $h; $n++) {
                                                  fiddle();
                                              }
                                          } else {
                                              switch ($z) {
                                  9               case 1:
                                                      fiddle();
                                                      break;
                                  10              case 2:
                                                      fiddle();
                                                      break;
                                  11              case 3:
                                                      fiddle();
                                                      break;
                                                  default:
                                                      fiddle();
                                                      break;
                                              }
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                  The method showPost() has a Cyclomatic Complexity of 42. The configured cyclomatic complexity threshold is 10.
                                  Open

                                      public function showPost($isadmin)
                                      {
                                          global $myts;
                                          global $forumUrl, $forumImage;
                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  CyclomaticComplexity

                                  Since: 0.1

                                  Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                  Example

                                  // Cyclomatic Complexity = 11
                                  class Foo {
                                  1   public function example() {
                                  2       if ($a == $b) {
                                  3           if ($a1 == $b1) {
                                                  fiddle();
                                  4           } elseif ($a2 == $b2) {
                                                  fiddle();
                                              } else {
                                                  fiddle();
                                              }
                                  5       } elseif ($c == $d) {
                                  6           while ($c == $d) {
                                                  fiddle();
                                              }
                                  7        } elseif ($e == $f) {
                                  8           for ($n = 0; $n < $h; $n++) {
                                                  fiddle();
                                              }
                                          } else {
                                              switch ($z) {
                                  9               case 1:
                                                      fiddle();
                                                      break;
                                  10              case 2:
                                                      fiddle();
                                                      break;
                                  11              case 3:
                                                      fiddle();
                                                      break;
                                                  default:
                                                      fiddle();
                                                      break;
                                              }
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                  The method approve() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
                                  Open

                                      public function approve(&$post, $force = false)
                                      {
                                          if (empty($post)) {
                                              return false;
                                          }

                                  CyclomaticComplexity

                                  Since: 0.1

                                  Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                  Example

                                  // Cyclomatic Complexity = 11
                                  class Foo {
                                  1   public function example() {
                                  2       if ($a == $b) {
                                  3           if ($a1 == $b1) {
                                                  fiddle();
                                  4           } elseif ($a2 == $b2) {
                                                  fiddle();
                                              } else {
                                                  fiddle();
                                              }
                                  5       } elseif ($c == $d) {
                                  6           while ($c == $d) {
                                                  fiddle();
                                              }
                                  7        } elseif ($e == $f) {
                                  8           for ($n = 0; $n < $h; $n++) {
                                                  fiddle();
                                              }
                                          } else {
                                              switch ($z) {
                                  9               case 1:
                                                      fiddle();
                                                      break;
                                  10              case 2:
                                                      fiddle();
                                                      break;
                                  11              case 3:
                                                      fiddle();
                                                      break;
                                                  default:
                                                      fiddle();
                                                      break;
                                              }
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                  The method setPostEdit() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
                                  Open

                                      public function setPostEdit($poster_name = '', $post_editmsg = '')
                                      {
                                          if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])
                                              || (time() - $this->getVar('post_time')) < $GLOBALS['xoopsModuleConfig']['recordedit_timelimit'] * 60
                                              || $this->getVar('approved') < 1

                                  CyclomaticComplexity

                                  Since: 0.1

                                  Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                  Example

                                  // Cyclomatic Complexity = 11
                                  class Foo {
                                  1   public function example() {
                                  2       if ($a == $b) {
                                  3           if ($a1 == $b1) {
                                                  fiddle();
                                  4           } elseif ($a2 == $b2) {
                                                  fiddle();
                                              } else {
                                                  fiddle();
                                              }
                                  5       } elseif ($c == $d) {
                                  6           while ($c == $d) {
                                                  fiddle();
                                              }
                                  7        } elseif ($e == $f) {
                                  8           for ($n = 0; $n < $h; $n++) {
                                                  fiddle();
                                              }
                                          } else {
                                              switch ($z) {
                                  9               case 1:
                                                      fiddle();
                                                      break;
                                  10              case 2:
                                                      fiddle();
                                                      break;
                                  11              case 3:
                                                      fiddle();
                                                      break;
                                                  default:
                                                      fiddle();
                                                      break;
                                              }
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                  The method insert() has a Cyclomatic Complexity of 20. The configured cyclomatic complexity threshold is 10.
                                  Open

                                      public function insert(XoopsObject $post, $force = true)
                                      {
                                          // Set the post time
                                          // The time should be 'publish' time. To be adjusted later
                                          if (!$post->getVar('post_time')) {

                                  CyclomaticComplexity

                                  Since: 0.1

                                  Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                  Example

                                  // Cyclomatic Complexity = 11
                                  class Foo {
                                  1   public function example() {
                                  2       if ($a == $b) {
                                  3           if ($a1 == $b1) {
                                                  fiddle();
                                  4           } elseif ($a2 == $b2) {
                                                  fiddle();
                                              } else {
                                                  fiddle();
                                              }
                                  5       } elseif ($c == $d) {
                                  6           while ($c == $d) {
                                                  fiddle();
                                              }
                                  7        } elseif ($e == $f) {
                                  8           for ($n = 0; $n < $h; $n++) {
                                                  fiddle();
                                              }
                                          } else {
                                              switch ($z) {
                                  9               case 1:
                                                      fiddle();
                                                      break;
                                  10              case 2:
                                                      fiddle();
                                                      break;
                                  11              case 3:
                                                      fiddle();
                                                      break;
                                                  default:
                                                      fiddle();
                                                      break;
                                              }
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                  The method _delete() has a Cyclomatic Complexity of 30. The configured cyclomatic complexity threshold is 10.
                                  Open

                                      private function _delete(&$post, $force = false)
                                      {
                                          if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
                                              return false;
                                          }

                                  CyclomaticComplexity

                                  Since: 0.1

                                  Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                  Example

                                  // Cyclomatic Complexity = 11
                                  class Foo {
                                  1   public function example() {
                                  2       if ($a == $b) {
                                  3           if ($a1 == $b1) {
                                                  fiddle();
                                  4           } elseif ($a2 == $b2) {
                                                  fiddle();
                                              } else {
                                                  fiddle();
                                              }
                                  5       } elseif ($c == $d) {
                                  6           while ($c == $d) {
                                                  fiddle();
                                              }
                                  7        } elseif ($e == $f) {
                                  8           for ($n = 0; $n < $h; $n++) {
                                                  fiddle();
                                              }
                                          } else {
                                              switch ($z) {
                                  9               case 1:
                                                      fiddle();
                                                      break;
                                  10              case 2:
                                                      fiddle();
                                                      break;
                                  11              case 3:
                                                      fiddle();
                                                      break;
                                                  default:
                                                      fiddle();
                                                      break;
                                              }
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                  Avoid using undefined variables such as '$counter' which will lead to PHP notices.
                                  Open

                                              $key                          = (string)(time() + $counter++);

                                  UndefinedVariable

                                  Since: 2.8.0

                                  Detects when a variable is used that has not been defined before.

                                  Example

                                  class Foo
                                  {
                                      private function bar()
                                      {
                                          // $message is undefined
                                          echo $message;
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                                  Avoid using undefined variables such as '$viewtopic_users' which will lead to PHP notices.
                                  Open

                                                        || !isset($viewtopic_users[$uid]))

                                  UndefinedVariable

                                  Since: 2.8.0

                                  Detects when a variable is used that has not been defined before.

                                  Example

                                  class Foo
                                  {
                                      private function bar()
                                      {
                                          // $message is undefined
                                          echo $message;
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                                  Avoid using undefined variables such as '$eachposter' which will lead to PHP notices.
                                  Open

                                          unset($thread_buttons, $mod_buttons, $eachposter);

                                  UndefinedVariable

                                  Since: 2.8.0

                                  Detects when a variable is used that has not been defined before.

                                  Example

                                  class Foo
                                  {
                                      private function bar()
                                      {
                                          // $message is undefined
                                          echo $message;
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                                  Avoid using undefined variables such as '$post_NO' which will lead to PHP notices.
                                  Open

                                          ++$post_NO;

                                  UndefinedVariable

                                  Since: 2.8.0

                                  Detects when a variable is used that has not been defined before.

                                  Example

                                  class Foo
                                  {
                                      private function bar()
                                      {
                                          // $message is undefined
                                          echo $message;
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                                  Avoid using undefined variables such as '$post_NO' which will lead to PHP notices.
                                  Open

                                              $post_no = $start + $post_NO;

                                  UndefinedVariable

                                  Since: 2.8.0

                                  Detects when a variable is used that has not been defined before.

                                  Example

                                  class Foo
                                  {
                                      private function bar()
                                      {
                                          // $message is undefined
                                          echo $message;
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                                  Avoid using undefined variables such as '$post_NO' which will lead to PHP notices.
                                  Open

                                              $post_no = $total_posts - ($start + $post_NO) + 1;

                                  UndefinedVariable

                                  Since: 2.8.0

                                  Detects when a variable is used that has not been defined before.

                                  Example

                                  class Foo
                                  {
                                      private function bar()
                                      {
                                          // $message is undefined
                                          echo $message;
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                                  Avoid using undefined variables such as '$myObjtree' which will lead to PHP notices.
                                  Open

                                                  $arr       = $myObjtree->getAllChild(); // get all children of this object

                                  UndefinedVariable

                                  Since: 2.8.0

                                  Detects when a variable is used that has not been defined before.

                                  Example

                                  class Foo
                                  {
                                      private function bar()
                                      {
                                          // $message is undefined
                                          echo $message;
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                                  Remove error control operator '@' on line 149.
                                  Open

                                      public function deleteAttachment($attach_array = null)
                                      {
                                          $attach_old = $this->getAttachment();
                                          if (!is_array($attach_old) || count($attach_old) < 1) {
                                              return true;

                                  ErrorControlOperator

                                  Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

                                  Example

                                  function foo($filePath) {
                                      $file = @fopen($filPath); // hides exceptions
                                      $key = @$array[$notExistingKey]; // assigns null to $key
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

                                  Remove error control operator '@' on line 150.
                                  Open

                                      public function deleteAttachment($attach_array = null)
                                      {
                                          $attach_old = $this->getAttachment();
                                          if (!is_array($attach_old) || count($attach_old) < 1) {
                                              return true;

                                  ErrorControlOperator

                                  Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

                                  Example

                                  function foo($filePath) {
                                      $file = @fopen($filPath); // hides exceptions
                                      $key = @$array[$notExistingKey]; // assigns null to $key
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

                                  Remove error control operator '@' on line 89.
                                  Open

                                      public function getAttachment()
                                      {
                                          if (count($this->attachment_array)) {
                                              return $this->attachment_array;
                                          }

                                  ErrorControlOperator

                                  Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

                                  Example

                                  function foo($filePath) {
                                      $file = @fopen($filPath); // hides exceptions
                                      $key = @$array[$notExistingKey]; // assigns null to $key
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

                                  The method approve has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.
                                  Open

                                      public function approve(&$post, $force = false)

                                  BooleanArgumentFlag

                                  Since: 1.4.0

                                  A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                                  Example

                                  class Foo {
                                      public function bar($flag = true) {
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                                  Remove error control operator '@' on line 220.
                                  Open

                                      public function displayAttachment($asSource = false)
                                      {
                                          $post_attachment = '';
                                          $attachments     = $this->getAttachment();
                                          if (is_array($attachments) && count($attachments) > 0) {

                                  ErrorControlOperator

                                  Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

                                  Example

                                  function foo($filePath) {
                                      $file = @fopen($filPath); // hides exceptions
                                      $key = @$array[$notExistingKey]; // assigns null to $key
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

                                  The method insert has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.
                                  Open

                                      public function insert(XoopsObject $post, $force = true)

                                  BooleanArgumentFlag

                                  Since: 1.4.0

                                  A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                                  Example

                                  class Foo {
                                      public function bar($flag = true) {
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                                  The method displayAttachment has a boolean flag argument $asSource, which is a certain sign of a Single Responsibility Principle violation.
                                  Open

                                      public function displayAttachment($asSource = false)

                                  BooleanArgumentFlag

                                  Since: 1.4.0

                                  A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                                  Example

                                  class Foo {
                                      public function bar($flag = true) {
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                                  Remove error control operator '@' on line 656.
                                  Open

                                      public function showPost($isadmin)
                                      {
                                          global $myts;
                                          global $forumUrl, $forumImage;
                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  ErrorControlOperator

                                  Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

                                  Example

                                  function foo($filePath) {
                                      $file = @fopen($filPath); // hides exceptions
                                      $key = @$array[$notExistingKey]; // assigns null to $key
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

                                  Missing class import via use statement (line '1046', column '60').
                                  Open

                                                                  $logHandler->deleteAll(new Criteria('poll_id', $poll_id, '='));

                                  MissingImport

                                  Since: 2.7.0

                                  Importing all external classes in a file through use statements makes them clearly visible.

                                  Example

                                  function make() {
                                      return new \stdClass();
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                                  The method _delete has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.
                                  Open

                                      private function _delete(&$post, $force = false)

                                  BooleanArgumentFlag

                                  Since: 1.4.0

                                  A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                                  Example

                                  class Foo {
                                      public function bar($flag = true) {
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                                  Missing class import via use statement (line '945', column '40').
                                  Open

                                                      $criteria->add(new Criteria('approved', 1));

                                  MissingImport

                                  Since: 2.7.0

                                  Importing all external classes in a file through use statements makes them clearly visible.

                                  Example

                                  function make() {
                                      return new \stdClass();
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                                  Missing class import via use statement (line '1240', column '28').
                                  Open

                                          $crit_expire = new CriteriaCompo(new Criteria('approved', 0, '<='));

                                  MissingImport

                                  Since: 2.7.0

                                  Importing all external classes in a file through use statements makes them clearly visible.

                                  Example

                                  function make() {
                                      return new \stdClass();
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                                  Missing class import via use statement (line '946', column '40').
                                  Open

                                                      $criteria->add(new Criteria('pid', 0, '>'));

                                  MissingImport

                                  Since: 2.7.0

                                  Importing all external classes in a file through use statements makes them clearly visible.

                                  Example

                                  function make() {
                                      return new \stdClass();
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                                  The method delete has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.
                                  Open

                                      public function delete($post, $isDeleteOne = true, $force = false)

                                  BooleanArgumentFlag

                                  Since: 1.4.0

                                  A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                                  Example

                                  class Foo {
                                      public function bar($flag = true) {
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                                  Missing class import via use statement (line '957', column '34').
                                  Open

                                                  $myObjTree = new XoopsObjectTree($this->getAll(), 'post_id', 'pid', $post->getVar('post_id'));

                                  MissingImport

                                  Since: 2.7.0

                                  Importing all external classes in a file through use statements makes them clearly visible.

                                  Example

                                  function make() {
                                      return new \stdClass();
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                                  Missing class import via use statement (line '1042', column '71').
                                  Open

                                                              if (false !== $pollHandler->deleteAll(new Criteria('poll_id', $poll_id, '='))) {

                                  MissingImport

                                  Since: 2.7.0

                                  Importing all external classes in a file through use statements makes them clearly visible.

                                  Example

                                  function make() {
                                      return new \stdClass();
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                                  Missing class import via use statement (line '1242', column '31').
                                  Open

                                          $crit_expire->add(new Criteria('post_time', time() - (int)$expire, '<'));

                                  MissingImport

                                  Since: 2.7.0

                                  Importing all external classes in a file through use statements makes them clearly visible.

                                  Example

                                  function make() {
                                      return new \stdClass();
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                                  Missing class import via use statement (line '1240', column '46').
                                  Open

                                          $crit_expire = new CriteriaCompo(new Criteria('approved', 0, '<='));

                                  MissingImport

                                  Since: 2.7.0

                                  Importing all external classes in a file through use statements makes them clearly visible.

                                  Example

                                  function make() {
                                      return new \stdClass();
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                                  Missing class import via use statement (line '1059', column '45').
                                  Open

                                                                  $poll = new Umfrage($poll_id);

                                  MissingImport

                                  Since: 2.7.0

                                  Importing all external classes in a file through use statements makes them clearly visible.

                                  Example

                                  function make() {
                                      return new \stdClass();
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                                  Missing class import via use statement (line '1197', column '30').
                                  Open

                                          $this->deleteAll(new Criteria('post_time', 0), true, true);

                                  MissingImport

                                  Since: 2.7.0

                                  Importing all external classes in a file through use statements makes them clearly visible.

                                  Example

                                  function make() {
                                      return new \stdClass();
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                                  Missing class import via use statement (line '944', column '37').
                                  Open

                                                      $criteria = new CriteriaCompo(new Criteria('topic_id', $post->getVar('topic_id')));

                                  MissingImport

                                  Since: 2.7.0

                                  Importing all external classes in a file through use statements makes them clearly visible.

                                  Example

                                  function make() {
                                      return new \stdClass();
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                                  Missing class import via use statement (line '1044', column '63').
                                  Open

                                                                  $optionHandler->deleteAll(new Criteria('poll_id', $poll_id, '='));

                                  MissingImport

                                  Since: 2.7.0

                                  Importing all external classes in a file through use statements makes them clearly visible.

                                  Example

                                  function make() {
                                      return new \stdClass();
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                                  The method delete has a boolean flag argument $isDeleteOne, which is a certain sign of a Single Responsibility Principle violation.
                                  Open

                                      public function delete($post, $isDeleteOne = true, $force = false)

                                  BooleanArgumentFlag

                                  Since: 1.4.0

                                  A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                                  Example

                                  class Foo {
                                      public function bar($flag = true) {
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                                  Missing class import via use statement (line '944', column '55').
                                  Open

                                                      $criteria = new CriteriaCompo(new Criteria('topic_id', $post->getVar('topic_id')));

                                  MissingImport

                                  Since: 2.7.0

                                  Importing all external classes in a file through use statements makes them clearly visible.

                                  Example

                                  function make() {
                                      return new \stdClass();
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#MissingImport

                                  Avoid assigning values to variables in if clauses and the like (line '120', column '14').
                                  Open

                                      public function saveAttachment()
                                      {
                                          $attachment_save = '';
                                          if (is_array($this->attachment_array) && count($this->attachment_array) > 0) {
                                              $attachment_save = base64_encode(serialize($this->attachment_array));

                                  IfStatementAssignment

                                  Since: 2.7.0

                                  Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($foo = 'bar') { // possible typo
                                              // ...
                                          }
                                          if ($baz = 0) { // always false
                                              // ...
                                          }
                                      }
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                  The method setAttachment uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                          } else {
                                              $attachment_save = null;
                                          }

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  The method getAttachment uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                          } else {
                                              $this->attachment_array = @unserialize(base64_decode($attachment));
                                          }

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  The method getPostBody uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                              } else {
                                                  $post['author'] = $eachposter->getVar('uname');
                                              }

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  The method deleteAttachment uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                          } else {
                                              $attachment_save = '';
                                          }

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  The method getPostBody uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                          } else {
                                              $post['text'] = $post_text . '<br>' . $this->displayAttachment();
                                          }

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  The method setPostEdit uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                              } else {
                                                  $edit_user = $GLOBALS['xoopsUser']->getVar('uname');
                                              }

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  The method showPost uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                          } else {
                                              $name   = ($post_name = $this->getVar('poster_name')) ? $post_name : $name_anonymous;
                                              $poster = array(
                                                  'poster_uid' => 0,
                                                  'name'       => $name,

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  Avoid using static access to class 'XoopsUserUtility' in method 'checkIdentity'.
                                  Open

                                                  $user_ip = XoopsUserUtility::getIP();

                                  StaticAccess

                                  Since: 1.4.0

                                  Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                  Example

                                  class Foo
                                  {
                                      public function bar()
                                      {
                                          Bar::baz();
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#staticaccess

                                  The method displayAttachment uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                                      } else {
                                                          $post_attachment .= _MD_NEWBB_SEENOTGUEST;
                                                      }

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  The method showPost uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                          } else {
                                              $post_text       = $this->getVar('post_text');
                                              $post_attachment = $this->displayAttachment();
                                          }

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  The method checkIdentity uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                          } else {
                                              static $user_ip;
                                              if (!isset($user_ip)) {
                                                  $user_ip = XoopsUserUtility::getIP();
                                              }

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  The method getPostBody uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                          } else {
                                              $post['author'] = $this->getVar('poster_name') ?: $GLOBALS['xoopsConfig']['anonymous'];
                                          }

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  Avoid assigning values to variables in if clauses and the like (line '876', column '18').
                                  Open

                                      public function insert(XoopsObject $post, $force = true)
                                      {
                                          // Set the post time
                                          // The time should be 'publish' time. To be adjusted later
                                          if (!$post->getVar('post_time')) {

                                  IfStatementAssignment

                                  Since: 2.7.0

                                  Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($foo = 'bar') { // possible typo
                                              // ...
                                          }
                                          if ($baz = 0) { // always false
                                              // ...
                                          }
                                      }
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                  Avoid assigning values to variables in if clauses and the like (line '902', column '22').
                                  Open

                                      public function insert(XoopsObject $post, $force = true)
                                      {
                                          // Set the post time
                                          // The time should be 'publish' time. To be adjusted later
                                          if (!$post->getVar('post_time')) {

                                  IfStatementAssignment

                                  Since: 2.7.0

                                  Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($foo = 'bar') { // possible typo
                                              // ...
                                          }
                                          if ($baz = 0) { // always false
                                              // ...
                                          }
                                      }
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                  Avoid assigning values to variables in if clauses and the like (line '503', column '13').
                                  Open

                                      public function showPost($isadmin)
                                      {
                                          global $myts;
                                          global $forumUrl, $forumImage;
                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  IfStatementAssignment

                                  Since: 2.7.0

                                  Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($foo = 'bar') { // possible typo
                                              // ...
                                          }
                                          if ($baz = 0) { // always false
                                              // ...
                                          }
                                      }
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                  The method showPost uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                          } else {
                                              $post_no = $start + $post_NO;
                                          }

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  Avoid assigning values to variables in if clauses and the like (line '829', column '13').
                                  Open

                                      public function insert(XoopsObject $post, $force = true)
                                      {
                                          // Set the post time
                                          // The time should be 'publish' time. To be adjusted later
                                          if (!$post->getVar('post_time')) {

                                  IfStatementAssignment

                                  Since: 2.7.0

                                  Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($foo = 'bar') { // possible typo
                                              // ...
                                          }
                                          if ($baz = 0) { // always false
                                              // ...
                                          }
                                      }
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                  The method showPost uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                          } else {
                                              $post_image = "<a name='{$post_id}'><img src='" . $GLOBALS['xoops']->url('images/icons/posticon.gif') . "' alt='' /></a>";
                                          }

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  The method approve uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                          } else {
                                              $topic_obj->setVar('topic_replies', $topic_obj->getVar('topic_replies') + 1);
                                          }

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  Avoid assigning values to variables in if clauses and the like (line '855', column '22').
                                  Open

                                      public function insert(XoopsObject $post, $force = true)
                                      {
                                          // Set the post time
                                          // The time should be 'publish' time. To be adjusted later
                                          if (!$post->getVar('post_time')) {

                                  IfStatementAssignment

                                  Since: 2.7.0

                                  Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($foo = 'bar') { // possible typo
                                              // ...
                                          }
                                          if ($baz = 0) { // always false
                                              // ...
                                          }
                                      }
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                  Avoid assigning values to variables in if clauses and the like (line '915', column '18').
                                  Open

                                      public function insert(XoopsObject $post, $force = true)
                                      {
                                          // Set the post time
                                          // The time should be 'publish' time. To be adjusted later
                                          if (!$post->getVar('post_time')) {

                                  IfStatementAssignment

                                  Since: 2.7.0

                                  Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($foo = 'bar') { // possible typo
                                              // ...
                                          }
                                          if ($baz = 0) { // always false
                                              // ...
                                          }
                                      }
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                  The method showPost uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                          } else {
                                              $mod_buttons['edit']['image'] = newbb_displayImage('p_edit', _EDIT);
                                              $mod_buttons['edit']['link']  = $GLOBALS['xoops']->url('modules/' . $GLOBALS['xoopsModule']->getVar('dirname') . "/edit.php?{$page_query}");
                                              $mod_buttons['edit']['name']  = _EDIT;
                                  
                                  

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  Avoid assigning values to variables in if clauses and the like (line '695', column '13').
                                  Open

                                      public function get($id)
                                      {
                                          $id   = (int)$id;
                                          $post = null;
                                          $sql  = 'SELECT p.*, t.* FROM ' . $this->db->prefix('bb_posts') . ' p LEFT JOIN ' . $this->db->prefix('bb_posts_text') . ' t ON p.post_id=t.post_id WHERE p.post_id=' . $id;

                                  IfStatementAssignment

                                  Since: 2.7.0

                                  Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($foo = 'bar') { // possible typo
                                              // ...
                                          }
                                          if ($baz = 0) { // always false
                                              // ...
                                          }
                                      }
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                  The method displayAttachment uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                                  } else {
                                                      $icon_filetype = $GLOBALS['xoops']->url("{$mime_path}/unknown.gif");
                                                  }

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  The method displayAttachment uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                                  } else {
                                                      if (empty($GLOBALS['xoopsModuleConfig']['show_userattach'])) {
                                                          $post_attachment .= "<a href='" . $GLOBALS['xoops']->url('/modules/' . $GLOBALS['xoopsModule']->getVar('dirname', 'n') . "/dl_attachment.php?attachid={$key}&amp;post_id=" . $this->getVar('post_id'))
                                                                              . "'> <img src='{$icon_filetype}' alt='{$filetype}' /> {$att['name_display']}</a> " . _MD_FILESIZE . ": {$file_size}; " . _MD_HITS . ": {$att['num_download']}";
                                                      } elseif (($GLOBALS['xoopsUser'] instanceof XoopsUser) && $GLOBALS['xoopsUser']->uid() > 0

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  Avoid assigning values to variables in if clauses and the like (line '847', column '18').
                                  Open

                                      public function insert(XoopsObject $post, $force = true)
                                      {
                                          // Set the post time
                                          // The time should be 'publish' time. To be adjusted later
                                          if (!$post->getVar('post_time')) {

                                  IfStatementAssignment

                                  Since: 2.7.0

                                  Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($foo = 'bar') { // possible typo
                                              // ...
                                          }
                                          if ($baz = 0) { // always false
                                              // ...
                                          }
                                      }
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                  The method insert uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                              } else {
                                                  $post->unsetNew();
                                              }

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  The method delete uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                              } else { // want to delete multiple posts
                                                  //@TODO: test replacement of XoopsTree with XoopsObjectTree
                                                  require_once $GLOBALS['xoops']->path('class/tree.php');
                                                  // get tree with this object as the root
                                                  $myObjTree = new XoopsObjectTree($this->getAll(), 'post_id', 'pid', $post->getVar('post_id'));

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  Avoid assigning values to variables in if clauses and the like (line '1000', column '18').
                                  Open

                                      private function _delete(&$post, $force = false)
                                      {
                                          if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
                                              return false;
                                          }

                                  IfStatementAssignment

                                  Since: 2.7.0

                                  Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($foo = 'bar') { // possible typo
                                              // ...
                                          }
                                          if ($baz = 0) { // always false
                                              // ...
                                          }
                                      }
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                  Avoid assigning values to variables in if clauses and the like (line '1103', column '22').
                                  Open

                                      private function _delete(&$post, $force = false)
                                      {
                                          if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
                                              return false;
                                          }

                                  IfStatementAssignment

                                  Since: 2.7.0

                                  Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($foo = 'bar') { // possible typo
                                              // ...
                                          }
                                          if ($baz = 0) { // always false
                                              // ...
                                          }
                                      }
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                  The method _delete uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                          } else {
                                              $sql = 'UPDATE ' . $this->db->prefix('bb_topics') . ' t ' . 'LEFT JOIN ' . $this->db->prefix('bb_posts') . ' p ON p.topic_id = t.topic_id ' . 'SET t.topic_last_post_id = p.post_id ' . 'WHERE t.topic_last_post_id = '
                                                     . $post->getVar('post_id') . ' ' . 'AND p.post_id = (SELECT MAX(post_id) FROM ' . $this->db->prefix('bb_posts') . ' ' . 'WHERE topic_id=t.topic_id)';
                                              if (!$result = $this->db->queryF($sql)) {
                                                  //@TODO: add error checking here

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  Avoid assigning values to variables in if clauses and the like (line '1215', column '14').
                                  Open

                                      public function cleanOrphan()
                                      {
                                          $this->deleteAll(new Criteria('post_time', 0), true, true);
                                          parent::cleanOrphan($this->db->prefix('bb_topics'), 'topic_id');
                                          parent::cleanOrphan($this->db->prefix('bb_posts_text'), 'post_id');

                                  IfStatementAssignment

                                  Since: 2.7.0

                                  Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($foo = 'bar') { // possible typo
                                              // ...
                                          }
                                          if ($baz = 0) { // always false
                                              // ...
                                          }
                                      }
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                  The method insert uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                              } else {
                                                  $post->unsetNew();
                                              }

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  Avoid assigning values to variables in if clauses and the like (line '1005', column '18').
                                  Open

                                      private function _delete(&$post, $force = false)
                                      {
                                          if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
                                              return false;
                                          }

                                  IfStatementAssignment

                                  Since: 2.7.0

                                  Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($foo = 'bar') { // possible typo
                                              // ...
                                          }
                                          if ($baz = 0) { // always false
                                              // ...
                                          }
                                      }
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                  The method delete uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                                  } else {
                                                      // did not successfully delte all children so don't delete this post
                                                      $retVal = false;
                                                  }

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  Avoid using static access to class 'UmfrageLog' in method '_delete'.
                                  Open

                                                                      UmfrageLog::deleteByPollId($poll_id);

                                  StaticAccess

                                  Since: 1.4.0

                                  Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                  Example

                                  class Foo
                                  {
                                      public function bar()
                                      {
                                          Bar::baz();
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#staticaccess

                                  Avoid assigning values to variables in if clauses and the like (line '1071', column '22').
                                  Open

                                      private function _delete(&$post, $force = false)
                                      {
                                          if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
                                              return false;
                                          }

                                  IfStatementAssignment

                                  Since: 2.7.0

                                  Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($foo = 'bar') { // possible typo
                                              // ...
                                          }
                                          if ($baz = 0) { // always false
                                              // ...
                                          }
                                      }
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                  Avoid assigning values to variables in if clauses and the like (line '1075', column '22').
                                  Open

                                      private function _delete(&$post, $force = false)
                                      {
                                          if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
                                              return false;
                                          }

                                  IfStatementAssignment

                                  Since: 2.7.0

                                  Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($foo = 'bar') { // possible typo
                                              // ...
                                          }
                                          if ($baz = 0) { // always false
                                              // ...
                                          }
                                      }
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                  The method cleanOrphan uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                          } else { /* for 4.0+ */
                                              /* */
                                              $sql = 'DELETE ' . $this->db->prefix('bb_posts_text') . ' FROM ' . $this->db->prefix('bb_posts_text') . ' ' . 'LEFT JOIN ' . $this->table . ' AS aa ON ' . $this->db->prefix('bb_posts_text') . '.post_id = aa.post_id ' . ' '
                                                     . 'WHERE (aa.post_id IS NULL)';
                                              /* */

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  Avoid assigning values to variables in if clauses and the like (line '1013', column '18').
                                  Open

                                      private function _delete(&$post, $force = false)
                                      {
                                          if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
                                              return false;
                                          }

                                  IfStatementAssignment

                                  Since: 2.7.0

                                  Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($foo = 'bar') { // possible typo
                                              // ...
                                          }
                                          if ($baz = 0) { // always false
                                              // ...
                                          }
                                      }
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                  Avoid assigning values to variables in if clauses and the like (line '1082', column '18').
                                  Open

                                      private function _delete(&$post, $force = false)
                                      {
                                          if ((!$post instanceof Post) || (0 === $post->getVar('post_id'))) {
                                              return false;
                                          }

                                  IfStatementAssignment

                                  Since: 2.7.0

                                  Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($foo = 'bar') { // possible typo
                                              // ...
                                          }
                                          if ($baz = 0) { // always false
                                              // ...
                                          }
                                      }
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                  The method _delete uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                                          } else {
                                                              $poll_moduleHandler = $moduleHandler->getByDirname('umfrage');
                                                              if (($poll_moduleHandler instanceof XoopsModuleHandler)
                                                                  && $poll_moduleHandler->isactive()
                                                              ) {

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  Avoid assigning values to variables in if clauses and the like (line '1132', column '14').
                                  Open

                                      public function getPostCount($criteria = null, $join = null)
                                      {
                                          // If not join get the count from XOOPS/class/model/stats as before
                                          if (empty($join)) {
                                              return parent::getCount($criteria);

                                  IfStatementAssignment

                                  Since: 2.7.0

                                  Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($foo = 'bar') { // possible typo
                                              // ...
                                          }
                                          if ($baz = 0) { // always false
                                              // ...
                                          }
                                      }
                                  }

                                  Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                  The method insert uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                          } else {
                                              if ($post->isTopic()) {
                                                  if ($post->getVar('subject') !== $topic_obj->getVar('topic_title')) {
                                                      $topic_obj->setVar('topic_title', $post->getVar('subject', 'n'));
                                                  }

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  The method _delete uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                          } else { /* delete pending post directly */
                                              $sql = sprintf('DELETE FROM %s WHERE post_id = %u', $this->db->prefix('bb_posts'), $post->getVar('post_id'));
                                              if (!$result = $this->db->queryF($sql)) {
                                                  $post->setErrors('delte post error: ' . $sql);
                                  
                                  

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  The method _delete uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                              } else {
                                                  if (is_object($topic_obj)) {
                                                      if ($topic_obj->getVar('approved') > 0) {
                                                          xoops_notification_deletebyitem($GLOBALS['xoopsModule']->getVar('mid'), 'thread', $post->getVar('topic_id'));
                                                      }

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  The method delete uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                  Open

                                                  } else {
                                                      $retVal = $this->_delete($post, $force);
                                                  }

                                  ElseExpression

                                  Since: 1.4.0

                                  An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                  Example

                                  class Foo
                                  {
                                      public function bar($flag)
                                      {
                                          if ($flag) {
                                              // one branch
                                          } else {
                                              // another branch
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#elseexpression

                                  Avoid using static access to class 'UmfrageOption' in method '_delete'.
                                  Open

                                                                      UmfrageOption::deleteByPollId($poll_id);

                                  StaticAccess

                                  Since: 1.4.0

                                  Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                                  Example

                                  class Foo
                                  {
                                      public function bar()
                                      {
                                          Bar::baz();
                                      }
                                  }

                                  Source https://phpmd.org/rules/cleancode.html#staticaccess

                                  Avoid unused local variables such as '$result'.
                                  Open

                                          if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {

                                  UnusedLocalVariable

                                  Since: 0.2

                                  Detects when a local variable is declared and/or assigned, but not used.

                                  Example

                                  class Foo {
                                      public function doSomething()
                                      {
                                          $i = 5; // Unused
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                  Avoid unused local variables such as '$myts'.
                                  Open

                                          global $myts;

                                  UnusedLocalVariable

                                  Since: 0.2

                                  Detects when a local variable is declared and/or assigned, but not used.

                                  Example

                                  class Foo {
                                      public function doSomething()
                                      {
                                          $i = 5; // Unused
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                  Avoid unused local variables such as '$forum_obj'.
                                  Open

                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  UnusedLocalVariable

                                  Since: 0.2

                                  Detects when a local variable is declared and/or assigned, but not used.

                                  Example

                                  class Foo {
                                      public function doSomething()
                                      {
                                          $i = 5; // Unused
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                  Avoid unused local variables such as '$eachposter'.
                                  Open

                                          unset($thread_buttons, $mod_buttons, $eachposter);

                                  UnusedLocalVariable

                                  Since: 0.2

                                  Detects when a local variable is declared and/or assigned, but not used.

                                  Example

                                  class Foo {
                                      public function doSomething()
                                      {
                                          $i = 5; // Unused
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                  Avoid unused local variables such as '$res'.
                                  Open

                                                  $res = $memberHandler->insertUser($poster, true);

                                  UnusedLocalVariable

                                  Since: 0.2

                                  Detects when a local variable is declared and/or assigned, but not used.

                                  Example

                                  class Foo {
                                      public function doSomething()
                                      {
                                          $i = 5; // Unused
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                  Avoid unused local variables such as '$viewmode'.
                                  Open

                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  UnusedLocalVariable

                                  Since: 0.2

                                  Detects when a local variable is declared and/or assigned, but not used.

                                  Example

                                  class Foo {
                                      public function doSomething()
                                      {
                                          $i = 5; // Unused
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                  Avoid unused parameters such as '$asSource'.
                                  Open

                                      public function displayAttachment($asSource = false)

                                  UnusedFormalParameter

                                  Since: 0.2

                                  Avoid passing parameters to methods or constructors and then not using those parameters.

                                  Example

                                  class Foo
                                  {
                                      private function bar($howdy)
                                      {
                                          // $howdy is not used
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                                  Avoid unused local variables such as '$isDisplayed'.
                                  Open

                                                      $isDisplayed = true;

                                  UnusedLocalVariable

                                  Since: 0.2

                                  Detects when a local variable is declared and/or assigned, but not used.

                                  Example

                                  class Foo {
                                      public function doSomething()
                                      {
                                          $i = 5; // Unused
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                  Avoid unused local variables such as '$forumImage'.
                                  Open

                                          global $forumUrl, $forumImage;

                                  UnusedLocalVariable

                                  Since: 0.2

                                  Detects when a local variable is declared and/or assigned, but not used.

                                  Example

                                  class Foo {
                                      public function doSomething()
                                      {
                                          $i = 5; // Unused
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                  Avoid unused local variables such as '$post_id'.
                                  Open

                                          $post_id = $post->getVar('post_id');

                                  UnusedLocalVariable

                                  Since: 0.2

                                  Detects when a local variable is declared and/or assigned, but not used.

                                  Example

                                  class Foo {
                                      public function doSomething()
                                      {
                                          $i = 5; // Unused
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                  Avoid unused parameters such as '$poster_name'.
                                  Open

                                      public function setPostEdit($poster_name = '', $post_editmsg = '')

                                  UnusedFormalParameter

                                  Since: 0.2

                                  Avoid passing parameters to methods or constructors and then not using those parameters.

                                  Example

                                  class Foo
                                  {
                                      private function bar($howdy)
                                      {
                                          // $howdy is not used
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                                  Avoid unused local variables such as '$online'.
                                  Open

                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  UnusedLocalVariable

                                  Since: 0.2

                                  Detects when a local variable is declared and/or assigned, but not used.

                                  Example

                                  class Foo {
                                      public function doSomething()
                                      {
                                          $i = 5; // Unused
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                  Avoid unused local variables such as '$forumUrl'.
                                  Open

                                          global $forumUrl, $forumImage;

                                  UnusedLocalVariable

                                  Since: 0.2

                                  Detects when a local variable is declared and/or assigned, but not used.

                                  Example

                                  class Foo {
                                      public function doSomething()
                                      {
                                          $i = 5; // Unused
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                  Avoid unused local variables such as '$viewtopic_users'.
                                  Open

                                                        || !isset($viewtopic_users[$uid]))

                                  UnusedLocalVariable

                                  Since: 0.2

                                  Detects when a local variable is declared and/or assigned, but not used.

                                  Example

                                  class Foo {
                                      public function doSomething()
                                      {
                                          $i = 5; // Unused
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                  Avoid unused local variables such as '$result'.
                                  Open

                                              if (!$result = $this->db->queryF($sql)) {

                                  UnusedLocalVariable

                                  Since: 0.2

                                  Detects when a local variable is declared and/or assigned, but not used.

                                  Example

                                  class Foo {
                                      public function doSomething()
                                      {
                                          $i = 5; // Unused
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                  Avoid unused local variables such as '$result'.
                                  Open

                                          if (!$result = $this->db->queryF($sql)) {

                                  UnusedLocalVariable

                                  Since: 0.2

                                  Detects when a local variable is declared and/or assigned, but not used.

                                  Example

                                  class Foo {
                                      public function doSomething()
                                      {
                                          $i = 5; // Unused
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                  Avoid unused local variables such as '$res'.
                                  Open

                                                      $res = $memberHandler->insertUser($poster, true);

                                  UnusedLocalVariable

                                  Since: 0.2

                                  Detects when a local variable is declared and/or assigned, but not used.

                                  Example

                                  class Foo {
                                      public function doSomething()
                                      {
                                          $i = 5; // Unused
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                  Avoid unused local variables such as '$myObjTree'.
                                  Open

                                                  $myObjTree = new XoopsObjectTree($this->getAll(), 'post_id', 'pid', $post->getVar('post_id'));

                                  UnusedLocalVariable

                                  Since: 0.2

                                  Detects when a local variable is declared and/or assigned, but not used.

                                  Example

                                  class Foo {
                                      public function doSomething()
                                      {
                                          $i = 5; // Unused
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                  Avoid unused local variables such as '$result'.
                                  Open

                                                  if (!$result = $topicHandler->insert($topic_obj, $force)) {

                                  UnusedLocalVariable

                                  Since: 0.2

                                  Detects when a local variable is declared and/or assigned, but not used.

                                  Example

                                  class Foo {
                                      public function doSomething()
                                      {
                                          $i = 5; // Unused
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                  Avoid unused local variables such as '$topiccount_toupdate'.
                                  Open

                                                  $topiccount_toupdate = 1;

                                  UnusedLocalVariable

                                  Since: 0.2

                                  Detects when a local variable is declared and/or assigned, but not used.

                                  Example

                                  class Foo {
                                      public function doSomething()
                                      {
                                          $i = 5; // Unused
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                  Avoid unused local variables such as '$myObjtree'.
                                  Open

                                                  $arr       = $myObjtree->getAllChild(); // get all children of this object

                                  UnusedLocalVariable

                                  Since: 0.2

                                  Detects when a local variable is declared and/or assigned, but not used.

                                  Example

                                  class Foo {
                                      public function doSomething()
                                      {
                                          $i = 5; // Unused
                                      }
                                  }

                                  Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                  TODO found
                                  Open

                                       * TODO: refactor

                                  TODO found
                                  Open

                                                  //@TODO: test replacement of XoopsTree with XoopsObjectTree

                                  TODO found
                                  Open

                                      // attachment functions    TODO: there should be a file/attachment management class

                                  TODO found
                                  Open

                                      // TODO: cleaning up and merge with post hanldings in viewpost.php

                                  TODO found
                                  Open

                                       *@TODO: combining viewtopic.php

                                  TODO found
                                  Open

                                                  //@TODO: add error check here

                                  TODO found
                                  Open

                                                  //@TODO: add error checking here

                                  Identical blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                          if ($GLOBALS['xoopsModuleConfig']['enable_permcheck']) {
                                              /** @var NewbbTopicHandler $topicHandler */
                                              $topicHandler = \XoopsModules\Newbb\Helper::getInstance()->getHandler('Topic');
                                              $topic_status  = $topic_obj->getVar('topic_status');
                                              if ($topicHandler->getPermission($forum_id, $topic_status, 'edit')) {
                                  Severity: Major
                                  Found in extras/newbb_4x/irmtfan/class/post.php and 1 other location - About 1 day to fix
                                  extras/newbb_5x/irmtfan/class/Post.php on lines 536..585

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 279.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 4 locations. Consider refactoring.
                                  Open

                                              if ($topicHandler->getPermission($forum_id, $topic_status, 'edit')) {
                                                  $edit_ok = ($isadmin || ($this->checkIdentity() && $this->checkTimelimit('edit_timelimit')));
                                                  if ($edit_ok) {
                                                      $thread_buttons['edit']['image'] = newbb_displayImage('p_edit', _EDIT);
                                                      $thread_buttons['edit']['link']  = $GLOBALS['xoops']->url('modules/' . $GLOBALS['xoopsModule']->getVar('dirname') . "/edit.php?{$page_query}");
                                  Severity: Major
                                  Found in extras/newbb_4x/irmtfan/class/post.php and 3 other locations - About 7 hrs to fix
                                  extras/newbb_4x/irmtfan/class/post.php on lines 541..552
                                  extras/newbb_5x/irmtfan/class/Post.php on lines 540..550
                                  extras/newbb_5x/irmtfan/class/Post.php on lines 552..563

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 230.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 4 locations. Consider refactoring.
                                  Open

                                              if ($topicHandler->getPermission($forum_id, $topic_status, 'delete')) {
                                                  $delete_ok = ($isadmin || ($this->checkIdentity() && $this->checkTimelimit('delete_timelimit')));
                                  
                                                  if ($delete_ok) {
                                                      $thread_buttons['delete']['image'] = newbb_displayImage('p_delete', _DELETE);
                                  Severity: Major
                                  Found in extras/newbb_4x/irmtfan/class/post.php and 3 other locations - About 7 hrs to fix
                                  extras/newbb_4x/irmtfan/class/post.php on lines 529..539
                                  extras/newbb_5x/irmtfan/class/Post.php on lines 540..550
                                  extras/newbb_5x/irmtfan/class/Post.php on lines 552..563

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 230.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Identical blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                          if ($isadmin
                                              && (($GLOBALS['xoopsUser'] instanceof XoopsUser)
                                                  && $GLOBALS['xoopsUser']->getVar('uid') !== $this->getVar('uid'))
                                              && ($this->getVar('uid') > 0)
                                          ) {
                                  Severity: Major
                                  Found in extras/newbb_4x/irmtfan/class/post.php and 1 other location - About 6 hrs to fix
                                  extras/newbb_5x/irmtfan/class/Post.php on lines 524..534

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 207.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Identical blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                              if ($topicHandler->getPermission($forum_id, $topic_status, 'reply')) {
                                                  $thread_buttons['reply']['image'] = newbb_displayImage('p_reply', _MD_REPLY);
                                                  $thread_buttons['reply']['link']  = $GLOBALS['xoops']->url('modules/' . $GLOBALS['xoopsModule']->getVar('dirname') . "/reply.php?{$page_query}");
                                                  $thread_buttons['reply']['name']  = _MD_REPLY;
                                  
                                  
                                  Severity: Major
                                  Found in extras/newbb_4x/irmtfan/class/post.php and 1 other location - About 5 hrs to fix
                                  extras/newbb_5x/irmtfan/class/Post.php on lines 564..572

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 202.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Identical blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                      public function setAttachment($name_saved = '', $name_display = '', $mimetype = '', $num_download = 0)
                                      {
                                          static $counter = 0;
                                          $this->attachment_array = $this->getAttachment();
                                          if ($name_saved) {
                                  Severity: Major
                                  Found in extras/newbb_4x/irmtfan/class/post.php and 1 other location - About 5 hrs to fix
                                  extras/newbb_4x/trunk_4_00/class/post.php on lines 159..180

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 191.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Identical blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                      public function &getByLimit($topic_id, $limit, $approved = 1)
                                      {
                                          $sql    = 'SELECT p.*, t.*, tp.topic_status FROM ' . $this->db->prefix('bb_posts') . ' p LEFT JOIN ' . $this->db->prefix('bb_posts_text') . ' t ON p.post_id=t.post_id LEFT JOIN ' . $this->db->prefix('bb_topics')
                                                    . ' tp ON tp.topic_id=p.topic_id WHERE p.topic_id=' . $topic_id . ' AND p.approved =' . $approved . ' ORDER BY p.post_time DESC';
                                          $result = $this->db->query($sql, $limit, 0);
                                  Severity: Major
                                  Found in extras/newbb_4x/irmtfan/class/post.php and 1 other location - About 4 hrs to fix
                                  extras/newbb_4x/trunk_4_00/class/post.php on lines 616..640

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 180.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Identical blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                                          if (($poll_moduleHandler instanceof XoopsModuleHandler) && $poll_moduleHandler->isactive()) {
                                                              $pollHandler = xoops_getModuleHandler('poll', 'xoopspoll');
                                                              if (false !== $pollHandler->deleteAll(new Criteria('poll_id', $poll_id, '='))) {
                                                                  $optionHandler = xoops_getModuleHandler('option', 'xoopspoll');
                                                                  $optionHandler->deleteAll(new Criteria('poll_id', $poll_id, '='));
                                  Severity: Major
                                  Found in extras/newbb_4x/irmtfan/class/post.php and 1 other location - About 3 hrs to fix
                                  extras/newbb_4x/trunk_4_00/class/post.php on lines 932..941

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 150.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Identical blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                              if ($post->isTopic()) {
                                                  if ($post->getVar('subject') !== $topic_obj->getVar('topic_title')) {
                                                      $topic_obj->setVar('topic_title', $post->getVar('subject', 'n'));
                                                  }
                                                  if ($post->getVar('approved') !== $topic_obj->getVar('approved')) {
                                  Severity: Major
                                  Found in extras/newbb_4x/irmtfan/class/post.php and 1 other location - About 2 hrs to fix
                                  extras/newbb_5x/irmtfan/class/PostHandler.php on lines 265..279

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 130.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                          if ($this->mysql_major_version() >= 4) { /* for MySQL 4.1+ */
                                              $sql = 'DELETE FROM ' . $this->db->prefix('bb_posts_text') . ' ' . 'WHERE (post_id NOT IN ( SELECT DISTINCT post_id FROM ' . $this->table . ') )';
                                          } else { /* for 4.0+ */
                                              /* */
                                              $sql = 'DELETE ' . $this->db->prefix('bb_posts_text') . ' FROM ' . $this->db->prefix('bb_posts_text') . ' ' . 'LEFT JOIN ' . $this->table . ' AS aa ON ' . $this->db->prefix('bb_posts_text') . '.post_id = aa.post_id ' . ' '
                                  Severity: Major
                                  Found in extras/newbb_4x/irmtfan/class/post.php and 1 other location - About 2 hrs to fix
                                  extras/newbb_5x/irmtfan/class/PostHandler.php on lines 586..598

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 130.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Identical blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                      public function get($id)
                                      {
                                          $id   = (int)$id;
                                          $post = null;
                                          $sql  = 'SELECT p.*, t.* FROM ' . $this->db->prefix('bb_posts') . ' p LEFT JOIN ' . $this->db->prefix('bb_posts_text') . ' t ON p.post_id=t.post_id WHERE p.post_id=' . $id;
                                  Severity: Major
                                  Found in extras/newbb_4x/irmtfan/class/post.php and 1 other location - About 2 hrs to fix
                                  extras/newbb_4x/trunk_4_00/class/post.php on lines 592..608

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 123.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                                      } elseif (($GLOBALS['xoopsUser'] instanceof XoopsUser) && $GLOBALS['xoopsUser']->uid() > 0
                                                                && $GLOBALS['xoopsUser']->isActive()
                                                      ) {
                                                          $post_attachment .= "<a href='" . $GLOBALS['xoops']->url('/modules/' . $GLOBALS['xoopsModule']->getVar('dirname', 'n') . "/dl_attachment.php?attachid={$key}&amp;post_id=" . $this->getVar('post_id')) . "'> <img src='"
                                                                              . $icon_filetype . "' alt='{$filetype}' /> {$att['name_display']}</a> " . _MD_FILESIZE . ": {$file_size}; " . _MD_HITS . ": {$att['num_download']}";
                                  Severity: Major
                                  Found in extras/newbb_4x/irmtfan/class/post.php and 1 other location - About 1 hr to fix
                                  extras/newbb_5x/irmtfan/class/Post.php on lines 229..240

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 112.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                          if ($post->isTopic()) {
                                              /** @var NewbbTopicHandler $topicHandler */
                                              $topicHandler = \XoopsModules\Newbb\Helper::getInstance()->getHandler('Topic');
                                              $topic_obj     = $topicHandler->get($post->getVar('topic_id'));
                                              if (is_object($topic_obj) && $topic_obj->getVar('approved') > 0 && empty($force)) {
                                  Severity: Major
                                  Found in extras/newbb_4x/irmtfan/class/post.php and 1 other location - About 1 hr to fix
                                  extras/newbb_5x/irmtfan/class/PostHandler.php on lines 391..467

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 112.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Identical blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                          if (!$isadmin && $GLOBALS['xoopsModuleConfig']['reportmod_enabled']) {
                                              $thread_buttons['report']['image'] = newbb_displayImage('p_report', _MD_REPORT);
                                              $thread_buttons['report']['link']  = $GLOBALS['xoops']->url('modules/' . $GLOBALS['xoopsModule']->getVar('dirname') . "/report.php?{$page_query}");
                                              $thread_buttons['report']['name']  = _MD_REPORT;
                                          }
                                  Severity: Major
                                  Found in extras/newbb_4x/irmtfan/class/post.php and 1 other location - About 1 hr to fix
                                  extras/newbb_5x/irmtfan/class/Post.php on lines 587..591

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 111.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Identical blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                          if ($topicHandler->getPermission($forum_id, $topic_status, 'print')) {
                                              $thread_action['print']['image']  = newbb_displayImage('printer', _MD_PRINT);
                                              $thread_action['print']['link']   = $GLOBALS['xoops']->url("modules/newbb/print.php?form=2&amp;forum={$forum_id}&amp;topic_id={$topic_id}");
                                              $thread_action['print']['name']   = _MD_PRINT;
                                              $thread_action['print']['target'] = '_blank';
                                  Severity: Major
                                  Found in extras/newbb_4x/irmtfan/class/post.php and 1 other location - About 1 hr to fix
                                  extras/newbb_5x/irmtfan/class/Post.php on lines 603..608

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 108.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                                      if (empty($GLOBALS['xoopsModuleConfig']['show_userattach'])) {
                                                          $post_attachment .= "<a href='" . $GLOBALS['xoops']->url('/modules/' . $GLOBALS['xoopsModule']->getVar('dirname', 'n') . "/dl_attachment.php?attachid={$key}&amp;post_id=" . $this->getVar('post_id'))
                                                                              . "'> <img src='{$icon_filetype}' alt='{$filetype}' /> {$att['name_display']}</a> " . _MD_FILESIZE . ": {$file_size}; " . _MD_HITS . ": {$att['num_download']}";
                                                      } elseif (($GLOBALS['xoopsUser'] instanceof XoopsUser) && $GLOBALS['xoopsUser']->uid() > 0
                                                                && $GLOBALS['xoopsUser']->isActive()
                                  Severity: Major
                                  Found in extras/newbb_4x/irmtfan/class/post.php and 1 other location - About 1 hr to fix
                                  extras/newbb_5x/irmtfan/class/Post.php on lines 221..242

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 106.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Each class must be in a namespace of at least one level (a top-level vendor name)
                                  Open

                                  class Post extends XoopsObject

                                  Each class must be in a namespace of at least one level (a top-level vendor name)
                                  Open

                                  class NewbbPostHandler extends XoopsPersistableObjectHandler

                                  The parameter $name_display is not named in camelCase.
                                  Open

                                      public function setAttachment($name_saved = '', $name_display = '', $mimetype = '', $num_download = 0)
                                      {
                                          static $counter = 0;
                                          $this->attachment_array = $this->getAttachment();
                                          if ($name_saved) {

                                  CamelCaseParameterName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name parameters.

                                  Example

                                  class ClassName {
                                      public function doSomething($user_name) {
                                      }
                                  }

                                  Source

                                  The parameter $name_saved is not named in camelCase.
                                  Open

                                      public function setAttachment($name_saved = '', $name_display = '', $mimetype = '', $num_download = 0)
                                      {
                                          static $counter = 0;
                                          $this->attachment_array = $this->getAttachment();
                                          if ($name_saved) {

                                  CamelCaseParameterName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name parameters.

                                  Example

                                  class ClassName {
                                      public function doSomething($user_name) {
                                      }
                                  }

                                  Source

                                  The parameter $attach_array is not named in camelCase.
                                  Open

                                      public function deleteAttachment($attach_array = null)
                                      {
                                          $attach_old = $this->getAttachment();
                                          if (!is_array($attach_old) || count($attach_old) < 1) {
                                              return true;

                                  CamelCaseParameterName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name parameters.

                                  Example

                                  class ClassName {
                                      public function doSomething($user_name) {
                                      }
                                  }

                                  Source

                                  The parameter $num_download is not named in camelCase.
                                  Open

                                      public function setAttachment($name_saved = '', $name_display = '', $mimetype = '', $num_download = 0)
                                      {
                                          static $counter = 0;
                                          $this->attachment_array = $this->getAttachment();
                                          if ($name_saved) {

                                  CamelCaseParameterName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name parameters.

                                  Example

                                  class ClassName {
                                      public function doSomething($user_name) {
                                      }
                                  }

                                  Source

                                  The parameter $attach_key is not named in camelCase.
                                  Open

                                      public function incrementDownload($attach_key)
                                      {
                                          if (!$attach_key) {
                                              return false;
                                          }

                                  CamelCaseParameterName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name parameters.

                                  Example

                                  class ClassName {
                                      public function doSomething($user_name) {
                                      }
                                  }

                                  Source

                                  The property $attachment_array is not named in camelCase.
                                  Open

                                  class Post extends XoopsObject
                                  {
                                      //class Post extends XoopsObject {
                                      public $attachment_array = array();
                                  
                                  

                                  CamelCasePropertyName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name attributes.

                                  Example

                                  class ClassName {
                                      protected $property_name;
                                  }

                                  Source

                                  The parameter $post_editmsg is not named in camelCase.
                                  Open

                                      public function setPostEdit($poster_name = '', $post_editmsg = '')
                                      {
                                          if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])
                                              || (time() - $this->getVar('post_time')) < $GLOBALS['xoopsModuleConfig']['recordedit_timelimit'] * 60
                                              || $this->getVar('approved') < 1

                                  CamelCaseParameterName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name parameters.

                                  Example

                                  class ClassName {
                                      public function doSomething($user_name) {
                                      }
                                  }

                                  Source

                                  The parameter $poster_name is not named in camelCase.
                                  Open

                                      public function setPostEdit($poster_name = '', $post_editmsg = '')
                                      {
                                          if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])
                                              || (time() - $this->getVar('post_time')) < $GLOBALS['xoopsModuleConfig']['recordedit_timelimit'] * 60
                                              || $this->getVar('approved') < 1

                                  CamelCaseParameterName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name parameters.

                                  Example

                                  class ClassName {
                                      public function doSomething($user_name) {
                                      }
                                  }

                                  Source

                                  Avoid variables with short names like $db. Configured minimum length is 3.
                                  Open

                                      public function __construct(XoopsDatabase $db)

                                  ShortVariable

                                  Since: 0.2

                                  Detects when a field, local, or parameter has a very short name.

                                  Example

                                  class Something {
                                      private $q = 15; // VIOLATION - Field
                                      public static function main( array $as ) { // VIOLATION - Formal
                                          $r = 20 + $this->q; // VIOLATION - Local
                                          for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                              $r += $this->q;
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/naming.html#shortvariable

                                  Avoid variables with short names like $id. Configured minimum length is 3.
                                  Open

                                      public function get($id)

                                  ShortVariable

                                  Since: 0.2

                                  Detects when a field, local, or parameter has a very short name.

                                  Example

                                  class Something {
                                      private $q = 15; // VIOLATION - Field
                                      public static function main( array $as ) { // VIOLATION - Formal
                                          $r = 20 + $this->q; // VIOLATION - Local
                                          for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                              $r += $this->q;
                                          }
                                      }
                                  }

                                  Source https://phpmd.org/rules/naming.html#shortvariable

                                  The parameter $action_tag is not named in camelCase.
                                  Open

                                      public function checkTimelimit($action_tag = 'edit_timelimit')
                                      {
                                          $newbb_config = newbb_load_config();
                                          if (empty($newbb_config['edit_timelimit'])) {
                                              return true;

                                  CamelCaseParameterName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name parameters.

                                  Example

                                  class ClassName {
                                      public function doSomething($user_name) {
                                      }
                                  }

                                  Source

                                  The parameter $topic_id is not named in camelCase.
                                  Open

                                      public function &getByLimit($topic_id, $limit, $approved = 1)
                                      {
                                          $sql    = 'SELECT p.*, t.*, tp.topic_status FROM ' . $this->db->prefix('bb_posts') . ' p LEFT JOIN ' . $this->db->prefix('bb_posts_text') . ' t ON p.post_id=t.post_id LEFT JOIN ' . $this->db->prefix('bb_topics')
                                                    . ' tp ON tp.topic_id=p.topic_id WHERE p.topic_id=' . $topic_id . ' AND p.approved =' . $approved . ' ORDER BY p.post_time DESC';
                                          $result = $this->db->query($sql, $limit, 0);

                                  CamelCaseParameterName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name parameters.

                                  Example

                                  class ClassName {
                                      public function doSomething($user_name) {
                                      }
                                  }

                                  Source

                                  A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 40 and the first side effect is on line 34.
                                  Open

                                  <?php

                                  Each class must be in a file by itself
                                  Open

                                  class NewbbPostHandler extends XoopsPersistableObjectHandler

                                  Method name "_delete" should not be prefixed with an underscore to indicate visibility
                                  Open

                                      private function _delete(&$post, $force = false)

                                  Line exceeds 120 characters; contains 204 characters
                                  Open

                                                                              . "'> <img src='{$icon_filetype}' alt='{$filetype}' /> {$att['name_display']}</a> " . _MD_FILESIZE . ": {$file_size}; " . _MD_HITS . ": {$att['num_download']}";

                                  Line exceeds 120 characters; contains 240 characters
                                  Open

                                                          $post_attachment .= "<a href='" . $GLOBALS['xoops']->url('/modules/' . $GLOBALS['xoopsModule']->getVar('dirname', 'n') . "/dl_attachment.php?attachid={$key}&amp;post_id=" . $this->getVar('post_id')) . "'> <img src='"

                                  Line exceeds 120 characters; contains 192 characters
                                  Open

                                                                              . $icon_filetype . "' alt='{$filetype}' /> {$att['name_display']}</a> " . _MD_FILESIZE . ": {$file_size}; " . _MD_HITS . ": {$att['num_download']}";

                                  Line exceeds 120 characters; contains 154 characters
                                  Open

                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  Line exceeds 120 characters; contains 163 characters
                                  Open

                                                      $mod_buttons['edit']['link']     = $GLOBALS['xoops']->url('modules/' . $GLOBALS['xoopsModule']->getVar('dirname') . "/edit.php?{$page_query}");

                                  Line exceeds 120 characters; contains 156 characters
                                  Open

                                              $mod_buttons['delete']['link']  = $GLOBALS['xoops']->url('modules/' . $GLOBALS['xoopsModule']->getVar('dirname') . "/delete.php?{$page_query}");

                                  Line exceeds 120 characters; contains 126 characters
                                  Open

                                              $thread_action['social_delicious']['link']   = "http://del.icio.us/post?title={$full_title}&amp;url={$full_link}";

                                  Line exceeds 120 characters; contains 125 characters
                                  Open

                                              $thread_action['social_wong']['link']   = "http://www.mister-wong.de/index.php?action=addurl&bm_url=$full_link}";

                                  Line exceeds 120 characters; contains 144 characters
                                  Open

                                              include_once $GLOBALS['xoops']->path('modules/' . $GLOBALS['xoopsModule']->getVar('dirname', 'n') . '/include/functions.image.php');

                                  Line exceeds 120 characters; contains 195 characters
                                  Open

                                                      $post_attachment .= '<br><img src="' . $icon_filetype . '" alt="' . $filetype . '" /><strong>&nbsp; ' . $att['name_display'] . '</strong> <small>(' . $file_size . ')</small>';

                                  Line exceeds 120 characters; contains 159 characters
                                  Open

                                          $GLOBALS['xoopsModuleConfig'] = newbb_load_config(); // irmtfan  load all newbb configs - newbb config in blocks activated in some modules like profile

                                  Line exceeds 120 characters; contains 134 characters
                                  Open

                                              $post_image = "<a name='{$post_id}'><img src='" . $GLOBALS['xoops']->url('images/icons/posticon.gif') . "' alt='' /></a>";

                                  Line exceeds 120 characters; contains 176 characters
                                  Open

                                              'post_permalink'  => "<a href='" . $GLOBALS['xoops']->url('/modules/' . $GLOBALS['xoopsModule']->getVar('dirname') . "/viewtopic.php?post_id={$post_id}") . "'></a>"

                                  Line exceeds 120 characters; contains 161 characters
                                  Open

                                          $post_edit['edit_user'] = $edit_user; // The proper way is to store uid instead of name. However, to save queries when displaying, the current way is ok.

                                  Line exceeds 120 characters; contains 167 characters
                                  Open

                                                      $mod_buttons['delete']['link']     = $GLOBALS['xoops']->url('modules/' . $GLOBALS['xoopsModule']->getVar('dirname') . "/delete.php?{$page_query}");

                                  Line exceeds 120 characters; contains 159 characters
                                  Open

                                              $thread_buttons['report']['link']  = $GLOBALS['xoops']->url('modules/' . $GLOBALS['xoopsModule']->getVar('dirname') . "/report.php?{$page_query}");

                                  Line exceeds 120 characters; contains 124 characters
                                  Open

                                              $thread_action['social_reddit']['link']   = "http://reddit.com/submit?title={$full_title}&amp;url={$full_link}";

                                  Line exceeds 120 characters; contains 122 characters
                                  Open

                                                                    && $GLOBALS['xoopsModuleConfig']['show_ip']) ? long2ip($this->getVar('poster_ip')) : '',

                                  Line exceeds 120 characters; contains 180 characters
                                  Open

                                          $sql  = 'SELECT p.*, t.* FROM ' . $this->db->prefix('bb_posts') . ' p LEFT JOIN ' . $this->db->prefix('bb_posts_text') . ' t ON p.post_id=t.post_id WHERE p.post_id=' . $id;

                                  Line exceeds 120 characters; contains 211 characters
                                  Open

                                          $post_text          = newbb_displayTarea($this->vars['post_text']['value'], $this->getVar('dohtml'), $this->getVar('dosmiley'), $this->getVar('doxcode'), $this->getVar('doimage'), $this->getVar('dobr'));

                                  Line exceeds 120 characters; contains 222 characters
                                  Open

                                                          $post_attachment .= "<a href='" . $GLOBALS['xoops']->url('/modules/' . $GLOBALS['xoopsModule']->getVar('dirname', 'n') . "/dl_attachment.php?attachid={$key}&amp;post_id=" . $this->getVar('post_id'))

                                  Line exceeds 120 characters; contains 133 characters
                                  Open

                                                          xoops_notification_deletebyitem($GLOBALS['xoopsModule']->getVar('mid'), 'thread', $post->getVar('topic_id'));

                                  Line exceeds 120 characters; contains 162 characters
                                  Open

                                                  $sql = 'UPDATE ' . $this->db->prefix('bb_posts') . ' SET pid = ' . $post->getVar('pid') . ' WHERE approved=1 AND pid=' . $post->getVar('post_id');

                                  Line exceeds 120 characters; contains 174 characters
                                  Open

                                          $sql = 'SELECT p.*, t.* ' . 'FROM ' . $this->db->prefix('bb_posts') . ' AS p ' . 'LEFT JOIN ' . $this->db->prefix('bb_posts_text') . ' AS t ON t.post_id = p.post_id';

                                  Line exceeds 120 characters; contains 141 characters
                                  Open

                                                  $file_size = @filesize($GLOBALS['xoops']->path($GLOBALS['xoopsModuleConfig']['dir_attachments'] . '/' . $att['name_saved']));

                                  Line exceeds 120 characters; contains 167 characters
                                  Open

                                                      $thread_buttons['delete']['link']  = $GLOBALS['xoops']->url('modules/' . $GLOBALS['xoopsModule']->getVar('dirname') . "/delete.php?{$page_query}");

                                  Line exceeds 120 characters; contains 219 characters
                                  Open

                                          $sql    = 'SELECT p.*, t.*, tp.topic_status FROM ' . $this->db->prefix('bb_posts') . ' p LEFT JOIN ' . $this->db->prefix('bb_posts_text') . ' t ON p.post_id=t.post_id LEFT JOIN ' . $this->db->prefix('bb_topics')

                                  Line exceeds 120 characters; contains 125 characters
                                  Open

                                              $thread_action['social_twitter']['link']   = "http://twitter.com/share?text={$clean_title}&amp;url={$full_link}";

                                  Line exceeds 120 characters; contains 152 characters
                                  Open

                                              $thread_action['social_linkedin']['link']   = "http://www.linkedin.com/shareArticle?mini=true&amp;title={$full_title}&amp;url={$full_link}";

                                  Line exceeds 120 characters; contains 139 characters
                                  Open

                                              $post_text       = "<div class='karma'>" . sprintf(_MD_KARMA_REQUIREMENT, $user_karma, $this->getVar('post_karma')) . '</div>';

                                  Line exceeds 120 characters; contains 132 characters
                                  Open

                                              $thread_action['social_digg']['link']   = "http://digg.com/submit?phase=2&amp;title={$full_title}&amp;url={$full_link}";

                                  Line exceeds 120 characters; contains 158 characters
                                  Open

                                              $sql = 'DELETE FROM ' . $this->db->prefix('bb_posts_text') . ' ' . 'WHERE (post_id NOT IN ( SELECT DISTINCT post_id FROM ' . $this->table . ') )';

                                  Line exceeds 120 characters; contains 176 characters
                                  Open

                                                  $thread_buttons['quote']['link']  = $GLOBALS['xoops']->url('modules/' . $GLOBALS['xoopsModule']->getVar('dirname') . "/reply.php?{$page_query}&amp;quotedac=1");

                                  Line exceeds 120 characters; contains 190 characters
                                  Open

                                          $sql = 'UPDATE ' . $GLOBALS['xoopsDB']->prefix('bb_posts') . ' SET attachment=' . $GLOBALS['xoopsDB']->quoteString($attachment_save) . ' WHERE post_id = ' . $this->getVar('post_id');

                                  Line exceeds 120 characters; contains 128 characters
                                  Open

                                                  @unlink(XOOPS_ROOT_PATH . '/' . $GLOBALS['xoopsModuleConfig']['dir_attachments'] . '/' . $attach['name_saved']);

                                  Line exceeds 120 characters; contains 133 characters
                                  Open

                                                  $post_edit .= _MD_EDITEDBY . ' ' . $edit_user . ' ' . _MD_ON . ' ' . newbb_formatTimestamp((int)$edit_time) . '<br>';

                                  Line exceeds 120 characters; contains 126 characters
                                  Open

                                          $uid = ($uid > -1) ? $uid : (($GLOBALS['xoopsUser'] instanceof XoopsUser) ? $GLOBALS['xoopsUser']->getVar('uid') : 0);

                                  Line exceeds 120 characters; contains 135 characters
                                  Open

                                              $post_image = "<a name='{$post_id}'><img src='" . $GLOBALS['xoops']->url("images/subject/{$posticon}") . "' alt='' /></a>";

                                  Line exceeds 120 characters; contains 196 characters
                                  Open

                                              $mod_buttons['bann']['link']     = $GLOBALS['xoops']->url('modules/' . $GLOBALS['xoopsModule']->getVar('dirname') . "/moderate.php?forum={$forum_id}&amp;fuid=" . $this->getVar('uid'));

                                  Line exceeds 120 characters; contains 157 characters
                                  Open

                                              $thread_buttons['reply']['link']  = $GLOBALS['xoops']->url('modules/' . $GLOBALS['xoopsModule']->getVar('dirname') . "/reply.php?{$page_query}");

                                  Line exceeds 120 characters; contains 196 characters
                                  Open

                                              $thread_buttons['bann']['link']  = $GLOBALS['xoops']->url('modules/' . $GLOBALS['xoopsModule']->getVar('dirname') . "/moderate.php?forum={$forum_id}&amp;fuid=" . $this->getVar('uid'));

                                  Line exceeds 120 characters; contains 163 characters
                                  Open

                                                      $thread_buttons['edit']['link']  = $GLOBALS['xoops']->url('modules/' . $GLOBALS['xoopsModule']->getVar('dirname') . "/edit.php?{$page_query}");

                                  Line exceeds 120 characters; contains 161 characters
                                  Open

                                                  $thread_buttons['reply']['link']  = $GLOBALS['xoops']->url('modules/' . $GLOBALS['xoopsModule']->getVar('dirname') . "/reply.php?{$page_query}");

                                  Line exceeds 120 characters; contains 152 characters
                                  Open

                                              $mod_buttons['edit']['link']  = $GLOBALS['xoops']->url('modules/' . $GLOBALS['xoopsModule']->getVar('dirname') . "/edit.php?{$page_query}");

                                  Line exceeds 120 characters; contains 152 characters
                                  Open

                                              $thread_action['print']['link']   = $GLOBALS['xoops']->url("modules/newbb/print.php?form=2&amp;forum={$forum_id}&amp;topic_id={$topic_id}");

                                  Line exceeds 120 characters; contains 121 characters
                                  Open

                                              $thread_action['pdf']['link']   = $GLOBALS['xoops']->url('modules/newbb/makepdf.php?type=post&amp;pageid=0');

                                  Line exceeds 120 characters; contains 234 characters
                                  Open

                                              $sql = 'DELETE ' . $this->db->prefix('bb_posts_text') . ' FROM ' . $this->db->prefix('bb_posts_text') . ' ' . 'LEFT JOIN ' . $this->table . ' AS aa ON ' . $this->db->prefix('bb_posts_text') . '.post_id = aa.post_id ' . ' '

                                  Line exceeds 120 characters; contains 121 characters
                                  Open

                                              $sql = sprintf('DELETE FROM %s WHERE post_id = %u', $this->db->prefix('bb_posts'), $post->getVar('post_id'));

                                  Line exceeds 120 characters; contains 147 characters
                                  Open

                                                    . ' tp ON tp.topic_id=p.topic_id WHERE p.topic_id=' . $topic_id . ' AND p.approved =' . $approved . ' ORDER BY p.post_time DESC';

                                  Line exceeds 120 characters; contains 128 characters
                                  Open

                                                  $sql = sprintf('DELETE FROM %s WHERE topic_id = %u', $this->db->prefix('bb_topics'), $post->getVar('topic_id'));

                                  Line exceeds 120 characters; contains 126 characters
                                  Open

                                              $sql = sprintf('DELETE FROM %s WHERE post_id = %u', $this->db->prefix('bb_posts_text'), $post->getVar('post_id'));

                                  Line exceeds 120 characters; contains 125 characters
                                  Open

                                                  xoops_notification_deletebyitem($GLOBALS['xoopsModule']->getVar('mid'), 'thread', $post->getVar('topic_id'));

                                  Line exceeds 120 characters; contains 130 characters
                                  Open

                                                  $sql = sprintf('DELETE FROM %s WHERE topic_id = %u', $this->db->prefix('bb_votedata'), $post->getVar('topic_id'));

                                  Line exceeds 120 characters; contains 168 characters
                                  Open

                                                     . $post->getVar('post_id') . ' ' . 'AND p.post_id = (SELECT MAX(post_id) FROM ' . $this->db->prefix('bb_posts') . ' ' . 'WHERE topic_id=t.topic_id)';

                                  Line exceeds 120 characters; contains 198 characters
                                  Open

                                          $sql = 'SELECT COUNT(*) AS count' . ' ' . 'FROM ' . $this->db->prefix('bb_posts') . ' AS p' . ' ' . 'LEFT JOIN ' . $this->db->prefix('bb_posts_text') . ' ' . 'AS t ON t.post_id = p.post_id';

                                  Line exceeds 120 characters; contains 128 characters
                                  Open

                                              $sql = 'UPDATE ' . $this->db->prefix('bb_posts') . ' SET approved = -1 WHERE post_id = ' . $post->getVar('post_id');

                                  Line exceeds 120 characters; contains 227 characters
                                  Open

                                              $sql = 'UPDATE ' . $this->db->prefix('bb_topics') . ' t ' . 'LEFT JOIN ' . $this->db->prefix('bb_posts') . ' p ON p.topic_id = t.topic_id ' . 'SET t.topic_last_post_id = p.post_id ' . 'WHERE t.topic_last_post_id = '

                                  The variable $num_download is not named in camelCase.
                                  Open

                                      public function setAttachment($name_saved = '', $name_display = '', $mimetype = '', $num_download = 0)
                                      {
                                          static $counter = 0;
                                          $this->attachment_array = $this->getAttachment();
                                          if ($name_saved) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attach_array is not named in camelCase.
                                  Open

                                      public function deleteAttachment($attach_array = null)
                                      {
                                          $attach_old = $this->getAttachment();
                                          if (!is_array($attach_old) || count($attach_old) < 1) {
                                              return true;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attachment_save is not named in camelCase.
                                  Open

                                      public function saveAttachment()
                                      {
                                          $attachment_save = '';
                                          if (is_array($this->attachment_array) && count($this->attachment_array) > 0) {
                                              $attachment_save = base64_encode(serialize($this->attachment_array));

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attach_old is not named in camelCase.
                                  Open

                                      public function deleteAttachment($attach_array = null)
                                      {
                                          $attach_old = $this->getAttachment();
                                          if (!is_array($attach_old) || count($attach_old) < 1) {
                                              return true;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attachment_save is not named in camelCase.
                                  Open

                                      public function deleteAttachment($attach_array = null)
                                      {
                                          $attach_old = $this->getAttachment();
                                          if (!is_array($attach_old) || count($attach_old) < 1) {
                                              return true;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $name_display is not named in camelCase.
                                  Open

                                      public function setAttachment($name_saved = '', $name_display = '', $mimetype = '', $num_download = 0)
                                      {
                                          static $counter = 0;
                                          $this->attachment_array = $this->getAttachment();
                                          if ($name_saved) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attachment_save is not named in camelCase.
                                  Open

                                      public function saveAttachment()
                                      {
                                          $attachment_save = '';
                                          if (is_array($this->attachment_array) && count($this->attachment_array) > 0) {
                                              $attachment_save = base64_encode(serialize($this->attachment_array));

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attach_old is not named in camelCase.
                                  Open

                                      public function deleteAttachment($attach_array = null)
                                      {
                                          $attach_old = $this->getAttachment();
                                          if (!is_array($attach_old) || count($attach_old) < 1) {
                                              return true;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attach_old is not named in camelCase.
                                  Open

                                      public function deleteAttachment($attach_array = null)
                                      {
                                          $attach_old = $this->getAttachment();
                                          if (!is_array($attach_old) || count($attach_old) < 1) {
                                              return true;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attachment_save is not named in camelCase.
                                  Open

                                      public function saveAttachment()
                                      {
                                          $attachment_save = '';
                                          if (is_array($this->attachment_array) && count($this->attachment_array) > 0) {
                                              $attachment_save = base64_encode(serialize($this->attachment_array));

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attach_old is not named in camelCase.
                                  Open

                                      public function deleteAttachment($attach_array = null)
                                      {
                                          $attach_old = $this->getAttachment();
                                          if (!is_array($attach_old) || count($attach_old) < 1) {
                                              return true;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attachment_save is not named in camelCase.
                                  Open

                                      public function deleteAttachment($attach_array = null)
                                      {
                                          $attach_old = $this->getAttachment();
                                          if (!is_array($attach_old) || count($attach_old) < 1) {
                                              return true;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $name_saved is not named in camelCase.
                                  Open

                                      public function setAttachment($name_saved = '', $name_display = '', $mimetype = '', $num_download = 0)
                                      {
                                          static $counter = 0;
                                          $this->attachment_array = $this->getAttachment();
                                          if ($name_saved) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $num_download is not named in camelCase.
                                  Open

                                      public function setAttachment($name_saved = '', $name_display = '', $mimetype = '', $num_download = 0)
                                      {
                                          static $counter = 0;
                                          $this->attachment_array = $this->getAttachment();
                                          if ($name_saved) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attachment_save is not named in camelCase.
                                  Open

                                      public function saveAttachment()
                                      {
                                          $attachment_save = '';
                                          if (is_array($this->attachment_array) && count($this->attachment_array) > 0) {
                                              $attachment_save = base64_encode(serialize($this->attachment_array));

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attach_array is not named in camelCase.
                                  Open

                                      public function deleteAttachment($attach_array = null)
                                      {
                                          $attach_old = $this->getAttachment();
                                          if (!is_array($attach_old) || count($attach_old) < 1) {
                                              return true;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attachment_save is not named in camelCase.
                                  Open

                                      public function deleteAttachment($attach_array = null)
                                      {
                                          $attach_old = $this->getAttachment();
                                          if (!is_array($attach_old) || count($attach_old) < 1) {
                                              return true;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $name_saved is not named in camelCase.
                                  Open

                                      public function setAttachment($name_saved = '', $name_display = '', $mimetype = '', $num_download = 0)
                                      {
                                          static $counter = 0;
                                          $this->attachment_array = $this->getAttachment();
                                          if ($name_saved) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attach_key is not named in camelCase.
                                  Open

                                      public function incrementDownload($attach_key)
                                      {
                                          if (!$attach_key) {
                                              return false;
                                          }

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attach_old is not named in camelCase.
                                  Open

                                      public function deleteAttachment($attach_array = null)
                                      {
                                          $attach_old = $this->getAttachment();
                                          if (!is_array($attach_old) || count($attach_old) < 1) {
                                              return true;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attach_key is not named in camelCase.
                                  Open

                                      public function incrementDownload($attach_key)
                                      {
                                          if (!$attach_key) {
                                              return false;
                                          }

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $name_saved is not named in camelCase.
                                  Open

                                      public function setAttachment($name_saved = '', $name_display = '', $mimetype = '', $num_download = 0)
                                      {
                                          static $counter = 0;
                                          $this->attachment_array = $this->getAttachment();
                                          if ($name_saved) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attach_array is not named in camelCase.
                                  Open

                                      public function deleteAttachment($attach_array = null)
                                      {
                                          $attach_old = $this->getAttachment();
                                          if (!is_array($attach_old) || count($attach_old) < 1) {
                                              return true;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $name_display is not named in camelCase.
                                  Open

                                      public function setAttachment($name_saved = '', $name_display = '', $mimetype = '', $num_download = 0)
                                      {
                                          static $counter = 0;
                                          $this->attachment_array = $this->getAttachment();
                                          if ($name_saved) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $mime_path is not named in camelCase.
                                  Open

                                      public function displayAttachment($asSource = false)
                                      {
                                          $post_attachment = '';
                                          $attachments     = $this->getAttachment();
                                          if (is_array($attachments) && count($attachments) > 0) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $file_size is not named in camelCase.
                                  Open

                                      public function displayAttachment($asSource = false)
                                      {
                                          $post_attachment = '';
                                          $attachments     = $this->getAttachment();
                                          if (is_array($attachments) && count($attachments) > 0) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $post_edits is not named in camelCase.
                                  Open

                                      public function displayPostEdit()
                                      {
                                          global $myts;
                                  
                                          if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $post_edits is not named in camelCase.
                                  Open

                                      public function displayPostEdit()
                                      {
                                          global $myts;
                                  
                                          if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $post_edit is not named in camelCase.
                                  Open

                                      public function displayPostEdit()
                                      {
                                          global $myts;
                                  
                                          if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attach_key is not named in camelCase.
                                  Open

                                      public function incrementDownload($attach_key)
                                      {
                                          if (!$attach_key) {
                                              return false;
                                          }

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attach_array is not named in camelCase.
                                  Open

                                      public function deleteAttachment($attach_array = null)
                                      {
                                          $attach_old = $this->getAttachment();
                                          if (!is_array($attach_old) || count($attach_old) < 1) {
                                              return true;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $post_attachment is not named in camelCase.
                                  Open

                                      public function displayAttachment($asSource = false)
                                      {
                                          $post_attachment = '';
                                          $attachments     = $this->getAttachment();
                                          if (is_array($attachments) && count($attachments) > 0) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $post_edits is not named in camelCase.
                                  Open

                                      public function setPostEdit($poster_name = '', $post_editmsg = '')
                                      {
                                          if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])
                                              || (time() - $this->getVar('post_time')) < $GLOBALS['xoopsModuleConfig']['recordedit_timelimit'] * 60
                                              || $this->getVar('approved') < 1

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $user_karma is not named in camelCase.
                                  Open

                                      public function &getPostBody()
                                      {
                                          global $myts;
                                          $GLOBALS['xoopsModuleConfig'] = newbb_load_config(); // irmtfan  load all newbb configs - newbb config in blocks activated in some modules like profile
                                          mod_loadFunctions('user', 'newbb');

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $newbb_config is not named in camelCase.
                                  Open

                                      public function checkTimelimit($action_tag = 'edit_timelimit')
                                      {
                                          $newbb_config = newbb_load_config();
                                          if (empty($newbb_config['edit_timelimit'])) {
                                              return true;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $action_tag is not named in camelCase.
                                  Open

                                      public function checkTimelimit($action_tag = 'edit_timelimit')
                                      {
                                          $newbb_config = newbb_load_config();
                                          if (empty($newbb_config['edit_timelimit'])) {
                                              return true;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attach_array is not named in camelCase.
                                  Open

                                      public function deleteAttachment($attach_array = null)
                                      {
                                          $attach_old = $this->getAttachment();
                                          if (!is_array($attach_old) || count($attach_old) < 1) {
                                              return true;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $post_attachment is not named in camelCase.
                                  Open

                                      public function displayAttachment($asSource = false)
                                      {
                                          $post_attachment = '';
                                          $attachments     = $this->getAttachment();
                                          if (is_array($attachments) && count($attachments) > 0) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $icon_filetype is not named in camelCase.
                                  Open

                                      public function displayAttachment($asSource = false)
                                      {
                                          $post_attachment = '';
                                          $attachments     = $this->getAttachment();
                                          if (is_array($attachments) && count($attachments) > 0) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $post_edits is not named in camelCase.
                                  Open

                                      public function setPostEdit($poster_name = '', $post_editmsg = '')
                                      {
                                          if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])
                                              || (time() - $this->getVar('post_time')) < $GLOBALS['xoopsModuleConfig']['recordedit_timelimit'] * 60
                                              || $this->getVar('approved') < 1

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $post_edit is not named in camelCase.
                                  Open

                                      public function displayPostEdit()
                                      {
                                          global $myts;
                                  
                                          if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $edit_msg is not named in camelCase.
                                  Open

                                      public function displayPostEdit()
                                      {
                                          global $myts;
                                  
                                          if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $attach_array is not named in camelCase.
                                  Open

                                      public function deleteAttachment($attach_array = null)
                                      {
                                          $attach_old = $this->getAttachment();
                                          if (!is_array($attach_old) || count($attach_old) < 1) {
                                              return true;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $post_edit is not named in camelCase.
                                  Open

                                      public function setPostEdit($poster_name = '', $post_editmsg = '')
                                      {
                                          if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])
                                              || (time() - $this->getVar('post_time')) < $GLOBALS['xoopsModuleConfig']['recordedit_timelimit'] * 60
                                              || $this->getVar('approved') < 1

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $post_editmsg is not named in camelCase.
                                  Open

                                      public function setPostEdit($poster_name = '', $post_editmsg = '')
                                      {
                                          if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])
                                              || (time() - $this->getVar('post_time')) < $GLOBALS['xoopsModuleConfig']['recordedit_timelimit'] * 60
                                              || $this->getVar('approved') < 1

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $post_edits is not named in camelCase.
                                  Open

                                      public function displayPostEdit()
                                      {
                                          global $myts;
                                  
                                          if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $newbb_config is not named in camelCase.
                                  Open

                                      public function checkTimelimit($action_tag = 'edit_timelimit')
                                      {
                                          $newbb_config = newbb_load_config();
                                          if (empty($newbb_config['edit_timelimit'])) {
                                              return true;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $mime_path is not named in camelCase.
                                  Open

                                      public function displayAttachment($asSource = false)
                                      {
                                          $post_attachment = '';
                                          $attachments     = $this->getAttachment();
                                          if (is_array($attachments) && count($attachments) > 0) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $file_size is not named in camelCase.
                                  Open

                                      public function displayAttachment($asSource = false)
                                      {
                                          $post_attachment = '';
                                          $attachments     = $this->getAttachment();
                                          if (is_array($attachments) && count($attachments) > 0) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $post_edits is not named in camelCase.
                                  Open

                                      public function displayPostEdit()
                                      {
                                          global $myts;
                                  
                                          if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $post_text is not named in camelCase.
                                  Open

                                      public function &getPostBody()
                                      {
                                          global $myts;
                                          $GLOBALS['xoopsModuleConfig'] = newbb_load_config(); // irmtfan  load all newbb configs - newbb config in blocks activated in some modules like profile
                                          mod_loadFunctions('user', 'newbb');

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $user_karma is not named in camelCase.
                                  Open

                                      public function &getPostBody()
                                      {
                                          global $myts;
                                          $GLOBALS['xoopsModuleConfig'] = newbb_load_config(); // irmtfan  load all newbb configs - newbb config in blocks activated in some modules like profile
                                          mod_loadFunctions('user', 'newbb');

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $post_text is not named in camelCase.
                                  Open

                                      public function &getPostBody()
                                      {
                                          global $myts;
                                          $GLOBALS['xoopsModuleConfig'] = newbb_load_config(); // irmtfan  load all newbb configs - newbb config in blocks activated in some modules like profile
                                          mod_loadFunctions('user', 'newbb');

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $page_query is not named in camelCase.
                                  Open

                                      public function showPost($isadmin)
                                      {
                                          global $myts;
                                          global $forumUrl, $forumImage;
                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $post_image is not named in camelCase.
                                  Open

                                      public function showPost($isadmin)
                                      {
                                          global $myts;
                                          global $forumUrl, $forumImage;
                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $mod_buttons is not named in camelCase.
                                  Open

                                      public function showPost($isadmin)
                                      {
                                          global $myts;
                                          global $forumUrl, $forumImage;
                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $thread_buttons is not named in camelCase.
                                  Open

                                      public function showPost($isadmin)
                                      {
                                          global $myts;
                                          global $forumUrl, $forumImage;
                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $mod_buttons is not named in camelCase.
                                  Open

                                      public function showPost($isadmin)
                                      {
                                          global $myts;
                                          global $forumUrl, $forumImage;
                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $thread_action is not named in camelCase.
                                  Open

                                      public function showPost($isadmin)
                                      {
                                          global $myts;
                                          global $forumUrl, $forumImage;
                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $thread_action is not named in camelCase.
                                  Open

                                      public function showPost($isadmin)
                                      {
                                          global $myts;
                                          global $forumUrl, $forumImage;
                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $clean_title is not named in camelCase.
                                  Open

                                      public function showPost($isadmin)
                                      {
                                          global $myts;
                                          global $forumUrl, $forumImage;
                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $thread_action is not named in camelCase.
                                  Open

                                      public function showPost($isadmin)
                                      {
                                          global $myts;
                                          global $forumUrl, $forumImage;
                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $thread_action is not named in camelCase.
                                  Open

                                      public function showPost($isadmin)
                                      {
                                          global $myts;
                                          global $forumUrl, $forumImage;
                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $thread_action is not named in camelCase.
                                  Open

                                      public function showPost($isadmin)
                                      {
                                          global $myts;
                                          global $forumUrl, $forumImage;
                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $post_title is not named in camelCase.
                                  Open

                                      public function showPost($isadmin)
                                      {
                                          global $myts;
                                          global $forumUrl, $forumImage;
                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $topic_obj is not named in camelCase.
                                  Open

                                      public function approve(&$post, $force = false)
                                      {
                                          if (empty($post)) {
                                              return false;
                                          }

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $forum_obj is not named in camelCase.
                                  Open

                                      public function approve(&$post, $force = false)
                                      {
                                          if (empty($post)) {
                                              return false;
                                          }

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $icon_filetype is not named in camelCase.
                                  Open

                                      public function displayAttachment($asSource = false)
                                      {
                                          $post_attachment = '';
                                          $attachments     = $this->getAttachment();
                                          if (is_array($attachments) && count($attachments) > 0) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $file_size is not named in camelCase.
                                  Open

                                      public function displayAttachment($asSource = false)
                                      {
                                          $post_attachment = '';
                                          $attachments     = $this->getAttachment();
                                          if (is_array($attachments) && count($attachments) > 0) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $post_edits is not named in camelCase.
                                  Open

                                      public function displayPostEdit()
                                      {
                                          global $myts;
                                  
                                          if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])) {

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $total_posts is not named in camelCase.
                                  Open

                                      public function showPost($isadmin)
                                      {
                                          global $myts;
                                          global $forumUrl, $forumImage;
                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $post_text is not named in camelCase.
                                  Open

                                      public function showPost($isadmin)
                                      {
                                          global $myts;
                                          global $forumUrl, $forumImage;
                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;

                                  CamelCaseVariableName

                                  Since: 0.2

                                  It is considered best practice to use the camelCase notation to name variables.

                                  Example

                                  class ClassName {
                                      public function doSomething() {
                                          $data_module = new DataModule();
                                      }
                                  }

                                  Source

                                  The variable $post_text is not named in camelCase.
                                  Open

                                      public function showPost($isadmin)
                                      {
                                          global $myts;
                                          global $forumUrl, $forumImage;
                                          global $viewtopic_users, $viewtopic_posters, $forum_obj, $topic_obj, $online, $user_karma, $viewmode, $order, $start, $total_posts, $topic_status;
                                  Severity: Minor
                                  Found in extras/newbb_4x/irmtfan/class/post.php by