app/Integrations/Wapro/Synchronizer/Products.php
Function process has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
Open
public function process(): int
{
$query = (new \App\Db\Query())->select([
'dbo.ARTYKUL.*',
'category' => 'dbo.KATEGORIA_ARTYKULU_TREE.NAZWA',- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method process has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function process(): int
{
$query = (new \App\Db\Query())->select([
'dbo.ARTYKUL.*',
'category' => 'dbo.KATEGORIA_ARTYKULU_TREE.NAZWA',The method process() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10. Open
Open
public function process(): int
{
$query = (new \App\Db\Query())->select([
'dbo.ARTYKUL.*',
'category' => 'dbo.KATEGORIA_ARTYKULU_TREE.NAZWA',- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Missing class import via use statement (line '51', column '17'). Open
Open
$query = (new \App\Db\Query())->select([- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '209', column '35'). Open
Open
return $this->cache[$id] = (new \App\Db\Query())->select([- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '226', column '15'). Open
Open
return (new \App\Db\Query())->from('dbo.ARTYKUL')->count('*', $this->controller->getDb());- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class '\App\Cache' in method 'importRecord'. Open
Open
\App\Cache::save('WaproMapTable', "{$this->waproId}|ARTYKUL", $this->recordModel->getId());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Json' in method 'convertPrice'. Open
Open
return \App\Json::encode([
'currencies' => [
$currency['currencyId'] => ['price' => $value]
],
'currencyId' => $currency['currencyId']- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid assigning values to variables in if clauses and the like (line '62', column '7'). Open
Open
public function process(): int
{
$query = (new \App\Db\Query())->select([
'dbo.ARTYKUL.*',
'category' => 'dbo.KATEGORIA_ARTYKULU_TREE.NAZWA',- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid using static access to class '\Vtiger_Record_Model' in method 'importRecord'. Open
Open
$this->recordModel = \Vtiger_Record_Model::getInstanceById($id, 'Products');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid assigning values to variables in if clauses and the like (line '107', column '7'). Open
Open
public function importRecord(): int
{
if ($id = $this->findInMapTable($this->waproId, 'ARTYKUL')) {
$this->recordModel = \Vtiger_Record_Model::getInstanceById($id, 'Products');
} else {- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid using static access to class '\Vtiger_Record_Model' in method 'importRecord'. Open
Open
$this->recordModel = \Vtiger_Record_Model::getCleanInstance('Products');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Pauser' in method 'process'. Open
Open
$pauser = \App\Pauser::getInstance('WaproProductsLastId');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method importRecord uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$this->recordModel = \Vtiger_Record_Model::getCleanInstance('Products');
$this->recordModel->setDataForSave([\App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME => [
'wtable' => 'ARTYKUL',
]]);- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\App\Fields\Tree' in method 'convertCategory'. Open
Open
$list = \App\Fields\Tree::getPicklistValue($fieldModel->getFieldParams(), $fieldModel->getModuleName());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Define a constant instead of duplicating this literal "unitName" 3 times. Open
Open
'unitName' => ['fieldName' => 'usageunit', 'fn' => 'convertUnitName', 'moduleName' => 'Products'],- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "fieldName" 9 times. Open
Open
'NAZWA' => ['fieldName' => 'productname', 'fn' => 'decode'],- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "currencyId" 3 times. Open
Open
$currency['currencyId'] => ['price' => $value]- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "Products" 3 times. Open
Open
'unitName' => ['fieldName' => 'usageunit', 'fn' => 'convertUnitName', 'moduleName' => 'Products'],- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "dbo.ARTYKUL" 3 times. Open
Open
])->from('dbo.ARTYKUL')- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "total" 3 times. Open
Open
'total' => ['fieldName' => 'unit_price', 'fn' => 'convertPrice'],- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "decode" 3 times. Open
Open
'NAZWA' => ['fieldName' => 'productname', 'fn' => 'decode'],- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Move this "case default" clause to the end of this "switch" statement. Open
Open
default:- Read upRead up
- Exclude checks
The requirement for a final case default clause is defensive programming. The clause should either take appropriate action, or contain
a suitable comment as to why no action is taken. Even when the switch covers all current values of an enum, a default case
should still be used because there is no guarantee that the enum won't be extended.
Noncompliant Code Example
switch ($param) { //missing default clause
case 0:
do_something();
break;
case 1:
do_something_else();
break;
}
switch ($param) {
default: // default clause should be the last one
error();
break;
case 0:
do_something();
break;
case 1:
do_something_else();
break;
}
Compliant Solution
switch ($param) {
case 0:
do_something();
break;
case 1:
do_something_else();
break;
default:
error();
break;
}
See
- MISRA C:2004, 15.0 - The MISRA C switch syntax shall be used.
- MISRA C:2004, 15.3 - The final clause of a switch statement shall be the default clause
- MISRA C++:2008, 6-4-3 - A switch statement shall be a well-formed switch statement.
- MISRA C++:2008, 6-4-6 - The final clause of a switch statement shall be the default-clause
- MISRA C:2012, 16.1 - All switch statements shall be well-formed
- MISRA C:2012, 16.4 - Every switch statement shall have a default label
- MISRA C:2012, 16.5 - A default label shall appear as either the first or the last switch label of a switch statement
- MITRE, CWE-478 - Missing Default Case in Switch Statement
- CERT, MSC01-C. - Strive for logical completeness
- CERT, MSC01-CPP. - Strive for logical completeness
Define a constant instead of duplicating this literal "category" 3 times. Open
Open
'category' => ['fieldName' => 'pscategory', 'fn' => 'convertCategory'],- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Avoid unused parameters such as '$params'. Open
Open
protected function convertTaxes(string $value, array $params): string- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$params'. Open
Open
protected function convertPrice(string $value, array $params): string- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Call to undeclared method \App\Db\Query::select Open
Open
$query = (new \App\Db\Query())->select([- Exclude checks
Call to undeclared method \App\Db\Query::select Open
Open
return $this->cache[$id] = (new \App\Db\Query())->select([- Exclude checks
Argument 1 (templateId) is array but \App\Fields\Tree::getPicklistValue() takes int defined at /code/app/Fields/Tree.php:61 Open
Open
$list = \App\Fields\Tree::getPicklistValue($fieldModel->getFieldParams(), $fieldModel->getModuleName());- Exclude checks
Call to undeclared method \App\Db\Query::from Open
Open
return (new \App\Db\Query())->from('dbo.ARTYKUL')->count('*', $this->controller->getDb());- Exclude checks
Argument 1 (value) is int but \App\Pauser::setValue() takes string defined at /code/app/Pauser.php:77 Open
Open
$pauser->setValue($lastId);- Exclude checks
Avoid variables with short names like $i. Configured minimum length is 3. Open
Open
$lastId = $s = $e = $i = $u = 0;- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $id. Configured minimum length is 3. Open
Open
public function getRecordById(int $id): array- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $u. Configured minimum length is 3. Open
Open
$lastId = $s = $e = $i = $u = 0;- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $s. Configured minimum length is 3. Open
Open
$lastId = $s = $e = $i = $u = 0;- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $id. Configured minimum length is 3. Open
Open
public function importRecordById(int $id): int- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $e. Configured minimum length is 3. Open
Open
$lastId = $s = $e = $i = $u = 0;- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $id. Configured minimum length is 3. Open
Open
if ($id = $this->findInMapTable($this->waproId, 'ARTYKUL')) {- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'dbo.ARTYKUL.*',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'unitName' => 'dbo.JEDNOSTKA.SKROT',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'VAT_SPRZEDAZY' => ['fieldName' => 'taxes', 'fn' => 'convertTaxes'],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'category' => 'dbo.KATEGORIA_ARTYKULU_TREE.NAZWA',- Exclude checks
Line exceeds 120 characters; contains 134 characters Open
Open
->leftJoin('dbo.KATEGORIA_ARTYKULU_TREE', 'dbo.ARTYKUL.ID_KATEGORII_TREE = dbo.KATEGORIA_ARTYKULU_TREE.ID_KATEGORII_TREE')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'total' => 'dbo.CENA_ARTYKULU.CENA_NETTO',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->leftJoin('dbo.JEDNOSTKA', 'dbo.ARTYKUL.ID_JEDNOSTKI = dbo.JEDNOSTKA.ID_JEDNOSTKI')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
protected $fieldMap = [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'total' => ['fieldName' => 'unit_price', 'fn' => 'convertPrice'],- Exclude checks
Line exceeds 120 characters; contains 159 characters Open
Open
->leftJoin('dbo.CENA_ARTYKULU', 'dbo.ARTYKUL.ID_ARTYKULU = dbo.CENA_ARTYKULU.ID_ARTYKULU AND dbo.ARTYKUL.ID_CENY_DOM = dbo.CENA_ARTYKULU.ID_CENY');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
const SEQUENCE = 4;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'STAN_MINIMALNY' => 'reorderlevel',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'WAGA' => 'weight',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->leftJoin('dbo.CENA_ARTYKULU', 'dbo.ARTYKUL.ID_ARTYKULU = dbo.CENA_ARTYKULU.ID_ARTYKULU AND dbo.ARTYKUL.ID_CENY_DOM = dbo.CENA_ARTYKULU.ID_CENY');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->leftJoin('dbo.KATEGORIA_ARTYKULU_TREE', 'dbo.ARTYKUL.ID_KATEGORII_TREE = dbo.KATEGORIA_ARTYKULU_TREE.ID_KATEGORII_TREE')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'INDEKS_HANDLOWY' => ['fieldName' => 'serial_no', 'fn' => 'decode'],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function process(): int- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
const NAME = 'LBL_PRODUCTS';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'KOD_KRESKOWY' => 'ean',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'category' => ['fieldName' => 'pscategory', 'fn' => 'convertCategory'],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'INDEKS_KATALOGOWY' => ['fieldName' => 'mfr_part_no', 'fn' => 'decode'],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'OPIS' => 'description',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'CENA_ZAKUPU_BRUTTO' => ['fieldName' => 'purchase', 'fn' => 'convertPrice'],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'gross' => 'dbo.CENA_ARTYKULU.CENA_BRUTTO',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'NAZWA' => ['fieldName' => 'productname', 'fn' => 'decode'],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'STAN' => 'qtyinstock',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$query = (new \App\Db\Query())->select([- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'wtable' => 'ARTYKUL',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->recordModel->set('wapro_id', $this->waproId);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$currency['currencyId'] => ['price' => $value]- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} catch (\Throwable $th) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'unitName' => ['fieldName' => 'usageunit', 'fn' => 'convertUnitName', 'moduleName' => 'Products'],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($this->skip) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
\App\Cache::save('WaproMapTable', "{$this->waproId}|ARTYKUL", $this->recordModel->getId());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return \App\Json::encode([- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
protected function convertCategory(string $value, array $params): string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->importRecord();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** @var array Cache form products */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
protected $cache = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$pauser->setValue($lastId);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $i + $u;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return int- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->recordModel->getId();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'STAN_MAKSYMALNY' => 'qtyindemand',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'INDEKS_PRODUCENTA' => 'vendor_part_no',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
])->from('dbo.ARTYKUL')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->row = $row;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
try {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->recordModel->save();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($id) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$fieldModel = $this->recordModel->getField($params['fieldName']);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$key = array_search($value, $list);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
])->from('dbo.ARTYKUL')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->waproId = $row['ID_ARTYKULU'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
switch ($this->importRecord()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} catch (\Throwable $th) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->logError($th);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return 0;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param array $params- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Convert taxes to system format.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param array $params- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param int $id- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (isset($this->cache[$id])) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'unitName' => 'dbo.JEDNOSTKA.SKROT',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($query->batch(100, $this->controller->getDb()) as $rows) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
++$u;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
++$i;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
]]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return 2;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $key ?? '';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'total' => 'dbo.CENA_ARTYKULU.CENA_NETTO',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$lastId = $s = $e = $i = $u = 0;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 0:- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($this->controller->cron && $this->controller->cron->checkTimeout()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->recordModel = \Vtiger_Record_Model::getCleanInstance('Products');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->recordModel->set('discontinued', 1);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Convert category to system format.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$pauser = \App\Pauser::getInstance('WaproProductsLastId');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$query->where(['>', 'dbo.ARTYKUL.ID_ARTYKULU', $val]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->skip = false;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
default:- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 2:- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
++$e;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function importRecord(): int- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Convert price to system format.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
protected function convertTaxes(string $value, array $params): string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
throw $th;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $value- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function importRecordById(int $id): int- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->row = $this->getRecordById($id);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->leftJoin('dbo.KATEGORIA_ARTYKULU_TREE', 'dbo.ARTYKUL.ID_KATEGORII_TREE = dbo.KATEGORIA_ARTYKULU_TREE.ID_KATEGORII_TREE')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($val = $pauser->getValue()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->recordModel = \Vtiger_Record_Model::getInstanceById($id, 'Products');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->log("Create {$i} | Update {$u} | Skipped {$s} | Error {$e}");- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->recordModel->setDataForSave([\App\Integrations\Wapro::RECORDS_MAP_TABLE_NAME => [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$currency = $this->getBaseCurrency();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'dbo.ARTYKUL.*',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'category' => 'dbo.KATEGORIA_ARTYKULU_TREE.NAZWA',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'gross' => 'dbo.CENA_ARTYKULU.CENA_BRUTTO',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->where(['dbo.ARTYKUL.ID_ARTYKULU' => $id])- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->loadFromFieldMap();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $value- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->getGlobalTax($value, true);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->waproId = $this->row['ID_ARTYKULU'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
try {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->leftJoin('dbo.CENA_ARTYKULU', 'dbo.ARTYKUL.ID_CENY_DOM = dbo.CENA_ARTYKULU.ID_CENY')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->one($this->controller->getDb()) ?? [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
protected function convertPrice(string $value, array $params): string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->logError($th);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$lastId = 0;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->cache[$this->waproId] = $row;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$list = \App\Fields\Tree::getPicklistValue($fieldModel->getFieldParams(), $fieldModel->getModuleName());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param int $id- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getRecordById(int $id): array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->cache[$id];- Exclude checks
Line exceeds 120 characters; contains 134 characters Open
Open
->leftJoin('dbo.KATEGORIA_ARTYKULU_TREE', 'dbo.ARTYKUL.ID_KATEGORII_TREE = dbo.KATEGORIA_ARTYKULU_TREE.ID_KATEGORII_TREE')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach ($rows as $row) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$pauser->destroy();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->recordModel->getPreviousValue() ? 1 : 3;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $value- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'currencies' => [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'currencyId' => $currency['currencyId']- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param array $params- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Get product record by record id.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
++$s;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 1:- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$lastId = $this->waproId;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (0 == $lastId) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($id = $this->findInMapTable($this->waproId, 'ARTYKUL')) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Import record by id.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->cache[$id] = (new \App\Db\Query())->select([- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return (new \App\Db\Query())->from('dbo.ARTYKUL')->count('*', $this->controller->getDb());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->leftJoin('dbo.JEDNOSTKA', 'dbo.ARTYKUL.ID_JEDNOSTKI = dbo.JEDNOSTKA.ID_JEDNOSTKI')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getCounter(): int- Exclude checks