YetiForceCompany/YetiForceCRM

View on GitHub
app/Mail/ScannerAction/LinkByFields.php

Summary

Maintainability
A
45 mins
Test Coverage
F
0%

Function process has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function process(): void
    {
        $scanner = $this->scannerEngine;
        if (empty($scanner->processData['CreatedMail']) || false === $scanner->getMailCrmId()) {
            return;
Severity: Minor
Found in app/Mail/ScannerAction/LinkByFields.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing class import via use statement (line '31', column '25').
Open

            $relationModel = new \OSSMailView_Relation_Model();

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid assigning values to variables in if clauses and the like (line '30', column '7').
Open

    public function process(): void
    {
        $scanner = $this->scannerEngine;
        if (empty($scanner->processData['CreatedMail']) || false === $scanner->getMailCrmId()) {
            return;

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Argument 1 (sourceRecordId) is array but \OSSMailView_Relation_Model::addRelation() takes int defined at /code/modules/OSSMailView/models/Relation.php:21
Open

                if ($relationModel->addRelation($scanner->getMailCrmId(), $id, $scanner->get('date'))) {

false to array comparison
Open

        if (empty($scanner->processData['CreatedMail']) || false === $scanner->getMailCrmId()) {

Spaces must be used to indent lines; tabs are not allowed
Open

            $relationModel = new \OSSMailView_Relation_Model();

Spaces must be used to indent lines; tabs are not allowed
Open

                if ($relationModel->addRelation($scanner->getMailCrmId(), $id, $scanner->get('date'))) {

Spaces must be used to indent lines; tabs are not allowed
Open

                    $returnIds[] = $id;

Spaces must be used to indent lines; tabs are not allowed
Open

    public function process(): void

Spaces must be used to indent lines; tabs are not allowed
Open

        $scanner = $this->scannerEngine;

Spaces must be used to indent lines; tabs are not allowed
Open

        if ($ids = $scanner->findRelatedRecords(true)) {

Spaces must be used to indent lines; tabs are not allowed
Open

            }

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

    public static $priority = 3;

Spaces must be used to indent lines; tabs are not allowed
Open

        }

Spaces must be used to indent lines; tabs are not allowed
Open

        $returnIds = [];

Spaces must be used to indent lines; tabs are not allowed
Open

    {

Spaces must be used to indent lines; tabs are not allowed
Open

            foreach ($ids as $id) {

Spaces must be used to indent lines; tabs are not allowed
Open

    }

Spaces must be used to indent lines; tabs are not allowed
Open

        if (empty($scanner->processData['CreatedMail']) || false === $scanner->getMailCrmId()) {

Spaces must be used to indent lines; tabs are not allowed
Open

        $scanner->processData['LinkByFields'] = $returnIds;

Spaces must be used to indent lines; tabs are not allowed
Open

            return;

Spaces must be used to indent lines; tabs are not allowed
Open

    /** {@inheritdoc} */

Spaces must be used to indent lines; tabs are not allowed
Open

                }

Spaces must be used to indent lines; tabs are not allowed
Open

        }

There are no issues that match your filters.

Category
Status