Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
app/Map/Address/NominatimGeocoder.php

Summary

Maintainability
D
2 days
Test Coverage
F
0%

Method find has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function find($value): array
    {
        if (empty($value) || !\App\RequestUtil::isNetConnection()) {
            return [];
        }
Severity: Major
Found in app/Map/Address/NominatimGeocoder.php - About 2 hrs to fix

    Function find has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public function find($value): array
    {
        if (empty($value) || !\App\RequestUtil::isNetConnection()) {
            return [];
        }
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method find() has an NPath complexity of 348. The configured NPath complexity threshold is 200.
    Open

        public function find($value): array
    {
        if (empty($value) || !\App\RequestUtil::isNetConnection()) {
            return [];
        }
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
    function bar() {
        // lots of complicated code
    }
}

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method find() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
    Open

        public function find($value): array
    {
        if (empty($value) || !\App\RequestUtil::isNetConnection()) {
            return [];
        }
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Missing class import via use statement (line '83', column '15').
    Open

                    throw new \App\Exceptions\AppException('Error with connection |' . $response->getReasonPhrase() . '|' . $response->getBody());
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '79', column '21').
    Open

                $response = (new \GuzzleHttp\Client(\App\RequestHttp::getOptions()))
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class '\App\Log' in method 'find'.
    Open

                \App\Log::error('Error - ' . $ex->getMessage(), __CLASS__);
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Map\Address' in method 'find'.
    Open

    }
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\RequestUtil' in method 'find'.
    Open

            if (empty($value) || !\App\RequestUtil::isNetConnection()) {
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Config' in method 'find'.
    Open

                'accept-language' => \App\Language::getLanguage() . ',' . \App\Config::main('default_language') . ',en-US',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Config\Components\AddressFinder' in method 'find'.
    Open

                    $mainMapping = \Config\Components\AddressFinder::nominatimRemapping();
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Config\Components\AddressFinder' in method 'find'.
    Open

                    $countryMapping = \Config\Components\AddressFinder::nominatimRemappingForCountry();
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Log' in method 'find'.
    Open

                \App\Log::endProfile("GET|NominatimGeocoder::find|{$url}", __NAMESPACE__);
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Json' in method 'find'.
    Open

                $body = \App\Json::isEmpty($body) ? [] : \App\Json::decode($body);
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Language' in method 'find'.
    Open

                'accept-language' => \App\Language::getLanguage() . ',' . \App\Config::main('default_language') . ',en-US',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Json' in method 'find'.
    Open

                $body = \App\Json::isEmpty($body) ? [] : \App\Json::decode($body);
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\RequestHttp' in method 'find'.
    Open

                $response = (new \GuzzleHttp\Client(\App\RequestHttp::getOptions()))
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Log' in method 'find'.
    Open

                \App\Log::beginProfile("GET|NominatimGeocoder::find|{$url}", __NAMESPACE__);
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Define a constant instead of duplicating this literal "address" 23 times.
    Open

                        if (isset($row['address']['country_code'], $countryMapping[strtoupper($row['address']['country_code'])])) {
    Severity: Critical
    Found in app/Map/Address/NominatimGeocoder.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "label" 3 times.
    Open

                'label' => 'LBL_COUNTRY_CODES',
    Severity: Critical
    Found in app/Map/Address/NominatimGeocoder.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "country_code" 5 times.
    Open

                        if (isset($row['address']['country_code'], $countryMapping[strtoupper($row['address']['country_code'])])) {
    Severity: Critical
    Found in app/Map/Address/NominatimGeocoder.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "map_url" 3 times.
    Open

            'map_url' => [
    Severity: Critical
    Found in app/Map/Address/NominatimGeocoder.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "country_codes" 3 times.
    Open

            'country_codes' => [
    Severity: Critical
    Found in app/Map/Address/NominatimGeocoder.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Avoid unused private methods such as 'parseRow'.
    Open

        private function parseRow(array $row): array
    {
        return [
            'addresslevel1' => [$row['address']['country'] ?? '', strtoupper($row['address']['country_code'] ?? '')],
            'addresslevel2' => $row['address']['state'] ?? '',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpmd

    UnusedPrivateMethod

    Since: 0.2

    Unused Private Method detects when a private method is declared but is unused.

    Example

    class Something
{
    private function foo() {} // unused
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

    Reference to undeclared property \App\Map\Address\NominatimGeocoder->config
    Open

            if (!empty($this->config['country_codes'])) {
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phan

    Reference to undeclared property \App\Map\Address\NominatimGeocoder->config
    Open

                $url = $this->config['map_url'] . '?' . http_build_query($params);
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phan

    Class extends undeclared class \App\Map\Address\Base (Did you mean class \App\Base or class \App\Cache\Base or class \App\Cli\Base or class \App\Controller\Base or class \App\Controller\View\Base or class \App\Db\Importers\Base or class \Tests\Base)
    Open

    class NominatimGeocoder extends Base
    Severity: Critical
    Found in app/Map/Address/NominatimGeocoder.php by phan

    Call to method request from undeclared class \GuzzleHttp\Client
    Open

                $response = (new \GuzzleHttp\Client(\App\RequestHttp::getOptions()))
    Severity: Critical
    Found in app/Map/Address/NominatimGeocoder.php by phan

    Call to method endProfile from undeclared class \App\Log
    Open

                \App\Log::endProfile("GET|NominatimGeocoder::find|{$url}", __NAMESPACE__);
    Severity: Critical
    Found in app/Map/Address/NominatimGeocoder.php by phan

    Call to method nominatimRemappingForCountry from undeclared class \Config\Components\AddressFinder
    Open

                    $countryMapping = \Config\Components\AddressFinder::nominatimRemappingForCountry();
    Severity: Critical
    Found in app/Map/Address/NominatimGeocoder.php by phan

    Reference to undeclared property \App\Map\Address\NominatimGeocoder->config
    Open

            return !empty($this->config['map_url']);
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phan

    Call to method nominatimRemapping from undeclared class \Config\Components\AddressFinder
    Open

                    $mainMapping = \Config\Components\AddressFinder::nominatimRemapping();
    Severity: Critical
    Found in app/Map/Address/NominatimGeocoder.php by phan

    Call to method error from undeclared class \App\Log
    Open

                \App\Log::error('Error - ' . $ex->getMessage(), __CLASS__);
    Severity: Critical
    Found in app/Map/Address/NominatimGeocoder.php by phan

    Reference to static property nominatimMapUrlCustomOptions from undeclared class \Config\Components\AddressFinder
    Open

            if (!empty(\Config\Components\AddressFinder::$nominatimMapUrlCustomOptions)) {
    Severity: Critical
    Found in app/Map/Address/NominatimGeocoder.php by phan

    Reference to undeclared property \App\Map\Address\NominatimGeocoder->config
    Open

                $params['countrycodes'] = $this->config['country_codes'];
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phan

    Reference to static property nominatimMapUrlCustomOptions from undeclared class \Config\Components\AddressFinder
    Open

                $options = \Config\Components\AddressFinder::$nominatimMapUrlCustomOptions;
    Severity: Critical
    Found in app/Map/Address/NominatimGeocoder.php by phan

    Call to method beginProfile from undeclared class \App\Log
    Open

                \App\Log::beginProfile("GET|NominatimGeocoder::find|{$url}", __NAMESPACE__);
    Severity: Critical
    Found in app/Map/Address/NominatimGeocoder.php by phan

    Call to method __construct from undeclared class \GuzzleHttp\Client
    Open

                $response = (new \GuzzleHttp\Client(\App\RequestHttp::getOptions()))
    Severity: Critical
    Found in app/Map/Address/NominatimGeocoder.php by phan

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        private function parseRow(array $row): array
    {
        return [
            'addresslevel1' => [$row['address']['country'] ?? '', strtoupper($row['address']['country_code'] ?? '')],
            'addresslevel2' => $row['address']['state'] ?? '',
    Severity: Major
    Found in app/Map/Address/NominatimGeocoder.php and 1 other location - About 1 day to fix
    app/Map/Address/YetiForceGeocoder.php on lines 129..144

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 297.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if ($body) {
                $mainMapping = \Config\Components\AddressFinder::nominatimRemapping();
                if (!\is_callable($mainMapping)) {
                    $mainMapping = [$this, 'parseRow'];
                }
    Severity: Major
    Found in app/Map/Address/NominatimGeocoder.php and 1 other location - About 6 hrs to fix
    app/Map/Address/YetiForceGeocoder.php on lines 97..115

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 208.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public $customFields = [
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'typeofdata' => 'V~O',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            'map_url' => [
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'label' => 'LBL_COUNTRY_CODES',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ],
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'url' => 'https://wikipedia.org/wiki/List_of_ISO_3166_country_codes',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                ]
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'uitype' => 1,
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        ];
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    throw new \App\Exceptions\AppException('Error with connection |' . $response->getReasonPhrase() . '|' . $response->getBody());
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'typeofdata' => 'V~M'
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function find($value): array
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $rows = [];
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            try {
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            'label' => $row['display_name'],
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return [
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'localnumber' => $row['address']['local_number'] ?? '',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'maximumlength' => '100',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ],
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'format' => 'json',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ];
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Line exceeds 120 characters; contains 142 characters
    Open

                    throw new \App\Exceptions\AppException('Error with connection |' . $response->getReasonPhrase() . '|' . $response->getBody());
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if ($body) {
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        if (isset($row['address']['country_code'], $countryMapping[strtoupper($row['address']['country_code'])])) {
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            'coordinates' => ['lat' => $row['lat'], 'lon' => $row['lon']],
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public $docUrl = 'https://nominatim.org/release-docs/develop/';
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'link' => [
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'q' => $value,
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if (200 !== $response->getStatusCode()) {
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $countryMapping = \Config\Components\AddressFinder::nominatimRemappingForCountry();
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            ];
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            'country_codes' => [
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'label' => 'LBL_MAP_URL',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return !empty($this->config['map_url']);
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'addresslevel5' => $row['address']['city'] ?? $row['address']['town'] ?? $row['address']['village'] ?? '',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'addresslevel6' => $row['address']['hamlet'] ?? $row['address']['suburb'] ?? $row['address']['neighbourhood'] ?? $row['address']['city_district'] ?? '',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'buildingnumber' => $row['address']['house_number'] ?? '',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'tooltip' => 'LBL_COUNTRY_CODES_PLACEHOLDER',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'uitype' => 17,
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'addressdetails' => 1,
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $mainMapping = [$this, 'parseRow'];
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    foreach ($body as $row) {
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            } catch (\Throwable $ex) {
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return array
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'addresslevel3' => $row['address']['county'] ?? $row['address']['state_district'] ?? '',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'purifyType' => \App\Purifier::TEXT,
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    ->request('GET', $url, $options);
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                \App\Log::endProfile("GET|NominatimGeocoder::find|{$url}", __NAMESPACE__);
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return $rows;
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    'title' => 'LBL_COUNTRY_CODES_INFO',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'purifyType' => \App\Purifier::URL,
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $mappingFunction = $mainMapping;
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $rows[] = [
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        private function parseRow(array $row): array
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'company_name_' => $row['address']['office'] ?? '',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'maximumlength' => '200',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty($this->config['country_codes'])) {
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $options = [];
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $options = \Config\Components\AddressFinder::$nominatimMapUrlCustomOptions;
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $body = $response->getBody();
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $mappingFunction = $countryMapping[strtoupper($row['address']['country_code'])];
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Main function to parse information about address.
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (empty($value) || !\App\RequestUtil::isNetConnection()) {
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $url = $this->config['map_url'] . '?' . http_build_query($params);
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'addresslevel1' => [$row['address']['country'] ?? '', strtoupper($row['address']['country_code'] ?? '')],
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Line exceeds 120 characters; contains 164 characters
    Open

                'addresslevel6' => $row['address']['hamlet'] ?? $row['address']['suburb'] ?? $row['address']['neighbourhood'] ?? $row['address']['city_district'] ?? '',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'addresslevel7' => $row['address']['postcode'] ?? '',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                return [];
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Line exceeds 120 characters; contains 127 characters
    Open

                        if (isset($row['address']['country_code'], $countryMapping[strtoupper($row['address']['country_code'])])) {
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        }
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                \App\Log::beginProfile("GET|NominatimGeocoder::find|{$url}", __NAMESPACE__);
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            'address' => \call_user_func_array($mappingFunction, [$row]),
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        ];
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                \App\Log::error('Error - ' . $ex->getMessage(), __CLASS__);
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $params['countrycodes'] = $this->config['country_codes'];
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function isConfigured()
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty(\Config\Components\AddressFinder::$nominatimMapUrlCustomOptions)) {
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'addresslevel2' => $row['address']['state'] ?? '',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'limit' => \App\Map\Address::getConfig()['global']['result_num'],
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'accept-language' => \App\Language::getLanguage() . ',' . \App\Config::main('default_language') . ',en-US',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $response = (new \GuzzleHttp\Client(\App\RequestHttp::getOptions()))
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $body = \App\Json::isEmpty($body) ? [] : \App\Json::decode($body);
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $mainMapping = \Config\Components\AddressFinder::nominatimRemapping();
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param array $row
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'addresslevel4' => $row['address']['municipality'] ?? '',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                'addresslevel8' => $row['address']['road'] ?? '',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $params = [
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if (!\is_callable($mainMapping)) {
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            'countryCode' => $row['address']['country_code'] ?? '',
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in app/Map/Address/NominatimGeocoder.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status