Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
app/Menu.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Missing class import via use statement (line '41', column '26').
Open

        $menuRecordModel = new \Settings_Menu_Record_Model();
Severity: Minor
Found in app/Menu.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method reloadMenu uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $menuRecordModel->generateFileMenu($menuRoleId);
        }
Severity: Minor
Found in app/Menu.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Spaces must be used to indent lines; tabs are not allowed
Open

        } else {
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        9 => 'RecycleBin',
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @return void
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        if (null === $menuRoleId) {
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public const TYPES = [
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        6 => 'HomeIcon',
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        5 => 'QuickCreate',
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     *
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $menuRecordModel = new \Settings_Menu_Record_Model();
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     *
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        3 => 'Separator',
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public static function reloadMenu(?int $menuRoleId = null): void
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        0 => 'Module',
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /** @var string[] Menu types */
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        2 => 'Label',
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    ];
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        8 => 'Profile',
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        7 => 'CustomFilter',
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * Reload menu.
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param int|null $menuRoleId
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        1 => 'Shortcut',
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $menuRecordModel->refreshMenuFiles();
Severity: Minor
Found in app/Menu.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $menuRecordModel->generateFileMenu($menuRoleId);
Severity: Minor
Found in app/Menu.php by phpcodesniffer

There are no issues that match your filters.

Category
Status