YetiForceCompany/YetiForceCRM

View on GitHub
app/RecordAddsTemplates.php

Summary

Maintainability
A
25 mins
Test Coverage
F
0%

Function getTemplatesList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public static function getTemplatesList(): array
    {
        $listTemplates = [];
        $pathDirectory = ROOT_DIRECTORY . \DIRECTORY_SEPARATOR . 'app' . \DIRECTORY_SEPARATOR . 'RecordAddsTemplates';
        if (file_exists($pathDirectory)) {
Severity: Minor
Found in app/RecordAddsTemplates.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing class import via use statement (line '43', column '48').
Open

            foreach (new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($pathDirectory, \RecursiveDirectoryIterator::SKIP_DOTS), \RecursiveIteratorIterator::SELF_FIRST) as $item) {
Severity: Minor
Found in app/RecordAddsTemplates.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '43', column '17').
Open

            foreach (new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($pathDirectory, \RecursiveDirectoryIterator::SKIP_DOTS), \RecursiveIteratorIterator::SELF_FIRST) as $item) {
Severity: Minor
Found in app/RecordAddsTemplates.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * Get record adds templates instance.
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    /**
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                    $listTemplates[] = static::getInstance($fileName);
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @return object
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public static function getInstance(string $name): object
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $listTemplates = [];
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     */
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                    $fileName = $item->getBasename('.php');
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Line exceeds 120 characters; contains 192 characters
Open

            foreach (new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($pathDirectory, \RecursiveDirectoryIterator::SKIP_DOTS), \RecursiveIteratorIterator::SELF_FIRST) as $item) {
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     *
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                }
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        if (file_exists($pathDirectory)) {
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * List of available templates.
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    {
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $className = '\\App\\RecordAddsTemplates\\' . $name;
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public static function getTemplatesList(): array
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            }
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     *
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return $listTemplates;
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                if ($item->isFile()) {
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param string $name
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     *
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return new $className();
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

     * @return array
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $pathDirectory = ROOT_DIRECTORY . \DIRECTORY_SEPARATOR . 'app' . \DIRECTORY_SEPARATOR . 'RecordAddsTemplates';
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            foreach (new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($pathDirectory, \RecursiveDirectoryIterator::SKIP_DOTS), \RecursiveIteratorIterator::SELF_FIRST) as $item) {
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in app/RecordAddsTemplates.php by phpcodesniffer

There are no issues that match your filters.

Category
Status