app/RecordCollectors/UkVatPayerStatusVerification.php
Method search has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function search(): array
{
if (!$this->isActive()) {
return [];
}The method search uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$response['fields'] = [
'' => \App\Language::translate('LBL_UK_VAT_PAYER_NOT_CONFIRM', 'Other.RecordCollector')
];
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\App\Language' in method 'search'. Open
Open
'' => \App\Language::translate('LBL_UK_VAT_PAYER_NOT_CONFIRM', 'Other.RecordCollector')- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Json' in method 'search'. Open
Open
$response = \App\Json::decode(\App\RequestHttp::getClient()->get($this->url . 'organisations/vat/check-vat-number/lookup/' . $vatNumber)
->getBody()
->getContents());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Log' in method 'search'. Open
Open
\App\Log::warning($e->getMessage(), 'RecordCollectors');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Language' in method 'search'. Open
Open
'' => \App\Language::translate('LBL_UK_VAT_PAYER_CONFIRM', 'Other.RecordCollector'),- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) Open
Open
protected string $addOnName = 'YetiForceRcUkVatPayerStatus';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'Vendors' => [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'vatNumber' => 'vat_id',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} catch (\GuzzleHttp\Exception\GuzzleException $e) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
protected $modulesFieldsMap = [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->getBody()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'vatNumber' => 'vat_id',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'vatNumber' => 'vat_id',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'Competition' => [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $allowedModules = ['Accounts', 'Leads', 'Vendors', 'Competition', 'Partners'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $description = 'LBL_UK_VAT_PAYER_DESC';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $docUrl = 'https://developer.service.hmrc.gov.uk/api-documentation';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
protected string $addOnName = 'YetiForceRcUkVatPayerStatus';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'Leads' => [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function search(): array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
protected $fields = [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'vatNumber' => [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** @var string API sever address */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$response = [];- Exclude checks
Line exceeds 120 characters; contains 148 characters Open
Open
$response = \App\Json::decode(\App\RequestHttp::getClient()->get($this->url . 'organisations/vat/check-vat-number/lookup/' . $vatNumber)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
\App\Log::warning($e->getMessage(), 'RecordCollectors');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'labelModule' => '_Base',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'Partners' => [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->response['error'] = $e->getMessage();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $displayType = 'Summary';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!$this->isActive()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $label = 'LBL_UK_VAT_PAYER';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'label' => 'Vat ID',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'Accounts' => [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$response = \App\Json::decode(\App\RequestHttp::getClient()->get($this->url . 'organisations/vat/check-vat-number/lookup/' . $vatNumber)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'typeofdata' => 'V~M',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
->getContents());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$vatNumber = str_replace([' ', ',', '.', '-'], '', $this->request->getByType('vatNumber', 'Text'));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!$vatNumber) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
try {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$response['fields'] = [- Exclude checks
Line exceeds 120 characters; contains 195 characters Open
Open
'Address' => $response['target']['address']['line1'] . $response['target']['address']['line2'] . $response['target']['address']['line3'] . $response['target']['address']['line4'],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
protected $url = 'https://api.service.hmrc.gov.uk/';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'vatNumber' => 'vat_id',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'' => \App\Language::translate('LBL_UK_VAT_PAYER_CONFIRM', 'Other.RecordCollector'),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $icon = 'yfi-vat-uk';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'vatNumber' => 'vat_id',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'Country' => $response['target']['address']['countryCode']- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $response;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$response['fields'] = [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'' => \App\Language::translate('LBL_UK_VAT_PAYER_NOT_CONFIRM', 'Other.RecordCollector')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (isset($response['target'])) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'Address' => $response['target']['address']['line1'] . $response['target']['address']['line2'] . $response['target']['address']['line3'] . $response['target']['address']['line4'],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'Name' => $response['target']['name'],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'Vat ID' => $response['target']['vatNumber'],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'Postcode' => $response['target']['address']['postcode'],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks