Function initInventoryValuesByUser has a Cognitive Complexity of 68 (exceeds 5 allowed). Consider refactoring.

Open

    private function initInventoryValuesByUser()
    {
        $invData = [];
        $counter = 1;
        foreach ($this->cleanRecordModels as $groupBy => $newRecordModel) {

• Read up
  Read up

File RecordConverter.php has 439 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

/**
 * RecordConverter class.
 *

Function initInventoryValuesAuto has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.

Open

    private function initInventoryValuesAuto()
    {
        $invData = [];
        $counter = 1;
        foreach ($this->cleanRecordModels as $groupBy => $newRecordModel) {

• Read up
  Read up

Function checkIfDuplicateRecordExists has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.

Open

    public function checkIfDuplicateRecordExists()
    {
        if ($this->get('check_duplicate') && isset($this->fieldMapping['field_merge'][$this->destinyModuleModel->getId()])) {
            $referenceDestinyField = $this->fieldMapping['field_merge'][$this->destinyModuleModel->getId()];
            if ($referenceDestinyField) {

• Read up
  Read up

RecordConverter has 29 functions (exceeds 20 allowed). Consider refactoring.

Open

class RecordConverter extends Base
{
    /** @var int Field to mapping */
    const FIELD_TO_MAPPING = 1;

The class RecordConverter has 12 public methods. Consider refactoring RecordConverter to keep number of public methods under 10.

Open

class RecordConverter extends Base
{
    /** @var int Field to mapping */
    const FIELD_TO_MAPPING = 1;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

The class RecordConverter has an overall complexity of 142 which is very high. The configured complexity threshold is 50.

Open

class RecordConverter extends Base
{
    /** @var int Field to mapping */
    const FIELD_TO_MAPPING = 1;

• Exclude checks
  • Disable engine
  • Disable check

Function getModuleConverters has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.

Open

    public static function getModuleConverters(string $moduleName, string $view = '', array $recordIds = [], ?int $userId = null): array
    {
        $converters = [];
        if (null === $userId) {
            $userId = \App\User::getCurrentUserId();

• Read up
  Read up

Method initInventoryValuesByUser has 43 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function initInventoryValuesByUser()
    {
        $invData = [];
        $counter = 1;
        foreach ($this->cleanRecordModels as $groupBy => $newRecordModel) {

The class RecordConverter has 17 fields. Consider redesigning RecordConverter to keep the number of fields under 15.

Open

class RecordConverter extends Base
{
    /** @var int Field to mapping */
    const FIELD_TO_MAPPING = 1;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Person {
   protected $one;
   private $two;
   private $three;
   [... many more fields ...]
}

Method initInventoryValuesAuto has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function initInventoryValuesAuto()
    {
        $invData = [];
        $counter = 1;
        foreach ($this->cleanRecordModels as $groupBy => $newRecordModel) {

Function initFieldValuesAuto has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.

Open

    public function initFieldValuesAuto()
    {
        foreach ($this->cleanRecordModels as $groupBy => $newRecordModel) {
            foreach ($this->sourceModuleModel->getFields() as $fieldModel) {
                if ('picklist' === $fieldModel->getFieldDataType()) {

• Read up
  Read up

Function isAvailable has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

Open

    public static function isAvailable(\Vtiger_Record_Model $recordModel, string $view = '', ?int $userId = null): bool
    {
        $result = false;
        if (null === $userId) {
            $userId = \App\User::getCurrentUserId();

• Read up
  Read up

Method getModuleConverters has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public static function getModuleConverters(string $moduleName, string $view = '', array $recordIds = [], ?int $userId = null): array
    {
        $converters = [];
        if (null === $userId) {
            $userId = \App\User::getCurrentUserId();

Function getRecordModelsWithoutMerge has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

    public function getRecordModelsWithoutMerge(array $records)
    {
        foreach ($records as $recordId) {
            if (!$this->isPermitted($recordId)) {
                continue;

• Read up
  Read up

Function checkFieldMergeExist has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    public function checkFieldMergeExist()
    {
        $this->isFieldMergeExists = false;
        if (isset($this->fieldMapping['field_merge'])) {
            $destinyReferenceFields = $this->destinyModuleModel->getFieldsByReference();

• Read up
  Read up

Function initFieldValuesByUser has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    public function initFieldValuesByUser()
    {
        $fieldsData = $this->getMappingFields()[$this->destinyModuleModel->getId()] ?? [];
        $destFieldList = $this->destinyModuleModel->getFieldsById();
        foreach ($this->cleanRecordModels as $key => $cleanRecordModel) {

• Read up
  Read up

Function checkFieldMappingFields has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

    public function checkFieldMappingFields()
    {
        if (isset($this->fieldMapping['mapping'][$this->destinyModuleModel->getId()])) {
            foreach ($this->fieldMapping['mapping'][$this->destinyModuleModel->getId()] as $destinyField => $sourceField) {
                if (!$this->destinyModuleModel->getField($destinyField)) {

• Read up
  Read up

Function getRecordsGroupBy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

    public function getRecordsGroupBy(array $records)
    {
        foreach ($this->getGroupRecords($records) as $groupBy => $recordsId) {
            $this->cleanRecordModels[$groupBy] = \Vtiger_Record_Model::getCleanInstance($this->destinyModule);
            $this->cleanRecordModels[$groupBy]->set($this->fieldMapping['field_merge'][$this->destinyModuleModel->getId()], $groupBy);

• Read up
  Read up

The method initInventoryValuesByUser() has an NPath complexity of 271. The configured NPath complexity threshold is 200.

Open

    private function initInventoryValuesByUser()
    {
        $invData = [];
        $counter = 1;
        foreach ($this->cleanRecordModels as $groupBy => $newRecordModel) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    function bar() {
        // lots of complicated code
    }
}

The method getModuleConverters() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.

Open

    public static function getModuleConverters(string $moduleName, string $view = '', array $recordIds = [], ?int $userId = null): array
    {
        $converters = [];
        if (null === $userId) {
            $userId = \App\User::getCurrentUserId();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

The method initInventoryValuesByUser() has a Cyclomatic Complexity of 17. The configured cyclomatic complexity threshold is 10.

Open

    private function initInventoryValuesByUser()
    {
        $invData = [];
        $counter = 1;
        foreach ($this->cleanRecordModels as $groupBy => $newRecordModel) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

The method initInventoryValuesAuto() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.

Open

    private function initInventoryValuesAuto()
    {
        $invData = [];
        $counter = 1;
        foreach ($this->cleanRecordModels as $groupBy => $newRecordModel) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed.

Open

    public static function getModuleConverters(string $moduleName, string $view = '', array $recordIds = [], ?int $userId = null): array

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Refactor this function to reduce its Cognitive Complexity from 41 to the 15 allowed.

Open

    private function initInventoryValuesAuto()

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Refactor this function to reduce its Cognitive Complexity from 27 to the 15 allowed.

Open

    public function checkIfDuplicateRecordExists()

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Refactor this function to reduce its Cognitive Complexity from 68 to the 15 allowed.

Open

    private function initInventoryValuesByUser()

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Class "RecordConverter" has 29 methods, which is greater than 20 authorized. Split it into smaller classes.

Open

class RecordConverter extends Base

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

The class RecordConverter has a coupling between objects value of 20. Consider to reduce the number of dependencies under 13.

Open

class RecordConverter extends Base
{
    /** @var int Field to mapping */
    const FIELD_TO_MAPPING = 1;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Avoid assigning values to variables in if clauses and the like (line '232', column '11').

Open

    public static function getModuleConverters(string $moduleName, string $view = '', array $recordIds = [], ?int $userId = null): array
    {
        $converters = [];
        if (null === $userId) {
            $userId = \App\User::getCurrentUserId();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Avoid using static access to class '\App\Json' in method 'isPermitted'.

Open

            && (\App\Json::isEmpty($this->get('conditions')) || \App\Condition::checkConditions(\App\Json::decode($this->get('conditions')), \Vtiger_Record_Model::getInstanceById($recordId)));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'App\Cache' in method 'getQuery'.

Open

            return Cache::get('getQueryRecordConverter', $moduleName . $view);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'App\Log' in method 'getInstanceById'.

Open

            Log::error("Could not find record converter id: $id module name: $moduleName");

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Privilege' in method 'isAvailable'.

Open

                if (!($modulePermitted = \App\Privilege::isPermitted(\App\Module::getModuleName($destinyModuleId), 'CreateView', false, $userId))) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Json' in method 'getModuleConverters'.

Open

            $conditions = $row['conditions'] ? \App\Json::decode($row['conditions']) : [];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Module' in method 'getModuleConverters'.

Open

                if (!($modulePermitted = \App\Privilege::isPermitted(\App\Module::getModuleName($destinyModuleId), 'CreateView', false, $userId))) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method getInstanceById uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            Log::error("Could not find record converter id: $id module name: $moduleName");
            throw new Exceptions\AppException('ERR_NOT_FOUND_RECORD_CONVERTER|' . $id);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid assigning values to variables in if clauses and the like (line '200', column '11').

Open

    public static function isAvailable(\Vtiger_Record_Model $recordModel, string $view = '', ?int $userId = null): bool
    {
        $result = false;
        if (null === $userId) {
            $userId = \App\User::getCurrentUserId();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Avoid using static access to class 'App\Module' in method 'isPermitted'.

Open

        $moduleName = Module::getModuleName($this->get('source_module'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'App\Db' in method 'getInstanceById'.

Open

        $row = $query->one(Db::getInstance('admin'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Module' in method 'isAvailable'.

Open

                if (!($modulePermitted = \App\Privilege::isPermitted(\App\Module::getModuleName($destinyModuleId), 'CreateView', false, $userId))) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\User' in method 'getModuleConverters'.

Open

            $userId = \App\User::getCurrentUserId();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Privilege' in method 'isPermitted'.

Open

        return \App\Privilege::isPermitted($moduleName, 'RecordConventer') && \App\Privilege::isPermitted($moduleName, 'DetailView', $recordId)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'App\Json' in method 'init'.

Open

        $this->fieldMapping = $this->get('field_mapping') ? Json::decode($this->get('field_mapping')) : [];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'App\Json' in method 'init'.

Open

        $this->inventoryMapping = $this->get('inv_field_mapping') ? Json::decode($this->get('inv_field_mapping')) : [];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Privilege' in method 'isPermitted'.

Open

        return \App\Privilege::isPermitted($moduleName, 'RecordConventer') && \App\Privilege::isPermitted($moduleName, 'DetailView', $recordId)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'App\Module' in method 'getInstanceById'.

Open

            $query->andWhere(['source_module' => Module::getModuleId($moduleName)]);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'App\Cache' in method 'getQuery'.

Open

        Cache::save('getQueryRecordConverter', $moduleName . $view, $query);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Vtiger_Module_Model' in method 'init'.

Open

        $this->sourceModuleModel = \Vtiger_Module_Model::getInstance($this->sourceModule);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Vtiger_Record_Model' in method 'getRecordsGroupBy'.

Open

                    $this->recordModels[$groupBy][$recordId] = \Vtiger_Record_Model::getInstanceById($recordId, $this->sourceModule);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'App\Db' in method 'isActive'.

Open

        return self::getQuery($moduleName, $view)->exists(Db::getInstance('admin'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Vtiger_Record_Model' in method 'getModuleConverters'.

Open

                    if (\App\Condition::checkConditions($conditions, \Vtiger_Record_Model::getInstanceById($recordId))) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'App\Module' in method 'getDestinyModules'.

Open

            $destinyModuleName = Module::getModuleName($destinyModuleId);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Json' in method 'isPermitted'.

Open

            && (\App\Json::isEmpty($this->get('conditions')) || \App\Condition::checkConditions(\App\Json::decode($this->get('conditions')), \Vtiger_Record_Model::getInstanceById($recordId)));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $this->getRecordModelsWithoutMerge($records);
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\Vtiger_Module_Model' in method 'initDestinyModuleValues'.

Open

        $this->destinyModuleModel = \Vtiger_Module_Model::getInstance($this->destinyModule);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Json' in method 'isAvailable'.

Open

            $conditions = $row['conditions'] ? \App\Json::decode($row['conditions']) : [];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'App\Cache' in method 'getQuery'.

Open

        if (Cache::has('getQueryRecordConverter', $moduleName . $view)) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'App\Module' in method 'init'.

Open

        $this->sourceModule = Module::getModuleName($this->get('source_module'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Vtiger_Record_Model' in method 'getRecordsGroupBy'.

Open

            $this->cleanRecordModels[$groupBy] = \Vtiger_Record_Model::getCleanInstance($this->destinyModule);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Condition' in method 'isAvailable'.

Open

            $result = $modulePermitted && \App\Condition::checkConditions($conditions, $recordModel);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Privilege' in method 'getModuleConverters'.

Open

                if (!($modulePermitted = \App\Privilege::isPermitted(\App\Module::getModuleName($destinyModuleId), 'CreateView', false, $userId))) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Condition' in method 'getModuleConverters'.

Open

                    if (\App\Condition::checkConditions($conditions, \Vtiger_Record_Model::getInstanceById($recordId))) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'App\Module' in method 'getQuery'.

Open

            $moduleName = Module::getModuleId($moduleName);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Condition' in method 'isPermitted'.

Open

            && (\App\Json::isEmpty($this->get('conditions')) || \App\Condition::checkConditions(\App\Json::decode($this->get('conditions')), \Vtiger_Record_Model::getInstanceById($recordId)));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'App\Privilege' in method 'getDestinyModules'.

Open

            if (Privilege::isPermitted($destinyModuleName, 'CreateView')) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\User' in method 'isAvailable'.

Open

            $userId = \App\User::getCurrentUserId();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'App\Json' in method 'init'.

Open

        $this->defaultValuesCreatedRecord = $this->get('default_values') ? Json::decode($this->get('default_values')) : [];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Vtiger_Record_Model' in method 'isPermitted'.

Open

            && (\App\Json::isEmpty($this->get('conditions')) || \App\Condition::checkConditions(\App\Json::decode($this->get('conditions')), \Vtiger_Record_Model::getInstanceById($recordId)));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\CRMEntity' in method 'getGroupRecords'.

Open

        $focus = \CRMEntity::getInstance($this->sourceModule);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method processInventoryMapping uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $this->initInventoryValuesByUser();
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\Vtiger_Record_Model' in method 'getRecordModelsWithoutMerge'.

Open

            $this->cleanRecordModels[$recordId] = \Vtiger_Record_Model::getCleanInstance($this->destinyModule);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method checkIfDuplicateRecordExists uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

                        } else {
                            $sourceRecordModel = \Vtiger_Record_Model::getInstanceById($groupBy, $this->sourceModule);
                            $columnsToCheck[$referenceDestinyField] = $sourceRecordModel->get($this->get('field_merge'));
                        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\Vtiger_Record_Model' in method 'getRecordModelsWithoutMerge'.

Open

                $this->recordModels[$recordId] = \Vtiger_Record_Model::getInstanceById($recordId, $this->sourceModule);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'App\Fields\Picklist' in method 'initFieldValuesAuto'.

Open

                    if (Fields\Picklist::isExists($fieldModel->getFieldName(), $this->recordModels[$groupBy]->get($fieldModel->getFieldName()))) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\CRMEntity' in method 'getQueryForDuplicate'.

Open

        $focus = \CRMEntity::getInstance($this->destinyModule);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method checkIfDuplicateRecordExists uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

                    } else {
                        foreach ($this->fieldMapping['mapping'][$this->destinyModuleModel->getId()] as $destinyField => $sourceField) {
                            $columnsToCheck[$destinyField] = $this->textParserValues[$groupBy][$sourceField];
                        }
                    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method initFieldValuesAuto uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

                } else {
                    $newRecordModel->set($fieldModel->getFieldName(), $this->recordModels[$groupBy]->get($fieldModel->getFieldName()));
                }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method initInventoryValuesAuto uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

                            } else {
                                $inventoryFieldValue = $fieldModel->getDefaultValue();
                            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid assigning values to variables in if clauses and the like (line '636', column '13').

Open

    private function initInventoryValuesByUser()
    {
        $invData = [];
        $counter = 1;
        foreach ($this->cleanRecordModels as $groupBy => $newRecordModel) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

The method processFieldMapping uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $this->initFieldValuesByUser();
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid assigning values to variables in if clauses and the like (line '533', column '59').

Open

    public function initFieldValuesByUser()
    {
        $fieldsData = $this->getMappingFields()[$this->destinyModuleModel->getId()] ?? [];
        $destFieldList = $this->destinyModuleModel->getFieldsById();
        foreach ($this->cleanRecordModels as $key => $cleanRecordModel) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Avoid assigning values to variables in if clauses and the like (line '533', column '121').

Open

    public function initFieldValuesByUser()
    {
        $fieldsData = $this->getMappingFields()[$this->destinyModuleModel->getId()] ?? [];
        $destFieldList = $this->destinyModuleModel->getFieldsById();
        foreach ($this->cleanRecordModels as $key => $cleanRecordModel) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

The method initInventoryValuesAuto uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $sourceRecordModels = $this->recordModels[$groupBy];
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method initInventoryValuesByUser uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $sourceRecordModels = $this->recordModels[$groupBy];
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\Vtiger_Record_Model' in method 'checkIfDuplicateRecordExists'.

Open

                            $sourceRecordModel = \Vtiger_Record_Model::getInstanceById($groupBy, $this->sourceModule);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid assigning values to variables in if clauses and the like (line '650', column '12').

Open

    private function initInventoryValuesByUser()
    {
        $invData = [];
        $counter = 1;
        foreach ($this->cleanRecordModels as $groupBy => $newRecordModel) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Define a constant instead of duplicating this literal "getQueryRecordConverter" 3 times.

Open

        if (Cache::has('getQueryRecordConverter', $moduleName . $view)) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "destiny_module" 3 times.

Open

            $destinyModules = array_filter(explode(',', $row['destiny_module']));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "conditions" 6 times.

Open

            $conditions = $row['conditions'] ? \App\Json::decode($row['conditions']) : [];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "CreateView" 3 times.

Open

                if (!($modulePermitted = \App\Privilege::isPermitted(\App\Module::getModuleName($destinyModuleId), 'CreateView', false, $userId))) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "field_merge" 8 times.

Open

        $fieldModel = $this->sourceModuleModel->getField($this->get('field_merge'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "mapping" 6 times.

Open

        $this->fieldMappingExecute = $this->fieldMapping && (isset($this->fieldMapping['auto']) || isset($this->fieldMapping['mapping'][$this->destinyModuleModel->getId()])) && (!$this->isFieldMergeExists || 1 === $recordsAmount);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "source_module" 4 times.

Open

            $query->andWhere(['source_module' => Module::getModuleId($moduleName)]);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Avoid unused local variables such as '$recordModel'.

Open

                foreach ($this->cleanRecordModels as $groupBy => $recordModel) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Avoid unused local variables such as '$sourceField'.

Open

            foreach ($this->fieldMapping['mapping'][$this->destinyModuleModel->getId()] as $destinyField => $sourceField) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Call to method read from undeclared class \yii\db\DataReader

Open

        while (!$result && ($row = $dataReader->read())) {

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \App\RecordConverter->defaultValuesCreatedRecord

Open

        $this->defaultValuesCreatedRecord = $this->get('default_values') ? Json::decode($this->get('default_values')) : [];

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \App\RecordConverter->mapping

Open

                $this->mapping[$row['dest_module']][$row['dest_field']] = $row;

• Exclude checks
  • Disable engine
  • Disable check

Class \Vtiger_Record_Model was passed to foreach, but it does not extend Traversable. This may be intentional, because some of that class's declared properties are accessible from this context. (This check excludes dynamic properties)

Open

            foreach ($sourceRecordModels as $recordModel) {

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \CRMEntity->table_index

Open

        return (new Db\Query())->from($focus->table_name)->innerJoin($focus->customFieldTable[0], $focus->table_name . '.' . $focus->table_index . '=' . $focus->customFieldTable[0] . '.' . $focus->customFieldTable[1])

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \CRMEntity->table_name

Open

        return (new Db\Query())->from($focus->table_name)->innerJoin($focus->customFieldTable[0], $focus->table_name . '.' . $focus->table_index . '=' . $focus->customFieldTable[0] . '.' . $focus->customFieldTable[1])

• Exclude checks
  • Disable engine
  • Disable check

Call to method close from undeclared class \yii\db\DataReader

Open

        $dataReader->close();

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

        $query = (new Db\Query())->from('a_#__record_converter')->where(['source_module' => $moduleName, 'status' => 1]);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

            $dataReader = (new Db\Query())->from('a_#__record_converter_mapping')->where(['id' => $this->getId()])->createCommand()->query();

• Exclude checks
  • Disable engine
  • Disable check

Call to method getCurrentUserId from undeclared class \App\User (Did you mean class \Tests\App\User)

Open

            $userId = \App\User::getCurrentUserId();

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (tabId) is string but \App\Module::getModuleName() takes int defined at /code/app/Module.php:129

Open

                if (!($modulePermitted = \App\Privilege::isPermitted(\App\Module::getModuleName($destinyModuleId), 'CreateView', false, $userId))) {

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \App\RecordConverter->mapping

Open

        if (!isset($this->mapping)) {

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \CRMEntity->table_index

Open

            ->innerJoin('vtiger_crmentity', $focus->table_name . '.' . $focus->table_index . '= vtiger_crmentity.crmid');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

        $query = (new Db\Query())->from('a_#__record_converter')->where(['id' => $id]);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::exists

Open

        return self::getQuery($moduleName, $view)->exists(Db::getInstance('admin'));

• Exclude checks
  • Disable engine
  • Disable check

Call to method close from undeclared class \yii\db\DataReader

Open

        $dataReader->close();

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \CRMEntity->customFieldTable

Open

        return (new Db\Query())->from($focus->table_name)->innerJoin($focus->customFieldTable[0], $focus->table_name . '.' . $focus->table_index . '=' . $focus->customFieldTable[0] . '.' . $focus->customFieldTable[1])

• Exclude checks
  • Disable engine
  • Disable check

Doc-block of getInstanceById contains declared return type \self which is incompatible with the return type \App\RecordConverter declared in the signature

Open

     * @return \self

• Exclude checks
  • Disable engine
  • Disable check

Call to method getCurrentUserId from undeclared class \App\User (Did you mean class \Tests\App\User)

Open

            $userId = \App\User::getCurrentUserId();

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \App\RecordConverter->mapping

Open

        return $this->mapping;

• Exclude checks
  • Disable engine
  • Disable check

Return type of processToEdit() is undeclared type \App\Vtiger_Module_Model

Open

    public function processToEdit(int $record, string $destinyModule): \Vtiger_Record_Model

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \CRMEntity->table_name

Open

            ->innerJoin('vtiger_crmentity', $focus->table_name . '.' . $focus->table_index . '= vtiger_crmentity.crmid');

• Exclude checks
  • Disable engine
  • Disable check

Return type of getInstanceById() is undeclared type \self

Open

    public static function getInstanceById(int $id, string $moduleName = ''): self

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (tabId) is string but \App\Module::getModuleName() takes int defined at /code/app/Module.php:129

Open

                if (!($modulePermitted = \App\Privilege::isPermitted(\App\Module::getModuleName($destinyModuleId), 'CreateView', false, $userId))) {

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (tabId) is string but \App\Module::getModuleName() takes int defined at /code/app/Module.php:129

Open

            $destinyModuleName = Module::getModuleName($destinyModuleId);

• Exclude checks
  • Disable engine
  • Disable check

Assigning \Vtiger_Record_Model[][] to property but \App\RecordConverter->recordModels is \Vtiger_Record_Model[]

Open

                    $this->recordModels[$groupBy][$recordId] = \Vtiger_Record_Model::getInstanceById($recordId, $this->sourceModule);

• Exclude checks
  • Disable engine
  • Disable check

Class \Vtiger_Record_Model was passed to foreach, but it does not extend Traversable. This may be intentional, because some of that class's declared properties are accessible from this context. (This check excludes dynamic properties)

Open

            foreach ($sourceRecordModels as $recordModel) {

• Exclude checks
  • Disable engine
  • Disable check

Call to deprecated function \Vtiger_Field_Model::getFieldName() defined at /code/modules/Vtiger/models/Field.php:203

Open

                    if (Fields\Picklist::isExists($fieldModel->getFieldName(), $this->recordModels[$groupBy]->get($fieldModel->getFieldName()))) {

• Exclude checks
  • Disable engine
  • Disable check

Call to deprecated function \Vtiger_Field_Model::getFieldName() defined at /code/modules/Vtiger/models/Field.php:203

Open

                        $newRecordModel->set($fieldModel->getFieldName(), $this->recordModels[$groupBy]->get($fieldModel->getFieldName()));

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

        return (new Db\Query())->from($focus->table_name)->innerJoin($focus->customFieldTable[0], $focus->table_name . '.' . $focus->table_index . '=' . $focus->customFieldTable[0] . '.' . $focus->customFieldTable[1])

• Exclude checks
  • Disable engine
  • Disable check

Doc-block of processToEdit contains declared return type \App\Vtiger_Module_Model which is incompatible with the return type \Vtiger_Record_Model declared in the signature

Open

     * @return Vtiger_Module_Model

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::select

Open

        return (new Db\Query())->select([$fieldModel->getTableName() . ".{$fieldModel->getColumnName()}", $focus->tab_name_index[$fieldModel->getTableName()]])->from($fieldModel->getTableName())->where([$focus->tab_name_index[$fieldModel->getTableName()] => $records])->createCommand()->queryAllByGroup(2);

• Exclude checks
  • Disable engine
  • Disable check

Call to method error from undeclared class \App\Log

Open

            Log::error("Could not find record converter id: $id module name: $moduleName");

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \App\RecordConverter->mapping

Open

            $this->mapping = [];

• Exclude checks
  • Disable engine
  • Disable check

Call to deprecated function \Vtiger_Field_Model::getFieldName() defined at /code/modules/Vtiger/models/Field.php:203

Open

                    $newRecordModel->set($fieldModel->getFieldName(), $this->recordModels[$groupBy]->get($fieldModel->getFieldName()));

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::where

Open

                    if ($query->where($columnsToCheck)->exists()) {

• Exclude checks
  • Disable engine
  • Disable check

Call to method read from undeclared class \yii\db\DataReader

Open

        while ($row = $dataReader->read()) {

• Exclude checks
  • Disable engine
  • Disable check

Avoid excessively long variable names like $inventoryMappingExecute. Keep variable name length under 20.

Open

    public $inventoryMappingExecute = false;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $referenceDestinyField. Keep variable name length under 20.

Open

            $referenceDestinyField = $this->fieldMapping['field_merge'][$this->destinyModuleModel->getId()];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $destinyReferenceFields. Keep variable name length under 20.

Open

            $destinyReferenceFields = $this->destinyModuleModel->getFieldsByReference();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $referenceDestinyField. Keep variable name length under 20.

Open

            $referenceDestinyField = $this->fieldMapping['field_merge'][$this->destinyModuleModel->getId()];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid variables with short names like $id. Configured minimum length is 3.

Open

    public static function getInstanceById(int $id, string $moduleName = ''): self

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $fieldMappingExecute = false;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var bool

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Function to get the instance of the record converter model.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $sourceModuleModel;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var \Vtiger_Module_Model

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $recordModels = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var array|string

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var int[]

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $createdRecords = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $groupRecordConvert = false;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $destinyModule = '';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var \Vtiger_Record_Model[]

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $inventoryMapping;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var array

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Variable determines the possibility of inventory fields mapping.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $sourceModule = '';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    const FIELD_TO_MAPPING = 1;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $sourceInvFields = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Variable determines the possibility of fields mapping.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ($moduleName) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Contains values from text parser.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Source module inventory fields.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var bool

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $isFieldMergeExists = false;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $query = (new Db\Query())->from('a_#__record_converter')->where(['id' => $id]);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /** @var int Field to mapping */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var \Vtiger_Module_Model

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var string

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var \Vtiger_Record_Model[]

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var array

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var bool

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static function getInstanceById(int $id, string $moduleName = ''): self

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ($row) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $self->setData($row);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $query->andWhere(['source_module' => Module::getModuleId($moduleName)]);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Destiny module name.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Destiny module model.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param int    $id

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @return \self

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Source module name.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $fieldMapping;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var array

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Source record models.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $textParserValues = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $destinyInvFields = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $inventoryMappingExecute = false;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Variable determines the type of group records.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $self = new self();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Source module model.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Destiny module inventory fields.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var string

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $destinyModuleModel;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Record models of created records.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $cleanRecordModels = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Created records ids.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param string $moduleName

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Convert field mapping.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $error = '';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Variable determines if merge field exist.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $row = $query->one(Db::getInstance('admin'));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Convert inventory mapping.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var array|string

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var bool

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var string

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @return array

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $converters = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                foreach ($recordIds as $recordId) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (\is_string($moduleName)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Gets ID.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->fieldMapping = $this->get('field_mapping') ? Json::decode($this->get('field_mapping')) : [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ($this->sourceModuleModel->isInventory()) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static function isActive($moduleName, string $view = ''): bool

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param int|null $userId