app/Session/Base.php
__construct accesses the super-global variable $_SERVER. Open
Open
public function __construct(string $name = 'YTSID')
{
if (PHP_SESSION_ACTIVE === session_status()) {
return;
}- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}Source
has accesses the super-global variable $_SESSION. Open
Open
public function has($key)
{
return isset($_SESSION[$key]);
}- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}Source
delete accesses the super-global variable $_SESSION. Open
Open
public function delete($key)
{
unset($_SESSION[$key]);
}- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}Source
__construct accesses the super-global variable $_SERVER. Open
Open
public function __construct(string $name = 'YTSID')
{
if (PHP_SESSION_ACTIVE === session_status()) {
return;
}- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}Source
get accesses the super-global variable $_SESSION. Open
Open
public function get($key)
{
return $_SESSION[$key] ?? null;
}- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}Source
set accesses the super-global variable $_SESSION. Open
Open
public function set($key, $value)
{
$_SESSION[$key] = $value;
}- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}Source
The method regenerateId has a boolean flag argument $deleteOldSession, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function regenerateId($deleteOldSession = false)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Avoid using static access to class '\App\RequestUtil' in method '__construct'. Open
Open
$cookie['secure'] = \App\RequestUtil::isHttps();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid unused parameters such as '$sessionId'. Open
Open
public function getById(string $sessionId): array- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Argument 1 (lifetime) is array|array{domain:false|string}|array{httponly:true}|array{lifetime:0|int}|array{samesite:string}|array{secure:bool} but \session_set_cookie_params() takes int Open
Open
session_set_cookie_params($cookie);- Exclude checks
Method \App\Session\Base::clean is declared to return string[] but has no return value Open
Open
public static function clean()- Exclude checks
Method \App\Session\Base::set is declared to return \App\Session\Base|static but has no return value Open
Open
public function set($key, $value)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function __construct(string $name = 'YTSID')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$cookie['domain'] = strtok($_SERVER['HTTP_HOST'], ':');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (isset(\Config\Security::$cookieForceHttpOnly)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$cookie['samesite'] = \Config\Security::$cookieSameSite;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
session_set_cookie_params($cookie);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $key- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to remove the value.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$cookie = session_get_cookie_params();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($cookie['secure']) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function get($key)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function set($key, $value)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $key- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public static function isSupported()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return $this- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to check if the key exists.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Is driver available.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $name- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param mixed $value- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $key- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return true;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Construct.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
session_name($name);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$_SESSION[$key] = $value;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return bool- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$cookie['secure'] = \App\RequestUtil::isHttps();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$cookie['httponly'] = \Config\Security::$cookieForceHttpOnly;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $_SESSION[$key] ?? null;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return session_regenerate_id($deleteOldSession);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return bool- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function has($key)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return isset($_SESSION[$key]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
unset($_SESSION[$key]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (PHP_SESSION_ACTIVE === session_status()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string[]- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the value for a given key.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return mixed Value for the given key- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $key- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @see https://php.net/manual/en/function.session-regenerate-id.php- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param bool $deleteOldSession- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get session data by id.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return 0;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to set the value for a given key.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$cookie['lifetime'] = \Config\Security::$maxLifetimeSessionCookie ?? 0;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (isset($_SERVER['HTTP_HOST'])) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Update the current session id with a newly generated one.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public static function cleanAll(): int- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to clean all session.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return int- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function regenerateId($deleteOldSession = false)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public static function clean()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function delete($key)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $sessionId- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getById(string $sessionId): array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to clean session. Removed old session.- Exclude checks