Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
app/TextParser/TableCurrencySTwoLang.php

Summary

Maintainability
B
5 hrs
Test Coverage
F
0%

Function process has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function process()
    {
        if (!$this->textParser->recordModel || !$this->textParser->recordModel->getModule()->isInventory()) {
            return '';
        }
Severity: Minor
Found in app/TextParser/TableCurrencySTwoLang.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function process()
    {
        if (!$this->textParser->recordModel || !$this->textParser->recordModel->getModule()->isInventory()) {
            return '';
        }
Severity: Major
Found in app/TextParser/TableCurrencySTwoLang.php - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

                if (!empty($currency) && !empty($currencyData) && $baseCurrency['id'] !== $currency && $inventory->isField('tax') && $inventory->isField('taxmode') && $inventory->isField('currency')) {
                $RATE = $baseCurrency['conversion_rate'] / $currencyData['conversion_rate'];
                $html .= '<table class="table-currency-s-two-lang" style="border-collapse:collapse;width:100%;">
                                <thead>
                                    <tr>
    Severity: Major
    Found in app/TextParser/TableCurrencySTwoLang.php - About 40 mins to fix

      The method process() has an NPath complexity of 396. The configured NPath complexity threshold is 200.
      Open

          public function process()
    {
        if (!$this->textParser->recordModel || !$this->textParser->recordModel->getModule()->isInventory()) {
            return '';
        }
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
    function bar() {
        // lots of complicated code
    }
}

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The method process() has a Cyclomatic Complexity of 17. The configured cyclomatic complexity threshold is 10.
      Open

          public function process()
    {
        if (!$this->textParser->recordModel || !$this->textParser->recordModel->getModule()->isInventory()) {
            return '';
        }
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed.
      Open

          public function process()
      Severity: Critical
      Found in app/TextParser/TableCurrencySTwoLang.php by sonar-php

      Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

      See

      Avoid using static access to class '\Vtiger_Inventory_Model' in method 'process'.
      Open

              $inventory = \Vtiger_Inventory_Model::getInstance($this->textParser->moduleName);
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Vtiger_Util_Helper' in method 'process'.
      Open

              $baseCurrency = \Vtiger_Util_Helper::getBaseCurrency();
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\CurrencyField' in method 'process'.
      Open

                                          <td class="value" style="padding:0px 4px;text-align:right;">' . \CurrencyField::convertToUserFormat($tax * $RATE, null, true) . ' ' . $baseCurrency['currency_symbol'] . '</td>
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                  } else {
                $currency = $baseCurrency['id'];
            }
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class '\App\Language' in method 'process'.
      Open

                                              <th colspan="2" style="padding:0px 4px;text-align:center;">' . \App\Language::translate('LBL_CURRENCIES_SUMMARY', $this->textParser->moduleName) . ' / ' . \App\Language::translate('LBL_CURRENCIES_SUMMARY', $this->textParser->moduleName, \App\Language::DEFAULT_LANG) . '</th>
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\App\Language' in method 'process'.
      Open

                                      <td class="name" style="text-align:right;padding:0px 4px;">' . \App\Language::translate('LBL_AMOUNT', $this->textParser->moduleName) . ' / ' . \App\Language::translate('LBL_AMOUNT', $this->textParser->moduleName, \App\Language::DEFAULT_LANG) . '</td>
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\App\Fields\Currency' in method 'process'.
      Open

                  $currencyData = \App\Fields\Currency::getById($currency);
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\App\Language' in method 'process'.
      Open

                                      <td class="name" style="text-align:right;padding:0px 4px;">' . \App\Language::translate('LBL_AMOUNT', $this->textParser->moduleName) . ' / ' . \App\Language::translate('LBL_AMOUNT', $this->textParser->moduleName, \App\Language::DEFAULT_LANG) . '</td>
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\CurrencyField' in method 'process'.
      Open

                                      <td class="value" style="text-align:right;padding:0px 4px;">' . \CurrencyField::convertToUserFormat($currencyAmount * $RATE, null, true) . ' ' . $baseCurrency['currency_symbol'] . '</td>
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\App\Language' in method 'process'.
      Open

                                              <th colspan="2" style="padding:0px 4px;text-align:center;">' . \App\Language::translate('LBL_CURRENCIES_SUMMARY', $this->textParser->moduleName) . ' / ' . \App\Language::translate('LBL_CURRENCIES_SUMMARY', $this->textParser->moduleName, \App\Language::DEFAULT_LANG) . '</th>
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Define a constant instead of duplicating this literal "currency" 4 times.
      Open

              if ($inventory->isField('currency')) {
      Severity: Critical
      Found in app/TextParser/TableCurrencySTwoLang.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Reference to instance property moduleName from undeclared class \App\TextParser
      Open

                                              <th colspan="2" style="padding:0px 4px;text-align:center;">' . \App\Language::translate('LBL_CURRENCIES_SUMMARY', $this->textParser->moduleName) . ' / ' . \App\Language::translate('LBL_CURRENCIES_SUMMARY', $this->textParser->moduleName, \App\Language::DEFAULT_LANG) . '</th>
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phan

      Call to deprecated function \CurrencyField::convertToUserFormat() defined at /code/include/fields/CurrencyField.php:144
      Open

                                          <td class="value" style="padding:0px 4px;text-align:right;">' . \CurrencyField::convertToUserFormat($tax * $RATE, null, true) . ' ' . $baseCurrency['currency_symbol'] . '</td>
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phan

      Argument 2 (user) is null but \CurrencyField::convertToUserFormat() takes \App\User defined at /code/include/fields/CurrencyField.php:144
      Open

                                          <td class="value" style="padding:0px 4px;text-align:right;">' . \CurrencyField::convertToUserFormat($tax * $RATE, null, true) . ' ' . $baseCurrency['currency_symbol'] . '</td>
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phan

      Call to deprecated function \CurrencyField::convertToUserFormat() defined at /code/include/fields/CurrencyField.php:144
      Open

                                      <td class="value" style="text-align:right;padding:0px 4px;">' . \CurrencyField::convertToUserFormat($currencyAmount * $RATE, null, true) . ' ' . $baseCurrency['currency_symbol'] . '</td>
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phan

      Reference to instance property moduleName from undeclared class \App\TextParser
      Open

              $inventory = \Vtiger_Inventory_Model::getInstance($this->textParser->moduleName);
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phan

      Argument 2 (user) is null but \CurrencyField::convertToUserFormat() takes \App\User defined at /code/include/fields/CurrencyField.php:144
      Open

                                      <td class="value" style="text-align:right;padding:0px 4px;">' . \CurrencyField::convertToUserFormat($currencyAmount * $RATE, null, true) . ' ' . $baseCurrency['currency_symbol'] . '</td>
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phan

      Reference to instance property recordModel from undeclared class \App\TextParser
      Open

              if (!$this->textParser->recordModel || !$this->textParser->recordModel->getModule()->isInventory()) {
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phan

      Reference to instance property recordModel from undeclared class \App\TextParser
      Open

              $inventoryRows = $this->textParser->recordModel->getInventoryData();
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phan

      Reference to instance property moduleName from undeclared class \App\TextParser
      Open

                                      <td class="name" style="text-align:right;padding:0px 4px;">' . \App\Language::translate('LBL_AMOUNT', $this->textParser->moduleName) . ' / ' . \App\Language::translate('LBL_AMOUNT', $this->textParser->moduleName, \App\Language::DEFAULT_LANG) . '</td>
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phan

      Call to undeclared method \Vtiger_Basic_InventoryField::getTaxParam
      Open

                          $taxes = $taxField->getTaxParam($inventoryRow['taxparam'], $inventoryRow['net'], $taxes);
      Severity: Critical
      Found in app/TextParser/TableCurrencySTwoLang.php by phan

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $inventory = \Vtiger_Inventory_Model::getInstance($this->textParser->moduleName);
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $inventoryRows = $this->textParser->recordModel->getInventoryData();
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public $name = 'LBL_TABLE_CURRENCY_S_TWO_LANG';
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  if (!empty($firstRow) > 0 && null !== $firstRow['currency']) {
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  return '';
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public $type = 'pdf';
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * Process.
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public function process()
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if (!$this->textParser->recordModel || !$this->textParser->recordModel->getModule()->isInventory()) {
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $fields = $inventory->getFieldsByBlocks();
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  } else {
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           *
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * @return string
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  if ($inventory->isField('tax') && $inventory->isField('net')) {
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $html = '';
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      $currency = $firstRow['currency'];
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      $currency = $baseCurrency['id'];
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  }
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          /** @var mixed Parser type */
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $currencyData = \App\Fields\Currency::getById($currency);
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      foreach ($inventoryRows as $key => $inventoryRow) {
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $baseCurrency = \Vtiger_Util_Helper::getBaseCurrency();
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $firstRow = current($inventoryRows);
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          /** @var string Class name */
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if (!empty($fields[0])) {
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                          $taxes = $taxField->getTaxParam($inventoryRow['taxparam'], $inventoryRow['net'], $taxes);
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          /**
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $taxes = [];
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if ($inventory->isField('currency')) {
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      $taxField = $inventory->getField('tax');
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           */
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      }
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      $currencyAmount = 0;
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Line exceeds 120 characters; contains 282 characters
      Open

                                      <td class="name" style="text-align:right;padding:0px 4px;">' . \App\Language::translate('LBL_AMOUNT', $this->textParser->moduleName) . ' / ' . \App\Language::translate('LBL_AMOUNT', $this->textParser->moduleName, \App\Language::DEFAULT_LANG) . '</td>
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      $RATE = $baseCurrency['conversion_rate'] / $currencyData['conversion_rate'];
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      }
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                          $html .= '<tr>
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Line exceeds 120 characters; contains 211 characters
      Open

                                          <td class="value" style="padding:0px 4px;text-align:right;">' . \CurrencyField::convertToUserFormat($tax * $RATE, null, true) . ' ' . $baseCurrency['currency_symbol'] . '</td>
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  }
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  }
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              return $html;
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      foreach ($taxes as $key => &$tax) {
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Line exceeds 120 characters; contains 218 characters
      Open

                                      <td class="value" style="text-align:right;padding:0px 4px;">' . \CurrencyField::convertToUserFormat($currencyAmount * $RATE, null, true) . ' ' . $baseCurrency['currency_symbol'] . '</td>
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Line exceeds 120 characters; contains 197 characters
      Open

                  if (!empty($currency) && !empty($currencyData) && $baseCurrency['id'] !== $currency && $inventory->isField('tax') && $inventory->isField('taxmode') && $inventory->isField('currency')) {
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                          $currencyAmount += $tax;
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      $html .= '<tr class="summary">
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  if (!empty($currency) && !empty($currencyData) && $baseCurrency['id'] !== $currency && $inventory->isField('tax') && $inventory->isField('taxmode') && $inventory->isField('currency')) {
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      $html .= '<table class="table-currency-s-two-lang" style="border-collapse:collapse;width:100%;">
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Line exceeds 120 characters; contains 314 characters
      Open

                                              <th colspan="2" style="padding:0px 4px;text-align:center;">' . \App\Language::translate('LBL_CURRENCIES_SUMMARY', $this->textParser->moduleName) . ' / ' . \App\Language::translate('LBL_CURRENCIES_SUMMARY', $this->textParser->moduleName, \App\Language::DEFAULT_LANG) . '</th>
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpcodesniffer

      The variable $RATE is not named in camelCase.
      Open

          public function process()
    {
        if (!$this->textParser->recordModel || !$this->textParser->recordModel->getModule()->isInventory()) {
            return '';
        }
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $RATE is not named in camelCase.
      Open

          public function process()
    {
        if (!$this->textParser->recordModel || !$this->textParser->recordModel->getModule()->isInventory()) {
            return '';
        }
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $RATE is not named in camelCase.
      Open

          public function process()
    {
        if (!$this->textParser->recordModel || !$this->textParser->recordModel->getModule()->isInventory()) {
            return '';
        }
      Severity: Minor
      Found in app/TextParser/TableCurrencySTwoLang.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      There are no issues that match your filters.

      Category
      Status