Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
app/TextParser/UserCalendar.php

Summary

Maintainability
A
2 hrs
Test Coverage
F
0%

Function process has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function process(): string
    {
        $html = '';
        $moduleName = 'Calendar';
        if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])) {
Severity: Minor
Found in app/TextParser/UserCalendar.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function process(): string
    {
        $html = '';
        $moduleName = 'Calendar';
        if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])) {
Severity: Minor
Found in app/TextParser/UserCalendar.php - About 1 hr to fix

    Missing class import via use statement (line '45', column '28').
    Open

                    $queryGenerator = (new \App\QueryGenerator($moduleName))
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class '\App\User' in method 'process'.
    Open

                if (!empty($userId) && \App\User::isExists($userId) && \App\Module::isModuleActive($moduleName)) {
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid assigning values to variables in if clauses and the like (line '42', column '14').
    Open

        public function process(): string
    {
        $html = '';
        $moduleName = 'Calendar';
        if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])) {
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid using static access to class '\App\Module' in method 'process'.
    Open

                if (!empty($userId) && \App\User::isExists($userId) && \App\Module::isModuleActive($moduleName)) {
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Config' in method 'process'.
    Open

                    $query->limit(\App\Config::performance('REPORT_RECORD_NUMBERS'));
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Vtiger_Record_Model' in method 'process'.
    Open

                        $recordModel = \Vtiger_Record_Model::getInstanceById($row['id']);
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Language' in method 'process'.
    Open

            return !empty($html) ? $html : \App\Language::translate('LBL_NO_RECORDS', 'Other.Reports');
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Config' in method 'process'.
    Open

                        $entries[] = $recordModel->getDisplayValue('date_start', false, true) . ' - <a href="' . \App\Config::main('site_URL') . $recordModel->getDetailViewUrl() . '">' . $recordModel->getName() . '</a>';
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Call to method isExists from undeclared class \App\User (Did you mean class \Tests\App\User)
    Open

                if (!empty($userId) && \App\User::isExists($userId) && \App\Module::isModuleActive($moduleName)) {
    Severity: Critical
    Found in app/TextParser/UserCalendar.php by phan

    Call to method getParam from undeclared class \App\TextParser (Did you mean class \Tests\App\TextParser)
    Open

            if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])) {
    Severity: Critical
    Found in app/TextParser/UserCalendar.php by phan

    Call to method setFields from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
    Open

                    $queryGenerator = (new \App\QueryGenerator($moduleName))
    Severity: Critical
    Found in app/TextParser/UserCalendar.php by phan

    Call to method __construct from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
    Open

                    $queryGenerator = (new \App\QueryGenerator($moduleName))
    Severity: Critical
    Found in app/TextParser/UserCalendar.php by phan

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                    while ($row = $dataReader->read()) {
                    $recordModel = \Vtiger_Record_Model::getInstanceById($row['id']);
                    $entries[] = $recordModel->getDisplayValue('date_start', false, true) . ' - <a href="' . \App\Config::main('site_URL') . $recordModel->getDetailViewUrl() . '">' . $recordModel->getName() . '</a>';
                }
    Severity: Minor
    Found in app/TextParser/UserCalendar.php and 1 other location - About 40 mins to fix
    app/TextParser/UserOverdue.php on lines 51..54

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** @var string Class name */
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public $name = 'LBL_REPORT_CALENDAR';
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** @var mixed Parser type */
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @var string Default template
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @see \App\Condition::DATE_OPERATORS
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $entries[] = $recordModel->getDisplayValue('date_start', false, true) . ' - <a href="' . \App\Config::main('site_URL') . $recordModel->getDetailViewUrl() . '">' . $recordModel->getName() . '</a>';
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Process.
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])) {
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public $default = '$(custom : UserCalendar|__DATE_OPERATOR__)$';
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $moduleName = 'Calendar';
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return !empty($html) ? $html : \App\Language::translate('LBL_NO_RECORDS', 'Other.Reports');
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        ->addCondition('shownerid', $userId, 'e', false)
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        ->addCondition('assigned_user_id', $userId, 'e', false)
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $entries = [];
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $recordModel = \Vtiger_Record_Model::getInstanceById($row['id']);
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        ->setFields(['id'])
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function process(): string
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $queryGenerator->addCondition('date_start', false, $this->params[0]);
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if (isset(\App\Condition::DATE_OPERATORS[$this->params[0]])) {
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $query = $queryGenerator->createQuery();
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $dataReader = $query->createCommand()->query();
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Line exceeds 120 characters; contains 216 characters
    Open

                        $entries[] = $recordModel->getDisplayValue('date_start', false, true) . ' - <a href="' . \App\Config::main('site_URL') . $recordModel->getDetailViewUrl() . '">' . $recordModel->getName() . '</a>';
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        ->addCondition('activitystatus', 'PLL_OVERDUE', 'n', true);
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $query->orderBy(['vtiger_crmentity.createdtime' => SORT_DESC]);
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    while ($row = $dataReader->read()) {
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $html = implode('<br>', $entries);
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $html = '';
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $query->limit(\App\Config::performance('REPORT_RECORD_NUMBERS'));
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Line exceeds 120 characters; contains 128 characters
    Open

            if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])) {
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $userId = $textParserParams['userId'];
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public $type = 'pdf';
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if (!empty($userId) && \App\User::isExists($userId) && \App\Module::isModuleActive($moduleName)) {
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $queryGenerator = (new \App\QueryGenerator($moduleName))
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return string
    Severity: Minor
    Found in app/TextParser/UserCalendar.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status