YetiForceCompany/YetiForceCRM

View on GitHub
app/TextParser/UserNewRecords.php

Summary

Maintainability
B
6 hrs
Test Coverage
F
0%

Function process has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function process(): string
    {
        $html = '';
        $moduleName = $this->params[0];
        if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])) {
Severity: Minor
Found in app/TextParser/UserNewRecords.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function process(): string
    {
        $html = '';
        $moduleName = $this->params[0];
        if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])) {
Severity: Minor
Found in app/TextParser/UserNewRecords.php - About 1 hr to fix

    The method process() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
    Open

        public function process(): string
        {
            $html = '';
            $moduleName = $this->params[0];
            if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])) {
    Severity: Minor
    Found in app/TextParser/UserNewRecords.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Refactor this function to reduce its Cognitive Complexity from 33 to the 15 allowed.
    Open

        public function process(): string
    Severity: Critical
    Found in app/TextParser/UserNewRecords.php by sonar-php

    Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

    See

    Missing class import via use statement (line '46', column '28').
    Open

                    $queryGenerator = (new \App\QueryGenerator($moduleName))
    Severity: Minor
    Found in app/TextParser/UserNewRecords.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class '\Vtiger_Record_Model' in method 'process'.
    Open

                        $recordModel = \Vtiger_Record_Model::getInstanceById($row['id']);
    Severity: Minor
    Found in app/TextParser/UserNewRecords.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Config' in method 'process'.
    Open

                    $query->limit(\App\Config::performance('REPORT_RECORD_NUMBERS'));
    Severity: Minor
    Found in app/TextParser/UserNewRecords.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Config' in method 'process'.
    Open

                            $entries[] = $count . '. <a href="' . \App\Config::main('site_URL') . $recordModel->getDetailViewUrl() . '">' . $recordHtml . '</a>';
    Severity: Minor
    Found in app/TextParser/UserNewRecords.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\User' in method 'process'.
    Open

                if (!empty($userId) && \App\User::isExists($userId) && \App\Module::isModuleActive($moduleName)) {
    Severity: Minor
    Found in app/TextParser/UserNewRecords.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Language' in method 'process'.
    Open

            return !empty($html) ? $html : \App\Language::translate('LBL_NO_RECORDS', 'Other.Reports');
    Severity: Minor
    Found in app/TextParser/UserNewRecords.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid assigning values to variables in if clauses and the like (line '70', column '18').
    Open

        public function process(): string
        {
            $html = '';
            $moduleName = $this->params[0];
            if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])) {
    Severity: Minor
    Found in app/TextParser/UserNewRecords.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($foo = 'bar') { // possible typo
                // ...
            }
            if ($baz = 0) { // always false
                // ...
            }
        }
    }

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid using static access to class '\App\Module' in method 'process'.
    Open

                if (!empty($userId) && \App\User::isExists($userId) && \App\Module::isModuleActive($moduleName)) {
    Severity: Minor
    Found in app/TextParser/UserNewRecords.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Vtiger_Module_Model' in method 'process'.
    Open

                    $moduleModel = \Vtiger_Module_Model::getInstance($moduleName);
    Severity: Minor
    Found in app/TextParser/UserNewRecords.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid assigning values to variables in if clauses and the like (line '59', column '12').
    Open

        public function process(): string
        {
            $html = '';
            $moduleName = $this->params[0];
            if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])) {
    Severity: Minor
    Found in app/TextParser/UserNewRecords.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($foo = 'bar') { // possible typo
                // ...
            }
            if ($baz = 0) { // always false
                // ...
            }
        }
    }

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid assigning values to variables in if clauses and the like (line '42', column '14').
    Open

        public function process(): string
        {
            $html = '';
            $moduleName = $this->params[0];
            if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])) {
    Severity: Minor
    Found in app/TextParser/UserNewRecords.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($foo = 'bar') { // possible typo
                // ...
            }
            if ($baz = 0) { // always false
                // ...
            }
        }
    }

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Call to method __construct from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
    Open

                    $queryGenerator = (new \App\QueryGenerator($moduleName))
    Severity: Critical
    Found in app/TextParser/UserNewRecords.php by phan

    Call to method isExists from undeclared class \App\User (Did you mean class \Tests\App\User)
    Open

                if (!empty($userId) && \App\User::isExists($userId) && \App\Module::isModuleActive($moduleName)) {
    Severity: Critical
    Found in app/TextParser/UserNewRecords.php by phan

    Call to method getParam from undeclared class \App\TextParser (Did you mean class \Tests\App\TextParser)
    Open

            if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])) {
    Severity: Critical
    Found in app/TextParser/UserNewRecords.php by phan

    Call to method setFields from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
    Open

                    $queryGenerator = (new \App\QueryGenerator($moduleName))
    Severity: Critical
    Found in app/TextParser/UserNewRecords.php by phan

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if (!empty($userId) && \App\User::isExists($userId) && \App\Module::isModuleActive($moduleName)) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $fields[$fieldName] = $fieldModel;

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $entries = [];

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    while ($row = $dataReader->read()) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $userId = $textParserParams['userId'];

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $html = '';

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        ->addCondition('shownerid', $userId, 'e', false)

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $dataReader = $query->createCommand()->query();

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $recordModel = \Vtiger_Record_Model::getInstanceById($row['id']);

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            }

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        if (!empty($recordHtml)) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        ++$count;

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** @var mixed Parser type */

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            continue;

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public $type = 'pdf';

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Process.

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {

    Line exceeds 120 characters; contains 128 characters
    Open

            if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            if (!empty($value = $recordModel->getDisplayValue($field->getName(), false, true))) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $query = $queryGenerator->createQuery();

    Line exceeds 120 characters; contains 157 characters
    Open

                            $entries[] = $count . '. <a href="' . \App\Config::main('site_URL') . $recordModel->getDetailViewUrl() . '">' . $recordHtml . '</a>';

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public $name = 'LBL_REPORT_NEW_RECORDS';

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $query->limit(\App\Config::performance('REPORT_RECORD_NUMBERS'));

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $entries[] = $count . '. <a href="' . \App\Config::main('site_URL') . $recordModel->getDetailViewUrl() . '">' . $recordHtml . '</a>';

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @see \App\Condition::DATE_OPERATORS

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @return string

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $queryGenerator = (new \App\QueryGenerator($moduleName))

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        }

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    foreach (explode(':', $this->params[2]) as $fieldName) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $count = 1;

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        }

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return !empty($html) ? $html : \App\Language::translate('LBL_NO_RECORDS', 'Other.Reports');

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $moduleName = $this->params[0];

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $fields = [];

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $html = implode('<br>', $entries);

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if (isset(\App\Condition::DATE_OPERATORS[$this->params[1]])) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $query->orderBy(['vtiger_crmentity.createdtime' => SORT_DESC]);

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        if (!($fieldModel = $moduleModel->getFieldByName($fieldName)) || !$fieldModel->isActiveField()) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $recordHtml = '';

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** @var string Class name */

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @var string Default template

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        ->addCondition('assigned_user_id', $userId, 'e', false);

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        foreach ($fields as $field) {

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                $recordHtml .= $value . ' ';

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        ->setFields(['id'])

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $queryGenerator->addCondition('createdtime', false, $this->params[1]);

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        }

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public $default = '$(custom : UserNewRecords|__MODULE_NAME__|__DATE_OPERATOR__|__FIELDS_LIST__)$';

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function process(): string

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $moduleModel = \Vtiger_Module_Model::getInstance($moduleName);

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *

    There are no issues that match your filters.

    Category
    Status