Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
app/TextParser/UserRecordsList.php

Summary

Maintainability
D
2 days
Test Coverage
F
0%

Function process has a Cognitive Complexity of 69 (exceeds 5 allowed). Consider refactoring.
Open

    public function process(): string
    {
        $html = '';
        $moduleName = $this->params[0];
        if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])
Severity: Minor
Found in app/TextParser/UserRecordsList.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function process(): string
    {
        $html = '';
        $moduleName = $this->params[0];
        if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])
Severity: Major
Found in app/TextParser/UserRecordsList.php - About 3 hrs to fix

    Method addAdvConditions has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function addAdvConditions(\App\QueryGenerator $queryGenerator, int $relationId, string $operator, ?array $condition, ?int $userId)
    {
        $relationModel = \Vtiger_Relation_Model::getInstanceById($relationId);
        if (\Vtiger_Relation_Model::RELATION_M2M !== $relationModel->getRelationType()) {
            $parentModuleName = $relationModel->getParentModuleModel()->getName();
    Severity: Minor
    Found in app/TextParser/UserRecordsList.php - About 2 hrs to fix

      Function addAdvConditions has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          private function addAdvConditions(\App\QueryGenerator $queryGenerator, int $relationId, string $operator, ?array $condition, ?int $userId)
    {
        $relationModel = \Vtiger_Relation_Model::getInstanceById($relationId);
        if (\Vtiger_Relation_Model::RELATION_M2M !== $relationModel->getRelationType()) {
            $parentModuleName = $relationModel->getParentModuleModel()->getName();
      Severity: Minor
      Found in app/TextParser/UserRecordsList.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function parseConditions has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          private function parseConditions(\App\QueryGenerator $queryGenerator, array $searchParams, ?int $userId)
    {
        foreach ($searchParams as &$conditions) {
            if (empty($conditions)) {
                continue;
      Severity: Minor
      Found in app/TextParser/UserRecordsList.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method addAdvConditions has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private function addAdvConditions(\App\QueryGenerator $queryGenerator, int $relationId, string $operator, ?array $condition, ?int $userId)
      Severity: Minor
      Found in app/TextParser/UserRecordsList.php - About 35 mins to fix

        The method process() has an NPath complexity of 198154. The configured NPath complexity threshold is 200.
        Open

            public function process(): string
    {
        $html = '';
        $moduleName = $this->params[0];
        if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        NPathComplexity

        Since: 0.1

        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

        Example

        class Foo {
    function bar() {
        // lots of complicated code
    }
}

        Source https://phpmd.org/rules/codesize.html#npathcomplexity

        The method process() has a Cyclomatic Complexity of 32. The configured cyclomatic complexity threshold is 10.
        Open

            public function process(): string
    {
        $html = '';
        $moduleName = $this->params[0];
        if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        Refactor this function to reduce its Cognitive Complexity from 79 to the 15 allowed.
        Open

            public function process(): string
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by sonar-php

        Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

        See

        Missing class import via use statement (line '169', column '27').
        Open

                            $subQueryBase = (new \App\QueryGenerator($relationModel->getParentModuleModel()->getName(), $userId))->setFields(['id'])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '57', column '27').
        Open

                    $queryGenerator = (new \App\QueryGenerator($moduleName, $userId))->setFields(array_merge(['id'], array_keys($fields)));
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '136', column '25').
        Open

                    $subQueryBase = (new \App\QueryGenerator($parentModuleName, $userId))->setFields(['id'])->createQuery();
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '137', column '21').
        Open

                    $subQuery = (new \App\QueryGenerator($relationModel->getRelationModuleName(), $userId));
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '162', column '21').
        Open

                    $subQuery = (new \App\QueryGenerator($relationModel->getRelationModuleName(), $userId))->setFields(['id']);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Avoid using static access to class '\App\Json' in method 'process'.
        Open

                        $searchParams = \App\Json::decode($searchParams);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid assigning values to variables in if clauses and the like (line '41', column '14').
        Open

            public function process(): string
    {
        $html = '';
        $moduleName = $this->params[0];
        if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        Avoid using static access to class '\Vtiger_Record_Model' in method 'process'.
        Open

                                        $relatedRecordModel = \Vtiger_Record_Model::getInstanceById($recordModel->get($field->getName()));
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class '\App\Language' in method 'process'.
        Open

                return !empty($html) ? $html : \App\Language::translate('LBL_NO_RECORDS', 'Other.Reports');
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                                    } else {
                                $entriesPart[] = " [{$value}] ";
                            }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid using static access to class '\App\Json' in method 'process'.
        Open

                    if (!\App\Json::isEmpty($searchParams)) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class '\App\User' in method 'process'.
        Open

                    && !empty($userId = $textParserParams['userId']) && \App\User::isExists($userId) && \App\Module::isModuleActive($moduleName)
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                                } else {
                            $recordHtml .= " {$value} ";
                        }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid using static access to class '\Vtiger_Relation_Model' in method 'addAdvConditions'.
        Open

                $relationModel = \Vtiger_Relation_Model::getInstanceById($relationId);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class '\App\Config' in method 'process'.
        Open

                                    $entries[$recordModel->getId()] = "{$count}. " . ' <a href="' . \App\Config::main('site_URL') . $recordModel->getDetailViewUrl() . '">' . $recordHtml . '</a> ' . implode(' ', $entriesPart);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class '\App\Json' in method 'process'.
        Open

                    if ($orderBy && !\App\Json::isEmpty($orderBy)) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class '\App\Json' in method 'process'.
        Open

                        $orderBy = \App\Json::decode($orderBy);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid assigning values to variables in if clauses and the like (line '47', column '11').
        Open

            public function process(): string
    {
        $html = '';
        $moduleName = $this->params[0];
        if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        Avoid using static access to class '\App\Json' in method 'process'.
        Open

                    if (!\App\Json::isEmpty($advConditions)) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid assigning values to variables in if clauses and the like (line '40', column '14').
        Open

            public function process(): string
    {
        $html = '';
        $moduleName = $this->params[0];
        if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        Avoid using static access to class '\App\Module' in method 'process'.
        Open

                    && !empty($userId = $textParserParams['userId']) && \App\User::isExists($userId) && \App\Module::isModuleActive($moduleName)
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                                } else {
                            $entries[$recordModel->getId()] = "{$count}. " . ' <a href="' . \App\Config::main('site_URL') . $recordModel->getDetailViewUrl() . '">' . $recordHtml . '</a> ' . implode(' ', $entriesPart);
                        }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid using static access to class '\App\Config' in method 'process'.
        Open

                    $limit = $this->params[4] ?? \App\Config::performance('REPORT_RECORD_NUMBERS');
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class '\App\Record' in method 'process'.
        Open

                                    $relModule = \App\Record::getType($recordModel->get($field->getName()));
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class '\App\Config' in method 'process'.
        Open

                                        $entriesPart[] = ' [<a href="' . \App\Config::main('site_URL') . $relatedRecordModel->getDetailViewUrl() . '">' . $value . '</a>] ';
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class '\Vtiger_Record_Model' in method 'process'.
        Open

                            $recordModel = 1 === \count($row) ? \Vtiger_Record_Model::getInstanceById($row['id']) : $moduleModel->getRecordFromArray($row);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class '\App\Privilege' in method 'process'.
        Open

                                    if ($relModule && 'Users' !== $relModule && \App\Privilege::isPermitted($relModule, 'DetailView', $recordModel->get($field->getName()), $userId)) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class '\App\Json' in method 'process'.
        Open

                        $advConditions = \App\Json::decode($advConditions);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        The method addAdvConditions uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                } else {
            $relation = $relationModel->getTypeRelationModel();
            $tableName = \get_class($relation)::TABLE_NAME;
            $subQuery = (new \App\QueryGenerator($relationModel->getRelationModuleName(), $userId))->setFields(['id']);
            if ($condition) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid assigning values to variables in if clauses and the like (line '92', column '57').
        Open

            public function process(): string
    {
        $html = '';
        $moduleName = $this->params[0];
        if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        Avoid using static access to class '\Vtiger_Module_Model' in method 'process'.
        Open

                    $moduleModel = \Vtiger_Module_Model::getInstance($moduleName);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Call to method getQueryField from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                            $queryGenerator->addNativeCondition([$queryGenerator->getQueryField('id')->getColumnName() => $subQuery])
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method addNativeCondition from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                            $queryGenerator->addNativeCondition(['not', [$queryGenerator->getQueryField('id')->getColumnName() => $subQueryBase]])
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Argument 2 (relationId) is null but \App\TextParser\UserRecordsList::addAdvConditions() takes int defined at /code/app/TextParser/UserRecordsList.php:131
        Open

                            $this->addAdvConditions($queryGenerator, $relationId, $operator, $condition, $userId);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method addJoin from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                            $queryGenerator->addJoin(['INNER JOIN', $tableName, "({$tableName}.relcrmid = vtiger_crmentity.crmid OR {$tableName}.crmid = vtiger_crmentity.crmid)"]);
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method getParam from undeclared class \App\TextParser (Did you mean class \Tests\App\TextParser)
        Open

                if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method setFields from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                    $subQueryBase = (new \App\QueryGenerator($parentModuleName, $userId))->setFields(['id'])->createQuery();
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method getQueryField from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                            $queryGenerator->addNativeCondition(['not', ['in', $queryGenerator->getQueryField('id')->getColumnName(), $subQuery]])
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method __construct from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                    $queryGenerator = (new \App\QueryGenerator($moduleName, $userId))->setFields(array_merge(['id'], array_keys($fields)));
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method setFields from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                    $queryGenerator = (new \App\QueryGenerator($moduleName, $userId))->setFields(array_merge(['id'], array_keys($fields)));
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Argument 1 (moduleName) is false but \Vtiger_Module_Model::getReferenceFieldsForModule() takes string defined at /code/modules/Vtiger/models/Module.php:557
        Open

                    foreach ($relationModel->getRelationModuleModel()->getReferenceFieldsForModule($parentModuleName) as $fieldModel) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method getQueryField from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                            $queryGenerator->addNativeCondition(['not', [$queryGenerator->getQueryField('id')->getColumnName() => $subQueryBase]])
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method isExists from undeclared class \App\User (Did you mean class \Tests\App\User)
        Open

                    && !empty($userId = $textParserParams['userId']) && \App\User::isExists($userId) && \App\Module::isModuleActive($moduleName)
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Parameter $queryGenerator has undeclared type \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

            private function addAdvConditions(\App\QueryGenerator $queryGenerator, int $relationId, string $operator, ?array $condition, ?int $userId)
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phan

        Argument 3 (operator) is null but \App\TextParser\UserRecordsList::addAdvConditions() takes string defined at /code/app/TextParser/UserRecordsList.php:131
        Open

                            $this->addAdvConditions($queryGenerator, $relationId, $operator, $condition, $userId);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method __construct from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                    $subQueryBase = (new \App\QueryGenerator($parentModuleName, $userId))->setFields(['id'])->createQuery();
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method __construct from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                    $subQuery = (new \App\QueryGenerator($relationModel->getRelationModuleName(), $userId));
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method addNativeCondition from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                            $queryGenerator->addNativeCondition([$queryGenerator->getQueryField('id')->getColumnName() => $subQuery])
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method getQueryField from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                            ->addNativeCondition([$subQuery->getQueryField($fieldModel->getName())->getColumnName() => $subQueryBase])
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method setFields from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                            $subQueryBase = (new \App\QueryGenerator($relationModel->getParentModuleModel()->getName(), $userId))->setFields(['id'])
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method addNativeCondition from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                            $queryGenerator->addNativeCondition(['or', ["{$tableName}.crmid" => $subQuery], ["{$tableName}.relcrmid" => $subQuery]])
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method addNativeCondition from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                            $queryGenerator->addNativeCondition(['not', ['in', $queryGenerator->getQueryField('id')->getColumnName(), $subQuery]])
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method setFields from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                    $subQuery = (new \App\QueryGenerator($relationModel->getRelationModuleName(), $userId))->setFields(['id']);
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Reference to instance property permissions from undeclared class \App\QueryGenerator
        Open

                        $subQuery->permissions = false;
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phan

        Parameter $queryGenerator has undeclared type \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

            private function parseConditions(\App\QueryGenerator $queryGenerator, array $searchParams, ?int $userId)
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method __construct from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                    $subQuery = (new \App\QueryGenerator($relationModel->getRelationModuleName(), $userId))->setFields(['id']);
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method __construct from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                            $subQueryBase = (new \App\QueryGenerator($relationModel->getParentModuleModel()->getName(), $userId))->setFields(['id'])
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method parseBaseSearchParamsToCondition from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                $transformedSearchParams = $queryGenerator->parseBaseSearchParamsToCondition($searchParams);
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method parseAdvFilter from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                $queryGenerator->parseAdvFilter($transformedSearchParams);
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Call to method setFields from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
        Open

                        $subQuery = $subQuery->setFields([$fieldModel->getName()])
        Severity: Critical
        Found in app/TextParser/UserRecordsList.php by phan

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                                if ($field->isReferenceField()) {
                            $relModule = \App\Record::getType($recordModel->get($field->getName()));
                            if ($relModule && 'Users' !== $relModule && \App\Privilege::isPermitted($relModule, 'DetailView', $recordModel->get($field->getName()), $userId)) {
                                $relatedRecordModel = \Vtiger_Record_Model::getInstanceById($recordModel->get($field->getName()));
                                $entriesPart[] = ' [<a href="' . \App\Config::main('site_URL') . $relatedRecordModel->getDetailViewUrl() . '">' . $value . '</a>] ';
        Severity: Major
        Found in app/TextParser/UserRecordsList.php and 1 other location - About 4 hrs to fix
        app/TextParser/UserRecordsDuplicateList.php on lines 74..84

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 165.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid excessively long variable names like $transformedSearchParams. Keep variable name length under 20.
        Open

                $transformedSearchParams = $queryGenerator->parseBaseSearchParamsToCondition($searchParams);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $html = '';
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            /** @var string Default template
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $fieldsName = !empty($this->params[1]) ? explode(':', $this->params[1]) : $moduleModel->getNameFields();
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $advConditions = $this->params[6] ?? null;
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 125 characters
        Open

                if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $orderBy = $this->params[3] ?? null;
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $searchParams = \App\Json::decode($searchParams);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            /** @var string Class name */
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 161 characters
        Open

            public $default = '$(custom : UserRecordsList|__MODULE_NAME__|__FIELDS_TO_SHOW__|__CONDITIONS__|__ORDER_BY__|__LIMIT__|__VIEW_ID__|__ADVANCE_CONDITIONS__)$';
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * Example: $(custom : UserRecordsList|SSalesProcesses|subject:related_to|[[["description","y",""]]]|[["createdtime","ASC"]]|50)$
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $fields = [];
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        if (!($fieldModel = $moduleModel->getFieldByName($fieldName)) || !$fieldModel->isActiveField()) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 131 characters
        Open

                    $queryGenerator = (new \App\QueryGenerator($moduleName, $userId))->setFields(array_merge(['id'], array_keys($fields)));
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             */
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $moduleName = $this->params[0];
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $fields[$fieldName] = $fieldModel;
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $viewId = $this->params[5] ?? null;
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $this->parseConditions($queryGenerator, $searchParams, $userId);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            public $type = 'pdf';
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 133 characters
        Open

             * Example: $(custom : UserRecordsList|SSalesProcesses|subject:related_to|[[["description","y",""]]]|[["createdtime","ASC"]]|50)$
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            public $default = '$(custom : UserRecordsList|__MODULE_NAME__|__FIELDS_TO_SHOW__|__CONDITIONS__|__ORDER_BY__|__LIMIT__|__VIEW_ID__|__ADVANCE_CONDITIONS__)$';
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            /**
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             */
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    && !empty($userId = $textParserParams['userId']) && \App\User::isExists($userId) && \App\Module::isModuleActive($moduleName)
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $moduleModel = \Vtiger_Module_Model::getInstance($moduleName);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                ) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * Process.
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 136 characters
        Open

                    && !empty($userId = $textParserParams['userId']) && \App\User::isExists($userId) && \App\Module::isModuleActive($moduleName)
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    foreach ($fieldsName as $fieldName) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $limit = $this->params[4] ?? \App\Config::performance('REPORT_RECORD_NUMBERS');
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $searchParams = $this->params[2] ?? null;
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            public $name = 'LBL_USER_RECORD_FILTERED_LIST';
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            /** @var mixed Parser type */
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             *
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * @return string
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            public function process(): string
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    if (!\App\Json::isEmpty($searchParams)) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                if (!empty($textParserParams = $this->textParser->getParam('textParserParams')) && isset($textParserParams['userId'])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $queryGenerator->initForCustomViewById($viewId);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $count = 1;
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            $recordHtml = '';
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                    $relModule = \App\Record::getType($recordModel->get($field->getName()));
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                        $relatedRecordModel = \Vtiger_Record_Model::getInstanceById($recordModel->get($field->getName()));
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            ->addNativeCondition([$subQuery->getQueryField($fieldModel->getName())->getColumnName() => $subQueryBase])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            ->setDistinct($fieldModel->getName())
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 138 characters
        Open

                            $queryGenerator->addNativeCondition(['not', ['in', $queryGenerator->getQueryField('id')->getColumnName(), $subQuery]])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $this->parseConditions($subQuery, $condition, $userId);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            $queryGenerator->addNativeCondition(['or', ["{$tableName}.crmid" => $subQuery], ["{$tableName}.relcrmid" => $subQuery]])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * @param array               $searchParams
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            private function parseConditions(\App\QueryGenerator $queryGenerator, array $searchParams, ?int $userId)
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            continue;
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $queryGenerator = (new \App\QueryGenerator($moduleName, $userId))->setFields(array_merge(['id'], array_keys($fields)));
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    if (!empty($viewId)) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    if (!\App\Json::isEmpty($advConditions)) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            [$relationId, $operator, $condition] = array_pad($advCondition, 3, null);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * @param int                 $relationId
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * @param string              $operator
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                if (\Vtiger_Relation_Model::RELATION_M2M !== $relationModel->getRelationType()) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        default:
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $subQuery = (new \App\QueryGenerator($relationModel->getRelationModuleName(), $userId))->setFields(['id']);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                ->setFields(['id'])->setDistinct('id');
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * Parse conditions.
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                if ($recordModel->isEmpty($field->getName()) || !($value = $recordModel->getDisplayValue($field->getName(), false, true))) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                        $entriesPart[] = " [{$value}] ";
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                return !empty($html) ? $html : \App\Language::translate('LBL_NO_RECORDS', 'Other.Reports');
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $subQuery = $subQuery->createQuery();
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            $this->addAdvConditions($queryGenerator, $relationId, $operator, $condition, $userId);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 140 characters
        Open

                            $subQueryBase = (new \App\QueryGenerator($relationModel->getParentModuleModel()->getName(), $userId))->setFields(['id'])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    if ($orderBy && !\App\Json::isEmpty($orderBy)) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            break;
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    foreach ($conditions as &$condition) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            if (isset($entries[$row['id']])) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                continue;
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 175 characters
        Open

                                    if ($relModule && 'Users' !== $relModule && \App\Privilege::isPermitted($relModule, 'DetailView', $recordModel->get($field->getName()), $userId)) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 130 characters
        Open

                                        $relatedRecordModel = \Vtiger_Record_Model::getInstanceById($recordModel->get($field->getName()));
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                if ('ModComments' === $moduleName) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * @param array|null          $condition
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $subQueryBase = (new \App\QueryGenerator($parentModuleName, $userId))->setFields(['id'])->createQuery();
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    switch ($operator) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        case 'y':
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        case 'ny':
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        default:
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 164 characters
        Open

                                        $entriesPart[] = ' [<a href="' . \App\Config::main('site_URL') . $relatedRecordModel->getDetailViewUrl() . '">' . $value . '</a>] ';
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            /**
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $subQuery = $subQuery->setFields([$fieldModel->getName()])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                    continue;
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            break;
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            if (!empty($recordHtml)) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        case 'ny':
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 217 characters
        Open

                                    $entries[$recordModel->getId()] = "{$count}. " . ' <a href="' . \App\Config::main('site_URL') . $recordModel->getDetailViewUrl() . '">' . $recordHtml . '</a> ' . implode(' ', $entriesPart);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            private function addAdvConditions(\App\QueryGenerator $queryGenerator, int $relationId, string $operator, ?array $condition, ?int $userId)
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 172 characters
        Open

                            $queryGenerator->addJoin(['INNER JOIN', $tableName, "({$tableName}.relcrmid = vtiger_crmentity.crmid OR {$tableName}.crmid = vtiger_crmentity.crmid)"]);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 138 characters
        Open

                            $queryGenerator->addNativeCondition(['not', [$queryGenerator->getQueryField('id')->getColumnName() => $subQueryBase]])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    if (empty($conditions)) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        while ($row = $dataReader->read()) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            $recordModel = 1 === \count($row) ? \Vtiger_Record_Model::getInstanceById($row['id']) : $moduleModel->getRecordFromArray($row);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                    $entries[$recordModel->getId()] = "{$count}. " . ($entriesPart ? implode(', ', $entriesPart) . '<br>  ' : '') . " {$recordHtml} ";
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * @param int|null            $userId
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             */
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    if (!empty($fields)) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 148 characters
        Open

                                if ($recordModel->isEmpty($field->getName()) || !($value = $recordModel->getDisplayValue($field->getName(), false, true))) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $html = implode('<br>', $entries);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $this->parseConditions($subQuery, $condition, $userId);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 145 characters
        Open

                                ->addNativeCondition(['or', ["{$tableName}.crmid" => $subQuery], ["{$tableName}.relcrmid" => $subQuery]])->createQuery();
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 140 characters
        Open

                            $queryGenerator->addNativeCondition(['or', ["{$tableName}.crmid" => $subQuery], ["{$tableName}.relcrmid" => $subQuery]])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            $queryGenerator->setOrder($order[0], $order[1]);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $entries = [];
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * @param int|null            $userId
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $parentModuleName = $relationModel->getParentModuleModel()->getName();
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            $queryGenerator->addNativeCondition(['not', ['in', $queryGenerator->getQueryField('id')->getColumnName(), $subQuery]])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $orderBy = \App\Json::decode($orderBy);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            foreach ($fields as $field) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                    } else {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             */
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 142 characters
        Open

            private function addAdvConditions(\App\QueryGenerator $queryGenerator, int $relationId, string $operator, ?array $condition, ?int $userId)
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 127 characters
        Open

                    foreach ($relationModel->getRelationModuleModel()->getReferenceFieldsForModule($parentModuleName) as $fieldModel) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                ->setFields(['id'])->setDistinct('id');
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        foreach ($advConditions as $advCondition) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $dataReader = $queryGenerator->setLimit($limit)->createQuery()->createCommand()->query();
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                        $entriesPart[] = ' [<a href="' . \App\Config::main('site_URL') . $relatedRecordModel->getDetailViewUrl() . '">' . $value . '</a>] ';
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * @param \App\QueryGenerator $queryGenerator
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    foreach ($relationModel->getRelationModuleModel()->getReferenceFieldsForModule($parentModuleName) as $fieldModel) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 126 characters
        Open

                            ->addNativeCondition([$subQuery->getQueryField($fieldModel->getName())->getColumnName() => $subQueryBase])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            ->createQuery();
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        case 'y':
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                    }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                    $recordHtml .= " {$value} ";
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 158 characters
        Open

                                    $entries[$recordModel->getId()] = "{$count}. " . ($entriesPart ? implode(', ', $entriesPart) . '<br>  ' : '') . " {$recordHtml} ";
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * Add advance conditions.
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $relationModel = \Vtiger_Relation_Model::getInstanceById($relationId);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $subQuery->permissions = false;
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            break;
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        continue;
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                    $entries[$recordModel->getId()] = "{$count}. " . ' <a href="' . \App\Config::main('site_URL') . $recordModel->getDetailViewUrl() . '">' . $recordHtml . '</a> ' . implode(' ', $entriesPart);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        if ('om' === $condition[1]) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                ->setFields(['id'])->setDistinct('id');
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                if ($field->isReferenceField()) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                foreach ($searchParams as &$conditions) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                    if ($relModule && 'Users' !== $relModule && \App\Privilege::isPermitted($relModule, 'DetailView', $recordModel->get($field->getName()), $userId)) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            $queryGenerator->addNativeCondition([$queryGenerator->getQueryField('id')->getColumnName() => $subQuery])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                } else {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    switch ($operator) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            $subQueryBase = (new \App\QueryGenerator($relationModel->getParentModuleModel()->getName(), $userId))->setFields(['id'])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            $queryGenerator->addNativeCondition(['not', [$queryGenerator->getQueryField('id')->getColumnName() => $subQueryBase]])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            break;
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            $queryGenerator->addJoin(['INNER JOIN', $tableName, "({$tableName}.relcrmid = vtiger_crmentity.crmid OR {$tableName}.crmid = vtiger_crmentity.crmid)"]);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            /**
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             *
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             * @param \App\QueryGenerator $queryGenerator
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 147 characters
        Open

                            $recordModel = 1 === \count($row) ? \Vtiger_Record_Model::getInstanceById($row['id']) : $moduleModel->getRecordFromArray($row);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                } else {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                } else {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            ++$count;
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    if ($condition) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                ->setFields(['id'])->setDistinct('id');
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $relation = $relationModel->getTypeRelationModel();
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $tableName = \get_class($relation)::TABLE_NAME;
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                ->addJoin(['INNER JOIN', $tableName, "({$tableName}.relcrmid = vtiger_crmentity.crmid OR {$tableName}.crmid = vtiger_crmentity.crmid)"])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                                ->addNativeCondition(['or', ["{$tableName}.crmid" => $subQuery], ["{$tableName}.relcrmid" => $subQuery]])->createQuery();
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        $advConditions = \App\Json::decode($advConditions);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        foreach ($orderBy as $order) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            $entriesPart = [];
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

             *
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    $subQuery = (new \App\QueryGenerator($relationModel->getRelationModuleName(), $userId));
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 125 characters
        Open

                            $queryGenerator->addNativeCondition([$queryGenerator->getQueryField('id')->getColumnName() => $subQuery])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    if ($condition) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Line exceeds 120 characters; contains 160 characters
        Open

                                ->addJoin(['INNER JOIN', $tableName, "({$tableName}.relcrmid = vtiger_crmentity.crmid OR {$tableName}.crmid = vtiger_crmentity.crmid)"])
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        } elseif ('nom' === $condition[1]) {
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $queryGenerator->parseAdvFilter($transformedSearchParams);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                        }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            $condition[1] = 'n';
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            $condition[1] = 'e';
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                    }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            $condition[2] = $userId;
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                            $condition[2] = $userId;
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                $transformedSearchParams = $queryGenerator->parseBaseSearchParamsToCondition($searchParams);
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

                }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        Spaces must be used to indent lines; tabs are not allowed
        Open

            }
        Severity: Minor
        Found in app/TextParser/UserRecordsList.php by phpcodesniffer

        There are no issues that match your filters.

        Category
        Status