app/YetiForce/Order.php
Method getFieldInstances has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function getFieldInstances(): array
{
$company = \App\Company::getCompany();
$fields = [];
foreach (self::COMPANY_FORM_FIELDS as $fieldName) {Function getFieldInstances has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
public function getFieldInstances(): array
{
$company = \App\Company::getCompany();
$fields = [];
foreach (self::COMPANY_FORM_FIELDS as $fieldName) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid using static access to class '\App\Fields\Country' in method 'getFieldInstances'. Open
Open
foreach (\App\Fields\Country::getAll() as $country) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Json' in method 'send'. Open
Open
}- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Settings_Vtiger_Field_Model' in method 'getFieldInstances'. Open
Open
$fields[$fieldName] = \Settings_Vtiger_Field_Model::init('Vtiger', $params);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Language' in method 'getFieldInstances'. Open
Open
$params['picklistValues'][$country['name']] = \App\Language::translateSingleMod(
$country['name'],
'Other.Country'
);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Company' in method 'getFieldInstances'. Open
Open
$company = \App\Company::getCompany();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid assigning values to variables in if clauses and the like (line '121', column '25'). Open
Open
public function send(): bool
{
$this->success = false;
$client = new ApiClient();
$client->send(self::URL, 'POST', ['form_params' => $this->getData()]);- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
syntax error, unexpected '?', expecting function (T_FUNCTION) or const (T_CONST) Open
Open
public ?string $error = null;- Exclude checks
Avoid variables with short names like $id. Configured minimum length is 3. Open
Open
private ?string $id;- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $id. Configured minimum length is 3. Open
Open
private function setId(string $id): self- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
CASE statements must be defined using a colon Open
Open
case 'city':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'city',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params = [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$fields[$fieldName] = \Settings_Vtiger_Field_Model::init('Vtiger', $params);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->success = false;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Set product package ID.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
private array $data = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'typeofdata' => 'V~M',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['maximumlength'] = '100';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'maximumlength' => '255',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->data[$key] = $value;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->success = \in_array($code, [200, 201]) && $content;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getId()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->packageId = $packageId;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return self- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
private function getData(): array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'label' => 'LBL_' . strtoupper($fieldName),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'city':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->id = $id;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'name',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'uitype' => 1,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'fieldvalue' => $company[$fieldName] ?? null,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'isEditableReadOnly' => false,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'name' => $fieldName,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Set value.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function send(): bool- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$content = $client->getResponseBody();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Get order ID.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $id- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'vat_id',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** @var string Order ID */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function determines fields available in payment view.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Send order data.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'vatId' => $this->data['vat_id'],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'post_code',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
switch ($fieldName) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'postCode' => $this->data['post_code'],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public const URL = 'https://api.yetiforce.eu/registrations/orders';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'country',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'displaytype' => 1,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['picklistValues'][$country['name']] = \App\Language::translateSingleMod(- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$country['name'],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $fields;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return bool- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Get last error.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'packageId' => $this->packageId,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
private const COMPANY_FORM_FIELDS = [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'column' => $fieldName,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->error ?? '';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string[]- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'country' => $this->data['country'],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** @var string URL */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'address',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Array of company form fields.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** @var string Last error. */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
private bool $success;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$fields = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['picklistValues'] = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($this->success) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$client->send(self::URL, 'POST', ['form_params' => $this->getData()]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->error = $client->getError();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->setId(\App\Json::decode($content)['id']);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $packageId- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return self- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** @var array Raw data */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return \Settings_Vtiger_Field_Model[]- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getFieldInstances(): array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$company = \App\Company::getCompany();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['maximumlength'] = '100';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach (\App\Fields\Country::getAll() as $country) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $key- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param mixed $value- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** @var bool Response result */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach (self::COMPANY_FORM_FIELDS as $fieldName) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'purifyType' => \App\Purifier::TEXT- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['uitype'] = 16;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'Other.Country'- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$client = new ApiClient();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getError(): string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'company' => $this->data['name'],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
private ?string $id;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
default:- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!$this->error && ($code = $client->getStatusCode())) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->success;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->id ?? '';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function setPackageId(string $packageId): self- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public ?string $error = null;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** @var Product package ID */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function set(string $key, $value)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
private function setId(string $id): self- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'city' => $this->data['city'],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'address' => $this->data['address'],- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
private string $packageId;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'presence' => '',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'country':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return $this- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* set order ID.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Get registration data.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks