Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star

Showing 306,333 of 306,333 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public function validate($value, $isUserFormat = false)
    {
        if (empty($value) || isset($this->validate["$value"])) {
            return;
        }
Severity: Major
Found in modules/Vtiger/uitypes/Currency.php and 1 other location - About 1 day to fix
modules/Vtiger/uitypes/Double.php on lines 41..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 278.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function setRecordFieldValues has a Cognitive Complexity of 61 (exceeds 5 allowed). Consider refactoring.
Open

    public function setRecordFieldValues($parentRecordModel)
    {
        $mfInstance = Vtiger_MappedFields_Model::getInstanceByModules($parentRecordModel->getModule()->getId(), $this->getModule()->getId());
        if ($mfInstance) {
            $defaultInvRow = [];
Severity: Minor
Found in modules/Vtiger/models/Record.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Edit.js has 564 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*+***********************************************************************************
 * The contents of this file are subject to the vtiger CRM Public License Version 1.0
 * ("License"); You may not use this file except in compliance with the License
 * The Original Code is:  vtiger CRM Open Source
 * The Initial Developer of the Original Code is vtiger.
Severity: Major
Found in public_html/layouts/basic/modules/Calendar/resources/Edit.js - About 1 day to fix

    File Gantt.php has 564 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/**
 * Gantt Model class.
 *
    Severity: Major
    Found in modules/Project/models/Gantt.php - About 1 day to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          app.saveAjax('step2', saveData).done(function (data) {
                        if (data.success == true) {
                            Settings_Vtiger_Index_Js.showMessage({
                                text: app.vtranslate('JS_MF_SAVED_SUCCESSFULLY')
                            });
      Severity: Major
      Found in public_html/layouts/basic/modules/Settings/MappedFields/resources/Edit2.js and 1 other location - About 1 day to fix
      public_html/layouts/basic/modules/Settings/PDF/resources/Edit1.js on lines 72..101

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 225.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  AppConnector.request({
                method: 'POST',
                data: formData,
                processData: false,
                contentType: false
      Severity: Major
      Found in public_html/layouts/basic/modules/Settings/PDF/resources/Edit1.js and 1 other location - About 1 day to fix
      public_html/layouts/basic/modules/Settings/MappedFields/resources/Edit2.js on lines 57..80

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 225.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

              registerFilterChangeEvent: function () {
            var thisInstance = this;
            jQuery('#moduleFilter').on('change', function (e) {
                jQuery('#pageNumber').val('1');
                jQuery('#pageToJump').val('1');
      Severity: Major
      Found in public_html/layouts/basic/modules/Settings/TreesManager/resources/List.js and 2 other locations - About 1 day to fix
      public_html/layouts/basic/modules/Settings/AutomaticAssignment/resources/List.js on lines 9..29
      public_html/layouts/basic/modules/Settings/PDF/resources/List.js on lines 11..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 224.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

              registerFilterChangeEvent: function () {
            var thisInstance = this;
            jQuery('#moduleFilter').on('change', function (e) {
                jQuery('#pageNumber').val('1');
                jQuery('#pageToJump').val('1');
      Severity: Major
      Found in public_html/layouts/basic/modules/Settings/PDF/resources/List.js and 2 other locations - About 1 day to fix
      public_html/layouts/basic/modules/Settings/AutomaticAssignment/resources/List.js on lines 9..29
      public_html/layouts/basic/modules/Settings/TreesManager/resources/List.js on lines 47..67

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 224.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

              registerFilterChangeEvent: function () {
            var thisInstance = this;
            jQuery('#moduleFilter').on('change', function (e) {
                jQuery('#pageNumber').val('1');
                jQuery('#pageToJump').val('1');
      Severity: Major
      Found in public_html/layouts/basic/modules/Settings/AutomaticAssignment/resources/List.js and 2 other locations - About 1 day to fix
      public_html/layouts/basic/modules/Settings/PDF/resources/List.js on lines 11..31
      public_html/layouts/basic/modules/Settings/TreesManager/resources/List.js on lines 47..67

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 224.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function search has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring.
      Open

          public function search(): array
    {
        if (!$this->isActive()) {
            return [];
        }
      Severity: Minor
      Found in app/RecordCollectors/Gus.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function initMailPart has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring.
      Open

          protected static function initMailPart($mbox, $mail, $partStructure, $partNum)
    {
        if ($partNum) {
            \App\Log::beginProfile(__METHOD__ . '|imap_fetchbody', 'Mail|IMAP');
            $data = $orgData = imap_fetchbody($mbox, $mail['id'], $partNum, FT_UID | FT_PEEK);
      Severity: Minor
      Found in modules/OSSMail/models/Record.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getComposeParam has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function getComposeParam(App\Request $request)
    {
        $moduleName = $request->getByType('crmModule');
        $record = $request->getInteger('crmRecord');
        $type = $request->getByType('type');
      Severity: Minor
      Found in modules/OSSMail/models/Module.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getFieldsStructure has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getFieldsStructure(array $block): array
    {
        $fields = [];
        foreach ($block['fields'] as $field) {
            if (\is_array($field) && 'relatedField' === $field['type']) {
      Severity: Minor
      Found in modules/Vtiger/models/ProcessWizard.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      horizontalBar: {
                    basic: {
                        maintainAspectRatio: false,
                        title: {
                            display: false
      Severity: Major
      Found in public_html/layouts/basic/modules/Vtiger/resources/dashboards/Widget.js and 1 other location - About 1 day to fix
      public_html/layouts/basic/modules/Vtiger/resources/dashboards/Widget.js on lines 638..700

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 223.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      bar: {
                    basic: {
                        maintainAspectRatio: false,
                        title: {
                            display: false
      Severity: Major
      Found in public_html/layouts/basic/modules/Vtiger/resources/dashboards/Widget.js and 1 other location - About 1 day to fix
      public_html/layouts/basic/modules/Vtiger/resources/dashboards/Widget.js on lines 766..828

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 223.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              postShowModalAction: function (data, valueType) {
            if (valueType == 'fieldname') {
                jQuery('.useFieldContainer', data).removeClass('d-none');
                jQuery('.textType', data).val(valueType).trigger('change');
            } else if (valueType == 'expression') {
      Severity: Major
      Found in public_html/layouts/basic/modules/Vtiger/resources/AdvanceFilterEx.js and 1 other location - About 1 day to fix
      public_html/layouts/basic/modules/Settings/Workflows/resources/Edit.js on lines 315..328

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 221.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              postShowModalAction: function (data, valueType) {
            if (valueType == 'fieldname') {
                jQuery('.useFieldContainer', data).removeClass('d-none');
                jQuery('.textType', data).val(valueType).trigger('change');
            } else if (valueType == 'expression') {
      Severity: Major
      Found in public_html/layouts/basic/modules/Settings/Workflows/resources/Edit.js and 1 other location - About 1 day to fix
      public_html/layouts/basic/modules/Vtiger/resources/AdvanceFilterEx.js on lines 327..340

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 221.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function autoLink has a Cognitive Complexity of 59 (exceeds 5 allowed). Consider refactoring.
      Open

                  autoLink() {
                let fillChar = '\u200B';
                let sel = window.getSelection(),
                    range = sel.getRangeAt(0).cloneRange(),
                    offset,
      Severity: Minor
      Found in public_html/layouts/resources/Fields.js - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function save has a Cognitive Complexity of 59 (exceeds 5 allowed). Consider refactoring.
      Open

          public function save(App\Request $request)
    {
        $workflowId = !$request->isEmpty('for_workflow') ? $request->getInteger('for_workflow') : 0;
        if (!empty($workflowId)) {
            $record = !$request->isEmpty('task_id') ? $request->getInteger('task_id') : 0;
      Severity: Minor
      Found in modules/Settings/Workflows/actions/TaskAjax.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          public function getHierarchy($id, $getRawData = false, $getLinks = true)
    {
        $listviewHeader = [];
        $listviewEntries = [];
        $listColumns = App\Config::module('Contacts', 'COLUMNS_IN_HIERARCHY');
      Severity: Major
      Found in modules/Contacts/Contacts.php and 2 other locations - About 1 day to fix
      modules/Competition/Competition.php on lines 186..208
      modules/MultiCompany/MultiCompany.php on lines 79..101

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 270.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language