Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star

Showing 306,333 of 306,333 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        generateGroupColor: function (e) {
            var target = $(e.currentTarget);
            var colorPreview = $('#calendarColorPreviewGroup' + target.data('record'));
            AppConnector.request({
                module: 'Colors',
Severity: Major
Found in public_html/layouts/basic/modules/Settings/Colors/resources/Index.js and 2 other locations - About 7 hrs to fix
public_html/layouts/basic/modules/Settings/Colors/resources/Index.js on lines 106..123
public_html/layouts/basic/modules/Settings/Colors/resources/Index.js on lines 216..233

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 178.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        generateUserColor: function (e) {
            var target = $(e.currentTarget);
            var colorPreview = $('#calendarColorPreviewUser' + target.data('record'));
            AppConnector.request({
                module: 'Colors',
Severity: Major
Found in public_html/layouts/basic/modules/Settings/Colors/resources/Index.js and 2 other locations - About 7 hrs to fix
public_html/layouts/basic/modules/Settings/Colors/resources/Index.js on lines 161..178
public_html/layouts/basic/modules/Settings/Colors/resources/Index.js on lines 216..233

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 178.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Vtiger_Field_Js(
    'Workflows_Field_Js',
    {},
    {
        getUiTypeSpecificHtml: function () {
Severity: Major
Found in public_html/layouts/basic/modules/Settings/Workflows/resources/AdvanceFilter.js and 1 other location - About 7 hrs to fix
public_html/layouts/basic/modules/Vtiger/resources/AdvanceFilterEx.js on lines 428..457

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 178.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        generateModuleColor: function (e) {
            var target = $(e.currentTarget);
            var colorPreview = $('#calendarColorPreviewModule' + target.data('record'));
            AppConnector.request({
                module: 'Colors',
Severity: Major
Found in public_html/layouts/basic/modules/Settings/Colors/resources/Index.js and 2 other locations - About 7 hrs to fix
public_html/layouts/basic/modules/Settings/Colors/resources/Index.js on lines 106..123
public_html/layouts/basic/modules/Settings/Colors/resources/Index.js on lines 161..178

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 178.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Vtiger_Field_Js(
    'AdvanceFilterEx_Field_Js',
    {},
    {
        getUiTypeSpecificHtml: function () {
Severity: Major
Found in public_html/layouts/basic/modules/Vtiger/resources/AdvanceFilterEx.js and 1 other location - About 7 hrs to fix
public_html/layouts/basic/modules/Settings/Workflows/resources/AdvanceFilter.js on lines 245..276

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 178.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File Functions.php has 464 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

 /* +**********************************************************************************
 * The contents of this file are subject to the vtiger CRM Public License Version 1.0
 * ("License"); You may not use this file except in compliance with the License
Severity: Minor
Found in vtlib/Vtiger/Functions.php - About 7 hrs to fix

    Function parseBaseSearchParamsToCondition has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
    Open

        public function parseBaseSearchParamsToCondition($searchParams)
    {
        if (empty($searchParams)) {
            return [];
        }
    Severity: Minor
    Found in app/QueryGenerator.php - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function sendByRowQueue has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function sendByRowQueue($rowQueue)
    {
        if ('demo' === \App\Config::main('systemMode')) {
            return true;
        }
    Severity: Minor
    Found in app/Mailer.php - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function saveHandler has 177 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                    let saveHandler = function (e) {
                    thisInstance.registerNameAjaxEditEvent();
                    let element = $(e.target);
                    if ($(e.currentTarget).find('.dateTimePickerField').length) {
                        if (element.closest('.drp-calendar').length || element.hasClass('drp-calendar')) {
    Severity: Major
    Found in public_html/layouts/basic/modules/Vtiger/resources/Detail.js - About 7 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php
/**
 * YetiForce shop YetiForce Widgets Premium file.
 *
 * @package App
      Severity: Major
      Found in app/YetiForce/Shop/Product/YetiForceWidgets.php and 1 other location - About 7 hrs to fix
      app/YetiForce/Shop/Product/YetiForceWebservicePremium.php on lines 1..59

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 226.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      if (!empty($parRecordOwner)) {
                    $parModName = Module::getModuleName($parModId);
                    if (isset($sharingPrivileges['permission'][$parModName . '_' . $moduleName])) {
                        $writeRelated = $sharingPrivileges['permission'][$parModName . '_' . $moduleName]['write'];
                        $relOwnerType = '';
      Severity: Major
      Found in app/Privilege.php and 1 other location - About 7 hrs to fix
      app/Privilege.php on lines 430..466

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 226.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      if (\count($parRecordOwner) > 0) {
                    $parModName = Module::getModuleName($parModId);
                    if (isset($sharingPrivileges['permission'][$parModName . '_' . $moduleName])) {
                        $readRelated = $sharingPrivileges['permission'][$parModName . '_' . $moduleName]['read'];
      Severity: Major
      Found in app/Privilege.php and 1 other location - About 7 hrs to fix
      app/Privilege.php on lines 525..560

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 226.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php
/**
 * YetiForce shop YetiForce Webservice Premium file.
 *
 * @package App
      Severity: Major
      Found in app/YetiForce/Shop/Product/YetiForceWebservicePremium.php and 1 other location - About 7 hrs to fix
      app/YetiForce/Shop/Product/YetiForceWidgets.php on lines 1..59

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 226.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              registerActivityChange: function () {
            var thisInstance = this;
            var refreshContainer = this.getContainer().find('.dashboardWidgetContent');
            refreshContainer.find('.changeActivity').on('click', function (e) {
                if (jQuery(e.target).is('a') || thisInstance.modalView) {
      Severity: Major
      Found in public_html/layouts/basic/modules/Vtiger/resources/dashboards/Widget.js and 1 other location - About 7 hrs to fix
      public_html/layouts/basic/modules/Vtiger/resources/dashboards/Widget.js on lines 2685..2701

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 176.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              registerAction: function () {
            var thisInstance = this;
            var refreshContainer = this.getContainer().find('.dashboardWidgetContent');
            refreshContainer.find('.rowAction').on('click', function (e) {
                if (jQuery(e.target).is('a') || thisInstance.modalView) {
      Severity: Major
      Found in public_html/layouts/basic/modules/Vtiger/resources/dashboards/Widget.js and 1 other location - About 7 hrs to fix
      public_html/layouts/basic/modules/Vtiger/resources/dashboards/Widget.js on lines 2624..2640

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 176.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php
/**
 * Duplicate product ean handler.
 *
 * @package Handler
      Severity: Major
      Found in modules/Products/handlers/DuplicateEan.php and 1 other location - About 7 hrs to fix
      modules/Accounts/handlers/DuplicateVatId.php on lines 1..44

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 225.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php
/**
 * Duplicate vat id handler.
 *
 * @package Handler
      Severity: Major
      Found in modules/Accounts/handlers/DuplicateVatId.php and 1 other location - About 7 hrs to fix
      modules/Products/handlers/DuplicateEan.php on lines 1..44

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 225.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      File Privilege.php has 459 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

namespace App;

/**
      Severity: Minor
      Found in app/Privilege.php - About 7 hrs to fix

        File Import.js has 458 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /*+**********************************************************************************
 * The contents of this file are subject to the vtiger CRM Public License Version 1.0
 * ("License"); You may not use this file except in compliance with the License
 * The Original Code is:  vtiger CRM Open Source
 * The Initial Developer of the Original Code is vtiger.
        Severity: Minor
        Found in public_html/layouts/basic/modules/Import/resources/Import.js - About 7 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public function getDataCrm(bool $onEdit = false): array
    {
        $parsedData = parent::getDataCrm($onEdit);
        if (!empty($shippingAddress = $this->getAddressDataCrm('shipping'))) {
            $parsedData = \array_replace_recursive($parsedData, $shippingAddress);
          Severity: Major
          Found in app/Integrations/Magento/Synchronizer/Maps/Order.php and 1 other location - About 7 hrs to fix
          app/Integrations/Magento/Synchronizer/Maps/Invoice.php on lines 83..105

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 224.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language