Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Calendar/models/EditRecordStructure.php

Summary

Maintainability
C
1 day
Test Coverage
F
0%

Function getStructure has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
Open

    public function getStructure()
    {
        if (!empty($this->structuredValues)) {
            return $this->structuredValues;
        }
Severity: Minor
Found in modules/Calendar/models/EditRecordStructure.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getStructure has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getStructure()
    {
        if (!empty($this->structuredValues)) {
            return $this->structuredValues;
        }
Severity: Major
Found in modules/Calendar/models/EditRecordStructure.php - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                                    if ('Calendar' != $moduleModel->getName()) {
                                    $fieldValue = $fieldValue . ' ' . $recordModel->get('time_end');
                                }
    Severity: Major
    Found in modules/Calendar/models/EditRecordStructure.php - About 45 mins to fix

      The method getStructure() has an NPath complexity of 1116. The configured NPath complexity threshold is 200.
      Open

          public function getStructure()
    {
        if (!empty($this->structuredValues)) {
            return $this->structuredValues;
        }
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
    function bar() {
        // lots of complicated code
    }
}

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The method getStructure() has a Cyclomatic Complexity of 24. The configured cyclomatic complexity threshold is 10.
      Open

          public function getStructure()
    {
        if (!empty($this->structuredValues)) {
            return $this->structuredValues;
        }
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Refactor this function to reduce its Cognitive Complexity from 57 to the 15 allowed.
      Open

          public function getStructure()
      Severity: Critical
      Found in modules/Calendar/models/EditRecordStructure.php by sonar-php

      Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

      See

      Avoid using static access to class 'Users_Record_Model' in method 'getStructure'.
      Open

                                      $currentUserModel = Users_Record_Model::getCurrentUserModel();
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\App\FieldsDependency' in method 'getStructure'.
      Open

                  $fieldsDependency = \App\FieldsDependency::getByRecordModel($recordModel->isNew() ? 'Create' : 'Edit', $recordModel);
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'Users_Record_Model' in method 'getStructure'.
      Open

                                      $currentUserModel = Users_Record_Model::getCurrentUserModel();
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Each class must be in a namespace of at least one level (a top-level vendor name)
      Open

      class Calendar_EditRecordStructure_Model extends Vtiger_EditRecordStructure_Model
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      The class Calendar_EditRecordStructure_Model is not named in CamelCase.
      Open

      class Calendar_EditRecordStructure_Model extends Vtiger_EditRecordStructure_Model
{
    /** {@inheritdoc} */
    public function getStructure()
    {
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpmd

      CamelCaseClassName

      Since: 0.2

      It is considered best practice to use the CamelCase notation to name classes.

      Example

      class class_name {
}

      Source

      Spaces must be used to indent lines; tabs are not allowed
      Open

              foreach ($blockModelList as $blockLabel => $blockModel) {
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                  } elseif ('due_date' == $fieldName && 'Calendar' != $moduleModel->get('name')) {
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                          $fieldValue = $fieldValue . ' ' . $recordModel->get('time_end');
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                  $fieldModel->set('fieldvalue', $fieldValue);
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      foreach ($fieldModelList as $fieldName => $fieldModel) {
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                  $fieldValue = $recordModel->get($fieldName);
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                      //Do not concat duedate and endtime for Tasks as it contains only duedate
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                  } elseif ('activitystatus' === $fieldName && empty($fieldValue)) {
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if (!empty($this->structuredValues)) {
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      $values[$blockLabel] = [];
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                      if ('Calendar' != $moduleModel->getName()) {
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                              if ($recordExists) {
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                  } elseif ('activitytype' === $fieldName && empty($fieldValue)) {
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                              if ($fieldModel->get('tabindex') > Vtiger_Field_Model::$tabIndexLastSeq) {
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                          }
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              return $this->structuredValues = $values;
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                              if (!empty($fieldsDependency['hide']['frontend']) && \in_array($fieldName, $fieldsDependency['hide']['frontend'])) {
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                              $values[$blockLabel][$fieldName] = $fieldModel;
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $fieldModelList = $blockModel->getFields();
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                          if ($fieldModel->isEditable() && (empty($fieldsDependency['hide']['backend']) || !\in_array($fieldName, $fieldsDependency['hide']['backend']))) {
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                      }
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                  }
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public function getStructure()
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                      $currentUserModel = Users_Record_Model::getCurrentUserModel();
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                      $defaulteventstatus = $currentUserModel->get('defaulteventstatus');
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      }
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $values = [];
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Line exceeds 120 characters; contains 129 characters
      Open

                  $fieldsDependency = \App\FieldsDependency::getByRecordModel($recordModel->isNew() ? 'Create' : 'Edit', $recordModel);
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                  if ('date_start' === $fieldName) {
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                  $fieldModel->set('hideField', true);
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $blockModelList = $moduleModel->getBlocks();
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Line exceeds 120 characters; contains 165 characters
      Open

                          if ($fieldModel->isEditable() && (empty($fieldsDependency['hide']['backend']) || !\in_array($fieldName, $fieldsDependency['hide']['backend']))) {
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                              }
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              ++Vtiger_Field_Model::$tabIndexLastSeq;
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                      $currentUserModel = Users_Record_Model::getCurrentUserModel();
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                              if (!empty($fieldsDependency['mandatory']) && \in_array($fieldName, $fieldsDependency['mandatory'])) {
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  return $this->structuredValues;
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if ($recordExists) {
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $fieldsDependency = \App\FieldsDependency::getByRecordModel($recordModel->isNew() ? 'Create' : 'Edit', $recordModel);
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                      $fieldValue = $fieldValue . ' ' . $recordModel->get('time_start');
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  }
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $moduleModel = $this->getModule();
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  if (!empty($fieldModelList)) {
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                      $defaultactivitytype = $currentUserModel->get('defaultactivitytype');
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                      $fieldValue = $defaultactivitytype;
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Line exceeds 120 characters; contains 140 characters
      Open

                              if (!empty($fieldsDependency['hide']['frontend']) && \in_array($fieldName, $fieldsDependency['hide']['frontend'])) {
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          /** {@inheritdoc} */
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $recordModel = $this->getRecord();
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $recordExists = !empty($recordModel);
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                      $fieldValue = $defaulteventstatus;
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Line exceeds 120 characters; contains 126 characters
      Open

                              if (!empty($fieldsDependency['mandatory']) && \in_array($fieldName, $fieldsDependency['mandatory'])) {
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                              }
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                  Vtiger_Field_Model::$tabIndexLastSeq = $fieldModel->get('tabindex');
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                              }
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                              }
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                                  $fieldModel->set('isMandatory', true);
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      Class name "Calendar_EditRecordStructure_Model" is not in camel caps format
      Open

      class Calendar_EditRecordStructure_Model extends Vtiger_EditRecordStructure_Model
      Severity: Minor
      Found in modules/Calendar/models/EditRecordStructure.php by phpcodesniffer

      There are no issues that match your filters.

      Category
      Status