Method process has 70 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function process(App\Request $request)
{
$viewer = $this->getViewer($request);
$moduleName = $request->getModule();
$page = $request->getInteger('page');Function process has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
public function process(App\Request $request)
{
$viewer = $this->getViewer($request);
$moduleName = $request->getModule();
$page = $request->getInteger('page');- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Consider simplifying this complex logical expression. Open
if (empty($widgetData[$key])
|| ('all' !== $widgetData[$key] && !isset($accessibleUsers[$widgetData[$key]]) && !isset($accessibleGroups[$widgetData[$key]]))
|| ('all' === $widgetData[$key] && !\in_array($widgetData[$key], $available))) {
$defaultValue = Settings_WidgetsManagement_Module_Model::getDefaultUserId($widget, false, $defaultValue);
$widgetData[$key] = empty($defaultValue) ? \App\User::getCurrentUserId() : $defaultValue;Function getModules has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function getModules(): array
{
if (!isset($this->trackingModules)) {
$this->trackingModules = [];
$userPrivilegesModel = \Users_Privileges_Model::getCurrentUserPrivilegesModel();- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method process() has an NPath complexity of 5184. The configured NPath complexity threshold is 200. Open
public function process(App\Request $request)
{
$viewer = $this->getViewer($request);
$moduleName = $request->getModule();
$page = $request->getInteger('page');- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method process() has a Cyclomatic Complexity of 19. The configured cyclomatic complexity threshold is 10. Open
public function process(App\Request $request)
{
$viewer = $this->getViewer($request);
$moduleName = $request->getModule();
$page = $request->getInteger('page');- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Refactor this function to reduce its Cognitive Complexity from 25 to the 15 allowed. Open
public function process(App\Request $request)- Read upRead up
- Exclude checks
Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.
See
The class ModTracker_Updates_Dashboard has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13. Open
class ModTracker_Updates_Dashboard extends Vtiger_IndexAjax_View
{
/** {@inheritdoc} */
public function checkPermission(App\Request $request)
{- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}Source https://phpmd.org/rules/design.html#couplingbetweenobjects
Missing class import via use statement (line '25', column '14'). Open
throw new \App\Exceptions\NoPermitted('LBL_PERMISSION_DENIED', 406);- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '53', column '22'). Open
$pagingModel = new Vtiger_Paging_Model();- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
[$updates, $actions] = ModTracker_Updates_Helper::getSummary($this->getModules(), $widgetData['actions'], $dateRange, $owner, $historyOwner);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'ModTracker_Updates_Helper' in method 'process'. Open
[$updates, $actions] = ModTracker_Updates_Helper::getSummary($this->getModules(), $widgetData['actions'], $dateRange, $owner, $historyOwner);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'ModTracker' in method 'checkPermission'. Open
}- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Vtiger_Widget_Model' in method 'process'. Open
$widget = \Vtiger_Widget_Model::getInstance($linkId, \App\User::getCurrentUserId());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'ModTracker' in method 'process'. Open
$widgetData['actions'] = $widgetData['actions'] ?? array_keys(ModTracker::getAllActionsTypes());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Settings_WidgetsManagement_Module_Model' in method 'process'. Open
$defaultValue = Settings_WidgetsManagement_Module_Model::getDefaultUserId($widget, false, $defaultValue);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$viewer->view('dashboards/UpdatesContentsSummary.tpl', $moduleName);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\App\Json' in method 'process'. Open
}- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Users_Privileges_Model' in method 'checkPermission'. Open
$userPrivilegesModel = \Users_Privileges_Model::getCurrentUserPrivilegesModel();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\User' in method 'process'. Open
$widgetData[$key] = empty($defaultValue) ? \App\User::getCurrentUserId() : $defaultValue;- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'ModTracker_Updates_Helper' in method 'process'. Open
$updates = ModTracker_Updates_Helper::getUpdates(\App\Module::getModuleName($selectedModule), $widgetData['actions'], $dateRange, $owner, $historyOwner, $pagingModel);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Fields\Date' in method 'process'. Open
$viewer->assign('DATE_RANGE', \App\Fields\Date::formatRangeToDisplay($dateRange));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$viewer->assign('TRACKING_MODULES', $this->getModules());
$viewer->view('dashboards/Updates.tpl', $moduleName);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'App\Json' in method 'process'. Open
$widgetData = App\Json::decode($widget->get('data'));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'ModTracker' in method 'getModules'. Open
foreach (ModTracker::getTrackingModules() as $tabId => $moduleName) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Module' in method 'process'. Open
$updates = ModTracker_Updates_Helper::getUpdates(\App\Module::getModuleName($selectedModule), $widgetData['actions'], $dateRange, $owner, $historyOwner, $pagingModel);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\User' in method 'process'. Open
$widget = \Vtiger_Widget_Model::getInstance($linkId, \App\User::getCurrentUserId());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Users_Privileges_Model' in method 'getModules'. Open
$userPrivilegesModel = \Users_Privileges_Model::getCurrentUserPrivilegesModel();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Define a constant instead of duplicating this literal "owner" 3 times. Open
foreach (['owner' => false, 'historyOwner' => false] as $key => $defaultValue) {- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "historyOwner" 3 times. Open
foreach (['owner' => false, 'historyOwner' => false] as $key => $defaultValue) {- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "sourceModule" 4 times. Open
if ($request->has('sourceModule') && (!isset(ModTracker::getTrackingModules()[$request->getInteger('sourceModule')]) || !$userPrivilegesModel->hasModulePermission($request->getInteger('sourceModule')))) {- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "actions" 5 times. Open
$widgetData['actions'] = $widgetData['actions'] ?? array_keys(ModTracker::getAllActionsTypes());- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('UPDATES', $updates);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('URL', $widget->getUrl());- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('TRACKING_MODULES', $this->getModules());- Exclude checks
Reference to undeclared property \ModTracker_Updates_Dashboard->trackingModules Open
if (!isset($this->trackingModules)) {- Exclude checks
Call to method getInstance from undeclared class \App\Fields\Owner Open
$accessibleUsers = \App\Fields\Owner::getInstance(false)->getAccessibleUsers();- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('ACCESSIBLE_GROUPS', $accessibleGroups);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('AVAILABLE_OWNERS', $available);- Exclude checks
Reference to undeclared property \ModTracker_Updates_Dashboard->trackingModules Open
return $this->trackingModules;- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('MODULE_NAME', $moduleName);- Exclude checks
Call to method getCurrentUserId from undeclared class \App\User (Did you mean class \Tests\App\User) Open
$widgetData[$key] = empty($defaultValue) ? \App\User::getCurrentUserId() : $defaultValue;- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('WIDGET_DATA', $widgetData);- Exclude checks
Call to method getCurrentUserId from undeclared class \App\User (Did you mean class \Tests\App\User) Open
$widget = \Vtiger_Widget_Model::getInstance($linkId, \App\User::getCurrentUserId());- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('WIDGET', $widget);- Exclude checks
Argument 1 (mixed) is string but \Users_Privileges_Model::hasModulePermission() takes int defined at /code/modules/Users/models/Privileges.php:101 Open
if ($userPrivilegesModel->hasModulePermission($moduleName)) {- Exclude checks
Reference to undeclared property \ModTracker_Updates_Dashboard->trackingModules Open
$this->trackingModules[$tabId] = $moduleName;- Exclude checks
Call to method getInstance from undeclared class \App\Fields\Owner Open
$accessibleGroups = \App\Fields\Owner::getInstance(false)->getAccessibleGroups();- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('DATE_RANGE', \App\Fields\Date::formatRangeToDisplay($dateRange));- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('PAGING_MODEL', $pagingModel);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('ACCESSIBLE_USERS', $accessibleUsers);- Exclude checks
Call to method getInstance from undeclared class \Vtiger_Widget_Model Open
$widget = \Vtiger_Widget_Model::getInstance($linkId, \App\User::getCurrentUserId());- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('ACTIONS', $actions);- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign Open
$viewer->assign('SELECTED_MODULE', $selectedModule);- Exclude checks
Reference to undeclared property \ModTracker_Updates_Dashboard->trackingModules Open
$this->trackingModules = [];- Exclude checks
Each class must be in a namespace of at least one level (a top-level vendor name) Open
class ModTracker_Updates_Dashboard extends Vtiger_IndexAjax_View- Exclude checks
A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 17 and the first side effect is on line 13. Open
<?php- Exclude checks
The class ModTracker_Updates_Dashboard is not named in CamelCase. Open
class ModTracker_Updates_Dashboard extends Vtiger_IndexAjax_View
{
/** {@inheritdoc} */
public function checkPermission(App\Request $request)
{- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
$pagingModel = new Vtiger_Paging_Model();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$defaultValue = Settings_WidgetsManagement_Module_Model::getDefaultUserId($widget, false, $defaultValue);- Exclude checks
Line exceeds 120 characters; contains 183 characters Open
$updates = ModTracker_Updates_Helper::getUpdates(\App\Module::getModuleName($selectedModule), $widgetData['actions'], $dateRange, $owner, $historyOwner, $pagingModel);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} else {- Exclude checks
Line exceeds 120 characters; contains 157 characters Open
[$updates, $actions] = ModTracker_Updates_Helper::getSummary($this->getModules(), $widgetData['actions'], $dateRange, $owner, $historyOwner);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getModules(): array- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$userPrivilegesModel = \Users_Privileges_Model::getCurrentUserPrivilegesModel();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($userPrivilegesModel->hasModulePermission($moduleName)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$userPrivilegesModel = \Users_Privileges_Model::getCurrentUserPrivilegesModel();- Exclude checks
Line exceeds 120 characters; contains 212 characters Open
if ($request->has('sourceModule') && (!isset(ModTracker::getTrackingModules()[$request->getInteger('sourceModule')]) || !$userPrivilegesModel->hasModulePermission($request->getInteger('sourceModule')))) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$page = $request->getInteger('page');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$widgetData['actions'] = $widgetData['actions'] ?? array_keys(ModTracker::getAllActionsTypes());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!\is_array($available)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!empty($widgetData['actions'])) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
parent::checkPermission($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$owner = 'all' === $widgetData['owner'] ? null : $widgetData['owner'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($selectedModule) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$pagingModel->set('limit', $limit);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('DATE_RANGE', \App\Fields\Date::formatRangeToDisplay($dateRange));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('ACCESSIBLE_USERS', $accessibleUsers);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function checkPermission(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
|| ('all' === $widgetData[$key] && !\in_array($widgetData[$key], $available))) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$widgetData[$key] = empty($defaultValue) ? \App\User::getCurrentUserId() : $defaultValue;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('WIDGET', $widget);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('ACCESSIBLE_GROUPS', $accessibleGroups);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
throw new \App\Exceptions\NoPermitted('LBL_PERMISSION_DENIED', 406);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$accessibleUsers = \App\Fields\Owner::getInstance(false)->getAccessibleUsers();- Exclude checks
Line exceeds 120 characters; contains 143 characters Open
|| ('all' !== $widgetData[$key] && !isset($accessibleUsers[$widgetData[$key]]) && !isset($accessibleGroups[$widgetData[$key]]))- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('URL', $widget->getUrl());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->view('dashboards/UpdatesContentsSummary.tpl', $moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$dateRange = $request->getDateRange('dateRange');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$dateRange[1] = date('Y-m-d');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (empty($limit)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$accessibleGroups = \App\Fields\Owner::getInstance(false)->getAccessibleGroups();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
|| ('all' !== $widgetData[$key] && !isset($accessibleUsers[$widgetData[$key]]) && !isset($accessibleGroups[$widgetData[$key]]))- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('ACTIONS', $actions);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->view('dashboards/Updates.tpl', $moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$dateRange = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$page = 1;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('AVAILABLE_OWNERS', $available);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('SELECTED_MODULE', $selectedModule);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($request->has('content')) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->view('dashboards/UpdatesContents.tpl', $moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$widgetData = App\Json::decode($widget->get('data'));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->trackingModules[$tabId] = $moduleName;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$widget = \Vtiger_Widget_Model::getInstance($linkId, \App\User::getCurrentUserId());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$updates = ModTracker_Updates_Helper::getUpdates(\App\Module::getModuleName($selectedModule), $widgetData['actions'], $dateRange, $owner, $historyOwner, $pagingModel);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
[$updates, $actions] = ModTracker_Updates_Helper::getSummary($this->getModules(), $widgetData['actions'], $dateRange, $owner, $historyOwner);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$available = [$available];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('PAGING_MODEL', $pagingModel);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('MODULE_NAME', $moduleName);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('WIDGET_DATA', $widgetData);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!isset($this->trackingModules)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$limit = (int) $widget->get('limit');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$limit = 10;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (empty($page)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function process(App\Request $request)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$pagingModel->set('page', $page);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (empty($widgetData[$key])- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($selectedModule) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @return string[]- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$linkId = $request->getInteger('linkid');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (empty($dateRange)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$selectedModule = $request->getInteger('sourceModule', 0);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$available = \App\Json::decode(html_entity_decode($widget->get('owners')))['available'] ?? [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
foreach (['owner' => false, 'historyOwner' => false] as $key => $defaultValue) {- Exclude checks
Line exceeds 120 characters; contains 121 characters Open
$defaultValue = Settings_WidgetsManagement_Module_Model::getDefaultUserId($widget, false, $defaultValue);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('TRACKING_MODULES', $this->getModules());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
foreach (ModTracker::getTrackingModules() as $tabId => $moduleName) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$dateRange[0] = date('Y-m-d');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$updates = $actions = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* Gets modules.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return $this->trackingModules;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($request->has('sourceModule') && (!isset(ModTracker::getTrackingModules()[$request->getInteger('sourceModule')]) || !$userPrivilegesModel->hasModulePermission($request->getInteger('sourceModule')))) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer = $this->getViewer($request);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$moduleName = $request->getModule();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$historyOwner = 'all' === $widgetData['historyOwner'] ? null : $widgetData['historyOwner'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('UPDATES', $updates);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->trackingModules = [];- Exclude checks
Class name "ModTracker_Updates_Dashboard" is not in camel caps format Open
class ModTracker_Updates_Dashboard extends Vtiger_IndexAjax_View- Exclude checks