Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/OpenStreetMap/crons/UpdaterCoordinates.php

Summary

Maintainability
C
1 day
Test Coverage
F
0%

Function process has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
Open

    public function process()
    {
        $db = App\Db::getInstance();
        $lastUpdatedCrmId = (new App\Db\Query())->select(['crmid'])->from('u_#__openstreetmap_address_updater')->scalar();
        if (false !== $lastUpdatedCrmId) {
Severity: Minor
Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function process()
    {
        $db = App\Db::getInstance();
        $lastUpdatedCrmId = (new App\Db\Query())->select(['crmid'])->from('u_#__openstreetmap_address_updater')->scalar();
        if (false !== $lastUpdatedCrmId) {
Severity: Major
Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php - About 2 hrs to fix

    The method process() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10.
    Open

        public function process()
    {
        $db = App\Db::getInstance();
        $lastUpdatedCrmId = (new App\Db\Query())->select(['crmid'])->from('u_#__openstreetmap_address_updater')->scalar();
        if (false !== $lastUpdatedCrmId) {
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Refactor this function to reduce its Cognitive Complexity from 43 to the 15 allowed.
    Open

        public function process()
    Severity: Critical
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by sonar-php

    Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

    See

    Missing class import via use statement (line '24', column '23').
    Open

                $dataReader = (new App\Db\Query())->select(['crmid', 'setype', 'deleted'])
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '45', column '34').
    Open

                            $isCoordinateExists = (new App\Db\Query())->from(OpenStreetMap_Module_Model::COORDINATES_TABLE_NAME)->where(['crmid' => $recordModel->getId(), 'type' => $typeAddress])->exists();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '22', column '28').
    Open

            $lastUpdatedCrmId = (new App\Db\Query())->select(['crmid'])->from('u_#__openstreetmap_address_updater')->scalar();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class 'App\Db' in method 'process'.
    Open

            $db = App\Db::getInstance();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                } else {
                $db->createCommand()->update('u_#__openstreetmap_address_updater', ['crmid' => $lastUpdatedCrmId])->execute();
            }
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class 'OpenStreetMap_Module_Model' in method 'process'.
    Open

                $moduleModel = OpenStreetMap_Module_Model::getInstance('OpenStreetMap');
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Map\Coordinates' in method 'process'.
    Open

                $coordinatesConnector = \App\Map\Coordinates::getInstance();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                                } else {
                                $db->createCommand()->update(OpenStreetMap_Module_Model::COORDINATES_TABLE_NAME, [
                                    'lat' => round($coordinate['lat'], 7),
                                    'lon' => round($coordinate['lon'], 7),
                                ], ['crmid' => $recordModel->getId(), 'type' => $typeAddress])
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class 'App\Config' in method 'process'.
    Open

                    ->limit(App\Config::module('OpenStreetMap', 'cronMaxUpdatedAddresses'))
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Config' in method 'process'.
    Open

                    ->where(['setype' => \App\Config::module('OpenStreetMap', 'mapModules', [])])
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Vtiger_Record_Model' in method 'process'.
    Open

                        $recordModel = Vtiger_Record_Model::getInstanceById($row['crmid']);
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\Map\Coordinates' in method 'process'.
    Open

                            $addressInfo = \App\Map\Coordinates::getAddressParams($recordModel, $typeAddress);
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Define a constant instead of duplicating this literal "u_#__openstreetmap_address_updater" 3 times.
    Open

            $lastUpdatedCrmId = (new App\Db\Query())->select(['crmid'])->from('u_#__openstreetmap_address_updater')->scalar();
    Severity: Critical
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "crmid" 12 times.
    Open

            $lastUpdatedCrmId = (new App\Db\Query())->select(['crmid'])->from('u_#__openstreetmap_address_updater')->scalar();
    Severity: Critical
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "setype" 3 times.
    Open

                $dataReader = (new App\Db\Query())->select(['crmid', 'setype', 'deleted'])
    Severity: Critical
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "OpenStreetMap" 3 times.
    Open

                    ->where(['setype' => \App\Config::module('OpenStreetMap', 'mapModules', [])])
    Severity: Critical
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Call to undeclared method \App\Db\Query::from
    Open

                            $isCoordinateExists = (new App\Db\Query())->from(OpenStreetMap_Module_Model::COORDINATES_TABLE_NAME)->where(['crmid' => $recordModel->getId(), 'type' => $typeAddress])->exists();
    Severity: Critical
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phan

    Argument 2 (value) is true but \vtlib\Cron::set() takes \vtlib\type defined at /code/vtlib/Vtiger/Cron.php:50
    Open

                    $this->cronTask->set('lockStatus', true);
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phan

    When fetching an array index from a value of type string, found an array index of type 'lon', but expected the index to be of type int
    Open

                                        'lon' => round($coordinate['lon'], 7),
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phan

    Call to undeclared method \App\Db\Query::select
    Open

                $dataReader = (new App\Db\Query())->select(['crmid', 'setype', 'deleted'])
    Severity: Critical
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phan

    Call to undeclared method \App\Db::createCommand
    Open

                                    $db->createCommand()->delete(OpenStreetMap_Module_Model::COORDINATES_TABLE_NAME, ['crmid' => $recordModel->getId(), 'type' => $typeAddress])->execute();
    Severity: Critical
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phan

    Call to undeclared method \App\Db::createCommand
    Open

                                $db->createCommand()->insert(OpenStreetMap_Module_Model::COORDINATES_TABLE_NAME, [
    Severity: Critical
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phan

    Call to undeclared method \App\Db\Query::select
    Open

            $lastUpdatedCrmId = (new App\Db\Query())->select(['crmid'])->from('u_#__openstreetmap_address_updater')->scalar();
    Severity: Critical
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phan

    Argument 1 (number) is string but \round() takes float
    Open

                                    'lat' => round($coordinate['lat'], 7),
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phan

    Argument 1 (number) is string but \round() takes float
    Open

                                        'lat' => round($coordinate['lat'], 7),
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phan

    Call to undeclared method \App\Db::createCommand
    Open

                    $db->createCommand()->update('u_#__openstreetmap_address_updater', ['crmid' => $lastUpdatedCrmId])->execute();
    Severity: Critical
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phan

    When fetching an array index from a value of type string, found an array index of type 'lon', but expected the index to be of type int
    Open

                                    'lon' => round($coordinate['lon'], 7),
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phan

    When fetching an array index from a value of type string, found an array index of type 'lat', but expected the index to be of type int
    Open

                                    'lat' => round($coordinate['lat'], 7),
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phan

    Call to undeclared method \App\Db::createCommand
    Open

                                    $db->createCommand()->update(OpenStreetMap_Module_Model::COORDINATES_TABLE_NAME, [
    Severity: Critical
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phan

    Call to undeclared method \App\Db::createCommand
    Open

                    $db->createCommand()->update('u_#__openstreetmap_address_updater', ['crmid' => $lastUpdatedCrmId])->execute();
    Severity: Critical
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phan

    Argument 1 (number) is string but \round() takes float
    Open

                                    'lon' => round($coordinate['lon'], 7),
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phan

    When fetching an array index from a value of type string, found an array index of type 'lat', but expected the index to be of type int
    Open

                                        'lat' => round($coordinate['lat'], 7),
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phan

    Argument 1 (number) is string but \round() takes float
    Open

                                        'lon' => round($coordinate['lon'], 7),
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phan

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class OpenStreetMap_UpdaterCoordinates_Cron extends \App\CronHandler
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    The class OpenStreetMap_UpdaterCoordinates_Cron is not named in CamelCase.
    Open

    class OpenStreetMap_UpdaterCoordinates_Cron extends \App\CronHandler
{
    /** {@inheritdoc} */
    public function process()
    {
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

            $db = App\Db::getInstance();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if (false !== $lastUpdatedCrmId) {
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $coordinatesConnector = \App\Map\Coordinates::getInstance();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                }
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            if (false === $coordinate) {
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $isCoordinateExists = (new App\Db\Query())->from(OpenStreetMap_Module_Model::COORDINATES_TABLE_NAME)->where(['crmid' => $recordModel->getId(), 'type' => $typeAddress])->exists();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                    ], ['crmid' => $recordModel->getId(), 'type' => $typeAddress])
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Line exceeds 120 characters; contains 126 characters
    Open

                    $db->createCommand()->update('u_#__openstreetmap_address_updater', ['crmid' => $lastUpdatedCrmId])->execute();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                } else {
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Line exceeds 120 characters; contains 126 characters
    Open

                    $db->createCommand()->update('u_#__openstreetmap_address_updater', ['crmid' => $lastUpdatedCrmId])->execute();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                    $db->createCommand()->update(OpenStreetMap_Module_Model::COORDINATES_TABLE_NAME, [
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $lastRecordId = $db->getUniqueID('vtiger_crmentity', 'crmid', false);
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $db->createCommand()->update('u_#__openstreetmap_address_updater', ['crmid' => $lastUpdatedCrmId])->execute();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $recordModel = Vtiger_Record_Model::getInstanceById($row['crmid']);
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        foreach (\App\Map\Coordinates::TYPE_ADDRESS as $typeAddress) {
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Line exceeds 120 characters; contains 202 characters
    Open

                            $isCoordinateExists = (new App\Db\Query())->from(OpenStreetMap_Module_Model::COORDINATES_TABLE_NAME)->where(['crmid' => $recordModel->getId(), 'type' => $typeAddress])->exists();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                if (empty($coordinate['lat']) && empty($coordinate['lon'])) {
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            }
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $dataReader = (new App\Db\Query())->select(['crmid', 'setype', 'deleted'])
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                continue;
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if ($this->checkTimeout()) {
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $dataReader->close();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function process()
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    ->createCommand()->query();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Line exceeds 120 characters; contains 184 characters
    Open

                                    $db->createCommand()->delete(OpenStreetMap_Module_Model::COORDINATES_TABLE_NAME, ['crmid' => $recordModel->getId(), 'type' => $typeAddress])->execute();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            } elseif (!empty($coordinate['lat']) && !empty($coordinate['lon'])) {
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                    'type' => $typeAddress,
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        }
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    ->andWhere(['>', 'crmid', $lastUpdatedCrmId])
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $moduleModel = OpenStreetMap_Module_Model::getInstance('OpenStreetMap');
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $addressInfo = \App\Map\Coordinates::getAddressParams($recordModel, $typeAddress);
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                        'lat' => round($coordinate['lat'], 7),
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                $db->createCommand()->insert(OpenStreetMap_Module_Model::COORDINATES_TABLE_NAME, [
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                ])->execute();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $this->cronTask->updateStatus(\vtlib\Cron::$STATUS_DISABLED);
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            }
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                    'crmid' => $recordModel->getId(),
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $db = App\Db::getInstance();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $lastUpdatedCrmId = (new App\Db\Query())->select(['crmid'])->from('u_#__openstreetmap_address_updater')->scalar();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    ->limit(App\Config::module('OpenStreetMap', 'cronMaxUpdatedAddresses'))
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            }
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                } else {
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                        ->execute();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                    'lat' => round($coordinate['lat'], 7),
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    ->where(['setype' => \App\Config::module('OpenStreetMap', 'mapModules', [])])
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            if ($isCoordinateExists) {
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $coordinate = $coordinatesConnector->getCoordinates($addressInfo);
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                    'lon' => round($coordinate['lon'], 7),
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $lastUpdatedCrmId = $row['crmid'];
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /** {@inheritdoc} */
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Line exceeds 120 characters; contains 122 characters
    Open

            $lastUpdatedCrmId = (new App\Db\Query())->select(['crmid'])->from('u_#__openstreetmap_address_updater')->scalar();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $coordinate = reset($coordinate);
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    ->from('vtiger_crmentity')
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                while ($row = $dataReader->read()) {
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                break;
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            if (empty($coordinate)) {
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                    $db->createCommand()->delete(OpenStreetMap_Module_Model::COORDINATES_TABLE_NAME, ['crmid' => $recordModel->getId(), 'type' => $typeAddress])->execute();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                                        'lon' => round($coordinate['lon'], 7),
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $db->createCommand()->update('u_#__openstreetmap_address_updater', ['crmid' => $lastUpdatedCrmId])->execute();
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if ($moduleModel->isAllowModules($row['setype']) && 0 == $row['deleted']) {
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        break;
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if ($dataReader->count() || $lastRecordId === $lastUpdatedCrmId) {
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $this->cronTask->set('lockStatus', true);
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    Class name "OpenStreetMap_UpdaterCoordinates_Cron" is not in camel caps format
    Open

    class OpenStreetMap_UpdaterCoordinates_Cron extends \App\CronHandler
    Severity: Minor
    Found in modules/OpenStreetMap/crons/UpdaterCoordinates.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status