modules/Settings/Companies/models/Record.php
Method getFieldInstanceByName has 54 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function getFieldInstanceByName(string $name, string $label = ''): Vtiger_Field_Model
{
$moduleName = $this->getModule()->getName(true);
$labels = $this->getModule()->getFormFields();
$label = $label ?: ($labels[$name]['label'] ?? '');Function getFieldInstanceByName has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
Open
public function getFieldInstanceByName(string $name, string $label = ''): Vtiger_Field_Model
{
$moduleName = $this->getModule()->getName(true);
$labels = $this->getModule()->getFormFields();
$label = $label ?: ($labels[$name]['label'] ?? '');- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function save has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
public function save(): void
{
$db = App\Db::getInstance('admin');
$transaction = $db->beginTransaction();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method getFieldInstanceByName() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. Open
Open
public function getFieldInstanceByName(string $name, string $label = ''): Vtiger_Field_Model
{
$moduleName = $this->getModule()->getName(true);
$labels = $this->getModule()->getFormFields();
$label = $label ?: ($labels[$name]['label'] ?? '');- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The class Settings_Companies_Record_Model has a coupling between objects value of 19. Consider to reduce the number of dependencies under 13. Open
Open
class Settings_Companies_Record_Model extends Settings_Vtiger_Record_Model
{
public $module;
/** @var array Record changes */
protected $changes = [];- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}Source https://phpmd.org/rules/design.html#couplingbetweenobjects
Missing class import via use statement (line '57', column '15'). Open
Open
$row = (new \App\Db\Query())->from('s_#__companies')->one($db);- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '174', column '13'). Open
Open
throw new \App\Exceptions\NoPermitted('LBL_OPERATION_NOT_PERMITTED');- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '115', column '26'). Open
Open
$registration = (new \App\YetiForce\Register());- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '118', column '16'). Open
Open
throw new \App\Exceptions\AppException($error);- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '64', column '14'). Open
Open
throw new \App\Exceptions\DbException('LBL_RECORD_NOT_FOUND');- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class '\App\Cache' in method 'save'. Open
Open
\App\Cache::clear();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Purifier' in method 'getDisplayValue'. Open
Open
$value =\App\Purifier::encodeHtml($value);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method getInstance uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
throw new \App\Exceptions\DbException('LBL_RECORD_NOT_FOUND');
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\App\Fields\Country' in method 'getFieldInstanceByName'. Open
Open
foreach (\App\Fields\Country::getAll() as $country) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Settings_Vtiger_Module_Model' in method 'getModule'. Open
Open
$module = Settings_Vtiger_Module_Model::getInstance('Settings:Companies');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Cache' in method 'save'. Open
Open
\App\Cache::staticDelete('CompanyGet', '');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Language' in method 'getFieldInstanceByName'. Open
Open
$params['picklistValues'][$industry] = \App\Language::translate($industry, $moduleName, null, false);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid assigning values to variables in if clauses and the like (line '114', column '9'). Open
Open
public function save(): void
{
$db = App\Db::getInstance('admin');
$transaction = $db->beginTransaction();
- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid using static access to class '\App\Language' in method 'getDisplayValue'. Open
Open
$value =\App\Language::translateSingleMod($value, 'Other.Country');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Module' in method 'getDisplayValue'. Open
Open
$value = \App\Module::getModuleName((int) $value);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'App\Language' in method 'getDisplayValue'. Open
Open
$value = App\Language::translate($value);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Log' in method 'save'. Open
Open
\App\Log::error($ex->__toString());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Language' in method 'getFieldInstanceByName'. Open
Open
$params['picklistValues'][$country['name']] = \App\Language::translateSingleMod($country['name'], 'Other.Country', null, false);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Settings_Vtiger_Field_Model' in method 'getFieldInstanceByName'. Open
Open
return Settings_Vtiger_Field_Model::init($moduleName, $params);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid assigning values to variables in if clauses and the like (line '117', column '9'). Open
Open
public function save(): void
{
$db = App\Db::getInstance('admin');
$transaction = $db->beginTransaction();
- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid using static access to class 'App\Db' in method 'save'. Open
Open
$db = App\Db::getInstance('admin');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Settings_Companies_Module_Model' in method 'getFieldInstanceByName'. Open
Open
foreach (Settings_Companies_Module_Model::getIndustryList() as $industry) {- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Db' in method 'getInstance'. Open
Open
$db = \App\Db::getInstance('admin');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Process' in method 'save'. Open
Open
\App\Process::removeEvent(\Settings_Companies_EditModal_View::MODAL_EVENT['name']);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Define a constant instead of duplicating this literal "uitype" 5 times. Open
Open
'uitype' => 1,- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "maximumlength" 3 times. Open
Open
'maximumlength' => '255',- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Rename "$module" which has the same name as the field declared at line 13. Open
Open
$module = Settings_Vtiger_Module_Model::getInstance('Settings:Companies');- Read upRead up
- Exclude checks
Shadowing fields with a local variable is a bad practice that reduces code readability: it makes it confusing to know whether the field or the variable is being used.
Noncompliant Code Example
class Foo {
public $myField;
public function doSomething() {
$myField = 0;
...
}
}
See
- CERT, DCL51-J. - Do not shadow or obscure identifiers in subscopes
Define a constant instead of duplicating this literal "purifyType" 3 times. Open
Open
'purifyType' => \App\Purifier::TEXT- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Rename "$changes" which has the same name as the field declared at line 15. Open
Open
if (($changes = $this->getPreviousValue()) && (\count($changes) > 1) || false === $this->getPreviousValue('email')) {- Read upRead up
- Exclude checks
Shadowing fields with a local variable is a bad practice that reduces code readability: it makes it confusing to know whether the field or the variable is being used.
Noncompliant Code Example
class Foo {
public $myField;
public function doSomething() {
$myField = 0;
...
}
}
See
- CERT, DCL51-J. - Do not shadow or obscure identifiers in subscopes
Define a constant instead of duplicating this literal "picklistValues" 4 times. Open
Open
$params['picklistValues'] = [];- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Argument 3 (language) is null but \App\Language::translateSingleMod() takes bool|false|string defined at /code/app/Language.php:308 Open
Open
$params['picklistValues'][$country['name']] = \App\Language::translateSingleMod($country['name'], 'Other.Country', null, false);- Exclude checks
Call to method getName from undeclared class \Settings_Companies_Module_Model Open
Open
$moduleName = $this->getModule()->getName(true);- Exclude checks
Call to undeclared method \App\Db\Query::from Open
Open
$row = (new \App\Db\Query())->from('s_#__companies')->one($db);- Exclude checks
Return type of getModule() is undeclared type \Settings_Companies_Module_Model Open
Open
public function getModule(): Settings_Companies_Module_Model- Exclude checks
Call to method setRawCompanyData from undeclared class \App\YetiForce\Register Open
Open
$registration->setRawCompanyData($this->getData())->register();- Exclude checks
Call to method getNameFields from undeclared class \Settings_Companies_Module_Model Open
Open
$fields = $this->getModule()->getNameFields();- Exclude checks
Call to method error from undeclared class \App\Log Open
Open
\App\Log::error($ex->__toString());- Exclude checks
Call to method __construct from undeclared class \App\YetiForce\Register Open
Open
$registration = (new \App\YetiForce\Register());- Exclude checks
Call to method getIndustryList from undeclared class \Settings_Companies_Module_Model Open
Open
foreach (Settings_Companies_Module_Model::getIndustryList() as $industry) {- Exclude checks
Returning type \Settings_Vtiger_Module_Model but getModule() is declared to return \Settings_Companies_Module_Model Open
Open
return $this->module;- Exclude checks
Reference to constant MODAL_EVENT from undeclared class \Settings_Companies_EditModal_View Open
Open
\App\Process::removeEvent(\Settings_Companies_EditModal_View::MODAL_EVENT['name']);- Exclude checks
Call to undeclared method \App\Db::createCommand Open
Open
$db->createCommand()->update('s_#__companies', $params, ['id' => $this->getId()])->execute();- Exclude checks
Call to undeclared method \App\Db::beginTransaction Open
Open
$transaction = $db->beginTransaction();- Exclude checks
Call to method getError from undeclared class \App\YetiForce\Register Open
Open
if ($error = $registration->getError()) {- Exclude checks
Call to method getFormFields from undeclared class \Settings_Companies_Module_Model Open
Open
$labels = $this->getModule()->getFormFields();- Exclude checks
Identical blocks of code found in 3 locations. Consider refactoring. Open
Open
public function set($key, $value)
{
if ($this->getId() && !\in_array($key, ['id']) && (\array_key_exists($key, $this->value) && $this->value[$key] != $value)) {
$this->changes[$key] = $this->get($key);
}- Read upRead up
modules/Settings/AutomaticAssignment/models/Record.php on lines 204..210
modules/Settings/PickListDependency/models/Record.php on lines 234..240
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 102.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Settings_Companies_Record_Model extends Settings_Vtiger_Record_Model- Exclude checks
Avoid variables with short names like $db. Configured minimum length is 3. Open
Open
$db = App\Db::getInstance('admin');- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
The class Settings_Companies_Record_Model is not named in CamelCase. Open
Open
class Settings_Companies_Record_Model extends Settings_Vtiger_Record_Model
{
public $module;
/** @var array Record changes */
protected $changes = [];- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Avoid variables with short names like $db. Configured minimum length is 3. Open
Open
$db = \App\Db::getInstance('admin');- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$registration->setRawCompanyData($this->getData())->register();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $fieldName ? (array_key_exists($fieldName, $this->changes) ? $this->changes[$fieldName] : false) : $this->changes;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getModule(): Settings_Companies_Module_Model- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** @var Settings_Companies_Module_Model $module */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
try {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$transaction->commit();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return int Id- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($row) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$instance->setData($row);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
protected $changes = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the Name.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $instance;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to save.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the Display Value, for the current field type with given DB Insert Value.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $key- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'country':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$labels = $this->getModule()->getFormFields();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'name' => $fieldName,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['uitype'] = 16;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getId(): int- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the Edit View Url.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @throws \App\Exceptions\DbException- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get Module instance.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (($changes = $this->getPreviousValue()) && (\count($changes) > 1) || false === $this->getPreviousValue('email')) {- Exclude checks
Line exceeds 120 characters; contains 129 characters Open
Open
if (($changes = $this->getPreviousValue()) && (\count($changes) > 1) || false === $this->getPreviousValue('email')) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$fields = $this->getModule()->getNameFields();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
} catch (\Throwable $ex) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['picklistValues'][$industry] = \App\Language::translate($industry, $moduleName, null, false);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->get('id');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->get('name');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->changes[$key] = $this->get($key);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return parent::set($key, $value);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $this->module;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$db = App\Db::getInstance('admin');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$transaction->rollBack();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = $this->get($key) ?? '';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return $value;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return bool- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $name- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$companyId = $this->getId();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$fieldName = 'YetiForce' === $sourceModule ? "companies[$companyId][$name]" : $name;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'name':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['maximumlength'] = '50';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach (\App\Fields\Country::getAll() as $country) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['picklistValues'][$country['name']] = \App\Language::translateSingleMod($country['name'], 'Other.Country', null, false);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['uitype'] = 17;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
unset($params['validator']);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** @var array Record changes */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Line exceeds 120 characters; contains 132 characters Open
Open
if ($this->getId() && !\in_array($key, ['id']) && (\array_key_exists($key, $this->value) && $this->value[$key] != $value)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$registration = (new \App\YetiForce\Register());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params = array_intersect_key($this->getData(), array_flip($fields));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$db->createCommand()->update('s_#__companies', $params, ['id' => $this->getId()])->execute();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'tabid':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
throw new \App\Exceptions\NoPermitted('LBL_OPERATION_NOT_PERMITTED');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['uitype'] = 13;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public static function getInstance()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$module = Settings_Vtiger_Module_Model::getInstance('Settings:Companies');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$label = $label ?: ($labels[$name]['label'] ?? '');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'column' => $name,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'typeofdata' => 'V~M',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
foreach (Settings_Companies_Module_Model::getIndustryList() as $industry) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'country':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return bool|Settings_Companies_Record_Model instance, if exists- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $fieldName- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
\App\Process::removeEvent(\Settings_Companies_EditModal_View::MODAL_EVENT['name']);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
\App\Log::error($ex->__toString());- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
\App\Cache::clear();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
switch ($key) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'industry':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = App\Language::translate($value);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$moduleName = $this->getModule()->getName(true);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'email':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['isEditableReadOnly'] = true;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getEditViewUrl(): string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return '?module=Companies&parent=Settings&view=Edit';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$instance = new self();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Get pervious value by field.- Exclude checks
Line exceeds 120 characters; contains 129 characters Open
Open
return $fieldName ? (array_key_exists($fieldName, $this->changes) ? $this->changes[$fieldName] : false) : $this->changes;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function save(): void- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function determines fields available in edition view.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$sourceModule = $this->get('source');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'displaytype' => 1,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'presence' => '',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'maximumlength' => '255',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'purifyType' => \App\Purifier::TEXT- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the Id.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getPreviousValue(string $fieldName = '')- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @param string $label- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'label' => $label,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['picklistValues'] = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['purifyType'] = \App\Purifier::EMAIL;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $module;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getName(): string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
\App\Cache::staticDelete('CompanyGet', '');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
default:- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return \Vtiger_Field_Model- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['maximumlength'] = '100';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return Settings_Vtiger_Field_Model::init($moduleName, $params);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string URL- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to get the instance of companies record model.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/** {@inheritdoc} */- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->module = $module;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'value' => '',- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'isEditableReadOnly' => false,- Exclude checks
Line exceeds 120 characters; contains 148 characters Open
Open
$params['picklistValues'][$country['name']] = \App\Language::translateSingleMod($country['name'], 'Other.Country', null, false);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$row = (new \App\Db\Query())->from('s_#__companies')->one($db);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
throw new \App\Exceptions\AppException($error);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value =\App\Language::translateSingleMod($value, 'Other.Country');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'industry':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['picklistValues'] = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$db = \App\Db::getInstance('admin');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
throw new \App\Exceptions\DbException('LBL_RECORD_NOT_FOUND');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($this->getId() && !\in_array($key, ['id']) && (\array_key_exists($key, $this->value) && $this->value[$key] != $value)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return mixed- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if (!isset($this->module)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$transaction = $db->beginTransaction();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ($error = $registration->getError()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function delete(): bool- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params = [- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['uitype'] = 16;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function set($key, $value)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @return Settings_Companies_Module_Model- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* @throws \App\Exceptions\NoPermitted- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
unset($params['validator']);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['purifyType'] = \App\Purifier::URL;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
throw $ex;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getDisplayValue(string $key): string- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value = \App\Module::getModuleName((int) $value);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
switch ($name) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$params['typeofdata'] = 'V~O';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
* Function to delete the current Record Model.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
/**- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'uitype' => 1,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
case 'website':- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
default:- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$value =\App\Purifier::encodeHtml($value);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function getFieldInstanceByName(string $name, string $label = ''): Vtiger_Field_Model- Exclude checks
Line exceeds 120 characters; contains 121 characters Open
Open
$params['picklistValues'][$industry] = \App\Language::translate($industry, $moduleName, null, false);- Exclude checks
Class name "Settings_Companies_Record_Model" is not in camel caps format Open
Open
class Settings_Companies_Record_Model extends Settings_Vtiger_Record_Model- Exclude checks