Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Settings/CurrencyUpdate/bankmodels/CBR.php

Summary

Maintainability
C
1 day
Test Coverage
F
0%

Function getRates has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

    public function getRates($otherCurrencyCode, $dateParam, $cron = false)
    {
        $moduleModel = Settings_CurrencyUpdate_Module_Model::getCleanInstance();
        $selectedBank = $moduleModel->getActiveBankId();
        $yesterday = date('Y-m-d', strtotime('-1 day'));
Severity: Minor
Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getRates has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getRates($otherCurrencyCode, $dateParam, $cron = false)
    {
        $moduleModel = Settings_CurrencyUpdate_Module_Model::getCleanInstance();
        $selectedBank = $moduleModel->getActiveBankId();
        $yesterday = date('Y-m-d', strtotime('-1 day'));
Severity: Major
Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php - About 2 hrs to fix

    The method getRates() has an NPath complexity of 1344. The configured NPath complexity threshold is 200.
    Open

        public function getRates($otherCurrencyCode, $dateParam, $cron = false)
    {
        $moduleModel = Settings_CurrencyUpdate_Module_Model::getCleanInstance();
        $selectedBank = $moduleModel->getActiveBankId();
        $yesterday = date('Y-m-d', strtotime('-1 day'));
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
    function bar() {
        // lots of complicated code
    }
}

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method getRates() has a Cyclomatic Complexity of 20. The configured cyclomatic complexity threshold is 10.
    Open

        public function getRates($otherCurrencyCode, $dateParam, $cron = false)
    {
        $moduleModel = Settings_CurrencyUpdate_Module_Model::getCleanInstance();
        $selectedBank = $moduleModel->getActiveBankId();
        $yesterday = date('Y-m-d', strtotime('-1 day'));
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Refactor this function to reduce its Cognitive Complexity from 39 to the 15 allowed.
    Open

        public function getRates($otherCurrencyCode, $dateParam, $cron = false)
    Severity: Critical
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by sonar-php

    Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

    See

    Missing class import via use statement (line '34', column '17').
    Open

            $client = new \SoapClient($source[0], \App\RequestHttp::getSoapOptions());
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '36', column '19').
    Open

            $ratesXml = new \SimpleXMLElement($curs->GetCursOnDateResult->any);
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '78', column '17').
    Open

            $client = new \SoapClient($source[0], \App\RequestHttp::getSoapOptions());
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '80', column '19').
    Open

            $ratesXml = new \SimpleXMLElement($curs->GetCursOnDateResult->any);
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The method getRates has a boolean flag argument $cron, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function getRates($otherCurrencyCode, $dateParam, $cron = false)
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    Avoid using static access to class 'Settings_CurrencyUpdate_Module_Model' in method 'getRates'.
    Open

            $moduleModel = Settings_CurrencyUpdate_Module_Model::getCleanInstance();
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method getRates uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                    } else {
                    $moduleModel->addCurrencyRate($mainCurrencyId, $datePublicationOfFile, $exchange, $selectedBank);
                }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class 'vtlib\Functions' in method 'getRates'.
    Open

            $lastWorkingDay = vtlib\Functions::getLastWorkingDay($yesterday);
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\RequestHttp' in method 'getSupportedCurrencies'.
    Open

            $client = new \SoapClient($source[0], \App\RequestHttp::getSoapOptions());
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Settings_CurrencyUpdate_Module_Model' in method 'getSupportedCurrencies'.
    Open

                $currencyName = Settings_CurrencyUpdate_Module_Model::getCRMCurrencyName($currencyCode);
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method getRates uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                        } else {
                        $moduleModel->addCurrencyRate($currId, $datePublicationOfFile, $exchange, $selectedBank);
                    }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class '\App\Fields\Currency' in method 'getRates'.
    Open

    }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Settings_CurrencyUpdate_Module_Model' in method 'getSupportedCurrencies'.
    Open

            $supportedCurrencies[Settings_CurrencyUpdate_Module_Model::getCRMCurrencyName($this->getMainCurrencyCode())] = $this->getMainCurrencyCode();
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\App\RequestHttp' in method 'getRates'.
    Open

            $client = new \SoapClient($source[0], \App\RequestHttp::getSoapOptions());
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Define a constant instead of duplicating this literal "Y-m-d" 3 times.
    Open

            $curs = $client->GetCursOnDate(['On_date' => date('Y-m-d')]);
    Severity: Critical
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Expected @param annotation for dateParam to be before the @param annotation for cron
    Open

         * @param bool    $cron              - if true then it is fired by server and crms currency conversion rates are updated
    Severity: Info
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phan

    Reference to instance property ValuteData from undeclared class \SimpleXMLElement
    Open

            foreach ($ratesXml->ValuteData[0] as $currency) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phan

    Saw unextractable annotation for comment '* @param <array> $currencies - list of systems active currencies'</array>
    Open

         * @param <Array> $currencies        - list of systems active currencies
    Severity: Info
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phan

    Saw unextractable annotation for comment '* @param <date> $date - date for which exchange is fetched'</date>
    Open

         * @param <Date>  $date              - date for which exchange is fetched
    Severity: Info
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phan

    Call to method __construct from undeclared class \SimpleXMLElement
    Open

            $ratesXml = new \SimpleXMLElement($curs->GetCursOnDateResult->any);
    Severity: Critical
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phan

    Call to method __construct from undeclared class \SimpleXMLElement
    Open

            $ratesXml = new \SimpleXMLElement($curs->GetCursOnDateResult->any);
    Severity: Critical
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phan

    Reference to instance property ValuteData from undeclared class \SimpleXMLElement
    Open

            foreach ($ratesXml->ValuteData[0] as $currencyRate) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phan

    Reference to instance property ValuteData from undeclared class \SimpleXMLElement
    Open

                foreach ($ratesXml->ValuteData[0] as $currencyRate) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phan

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                if ($mainCurrencyId) {
                if (true === $cron || ((strtotime($dateParam) == strtotime($today)) || (strtotime($dateParam) == strtotime($lastWorkingDay)))) {
                    $moduleModel->setCRMConversionRate($this->getMainCurrencyCode(), $exchangeRate);
                }
    Severity: Major
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php and 3 other locations - About 2 hrs to fix
    modules/Settings/CurrencyUpdate/bankmodels/ECB.php on lines 158..170
    modules/Settings/CurrencyUpdate/bankmodels/NBP.php on lines 178..190
    modules/Settings/CurrencyUpdate/bankmodels/NBR.php on lines 158..170

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 137.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid excessively long variable names like $datePublicationOfFile. Keep variable name length under 20.
    Open

            $datePublicationOfFile = $dateCur;
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class Settings_CurrencyUpdate_CBR_BankModel extends Settings_CurrencyUpdate_AbstractBank_Model
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    The class Settings_CurrencyUpdate_CBR_BankModel is not named in CamelCase.
    Open

    class Settings_CurrencyUpdate_CBR_BankModel extends Settings_CurrencyUpdate_AbstractBank_Model
{
    // Returns bank name

    public function getName()
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getName()
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $supportedCurrencies = [];
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        // Returns url sources from where exchange rates are taken from
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return 'CBR';
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return ['http://www.cbr.ru/DailyInfoWebServ/DailyInfo.asmx?WSDL'];
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $supportedCurrencies[Settings_CurrencyUpdate_Module_Model::getCRMCurrencyName($this->getMainCurrencyCode())] = $this->getMainCurrencyCode();
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        // Returns bank name
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $client = new \SoapClient($source[0], \App\RequestHttp::getSoapOptions());
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $ratesXml = new \SimpleXMLElement($curs->GetCursOnDateResult->any);
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $source = $this->getSource();
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $supportedCurrencies[$currencyName] = $currencyCode;
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getRates($otherCurrencyCode, $dateParam, $cron = false)
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    } else {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            foreach ($ratesXml->ValuteData[0] as $currency) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $yesterday = date('Y-m-d', strtotime('-1 day'));
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($mainCurrency != $this->getMainCurrencyCode()) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if ($existingId > 0) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getSupportedCurrencies()
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $currencyName = Settings_CurrencyUpdate_Module_Model::getCRMCurrencyName($currencyCode);
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return $supportedCurrencies;
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                foreach ($otherCurrencyCode as $key => $currId) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $exchangeVtiger = $exchangeRate / $exchange;
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            // currency diffrent than RUB, we need to add manually RUB rates
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getSource()
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        // Returns list of currencies supported by this bank
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Line exceeds 120 characters; contains 148 characters
    Open

            $supportedCurrencies[Settings_CurrencyUpdate_Module_Model::getCRMCurrencyName($this->getMainCurrencyCode())] = $this->getMainCurrencyCode();
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $currencyCode = (string) $currency->VchCode;
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $today = date('Y-m-d');
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $existingId = $moduleModel->getCurrencyRateId($currId, $datePublicationOfFile, $selectedBank);
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if (true === $cron || ((strtotime($dateParam) == strtotime($today)) || (strtotime($dateParam) == strtotime($lastWorkingDay)))) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $moduleModel->addCurrencyRate($mainCurrencyId, $datePublicationOfFile, $exchange, $selectedBank);
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            return 'RUB';
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * Fetch exchange rates.
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $exchangeRate = $currencyRate->Vcurs;
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $mainCurrencyId = $id;
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $curs = $client->GetCursOnDate(['On_date' => date('Y-m-d')]);
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        /**
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $datePublicationOfFile = $dateCur;
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $exchangeRate = 1.0;
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $exchange = $exchange / $exchangeRate;
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if ($code == $this->getMainCurrencyCode()) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if ($mainCurrencyId) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         *
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param mixed   $otherCurrencyCode
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $curs = $client->GetCursOnDate(['On_date' => $dateCur]);
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $nom = (string) $currencyRate->Vnom;
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        } else {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        public function getMainCurrencyCode()
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param mixed   $dateParam
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $lastWorkingDay = vtlib\Functions::getLastWorkingDay($yesterday);
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $exchange = $curs / $nom;
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $moduleModel = Settings_CurrencyUpdate_Module_Model::getCleanInstance();
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                foreach ($ratesXml->ValuteData[0] as $currencyRate) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $moduleModel->updateCurrencyRate($existingId, $exchange);
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $mainCurrencyId = false;
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $moduleModel->setCRMConversionRate($this->getMainCurrencyCode(), $exchangeRate);
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $moduleModel->updateCurrencyRate($existingId, $exchange);
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param bool    $cron              - if true then it is fired by server and crms currency conversion rates are updated
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $ratesXml = new \SimpleXMLElement($curs->GetCursOnDateResult->any);
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            foreach ($ratesXml->ValuteData[0] as $currencyRate) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Line exceeds 120 characters; contains 148 characters
    Open

                        if (true === $cron || ((strtotime($dateParam) == strtotime($today)) || (strtotime($dateParam) == strtotime($lastWorkingDay)))) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $moduleModel->addCurrencyRate($currId, $datePublicationOfFile, $exchange, $selectedBank);
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                if ($currencyName) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         */
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            if ($mainCurrency != $this->getMainCurrencyCode()) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Line exceeds 120 characters; contains 144 characters
    Open

                    if (true === $cron || ((strtotime($dateParam) == strtotime($today)) || (strtotime($dateParam) == strtotime($lastWorkingDay)))) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            // check if data is correct, currency rates can be retrieved only for working days
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $client = new \SoapClient($source[0], \App\RequestHttp::getSoapOptions());
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            // if currency is diffrent than RUB we need to calculate rate for converting other currencies to this one from RUB
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $currency = (string) $currencyRate->VchCode;
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if ($key == $currency && $currency != $mainCurrency) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                            $moduleModel->setCRMConversionRate($currency, $exchangeVtiger);
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        // Returns banks main currency
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Line exceeds 120 characters; contains 124 characters
    Open

         * @param bool    $cron              - if true then it is fired by server and crms currency conversion rates are updated
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $source = $this->getSource();
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Line exceeds 120 characters; contains 122 characters
    Open

            // if currency is diffrent than RUB we need to calculate rate for converting other currencies to this one from RUB
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    if ($currencyRate->VchCode == $mainCurrency) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        $curs = (string) $currencyRate->Vcurs;
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                $exchange = 1.00000 / $exchangeRate;
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        }
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param <Date>  $date              - date for which exchange is fetched
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $dateCur = $dateParam;
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        if ($existingId > 0) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                    $existingId = $moduleModel->getCurrencyRateId($mainCurrencyId, $datePublicationOfFile, $selectedBank);
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

         * @param <Array> $currencies        - list of systems active currencies
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

        {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $selectedBank = $moduleModel->getActiveBankId();
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $mainCurrency = \App\Fields\Currency::getDefault()['currency_code'];
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                        if (true === $cron || ((strtotime($dateParam) == strtotime($today)) || (strtotime($dateParam) == strtotime($lastWorkingDay)))) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

                foreach ($otherCurrencyCode as $code => $id) {
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    Class name "Settings_CurrencyUpdate_CBR_BankModel" is not in camel caps format
    Open

    class Settings_CurrencyUpdate_CBR_BankModel extends Settings_CurrencyUpdate_AbstractBank_Model
    Severity: Minor
    Found in modules/Settings/CurrencyUpdate/bankmodels/CBR.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status