Function getRates has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring. Open
public function getRates($otherCurrencyCode, $dateParam, $cron = false)
{
$moduleModel = Settings_CurrencyUpdate_Module_Model::getCleanInstance();
$selectedBank = $moduleModel->getActiveBankId();
$yesterday = date('Y-m-d', strtotime('-1 day'));- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getSupportedCurrencies has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring. Open
public function getSupportedCurrencies()
{
$supportedCurrencies = [];
$supportedCurrencies[Settings_CurrencyUpdate_Module_Model::getCRMCurrencyName($this->getMainCurrencyCode())] = $this->getMainCurrencyCode();
$dateCur = date('Y-m-d', strtotime('last monday'));- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getRates has 81 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getRates($otherCurrencyCode, $dateParam, $cron = false)
{
$moduleModel = Settings_CurrencyUpdate_Module_Model::getCleanInstance();
$selectedBank = $moduleModel->getActiveBankId();
$yesterday = date('Y-m-d', strtotime('-1 day'));Method getSupportedCurrencies has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getSupportedCurrencies()
{
$supportedCurrencies = [];
$supportedCurrencies[Settings_CurrencyUpdate_Module_Model::getCRMCurrencyName($this->getMainCurrencyCode())] = $this->getMainCurrencyCode();
$dateCur = date('Y-m-d', strtotime('last monday'));The method getRates() has an NPath complexity of 44000. The configured NPath complexity threshold is 200. Open
public function getRates($otherCurrencyCode, $dateParam, $cron = false)
{
$moduleModel = Settings_CurrencyUpdate_Module_Model::getCleanInstance();
$selectedBank = $moduleModel->getActiveBankId();
$yesterday = date('Y-m-d', strtotime('-1 day'));- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method getSupportedCurrencies() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10. Open
public function getSupportedCurrencies()
{
$supportedCurrencies = [];
$supportedCurrencies[Settings_CurrencyUpdate_Module_Model::getCRMCurrencyName($this->getMainCurrencyCode())] = $this->getMainCurrencyCode();
$dateCur = date('Y-m-d', strtotime('last monday'));- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method getRates() has a Cyclomatic Complexity of 27. The configured cyclomatic complexity threshold is 10. Open
public function getRates($otherCurrencyCode, $dateParam, $cron = false)
{
$moduleModel = Settings_CurrencyUpdate_Module_Model::getCleanInstance();
$selectedBank = $moduleModel->getActiveBankId();
$yesterday = date('Y-m-d', strtotime('-1 day'));- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Refactor this function to reduce its Cognitive Complexity from 28 to the 15 allowed. Open
public function getSupportedCurrencies()- Read upRead up
- Exclude checks
Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.
See
Refactor this function to reduce its Cognitive Complexity from 55 to the 15 allowed. Open
public function getRates($otherCurrencyCode, $dateParam, $cron = false)- Read upRead up
- Exclude checks
Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.
See
Missing class import via use statement (line '43', column '22'). Open
$tryTable = (new \GuzzleHttp\Client(\App\RequestHttp::getOptions()))->get($url, ['timeout' => 20, 'connect_timeout' => 10]);- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '57', column '16'). Open
throw new \App\Exceptions\IntegrationException('ERR_ITERATIONS_LIMIT_EXCEEDED');- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '118', column '22'). Open
$tryTable = (new \GuzzleHttp\Client(\App\RequestHttp::getOptions()))->get($url, ['timeout' => 20, 'connect_timeout' => 10]);- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
The method getRates has a boolean flag argument $cron, which is a certain sign of a Single Responsibility Principle violation. Open
public function getRates($otherCurrencyCode, $dateParam, $cron = false)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Missing class import via use statement (line '77', column '14'). Open
throw new \App\Exceptions\IntegrationException('ERR_CANNOT_CONNECT_TO_REMOTE' . $tableBody);- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class 'Settings_CurrencyUpdate_Module_Model' in method 'getSupportedCurrencies'. Open
$supportedCurrencies[Settings_CurrencyUpdate_Module_Model::getCRMCurrencyName($rawCurrency['code'])] = $rawCurrency['code'];- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Settings_CurrencyUpdate_Module_Model' in method 'getRates'. Open
$moduleModel = Settings_CurrencyUpdate_Module_Model::getCleanInstance();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method getSupportedCurrencies uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
\App\Log::error('Cannot parse server response' . $tableBody, __METHOD__);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\App\Log' in method 'getRates'. Open
\App\Log::endProfile("GET|NBP|{$url}", __NAMESPACE__);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Settings_CurrencyUpdate_Module_Model' in method 'getSupportedCurrencies'. Open
$supportedCurrencies[Settings_CurrencyUpdate_Module_Model::getCRMCurrencyName($this->getMainCurrencyCode())] = $this->getMainCurrencyCode();- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\RequestHttp' in method 'getSupportedCurrencies'. Open
$tryTable = (new \GuzzleHttp\Client(\App\RequestHttp::getOptions()))->get($url, ['timeout' => 20, 'connect_timeout' => 10]);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Log' in method 'getSupportedCurrencies'. Open
\App\Log::endProfile("GET|NBP::getSupportedCurrencies|{$url}", 'CurrencyUpdate');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Json' in method 'getRates'. Open
$json = \App\Json::decode($tableBody);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\RequestHttp' in method 'getRates'. Open
$tryTable = (new \GuzzleHttp\Client(\App\RequestHttp::getOptions()))->get($url, ['timeout' => 20, 'connect_timeout' => 10]);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Json' in method 'getSupportedCurrencies'. Open
$json = \App\Json::decode($tableBody);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Fields\Currency' in method 'getRates'. Open
}- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method getRates uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$moduleModel->addCurrencyRate($mainCurrencyId, $datePublicationOfFile, $exchange, $selectedBank);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\App\Log' in method 'getSupportedCurrencies'. Open
\App\Log::beginProfile("GET|NBP::getSupportedCurrencies|{$url}", 'CurrencyUpdate');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'vtlib\Functions' in method 'getRates'. Open
$lastWorkingDay = vtlib\Functions::getLastWorkingDay($yesterday);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method getRates uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$moduleModel->addCurrencyRate($currId, $datePublicationOfFile, $exchange, $selectedBank);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\App\Log' in method 'getSupportedCurrencies'. Open
\App\Log::info('Error during downloading table: ' . PHP_EOL . $ex->__toString() . PHP_EOL, 'CurrencyUpdate');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method getSupportedCurrencies uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
throw new \App\Exceptions\IntegrationException('ERR_CANNOT_CONNECT_TO_REMOTE' . $tableBody);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\App\Log' in method 'getSupportedCurrencies'. Open
\App\Log::error('Cannot parse server response' . $tableBody, __METHOD__);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\App\Log' in method 'getRates'. Open
\App\Log::beginProfile("GET|NBP|{$url}", __NAMESPACE__);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Define a constant instead of duplicating this literal "Y-m-d" 5 times. Open
$dateCur = date('Y-m-d', strtotime('last monday'));- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "CurrencyUpdate" 3 times. Open
\App\Log::beginProfile("GET|NBP::getSupportedCurrencies|{$url}", 'CurrencyUpdate');- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "rates" 4 times. Open
if (!empty($json) && !empty($json[0]) && !empty($json[0]['rates'])) {- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() {
prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times
execute('action1');
release('action1');
}
Compliant Solution
ACTION_1 = 'action1';
function run() {
prepare(ACTION_1);
execute(ACTION_1);
release(ACTION_1);
}
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Avoid using empty try-catch blocks in getRates. Open
} catch (\Throwable $exc) {
}- Read upRead up
- Exclude checks
EmptyCatchBlock
Since: 2.7.0
Usually empty try-catch is a bad idea because you are silently swallowing an error condition and then continuing execution. Occasionally this may be the right thing to do, but often it's a sign that a developer saw an exception, didn't know what to do about it, and so used an empty catch to silence the problem.
Example
class Foo {
public function bar()
{
try {
// ...
} catch (Exception $e) {} // empty catch block
}
}Source https://phpmd.org/rules/design.html#emptycatchblock
Suspicious type null of a variable or expression used to build a string. (Expected type to be able to cast to a string) Open
throw new \App\Exceptions\IntegrationException('ERR_CANNOT_CONNECT_TO_REMOTE' . $tableBody);- Exclude checks
Call to method __construct from undeclared class \GuzzleHttp\Client Open
$tryTable = (new \GuzzleHttp\Client(\App\RequestHttp::getOptions()))->get($url, ['timeout' => 20, 'connect_timeout' => 10]);- Exclude checks
Call to method get from undeclared class \GuzzleHttp\Client Open
$tryTable = (new \GuzzleHttp\Client(\App\RequestHttp::getOptions()))->get($url, ['timeout' => 20, 'connect_timeout' => 10]);- Exclude checks
Saw unextractable annotation for comment '* @param <array> $currencies - list of systems active currencies'</array> Open
* @param <Array> $currencies - list of systems active currencies- Exclude checks
Expected @param annotation for dateParam to be before the @param annotation for cron Open
* @param bool $cron - if true then it is fired by server and crms currency conversion rates are updated- Exclude checks
Call to method get from undeclared class \GuzzleHttp\Client Open
$tryTable = (new \GuzzleHttp\Client(\App\RequestHttp::getOptions()))->get($url, ['timeout' => 20, 'connect_timeout' => 10]);- Exclude checks
Call to method endProfile from undeclared class \App\Log Open
\App\Log::endProfile("GET|NBP|{$url}", __NAMESPACE__);- Exclude checks
Call to method __construct from undeclared class \GuzzleHttp\Client Open
$tryTable = (new \GuzzleHttp\Client(\App\RequestHttp::getOptions()))->get($url, ['timeout' => 20, 'connect_timeout' => 10]);- Exclude checks
Saw unextractable annotation for comment '* @param <date> $date - date for which exchange is fetched'</date> Open
* @param <Date> $date - date for which exchange is fetched- Exclude checks
Call to method beginProfile from undeclared class \App\Log Open
\App\Log::beginProfile("GET|NBP::getSupportedCurrencies|{$url}", 'CurrencyUpdate');- Exclude checks
Call to method endProfile from undeclared class \App\Log Open
\App\Log::endProfile("GET|NBP::getSupportedCurrencies|{$url}", 'CurrencyUpdate');- Exclude checks
Call to method error from undeclared class \App\Log Open
\App\Log::error('Cannot parse server response' . $tableBody, __METHOD__);- Exclude checks
Call to method info from undeclared class \App\Log Open
\App\Log::info('Error during downloading table: ' . PHP_EOL . $ex->__toString() . PHP_EOL, 'CurrencyUpdate');- Exclude checks
Call to method beginProfile from undeclared class \App\Log Open
\App\Log::beginProfile("GET|NBP|{$url}", __NAMESPACE__);- Exclude checks
Argument 1 (encodedValue) is null but \App\Json::decode() takes string defined at /code/app/Json.php:37 Open
$json = \App\Json::decode($tableBody);- Exclude checks
Either remove or fill this block of code. Open
} catch (\Throwable $exc) {
}- Read upRead up
- Exclude checks
Most of the time a block of code is empty when a piece of code is really missing. So such empty block must be either filled or removed.
Noncompliant Code Example
for ($i = 0; $i < 42; $i++){} // Empty on purpose or missing piece of code ?
Exceptions
When a block contains a comment, this block is not considered to be empty.
Similar blocks of code found in 4 locations. Consider refactoring. Open
if ($mainCurrencyId) {
if (true === $cron || ((strtotime($dateParam) == strtotime($today)) || (strtotime($dateParam) == strtotime($lastWorkingDay)))) {
$moduleModel->setCRMConversionRate($this->getMainCurrencyCode(), $exchangeRate);
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 137.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Avoid excessively long variable names like $datePublicationOfFile. Keep variable name length under 20. Open
$datePublicationOfFile = (string) $json[0]['effectiveDate'];- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}Source https://phpmd.org/rules/naming.html#longvariable
Each class must be in a namespace of at least one level (a top-level vendor name) Open
class Settings_CurrencyUpdate_NBP_BankModel extends Settings_CurrencyUpdate_AbstractBank_Model- Exclude checks
The class Settings_CurrencyUpdate_NBP_BankModel is not named in CamelCase. Open
class Settings_CurrencyUpdate_NBP_BankModel extends Settings_CurrencyUpdate_AbstractBank_Model
{
// Returns bank name
public function getName()- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Spaces must be used to indent lines; tabs are not allowed Open
// Returns url sources from where exchange rates are taken from- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return ['http://nbp.pl/kursy/xml/LastA.xml'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!empty($json) && !empty($json[0]) && !empty($json[0]['rates'])) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return 'NBP';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$supportedCurrencies = [];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$tableUrl = 'http://api.nbp.pl/api/exchangerates/tables/a/';- Exclude checks
Line exceeds 120 characters; contains 140 characters Open
$tryTable = (new \GuzzleHttp\Client(\App\RequestHttp::getOptions()))->get($url, ['timeout' => 20, 'connect_timeout' => 10]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getName()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Line exceeds 120 characters; contains 148 characters Open
$supportedCurrencies[Settings_CurrencyUpdate_Module_Model::getCRMCurrencyName($this->getMainCurrencyCode())] = $this->getMainCurrencyCode();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$iterationsLimit = 60;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
\App\Log::beginProfile("GET|NBP::getSupportedCurrencies|{$url}", 'CurrencyUpdate');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
continue;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getSupportedCurrencies()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$supportedCurrencies[Settings_CurrencyUpdate_Module_Model::getCRMCurrencyName($this->getMainCurrencyCode())] = $this->getMainCurrencyCode();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$numberOfDays = 1;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$dateCur = date('Y-m-d', $newDate);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
foreach ($json[0]['rates'] as $rawCurrency) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
// Returns list of currencies supported by this bank- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
try {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$tableBody = $tryTable->getBody();- Exclude checks
Line exceeds 120 characters; contains 125 characters Open
\App\Log::info('Error during downloading table: ' . PHP_EOL . $ex->__toString() . PHP_EOL, 'CurrencyUpdate');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
throw new \App\Exceptions\IntegrationException('ERR_ITERATIONS_LIMIT_EXCEEDED');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
// Returns bank name- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$url = $tableUrl . $dateCur . '/?format=json';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$supportedCurrencies[Settings_CurrencyUpdate_Module_Model::getCRMCurrencyName($rawCurrency['code'])] = $rawCurrency['code'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getSource()- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($stateA && $tableBody) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$tryTable = (new \GuzzleHttp\Client(\App\RequestHttp::getOptions()))->get($url, ['timeout' => 20, 'connect_timeout' => 10]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
\App\Log::info('Error during downloading table: ' . PHP_EOL . $ex->__toString() . PHP_EOL, 'CurrencyUpdate');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$dateCur = date('Y-m-d', strtotime('last monday'));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$stateA = false;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
while (!$stateA) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!$stateA) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
continue;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
++$numberOfDays;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Line exceeds 120 characters; contains 144 characters Open
$supportedCurrencies[Settings_CurrencyUpdate_Module_Model::getCRMCurrencyName($rawCurrency['code'])] = $rawCurrency['code'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @param <Date> $date - date for which exchange is fetched- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getRates($otherCurrencyCode, $dateParam, $cron = false)- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$iterationsLimit = 60;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
foreach ($json[0]['rates'] as $item) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($item['code'] === $mainCurrency) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($code == $this->getMainCurrencyCode()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$mainCurrencyId = $id;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (200 == $tryTable->getStatusCode()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$stateA = true;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (empty($rawCurrency['currency'])) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$tableUrl = 'http://api.nbp.pl/api/exchangerates/tables/a/';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$tableBody = $tryTable->getBody();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
foreach ($json[0]['rates'] as $item) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$currency = $item['code'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
foreach ($otherCurrencyCode as $code => $id) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($mainCurrencyId) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($numberOfDays > $iterationsLimit) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return $supportedCurrencies;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$numberOfDays = 1;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
++$numberOfDays;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
\App\Log::endProfile("GET|NBP::getSupportedCurrencies|{$url}", 'CurrencyUpdate');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$newDate = strtotime("-$numberOfDays day", strtotime($dateCur));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$json = \App\Json::decode($tableBody);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getMainCurrencyCode()- Exclude checks
Line exceeds 120 characters; contains 124 characters Open
* @param bool $cron - if true then it is fired by server and crms currency conversion rates are updated- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$tryTable = (new \GuzzleHttp\Client(\App\RequestHttp::getOptions()))->get($url, ['timeout' => 20, 'connect_timeout' => 10]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$exchangeRate = (float) $item['mid'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$existingId = $moduleModel->getCurrencyRateId($currId, $datePublicationOfFile, $selectedBank);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$moduleModel->updateCurrencyRate($existingId, $exchange);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (true === $cron || ((strtotime($dateParam) == strtotime($today)) || (strtotime($dateParam) == strtotime($lastWorkingDay)))) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
\App\Log::error('Cannot parse server response' . $tableBody, __METHOD__);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$yesterday = date('Y-m-d', strtotime('-1 day'));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$dateCur = $dateParam;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
\App\Log::beginProfile("GET|NBP|{$url}", __NAMESPACE__);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
// if currency is diffrent than PLN we need to calculate rate for converting other currencies to this one from PLN- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$exchangeVtiger = $exchangeRate / $exchange;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
// currency diffrent than PLN, we need to add manually PLN rates- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} catch (\Throwable $ex) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ('XDR' === $rawCurrency['code']) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/**- Exclude checks
Line exceeds 120 characters; contains 140 characters Open
$tryTable = (new \GuzzleHttp\Client(\App\RequestHttp::getOptions()))->get($url, ['timeout' => 20, 'connect_timeout' => 10]);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (false === $stateA) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$dateCur = date('Y-m-d', $dateCur);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$datePublicationOfFile = (string) $json[0]['effectiveDate'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$mainCurrencyId = false;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$existingId = $moduleModel->getCurrencyRateId($mainCurrencyId, $datePublicationOfFile, $selectedBank);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
// Returns banks main currency- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
while (!$stateA) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$url = $tableUrl . $dateCur . '/?format=json';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
try {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
\App\Log::endProfile("GET|NBP|{$url}", __NAMESPACE__);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$dateCur = strtotime("-$numberOfDays day", strtotime($dateCur));- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (true === $cron || ((strtotime($dateParam) == strtotime($today)) || (strtotime($dateParam) == strtotime($lastWorkingDay)))) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
throw new \App\Exceptions\IntegrationException('ERR_CANNOT_CONNECT_TO_REMOTE' . $tableBody);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @param mixed $otherCurrencyCode- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Line exceeds 120 characters; contains 148 characters Open
if (true === $cron || ((strtotime($dateParam) == strtotime($today)) || (strtotime($dateParam) == strtotime($lastWorkingDay)))) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$moduleModel->addCurrencyRate($currId, $datePublicationOfFile, $exchange, $selectedBank);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @param <Array> $currencies - list of systems active currencies- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*/- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
// check if data is correct, currency rates can be retrieved only for working days- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$stateA = true;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} catch (\Throwable $exc) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($key == $currency && $currency != $mainCurrency) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$exchange = $exchangeRate ? ($exchange / $exchangeRate) : 0;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$moduleModel->setCRMConversionRate($currency, $exchangeVtiger);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$moduleModel->addCurrencyRate($mainCurrencyId, $datePublicationOfFile, $exchange, $selectedBank);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$moduleModel = Settings_CurrencyUpdate_Module_Model::getCleanInstance();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
foreach ($otherCurrencyCode as $key => $currId) {- Exclude checks
Line exceeds 120 characters; contains 144 characters Open
if (true === $cron || ((strtotime($dateParam) == strtotime($today)) || (strtotime($dateParam) == strtotime($lastWorkingDay)))) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* Fetch exchange rates.- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($numberOfDays > $iterationsLimit) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
break;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$exchangeRate = 1.0;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$exchange = $item['mid'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} else {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return 'PLN';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @param bool $cron - if true then it is fired by server and crms currency conversion rates are updated- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @param mixed $dateParam- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$selectedBank = $moduleModel->getActiveBankId();- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$stateA = false;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$lastWorkingDay = vtlib\Functions::getLastWorkingDay($yesterday);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$mainCurrency = \App\Fields\Currency::getDefault()['currency_code'];- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($mainCurrency !== $this->getMainCurrencyCode()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$moduleModel->setCRMConversionRate($this->getMainCurrencyCode(), $exchangeRate);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$today = date('Y-m-d');- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$json = \App\Json::decode($tableBody);- Exclude checks
Line exceeds 120 characters; contains 122 characters Open
// if currency is diffrent than PLN we need to calculate rate for converting other currencies to this one from PLN- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($mainCurrency != $this->getMainCurrencyCode()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$exchange = $exchangeRate ? (1.00000 / $exchangeRate) : 0;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (200 == $tryTable->getStatusCode()) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($existingId > 0) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ($existingId > 0) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$moduleModel->updateCurrencyRate($existingId, $exchange);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}- Exclude checks
Class name "Settings_CurrencyUpdate_NBP_BankModel" is not in camel caps format Open
class Settings_CurrencyUpdate_NBP_BankModel extends Settings_CurrencyUpdate_AbstractBank_Model- Exclude checks