Method initializeListViewContents
has 116 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function initializeListViewContents(App\Request $request, Vtiger_Viewer $viewer)
{
$moduleName = $request->getModule();
$cvId = $request->getByType('viewname', 2);
$pageNumber = $request->getInteger('page');
Function initializeListViewContents
has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring. Open
public function initializeListViewContents(App\Request $request, Vtiger_Viewer $viewer)
{
$moduleName = $request->getModule();
$cvId = $request->getByType('viewname', 2);
$pageNumber = $request->getInteger('page');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getListViewCount
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function getListViewCount(App\Request $request)
{
$moduleName = $request->getModule();
$cvId = App\CustomView::getInstance($moduleName)->getViewId();
if (empty($cvId)) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method initializeListViewContents() has 125 lines of code. Current threshold is set to 100. Avoid really long methods. Open
public function initializeListViewContents(App\Request $request, Vtiger_Viewer $viewer)
{
$moduleName = $request->getModule();
$cvId = $request->getByType('viewname', 2);
$pageNumber = $request->getInteger('page');
- Exclude checks
The method initializeListViewContents() has an NPath complexity of 1658880. The configured NPath complexity threshold is 200. Open
public function initializeListViewContents(App\Request $request, Vtiger_Viewer $viewer)
{
$moduleName = $request->getModule();
$cvId = $request->getByType('viewname', 2);
$pageNumber = $request->getInteger('page');
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method initializeListViewContents() has a Cyclomatic Complexity of 26. The configured cyclomatic complexity threshold is 10. Open
public function initializeListViewContents(App\Request $request, Vtiger_Viewer $viewer)
{
$moduleName = $request->getModule();
$cvId = $request->getByType('viewname', 2);
$pageNumber = $request->getInteger('page');
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Refactor this function to reduce its Cognitive Complexity from 29 to the 15 allowed. Open
public function initializeListViewContents(App\Request $request, Vtiger_Viewer $viewer)
- Read upRead up
- Exclude checks
Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.
See
Missing class import via use statement (line '237', column '22'). Open
$pagingModel = new Vtiger_Paging_Model();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '247', column '19'). Open
$response = new Vtiger_Response();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '74', column '22'). Open
$pagingModel = new Vtiger_Paging_Model();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '188', column '19'). Open
$response = new Vtiger_Response();
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class 'App\Condition' in method 'initializeListViewContents'. Open
$searchParams = App\Condition::validSearchParams($moduleName, $request->getArray('search_params'));
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'App\Condition' in method 'getListViewCount'. Open
$searchParams = App\Condition::validSearchParams($moduleName, $request->getArray('search_params'));
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_ListView_Model' in method 'getListViewCount'. Open
$listViewModel = Vtiger_ListView_Model::getInstance($moduleName, $cvId);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method initializeListViewContents uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$nextSortOrder = 'ASC';
$sortImage = 'fas fa-chevron-up';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'App\Config' in method 'initializeListViewContents'. Open
if (App\Config::performance('LISTVIEW_COMPUTE_PAGE_COUNT') && empty($this->listViewCount)) {
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Vtiger_ListView_Model' in method 'initializeListViewContents'. Open
$this->listViewModel = Vtiger_ListView_Model::getInstance($moduleName, $cvId);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Users_Record_Model' in method 'initializeListViewContents'. Open
$viewer->assign('USER_MODEL', Users_Record_Model::getCurrentUserModel());
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'CRMEntity' in method 'initializeListViewContents'. Open
$moduleInstance = CRMEntity::getInstance($moduleName);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'App\Condition' in method 'initializeListViewContents'. Open
$searchValue = App\Condition::validSearchValue($request->getByType('search_value', 'Text'), $moduleName, $searchKey, $operator);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Define a constant instead of duplicating this literal "operator" 5 times. Open
if (!$request->isEmpty('operator', true)) {
- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() { prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times execute('action1'); release('action1'); }
Compliant Solution
ACTION_1 = 'action1'; function run() { prepare(ACTION_1); execute(ACTION_1); release(ACTION_1); }
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "search_key" 5 times. Open
if (!$request->isEmpty('search_key', true)) {
- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() { prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times execute('action1'); release('action1'); }
Compliant Solution
ACTION_1 = 'action1'; function run() { prepare(ACTION_1); execute(ACTION_1); release(ACTION_1); }
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Rename "$listViewModel" which has the same name as the field declared at line 21. Open
$listViewModel = Vtiger_ListView_Model::getInstance($moduleName, $cvId);
- Read upRead up
- Exclude checks
Shadowing fields with a local variable is a bad practice that reduces code readability: it makes it confusing to know whether the field or the variable is being used.
Noncompliant Code Example
class Foo { public $myField; public function doSomething() { $myField = 0; ... } }
See
- CERT, DCL51-J. - Do not shadow or obscure identifiers in subscopes
Define a constant instead of duplicating this literal "search_value" 4 times. Open
$searchValue = App\Condition::validSearchValue($request->getByType('search_value', 'Text'), $moduleName, $searchKey, $operator);
- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() { prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times execute('action1'); release('action1'); }
Compliant Solution
ACTION_1 = 'action1'; function run() { prepare(ACTION_1); execute(ACTION_1); release(ACTION_1); }
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "search_params" 5 times. Open
$searchParams = App\Condition::validSearchParams($moduleName, $request->getArray('search_params'));
- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() { prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times execute('action1'); release('action1'); }
Compliant Solution
ACTION_1 = 'action1'; function run() { prepare(ACTION_1); execute(ACTION_1); release(ACTION_1); }
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Define a constant instead of duplicating this literal "viewname" 3 times. Open
$cvId = $request->getByType('viewname', 2);
- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() { prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times execute('action1'); release('action1'); }
Compliant Solution
ACTION_1 = 'action1'; function run() { prepare(ACTION_1); execute(ACTION_1); release(ACTION_1); }
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Argument 1 (var)
is false
but \count()
takes \Countable|array
Open
$noOfEntries = \count($this->listViewEntries);
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('PAGE_NUMBER', $pageNumber);
- Exclude checks
Reference to undeclared property \Users_List_View->listViewCount
Open
if (!isset($this->listViewCount)) {
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('SEARCH_DETAILS', $searchParams);
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('LISTVIEW_MASSACTIONS', $linkModels['LISTVIEWMASSACTION']);
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('START_PAGIN_FROM', $startPaginFrom);
- Exclude checks
Reference to undeclared property \Users_List_View->listViewLinks
Open
$this->listViewLinks = $this->listViewModel->getListViewLinks($linkParams);
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('LISTVIEW_HEADERS', $this->listViewHeaders);
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('LISTVIEW_ENTRIES', $this->listViewEntries);
- Exclude checks
Reference to undeclared property \Users_List_View->listViewCount
Open
if (App\Config::performance('LISTVIEW_COMPUTE_PAGE_COUNT') && empty($this->listViewCount)) {
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('IS_MODULE_EDITABLE', $this->listViewModel->getModule()->isPermitted('CreateView'));
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('LOCKED_EMPTY_FIELDS', $request->isEmpty('lockedEmptyFields', true) ? [] : $request->getArray('lockedEmptyFields'));
- Exclude checks
Call to method parseBaseSearchParamsToCondition
from undeclared class \App\QueryGenerator
(Did you mean class \Tests\App\QueryGenerator) Open
$transformedSearchParams = $listViewModel->getQueryGenerator()->parseBaseSearchParamsToCondition($searchParams);
- Exclude checks
Reference to undeclared property \CRMEntity->default_order_by
Open
$orderBy = $moduleInstance->default_order_by;
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('LISTVIEW_LINKS', $this->listViewLinks);
- Exclude checks
Reference to undeclared property \Users_List_View->listViewCount
Open
$this->listViewCount = $this->listViewModel->getListViewCount();
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('LISTVIEW_ENTRIES_COUNT', $noOfEntries);
- Exclude checks
Reference to undeclared property \Users_List_View->listViewCount
Open
$this->listViewCount = 0;
- Exclude checks
Reference to undeclared property \Users_List_View->listViewCount
Open
$viewer->assign('LISTVIEW_COUNT', (int) $this->listViewCount);
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('MODULE_MODEL', $this->listViewModel->getModule());
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('OPERATOR', $operator);
- Exclude checks
Call to method addNativeCondition
from undeclared class \App\QueryGenerator
(Did you mean class \Tests\App\QueryGenerator) Open
$this->listViewModel->getQueryGenerator()->addNativeCondition(['vtiger_crmentity.crmid' => $searchResult]);
- Exclude checks
Assigning \Vtiger_Field_Model[]
to property but \Users_List_View->listViewHeaders
is false
Open
$this->listViewHeaders = $this->listViewModel->getListViewHeaders();
- Exclude checks
Reference to undeclared property \Users_List_View->listViewLinks
Open
if (!isset($this->listViewLinks)) {
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('VIEW_MODEL', $this->listViewModel);
- Exclude checks
Call to method parseBaseSearchParamsToCondition
from undeclared class \App\QueryGenerator
(Did you mean class \Tests\App\QueryGenerator) Open
$transformedSearchParams = $this->listViewModel->getQueryGenerator()->parseBaseSearchParamsToCondition($searchParams);
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('SORT_IMAGE', $sortImage);
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('LISTVIEW_COUNT', (int) $this->listViewCount);
- Exclude checks
Argument 2 (viewId)
is '0'
but \Vtiger_ListView_Model::getInstance()
takes int
defined at /code/modules/Vtiger/models/ListView.php:35
Open
$listViewModel = Vtiger_ListView_Model::getInstance($moduleName, $cvId);
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('COLUMN_NAME', $orderBy);
- Exclude checks
Return type of getFooterScripts()
is undeclared type \App\Controller\View\Vtiger_JsScript_Model[]
Open
public function getFooterScripts(App\Request $request)
- Exclude checks
Reference to undeclared property \CRMEntity->default_sort_order
Open
$sortOrder = $moduleInstance->default_sort_order;
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('SORT_ORDER', $sortOrder);
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('QUALIFIED_MODULE', $moduleName);
- Exclude checks
Reference to undeclared property \Users_List_View->listViewCount
Open
$pagingModel->set('totalCount', (int) $this->listViewCount);
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('ORDER_BY', $orderBy);
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('IS_MODULE_DELETABLE', $this->listViewModel->getModule()->isPermitted('Delete'));
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('USER_MODEL', Users_Record_Model::getCurrentUserModel());
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('SEARCH_PARAMS', $searchParamsRaw);
- Exclude checks
Reference to undeclared property \Users_List_View->listViewLinks
Open
$viewer->assign('LISTVIEW_LINKS', $this->listViewLinks);
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('PAGING_MODEL', $pagingModel);
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('NEXT_SORT_ORDER', $nextSortOrder);
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('PAGE_COUNT', $pageCount);
- Exclude checks
Method \Users_List_View::getPageCount
is declared to return \total
but has no return value Open
public function getPageCount(App\Request $request)
- Exclude checks
Assigning \Vtiger_Record_Model[]
to property but \Users_List_View->listViewEntries
is false
Open
$this->listViewEntries = $this->listViewModel->getListViewEntries($pagingModel);
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('MODULE', $moduleName);
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('VIEW', $request->getByType('view', 1));
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('ADVANCED_CONDITIONS', []);
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('ALPHABET_VALUE', $searchValue);
- Exclude checks
Return type of getPageCount()
is undeclared type \total
Open
public function getPageCount(App\Request $request)
- Exclude checks
Call to undeclared method \Vtiger_Viewer::assign
Open
$viewer->assign('ALPHABET_VALUE', $searchValue ?? '');
- Exclude checks
Identical blocks of code found in 2 locations. Consider refactoring. Open
public function getPageCount(App\Request $request)
{
$listViewCount = $this->getListViewCount($request);
$pagingModel = new Vtiger_Paging_Model();
$pageLimit = $pagingModel->getPageLimit();
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 139.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
public function getRecordsCount(App\Request $request)
{
$moduleName = $request->getModule();
$cvId = $request->getByType('viewname', 2);
$count = $this->getListViewCount($request);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 129.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 3 locations. Consider refactoring. Open
foreach ($request->getArray('search_params') as $fieldListGroup) {
$searchParamsRaw[] = $fieldListGroup;
foreach ($fieldListGroup as $fieldSearchInfo) {
$fieldSearchInfo['searchValue'] = $fieldSearchInfo[2] ?? '';
$fieldSearchInfo['fieldName'] = $fieldName = $fieldSearchInfo[0] ?? '';
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 99.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Avoid excessively long variable names like $transformedSearchParams. Keep variable name length under 20. Open
$transformedSearchParams = $this->listViewModel->getQueryGenerator()->parseBaseSearchParamsToCondition($searchParams);
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
Avoid excessively long variable names like $transformedSearchParams. Keep variable name length under 20. Open
$transformedSearchParams = $listViewModel->getQueryGenerator()->parseBaseSearchParamsToCondition($searchParams);
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
Each class must be in a namespace of at least one level (a top-level vendor name) Open
class Users_List_View extends Settings_Vtiger_List_View
- Exclude checks
The class Users_List_View is not named in CamelCase. Open
class Users_List_View extends Settings_Vtiger_List_View
{
use \App\Controller\Traits\SettingsPermission;
/**
- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}
Source
Spaces must be used to indent lines; tabs are not allowed Open
'modules.Users.resources.List',
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$pageNumber = 1;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$linkModels = $this->listViewModel->getListViewMassActions($linkParams);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->listViewModel->set('orderby', $orderBy);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->listViewModel->set('search_key', $searchKey);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$searchParamsRaw[] = $fieldListGroup;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$fieldSearchInfo['searchValue'] = $fieldSearchInfo[2] ?? '';
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('LISTVIEW_HEADERS', $this->listViewHeaders);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$startPaginFrom = $pagingModel->getStartPagingFrom();
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('IS_MODULE_EDITABLE', $this->listViewModel->getModule()->isPermitted('CreateView'));
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* Function returns the number of records for the current filter.
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/** {@inheritdoc} */
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$pagingModel->set('viewid', $cvId);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$searchKey = $request->getByType('search_key', 'Alnum');
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$noOfEntries = \count($this->listViewEntries);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* List view model instance.
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('START_PAGIN_FROM', $startPaginFrom);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$moduleName = $request->getModule();
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ('status' != $searchKey) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('SORT_ORDER', $sortOrder);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('LISTVIEW_ENTRIES', $this->listViewEntries);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('SEARCH_DETAILS', $searchParams);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/**
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public $listViewModel;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* Function to initialize the required data in smarty to display the List View Contents.
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$sortOrder = $moduleInstance->default_sort_order;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!$this->listViewModel) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$pagingModel = new Vtiger_Paging_Model();
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (empty($searchParams) || !\is_array($searchParams) || empty($searchParams[0])) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->listViewModel->set('search_params', $transformedSearchParams);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
foreach ($fieldListGroup as $fieldSearchInfo) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$fieldSearchInfo['specialOption'] = $fieldSearchInfo[3] ?? '';
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (App\Config::performance('LISTVIEW_COMPUTE_PAGE_COUNT') && empty($this->listViewCount)) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('LISTVIEW_COUNT', (int) $this->listViewCount);
- Exclude checks
Line exceeds 120 characters; contains 140 characters Open
$viewer->assign('LOCKED_EMPTY_FIELDS', $request->isEmpty('lockedEmptyFields', true) ? [] : $request->getArray('lockedEmptyFields'));
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*/
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/**
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$cvId = $request->getByType('viewname', 2);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$sortImage = 'fas fa-chevron-up';
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$operator = '';
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('OPERATOR', $operator);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$transformedSearchParams = $this->listViewModel->getQueryGenerator()->parseBaseSearchParamsToCondition($searchParams);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!empty($searchResult) && \is_array($searchResult)) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->listViewLinks = $this->listViewModel->getListViewLinks($linkParams);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$nextSortOrder = 'ASC';
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (empty($pageNumber)) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!empty($searchKey) && !empty($searchValue)) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->listViewModel->set('search_value', $searchValue);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
//To make smarty to get the details easily accesible
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->listViewHeaders = $this->listViewModel->getListViewHeaders();
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('LISTVIEW_LINKS', $this->listViewLinks);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$pagingModel->set('totalCount', (int) $this->listViewCount);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('IS_MODULE_DELETABLE', $this->listViewModel->getModule()->isPermitted('Delete'));
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('SEARCH_PARAMS', $searchParamsRaw);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
'modules.Vtiger.resources.List',
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->view('ListViewContents.tpl', $request->getModule(false));
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @param \App\Request $request
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @param Vtiger_Viewer $viewer
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->listViewModel->set('sortorder', $sortOrder);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$operator = $request->getByType('operator');
- Exclude checks
Line exceeds 120 characters; contains 126 characters Open
$transformedSearchParams = $this->listViewModel->getQueryGenerator()->parseBaseSearchParamsToCondition($searchParams);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->listViewCount = 0;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('MODULE_MODEL', $this->listViewModel->getModule());
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('LOCKED_EMPTY_FIELDS', $request->isEmpty('lockedEmptyFields', true) ? [] : $request->getArray('lockedEmptyFields'));
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
use \App\Controller\Traits\SettingsPermission;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/** {@inheritdoc} */
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$searchResult = $request->get('searchResult');
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ('ASC' == $sortOrder) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('MODULE', $moduleName);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('NEXT_SORT_ORDER', $nextSortOrder);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$orderBy = $moduleInstance->default_order_by;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$searchParams = App\Condition::validSearchParams($moduleName, $request->getArray('search_params'));
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->listViewModel->loadSearchLockedFields($request);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$moduleName = $request->getModule();
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*/
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @param \App\Request $request
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$result = [];
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$sortOrder = $request->getForSql('sortorder');
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$sortImage = 'fas fa-chevron-down';
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!$this->listViewEntries) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('QUALIFIED_MODULE', $moduleName);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$pageCount = $pagingModel->getPageCount();
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('USER_MODEL', Users_Record_Model::getCurrentUserModel());
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*/
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/**
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$searchValue = $request->get('search_value');
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$operator = $request->getByType('operator');
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$listViewModel->set('search_value', $searchValue);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$response->emit();
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$searchParamsRaw = $searchParams = [[['status', 'e', 'Active']]];
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
foreach ($request->getArray('search_params') as $fieldListGroup) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('VIEW_MODEL', $this->listViewModel);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* Function to get listView count.
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!empty($operator)) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*/
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$pageCount = 1;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!$request->isEmpty('operator', true)) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!$request->isEmpty('search_key', true)) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('ALPHABET_VALUE', $searchValue);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('LISTVIEW_ENTRIES_COUNT', $noOfEntries);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!isset($this->listViewCount)) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
]));
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function process(App\Request $request)
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$pageNumber = $request->getInteger('page');
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$pagingModel->set('page', $pageNumber);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->listViewModel->set('operator', $operator);
- Exclude checks
Line exceeds 120 characters; contains 140 characters Open
$searchValue = App\Condition::validSearchValue($request->getByType('search_value', 'Text'), $moduleName, $searchKey, $operator);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!isset($this->listViewLinks)) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('ADVANCED_CONDITIONS', []);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @param \App\Request $request
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (empty($cvId)) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$listViewModel->set('operator', $operator);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$pageLimit = $pagingModel->getPageLimit();
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$response = new Vtiger_Response();
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getFooterScripts(App\Request $request)
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer = $this->getViewer($request);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$orderBy = $request->getForSql('orderby');
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (empty($orderBy) && empty($sortOrder)) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$moduleInstance = CRMEntity::getInstance($moduleName);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$nextSortOrder = 'DESC';
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$searchParams[$fieldName] = $fieldSearchInfo;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->listViewModel->getQueryGenerator()->addNativeCondition(['vtiger_crmentity.crmid' => $searchResult]);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('PAGING_MODEL', $pagingModel);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('PAGE_NUMBER', $pageNumber);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('COLUMN_NAME', $orderBy);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('PAGE_COUNT', $pageCount);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/**
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getRecordsCount(App\Request $request)
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @param \App\Request $request
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$searchParams = App\Condition::validSearchParams($moduleName, $request->getArray('search_params'));
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$pageCount = ceil((int) $listViewCount / (int) $pageLimit);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return array_merge(parent::getFooterScripts($request), $this->checkAndConvertJsScripts([
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->initializeListViewContents($request, $viewer);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
} else {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->listViewModel = Vtiger_ListView_Model::getInstance($moduleName, $cvId);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$fieldSearchInfo['fieldName'] = $fieldName = $fieldSearchInfo[0] ?? '';
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('LISTVIEW_MASSACTIONS', $linkModels['LISTVIEWMASSACTION']);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('SORT_IMAGE', $sortImage);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('ALPHABET_VALUE', $searchValue ?? '');
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->listViewCount = $this->listViewModel->getListViewCount();
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('VIEW', $request->getByType('view', 1));
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (empty($searchParams) || !\is_array($searchParams)) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* Function to get the page count for list.
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @var Vtiger_ListView_Model
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*/
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function initializeListViewContents(App\Request $request, Vtiger_Viewer $viewer)
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$linkParams = ['MODULE' => $moduleName, 'ACTION' => $request->getByType('view', 1), 'CVID' => $cvId];
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!empty($orderBy)) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$searchValue = App\Condition::validSearchValue($request->getByType('search_value', 'Text'), $moduleName, $searchKey, $operator);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!$this->listViewHeaders) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$this->listViewEntries = $this->listViewModel->getListViewEntries($pagingModel);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$viewer->assign('ORDER_BY', $orderBy);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$cvId = $request->getByType('viewname', 2);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
/**
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$result['page'] = $pageCount;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$result['module'] = $moduleName;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$result['viewname'] = $cvId;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$response = new Vtiger_Response();
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$response->setEmitType(Vtiger_Response::$EMIT_JSON);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getListViewCount(App\Request $request)
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$moduleName = $request->getModule();
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$pagingModel = new Vtiger_Paging_Model();
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$response->setResult($result);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (0 == $pageCount) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$cvId = '0';
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$count = $this->getListViewCount($request);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$searchKey = $request->getByType('search_key', 2);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$listViewModel->set('search_params', $transformedSearchParams);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$listViewModel->set('search_key', $searchKey);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$listViewCount = $this->getListViewCount($request);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
{
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$cvId = App\CustomView::getInstance($moduleName)->getViewId();
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
* @return total number of pages
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if (!empty($searchKey) && !empty($searchValue)) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return $listViewModel->getListViewCount();
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$result['count'] = $count;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$response->emit();
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$listViewModel = Vtiger_ListView_Model::getInstance($moduleName, $cvId);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
*
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$result['numberOfRecords'] = $listViewCount;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$result = [];
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$response->setResult($result);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$searchParams = [];
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$transformedSearchParams = $listViewModel->getQueryGenerator()->parseBaseSearchParamsToCondition($searchParams);
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function getPageCount(App\Request $request)
- Exclude checks
Class name "Users_List_View" is not in camel caps format Open
class Users_List_View extends Settings_Vtiger_List_View
- Exclude checks