Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
modules/Vtiger/models/TreeCategoryModal.php

Summary

Maintainability
B
4 hrs
Test Coverage
F
0%

Method getTreeList has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getTreeList()
    {
        $trees = [];
        $isDeletable = $this->getRelationModel()->privilegeToTreeDelete();
        $lastId = 0;
Severity: Minor
Found in modules/Vtiger/models/TreeCategoryModal.php - About 1 hr to fix

    Method getRecords has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getRecords()
    {
        $selectedRecords = $this->getSelectedRecords();
        $isDeletable = $this->isDeletable();
        if (2 == $this->getRelationType()) {
    Severity: Minor
    Found in modules/Vtiger/models/TreeCategoryModal.php - About 1 hr to fix

      Function getTreeList has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getTreeList()
    {
        $trees = [];
        $isDeletable = $this->getRelationModel()->privilegeToTreeDelete();
        $lastId = 0;
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getRecords has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getRecords()
    {
        $selectedRecords = $this->getSelectedRecords();
        $isDeletable = $this->isDeletable();
        if (2 == $this->getRelationType()) {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Missing class import via use statement (line '47', column '21').
      Open

              $fieldTemp = (new \App\Db\Query())->select(['tablename', 'columnname', 'fieldname', 'fieldlabel', 'fieldparams'])->from('vtiger_field')->where(['uitype' => 302, 'tabid' => \App\Module::getModuleId($this->getModuleName())])->one();
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '128', column '22').
      Open

              $dataReader = (new App\Db\Query())
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '172', column '15').
      Open

              return (new App\Db\Query())->select(['tree'])->from('u_#__crmentity_rel_tree')
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The method getSelectedRecords has a boolean flag argument $onlyKeys, which is a certain sign of a Single Responsibility Principle violation.
      Open

          private function getSelectedRecords($onlyKeys = true)
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Avoid using static access to class '\App\Language' in method 'getTreeList'.
      Open

                      'text' => \App\Language::translate($row['name'], $this->getModuleName()),
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'Vtiger_Relation_Model' in method 'getRelationModel'.
      Open

                  $this->relationModel = Vtiger_Relation_Model::getInstance($srcModuleModel, $this->get('module'));
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method getRecords uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            $listEntries = $this->getSelectedRecords(false);
        }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class 'Vtiger_Record_Model' in method 'getSelectedRecords'.
      Open

              $parentRecordModel = Vtiger_Record_Model::getInstanceById($this->get('srcRecord'), $this->get('srcModule'));
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'Vtiger_Loader' in method 'getInstance'.
      Open

              $modelClassName = Vtiger_Loader::getComponentClassName('Model', 'TreeCategoryModal', $moduleName);
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\App\Module' in method 'getTreeField'.
      Open

              $fieldTemp = (new \App\Db\Query())->select(['tablename', 'columnname', 'fieldname', 'fieldlabel', 'fieldparams'])->from('vtiger_field')->where(['uitype' => 302, 'tabid' => \App\Module::getModuleId($this->getModuleName())])->one();
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'Vtiger_RelationListView_Model' in method 'getSelectedRecords'.
      Open

              $relationListView = Vtiger_RelationListView_Model::getInstance($parentRecordModel, $this->getModuleName());
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'Vtiger_ListView_Model' in method 'getAllRecords'.
      Open

              $listViewModel = Vtiger_ListView_Model::getInstanceForPopup($this->getModuleName(), $this->get('srcModule'));
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'Vtiger_Module_Model' in method 'getRelationModel'.
      Open

                  $srcModuleModel = Vtiger_Module_Model::getInstance($this->get('srcModule'));
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Define a constant instead of duplicating this literal "fieldTemp" 3 times.
      Open

              if ($this->has('fieldTemp')) {
      Severity: Critical
      Found in modules/Vtiger/models/TreeCategoryModal.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Define a constant instead of duplicating this literal "relationType" 4 times.
      Open

              if ($this->has('relationType')) {
      Severity: Critical
      Found in modules/Vtiger/models/TreeCategoryModal.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Define a constant instead of duplicating this literal "category" 4 times.
      Open

                      'type' => 'category',
      Severity: Critical
      Found in modules/Vtiger/models/TreeCategoryModal.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Define a constant instead of duplicating this literal "fieldname" 3 times.
      Open

              $fieldTemp = (new \App\Db\Query())->select(['tablename', 'columnname', 'fieldname', 'fieldlabel', 'fieldparams'])->from('vtiger_field')->where(['uitype' => 302, 'tabid' => \App\Module::getModuleId($this->getModuleName())])->one();
      Severity: Critical
      Found in modules/Vtiger/models/TreeCategoryModal.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Define a constant instead of duplicating this literal "srcModule" 5 times.
      Open

                  $srcModuleModel = Vtiger_Module_Model::getInstance($this->get('srcModule'));
      Severity: Critical
      Found in modules/Vtiger/models/TreeCategoryModal.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Define a constant instead of duplicating this literal "module" 3 times.
      Open

              $instance->set('module', $moduleModel)->set('moduleName', $moduleName);
      Severity: Critical
      Found in modules/Vtiger/models/TreeCategoryModal.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Define a constant instead of duplicating this literal "srcRecord" 3 times.
      Open

                  ->where(['crmid' => $this->get('srcRecord'), 'relmodule' => $this->get('module')->getId()])
      Severity: Critical
      Found in modules/Vtiger/models/TreeCategoryModal.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Call to undeclared method \App\Db\Query::from
      Open

              $dataReader = (new App\Db\Query())
      Severity: Critical
      Found in modules/Vtiger/models/TreeCategoryModal.php by phan

      Call to method setField from undeclared class \App\QueryGenerator (Did you mean class \Tests\App\QueryGenerator)
      Open

              $listViewModel->getQueryGenerator()->setField($this->getTreeField()['fieldname']);
      Severity: Critical
      Found in modules/Vtiger/models/TreeCategoryModal.php by phan

      Call to undeclared method \App\Db\Query::select
      Open

              $fieldTemp = (new \App\Db\Query())->select(['tablename', 'columnname', 'fieldname', 'fieldlabel', 'fieldparams'])->from('vtiger_field')->where(['uitype' => 302, 'tabid' => \App\Module::getModuleId($this->getModuleName())])->one();
      Severity: Critical
      Found in modules/Vtiger/models/TreeCategoryModal.php by phan

      Return type of getTemplate() is undeclared type \type
      Open

          public function getTemplate()
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phan

      Reference to undeclared property \Vtiger_TreeCategoryModal_Model->lastIdinTree
      Open

                      'id' => $this->lastIdinTree,
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phan

      Reference to undeclared property \Vtiger_TreeCategoryModal_Model->relationModel
      Open

                  $this->relationModel = Vtiger_Relation_Model::getInstance($srcModuleModel, $this->get('module'));
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phan

      Saw possibly unextractable annotation for a fragment of comment '* @param string name of the module': after string, did not see an element name (will guess based on comment order)
      Open

           * @param string name of the module
      Severity: Info
      Found in modules/Vtiger/models/TreeCategoryModal.php by phan

      Call to undeclared method \App\Db\Query::select
      Open

              return (new App\Db\Query())->select(['tree'])->from('u_#__crmentity_rel_tree')
      Severity: Critical
      Found in modules/Vtiger/models/TreeCategoryModal.php by phan

      Reference to undeclared property \Vtiger_TreeCategoryModal_Model->lastIdinTree
      Open

                  ++$this->lastIdinTree;
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phan

      Returning type array<int>|array<int>|array<int>|array<int>|array{}</int></int></int></int> but getTreeList() is declared to return string
      Open

              return $trees;
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phan

      Argument 1 (arr1) is string but \array_merge() takes array
      Open

              return array_merge($this->getTreeList(), $this->getRecords());
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phan

      Reference to undeclared property \Vtiger_TreeCategoryModal_Model->lastIdinTree
      Open

              $this->lastIdinTree = $lastId;
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phan

      Reference to undeclared property \Vtiger_TreeCategoryModal_Model->relationModel
      Open

              if (!isset($this->relationModel)) {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phan

      Reference to undeclared property \Vtiger_TreeCategoryModal_Model->relationModel
      Open

              return $this->relationModel;
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phan

      Each class must be in a namespace of at least one level (a top-level vendor name)
      Open

      class Vtiger_TreeCategoryModal_Model extends \App\Base
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      The class Vtiger_TreeCategoryModal_Model is not named in CamelCase.
      Open

      class Vtiger_TreeCategoryModal_Model extends \App\Base
{
    public static $_cached_instance;

    /**
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpmd

      CamelCaseClassName

      Since: 0.2

      It is considered best practice to use the CamelCase notation to name classes.

      Example

      class class_name {
}

      Source

      The property $_cached_instance is not named in camelCase.
      Open

      class Vtiger_TreeCategoryModal_Model extends \App\Base
{
    public static $_cached_instance;

    /**
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpmd

      CamelCasePropertyName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name attributes.

      Example

      class ClassName {
    protected $property_name;
}

      Source

      Property name "$_cached_instance" should not be prefixed with an underscore to indicate visibility
      Open

          public static $_cached_instance;
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * @return array
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          /**
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              return $this->getRelationModel()->privilegeToDelete();
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * Load tree.
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $trees = [];
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      'type' => 'category',
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      $tree['state']['disabled'] = true;
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public static $_cached_instance;
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           */
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          /**
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $selected = $this->getSelectedTreeList();
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              return $this->get('moduleName');
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public function getTemplate()
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           *
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              return $fieldTemp;
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public static function getInstance(Vtiger_Module_Model $moduleModel)
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * @return mixed
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if ($this->has('relationType')) {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          /**
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $lastId = 0;
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              while ($row = $dataReader->read()) {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  if (!$isDeletable && $checked) {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Line exceeds 120 characters; contains 238 characters
      Open

              $fieldTemp = (new \App\Db\Query())->select(['tablename', 'columnname', 'fieldname', 'fieldlabel', 'fieldparams'])->from('vtiger_field')->where(['uitype' => 302, 'tabid' => \App\Module::getModuleId($this->getModuleName())])->one();
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * @param Vtiger_Module_Model $moduleModel
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              self::$_cached_instance[$moduleName] = $instance;
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * @return bool|\Vtiger_Relation_Model
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public function getRelationModel()
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           */
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public function getRelationType()
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * @return bool
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  ->where(['templateid' => $this->getTemplate()])
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          /**
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * @return string Module name
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  return $this->get('fieldTemp');
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $this->set('fieldTemp', $fieldTemp);
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if (isset(self::$_cached_instance[$moduleName])) {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  return self::$_cached_instance[$moduleName];
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              return $this->relationModel;
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           *
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * @return string
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          private function getTreeList()
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $pieces = explode('::', $row['parentTree']);
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $tree = [
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  if (!empty($row['icon'])) {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           *
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           *
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           */
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           */
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public function getTreeData()
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * Load tree ID.
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          /**
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $this->relationModel = Vtiger_Relation_Model::getInstance($srcModuleModel, $this->get('module'));
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           *
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      'text' => \App\Language::translate($row['name'], $this->getModuleName()),
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  ];
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  if ($treeID > $lastId) {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           */
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $fieldTemp = (new \App\Db\Query())->select(['tablename', 'columnname', 'fieldname', 'fieldlabel', 'fieldparams'])->from('vtiger_field')->where(['uitype' => 302, 'tabid' => \App\Module::getModuleId($this->getModuleName())])->one();
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * Static Function to get the instance of Vtiger TreeView Model for the given Vtiger Module Model.
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * Function check if record is deletable.
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $isDeletable = $this->getRelationModel()->privilegeToTreeDelete();
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $checked = \in_array($row['tree'], $selected);
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           *
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * Gets relation model.
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           *
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $treeID = (int) ltrim($row['tree'], 'T');
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public function getModuleName()
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           */
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          /**
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public function isDeletable()
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  ->from('vtiger_trees_templates_data')
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * Function to get the Module Name.
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * @return type
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  return $this->get('relationType');
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           *
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           */
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      'id' => $treeID,
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      'parent' => 0 == $parent ? '#' : $parent,
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          /**
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * Load tree field info.
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $instance = new $modelClassName();
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * Gets relation type.
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          /**
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           */
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              return array_merge($this->getTreeList(), $this->getRecords());
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  if ($checked) {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      $tree['category'] = ['checked' => true];
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          public function getTreeField()
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $srcModuleModel = Vtiger_Module_Model::getInstance($this->get('srcModule'));
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              return $this->get('relationType');
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $dataReader = (new App\Db\Query())
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $parent = (int) ltrim(prev($pieces), 'T');
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      $lastId = $treeID;
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           *
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * @return Vtiger_TreeView_Model instance
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $instance->set('module', $moduleModel)->set('moduleName', $moduleName);
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if ($this->has('fieldTemp')) {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $moduleName = $moduleModel->get('name');
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $modelClassName = Vtiger_Loader::getComponentClassName('Model', 'TreeCategoryModal', $moduleName);
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              return self::$_cached_instance[$moduleName];
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  ->createCommand()->query();
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $trees[] = $tree;
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          /**
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $listEntries = $this->getSelectedRecords(false);
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      'category' => ['checked' => $selected]
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $isDeletable = $this->isDeletable();
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $parent = (int) ltrim($item->get($fieldName), 'T');
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              return $listViewModel->getAllEntries();
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if (2 == $this->getRelationType()) {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $tree = [];
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  ++$this->lastIdinTree;
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  if (!$isDeletable && $selected) {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              return $this->getTreeField()['fieldparams'];
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * @param string name of the module
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if (!isset($this->relationModel)) {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $this->set('relationType', $this->getRelationModel()->getRelationType());
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  end($pieces);
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      'record_id' => $row['tree'],
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      $tree['icon'] = $row['icon'];
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  ->where(['crmid' => $this->get('srcRecord'), 'relmodule' => $this->get('module')->getId()])
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $listViewModel = Vtiger_ListView_Model::getInstanceForPopup($this->getModuleName(), $this->get('srcModule'));
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              return $entries;
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              } else {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      'parent' => 0 == $parent ? '#' : $parent,
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $listViewModel->getQueryGenerator()->setField($this->getTreeField()['fieldname']);
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $fieldName = $this->getTreeField()['fieldname'];
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $tree[] = [
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      'text' => $item->getName(),
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          private function getSelectedTreeList()
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              return (new App\Db\Query())->select(['tree'])->from('u_#__crmentity_rel_tree')
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $parentRecordModel = Vtiger_Record_Model::getInstanceById($this->get('srcRecord'), $this->get('srcModule'));
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if (!empty($this->get('srcModule'))) {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $selectedRecords = $this->getSelectedRecords();
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      'id' => $this->lastIdinTree,
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      'record_id' => $item->getId(),
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              return $tree;
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           *
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  ];
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $listViewModel->set('src_module', $this->get('srcModule'));
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      'type' => 'category',
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      'attr' => 'record',
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           */
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          private function getSelectedRecords($onlyKeys = true)
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $listViewModel->set('src_record', $this->get('srcRecord'));
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $listEntries = $this->getAllRecords();
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $this->lastIdinTree = $lastId;
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $relationListView = Vtiger_RelationListView_Model::getInstance($parentRecordModel, $this->getModuleName());
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              $entries = $relationListView->getAllEntries();
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $state = ['selected' => $selected];
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      $state['disabled'] = true;
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          private function getAllRecords()
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * Function to get selected item in the tree.
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      'state' => $state,
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              }
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  ->column();
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  return array_keys($entries);
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              foreach ($listEntries as $item) {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              return $trees;
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

           * @return array
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

              if ($onlyKeys) {
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

          private function getRecords()
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                  $selected = \in_array($item->getId(), $selectedRecords);
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Spaces must be used to indent lines; tabs are not allowed
      Open

                      'icon' => "js-detail__icon yfm-{$this->getModuleName()}",
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      Class name "Vtiger_TreeCategoryModal_Model" is not in camel caps format
      Open

      class Vtiger_TreeCategoryModal_Model extends \App\Base
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpcodesniffer

      The variable $_cached_instance is not named in camelCase.
      Open

          public static function getInstance(Vtiger_Module_Model $moduleModel)
    {
        $moduleName = $moduleModel->get('name');
        if (isset(self::$_cached_instance[$moduleName])) {
            return self::$_cached_instance[$moduleName];
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $_cached_instance is not named in camelCase.
      Open

          public static function getInstance(Vtiger_Module_Model $moduleModel)
    {
        $moduleName = $moduleModel->get('name');
        if (isset(self::$_cached_instance[$moduleName])) {
            return self::$_cached_instance[$moduleName];
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $_cached_instance is not named in camelCase.
      Open

          public static function getInstance(Vtiger_Module_Model $moduleModel)
    {
        $moduleName = $moduleModel->get('name');
        if (isset(self::$_cached_instance[$moduleName])) {
            return self::$_cached_instance[$moduleName];
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      The variable $_cached_instance is not named in camelCase.
      Open

          public static function getInstance(Vtiger_Module_Model $moduleModel)
    {
        $moduleName = $moduleModel->get('name');
        if (isset(self::$_cached_instance[$moduleName])) {
            return self::$_cached_instance[$moduleName];
      Severity: Minor
      Found in modules/Vtiger/models/TreeCategoryModal.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

      Source

      There are no issues that match your filters.

      Category
      Status