Function getNextTriggerTimeForWeekly has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.

Open

    public function getNextTriggerTimeForWeekly($scheduledDaysOfWeek, $scheduledTime)
    {
        $weekDays = ['1' => 'Monday', '2' => 'Tuesday', '3' => 'Wednesday', '4' => 'Thursday', '5' => 'Friday', '6' => 'Saturday', '7' => 'Sunday'];
        $currentTime = time();
        $currentWeekDay = date('N', $currentTime);

• Read up
  Read up

File Workflow.php has 338 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php
/* +**********************************************************************************
 * The contents of this file are subject to the vtiger CRM Public License Version 1.0
 * ("License"); You may not use this file except in compliance with the License
 * The Original Code is:  vtiger CRM Open Source

The class Workflow has an overall complexity of 74 which is very high. The configured complexity threshold is 50.

Open

class Workflow
{
    /**
     * Scheduled hourly.
     *

• Exclude checks
  • Disable engine
  • Disable check

Function getNextTriggerTimeForMonthlyByDate has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.

Open

    public function getNextTriggerTimeForMonthlyByDate($scheduledDayOfMonth, $scheduledTime)
    {
        $currentDayOfMonth = date('j', time());
        if ($scheduledDayOfMonth) {
            $scheduledDaysOfMonth = \App\Json::decode($scheduledDayOfMonth);

• Read up
  Read up

Function performTasks has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.

Open

    public function performTasks(Vtiger_Record_Model $recordModel, ?array $tasks = null)
    {
        require_once 'modules/com_vtiger_workflow/VTTaskManager.php';
        require_once 'modules/com_vtiger_workflow/VTTaskQueue.php';

• Read up
  Read up

Workflow has 21 functions (exceeds 20 allowed). Consider refactoring.

Open

class Workflow
{
    /**
     * Scheduled hourly.
     *

Function getNextTriggerTimeForAnnualDates has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.

Open

    public function getNextTriggerTimeForAnnualDates($annualDates, $scheduledTime)
    {
        if ($annualDates) {
            $today = date('Y-m-d');
            $annualDates = \App\Json::decode($annualDates);

• Read up
  Read up

Method getNextTriggerTime has 52 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function getNextTriggerTime()
    {
        $default_timezone = \App\Config::main('default_timezone');
        $admin = Users::getActiveAdminUser();
        $adminTimeZone = $admin->time_zone;

Function getNextTriggerTime has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.

Open

    public function getNextTriggerTime()
    {
        $default_timezone = \App\Config::main('default_timezone');
        $admin = Users::getActiveAdminUser();
        $adminTimeZone = $admin->time_zone;

• Read up
  Read up

Method getNextTriggerTimeForWeekly has 39 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function getNextTriggerTimeForWeekly($scheduledDaysOfWeek, $scheduledTime)
    {
        $weekDays = ['1' => 'Monday', '2' => 'Tuesday', '3' => 'Wednesday', '4' => 'Thursday', '5' => 'Friday', '6' => 'Saturday', '7' => 'Sunday'];
        $currentTime = time();
        $currentWeekDay = date('N', $currentTime);

Method getNextTriggerTimeForMonthlyByDate has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function getNextTriggerTimeForMonthlyByDate($scheduledDayOfMonth, $scheduledTime)
    {
        $currentDayOfMonth = date('j', time());
        if ($scheduledDayOfMonth) {
            $scheduledDaysOfMonth = \App\Json::decode($scheduledDayOfMonth);

Method getNextTriggerTimeForAnnualDates has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function getNextTriggerTimeForAnnualDates($annualDates, $scheduledTime)
    {
        if ($annualDates) {
            $today = date('Y-m-d');
            $annualDates = \App\Json::decode($annualDates);

The method getNextTriggerTime() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.

Open

    public function getNextTriggerTime()
    {
        $default_timezone = \App\Config::main('default_timezone');
        $admin = Users::getActiveAdminUser();
        $adminTimeZone = $admin->time_zone;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

The method getNextTriggerTimeForWeekly() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.

Open

    public function getNextTriggerTimeForWeekly($scheduledDaysOfWeek, $scheduledTime)
    {
        $weekDays = ['1' => 'Monday', '2' => 'Tuesday', '3' => 'Wednesday', '4' => 'Thursday', '5' => 'Friday', '6' => 'Saturday', '7' => 'Sunday'];
        $currentTime = time();
        $currentWeekDay = date('N', $currentTime);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed.

Open

    public function performTasks(Vtiger_Record_Model $recordModel, ?array $tasks = null)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Class "Workflow" has 21 methods, which is greater than 20 authorized. Split it into smaller classes.

Open

class Workflow

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed.

Open

    public function getNextTriggerTimeForMonthlyByDate($scheduledDayOfMonth, $scheduledTime)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Refactor this function to reduce its Cognitive Complexity from 36 to the 15 allowed.

Open

    public function getNextTriggerTimeForWeekly($scheduledDaysOfWeek, $scheduledTime)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

The class Workflow has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13.

Open

class Workflow
{
    /**
     * Scheduled hourly.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Missing class import via use statement (line '186', column '30').

Open

        $queryWorkflowTasks = (new \App\Db\Query())->from('com_vtiger_workflowtasks')

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '218', column '13').

Open

        $tm = new VTTaskManager();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '219', column '20').

Open

        $taskQueue = new VTTaskQueue();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '133', column '34').

Open

        $this->conditionStrategy = new VTJsonCondition();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '309', column '15').

Open

        return (new DateTimeField($this->schtime))->getDisplayTime();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '185', column '33').

Open

        $isExistsActivateDonce = (new \App\Db\Query())->from('com_vtiger_workflow_activatedonce')->where(['entity_id' => $recordId, 'workflow_id' => $this->id])->exists();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '389', column '29').

Open

                    $firstWorkingDay = new DateTime($nextTime);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '393', column '30').

Open

                    $firstDayNextWeek = new DateTime('monday next week');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '397', column '31').

Open

                    $firstDayNextMonth = new DateTime('first day of next month');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method performTasks uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

                } else {
                    $delay = 0;
                }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method getNextTriggerTimeForMonthlyByWeekDay uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $monthInFullText = date('F', $currentTime);
            $yearFullNumberic = date('Y', $currentTime);
            if ($scheduledWeekDayOfMonth < $currentDayOfMonth) {
                $nextMonth = date('Y-m-d H:i:s', strtotime('first day of next month'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\App\Fields\Date' in method 'getNextTriggerTime'.

Open

                    $nextTime = \App\Fields\Date::getWorkingDayFromDate($firstWorkingDay, '+0 day') . ' ' . $this->getWFScheduleTime();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method getNextTriggerTimeForDaily uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $nextTime = date('Y-m-d H:i:s', $todayScheduledTime);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\App\Json' in method 'getNextTriggerTimeForAnnualDates'.

Open

            $annualDates = \App\Json::decode($annualDates);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Config' in method 'getNextTriggerTime'.

Open

        $default_timezone = \App\Config::main('default_timezone');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Fields\Date' in method 'getNextTriggerTime'.

Open

                    $nextTime = \App\Fields\Date::getWorkingDayFromDate($firstDayNextMonth, '+0 day') . ' ' . $this->getWFScheduleTime();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method getNextTriggerTimeForAnnualDates uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $nextTriggerDay = $annualDates[0];
                $nextTime = date('Y:m:d H:i:s', strtotime($nextTriggerDay . ' ' . $scheduledTime . '+1 year'));
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\App\Json' in method 'getNextTriggerTimeForMonthlyByDate'.

Open

            $scheduledDaysOfMonth = \App\Json::decode($scheduledDayOfMonth);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'Users' in method 'getNextTriggerTime'.

Open

        $admin = Users::getActiveAdminUser();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method getNextTriggerTimeForMonthlyByDate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

                } else {
                    $firstDayofNextMonth = date('Y:m:d H:i:s', strtotime('first day of next month'));
                    $nextTime = date('Y:m:d', strtotime($firstDayofNextMonth . ' + ' . ($scheduledDaysOfMonth[0] - 1) . ' days'));
                    $nextTime = $nextTime . ' ' . $scheduledTime;
                }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method performTasks uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

                } else {
                    $hasContents = $task->hasContents($recordModel);
                    if ($hasContents) {
                        $taskQueue->queueTask($task->id, $recordModel->getId(), $delay, $task->getContents($recordModel));
                    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method getNextTriggerTimeForWeekly uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

                    } else {
                        $nextTime = date('Y-m-d H:i:s', strtotime($weekDays[$scheduledDaysOfWeek[0]] . ' ' . $scheduledTime));
                    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method getNextTriggerTimeForWeekly uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

                            } else {
                                $nextWeekDay = $scheduledDaysOfWeek[$index + 1]; // its the last day of the week i.e. sunday
                                if (empty($nextWeekDay)) {
                                    $nextWeekDay = $scheduledDaysOfWeek[0];
                                }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\App\Json' in method 'getNextTriggerTimeForWeekly'.

Open

            $scheduledDaysOfWeek = \App\Json::decode($scheduledDaysOfWeek);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Fields\Date' in method 'getNextTriggerTime'.

Open

                    $nextTime = \App\Fields\Date::getWorkingDayFromDate($firstDayNextWeek, '+0 day') . ' ' . $this->getWFScheduleTime();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Define a constant instead of duplicating this literal "Y:m:d H:i:s" 4 times.

Open

                    $firstDayofNextMonth = date('Y:m:d H:i:s', strtotime('first day of this month'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Add a "case default" clause to this "switch" statement.

Open

        switch ($this->getWFScheduleType()) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

switch ($param) {  //missing default clause
  case 0:
    do_something();
    break;
  case 1:
    do_something_else();
    break;
}

switch ($param) {
  default: // default clause should be the last one
    error();
    break;
  case 0:
    do_something();
    break;
  case 1:
    do_something_else();
    break;
}

switch ($param) {
  case 0:
    do_something();
    break;
  case 1:
    do_something_else();
    break;
  default:
    error();
    break;
}

Define a constant instead of duplicating this literal "+0 day" 3 times.

Open

                    $nextTime = \App\Fields\Date::getWorkingDayFromDate($firstWorkingDay, '+0 day') . ' ' . $this->getWFScheduleTime();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "Y-m-d H:i:s" 14 times.

Open

                $nextTime = date('Y-m-d H:i:s', strtotime('+5 minutes'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "workflow_id" 5 times.

Open

        $this->id = $row['workflow_id'] ?? '';

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "Y-m-d" 5 times.

Open

                        $scheduleWeekDayInTime = strtotime(date('Y-m-d', strtotime($weekDays[$currentWeekDay])) . ' ' . $scheduledTime);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "first day of next month" 3 times.

Open

                    $firstDayNextMonth = new DateTime('first day of next month');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "entity_id" 3 times.

Open

        $isExistsActivateDonce = (new \App\Db\Query())->from('com_vtiger_workflow_activatedonce')->where(['entity_id' => $recordId, 'workflow_id' => $this->id])->exists();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Reference to undeclared property \Workflow->test

Open

        $this->test = $row['test'] ?? '';

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->filtersavedinnew

Open

        $this->filtersavedinnew = $row['filtersavedinnew'] ?? '';

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->nexttrigger_time

Open

        $this->nexttrigger_time = $row['nexttrigger_time'] ?? '';

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (annualDates) is bool but \Workflow::getNextTriggerTimeForAnnualDates() takes \json defined at /code/modules/com_vtiger_workflow/Workflow.php:568

Open

                    $nextTime = $this->getNextTriggerTimeForAnnualDates($this->getWFScheduleAnnualDates(), $this->getWFScheduleTime());

• Exclude checks
  • Disable engine
  • Disable check

Parameter $scheduledTime has undeclared type \time

Open

    public function getNextTriggerTimeForWeekly($scheduledDaysOfWeek, $scheduledTime)

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \timestamp of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

                $nextTime = date('Y:m:d H:i:s', strtotime($nextTriggerDay . ' ' . $scheduledTime . '+1 year'));

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->executionCondition

Open

        $this->executionCondition = $row['execution_condition'] ?? '';

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->schdayofweek

Open

        $this->schdayofweek = $row['schdayofweek'] ?? '';

• Exclude checks
  • Disable engine
  • Disable check

Return type of getNextTriggerTimeForWeekly() is undeclared type \time

Open

    public function getNextTriggerTimeForWeekly($scheduledDaysOfWeek, $scheduledTime)

• Exclude checks
  • Disable engine
  • Disable check

Assigning array{10:'LBL_5_MINUTES',9:'LBL_15_MINUTES',8:'LBL_30_MINUTES',1:'LBL_HOURLY',2:'LBL_DAILY',3:'LBL_WEEKLY',4:'LBL_SPECIFIC_DATE',5:'LBL_MONTHLY_BY_DATE',6:'LBL_MONTHLY_BY_WEEKDAY',7:'LBL_YEARLY',11:'LBL_WORKINGDAY_DAY',12:'LBL_WORKINGDAY_WEEK',13:'LBL_WORKINGDAY_MONTH'} to property but \Workflow::$SCHEDULED_LIST is int[]

Open

    public static $SCHEDULED_LIST = [

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->description

Open

        $this->description = $row['summary'] ?? '';

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db::createCommand

Open

            \App\Db::getInstance()->createCommand()->update('com_vtiger_workflows', ['nexttrigger_time' => $time], ['workflow_id' => $this->id])->execute();

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->id

Open

            \App\Db::getInstance()->createCommand()->update('com_vtiger_workflows', ['nexttrigger_time' => $time], ['workflow_id' => $this->id])->execute();

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (time) is \time but \DateTime::__construct() takes ?string

Open

                    $firstWorkingDay = new DateTime($nextTime);

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \time of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

                        $nextTime = date('Y-m-d H:i:s', strtotime($weekDays[$nextTriggerWeekDay] . ' ' . $scheduledTime));

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->id

Open

        foreach ($tm->getTasksForWorkflow($this->id) as $task) {

• Exclude checks
  • Disable engine
  • Disable check

Parameter $time has undeclared type \timestamp

Open

    public function setNextTriggerTime($time)

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->schtime

Open

        return $this->schtime;

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \timestamp of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

            $nextTime = date('Y-m-d H:i:s', strtotime('+1 month ' . $scheduledTime));

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->schtypeid

Open

        $this->schtypeid = $row['schtypeid'] ?? '';

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->schtypeid

Open

        return 6 == $this->executionCondition ? $this->schtypeid : 0;

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (encodedValue) is \json but \App\Json::decode() takes string defined at /code/app/Json.php:37

Open

            $scheduledDaysOfWeek = \App\Json::decode($scheduledDaysOfWeek);

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \time of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

                                $nextTime = date('Y-m-d', strtotime('next ' . $weekDays[$weekDay])) . ' ' . $scheduledTime;

• Exclude checks
  • Disable engine
  • Disable check

Returning type null|string but getNextTriggerTimeForWeekly() is declared to return \time

Open

        return $nextTime;

• Exclude checks
  • Disable engine
  • Disable check

Parameter $scheduledTime has undeclared type \timestamp

Open

    public function getNextTriggerTimeForAnnualDates($annualDates, $scheduledTime)

• Exclude checks
  • Disable engine
  • Disable check

Return type of getNextTriggerTimeForAnnualDates() is undeclared type \time

Open

    public function getNextTriggerTimeForAnnualDates($annualDates, $scheduledTime)

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->id

Open

        $isExistsActivateDonce = (new \App\Db\Query())->from('com_vtiger_workflow_activatedonce')->where(['entity_id' => $recordId, 'workflow_id' => $this->id])->exists();

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (scheduledTime) is \timestamp but \Workflow::getNextTriggerTimeForMonthlyByDate() takes int defined at /code/modules/com_vtiger_workflow/Workflow.php:492

Open

                    $nextTime = $this->getNextTriggerTimeForMonthlyByDate($this->getWFScheduleDay(), $this->getWFScheduleTime());

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \timestamp of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

                    $nextTime = \App\Fields\Date::getWorkingDayFromDate($firstWorkingDay, '+0 day') . ' ' . $this->getWFScheduleTime();

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \timestamp of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

                    $nextTime = \App\Fields\Date::getWorkingDayFromDate($firstDayNextMonth, '+0 day') . ' ' . $this->getWFScheduleTime();

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (encodedValue) is \json but \App\Json::decode() takes string defined at /code/app/Json.php:37

Open

            $annualDates = \App\Json::decode($annualDates);

• Exclude checks
  • Disable engine
  • Disable check

Return type of getWFScheduleTime() is undeclared type \timestamp

Open

    public function getWFScheduleTime()

• Exclude checks
  • Disable engine
  • Disable check

Return type of getNextTriggerTime() is undeclared type \timestamp

Open

    public function getNextTriggerTime()

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->conditionStrategy

Open

        $this->conditionStrategy = new VTJsonCondition();

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->defaultworkflow

Open

            $this->defaultworkflow = $row['defaultworkflow'];

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->test

Open

        return $this->conditionStrategy->evaluate($this->test, $recordModel);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

        $queryWorkflowTasks = (new \App\Db\Query())->from('com_vtiger_workflowtasks')

• Exclude checks
  • Disable engine
  • Disable check

Returning type ?\time|?string but getNextTriggerTime() is declared to return \timestamp

Open

        return $nextTime;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->schdayofweek

Open

        return $this->schdayofweek;

• Exclude checks
  • Disable engine
  • Disable check

Returning type null|string but getNextTriggerTimeForAnnualDates() is declared to return \time

Open

        return $nextTime;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->moduleName

Open

        $this->moduleName = $row['module_name'] ?? '';

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->executionCondition

Open

            return $arr[$this->executionCondition - 1];

• Exclude checks
  • Disable engine
  • Disable check

Return type of getNextTriggerTimeValue() is undeclared type \timestamp

Open

    public function getNextTriggerTimeValue()

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Users->time_zone

Open

        $adminTimeZone = $admin->time_zone;

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \time of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

                        $nextTime = date('Y-m-d H:i:s', strtotime($weekDays[$scheduledDaysOfWeek[0]] . ' ' . $scheduledTime));

• Exclude checks
  • Disable engine
  • Disable check

Returning type string but getNextTriggerTimeForMonthlyByWeekDay() is declared to return \time

Open

        return $nextTime;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->schdayofmonth

Open

        $this->schdayofmonth = $row['schdayofmonth'] ?? '';

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db::createCommand

Open

        \App\Db::getInstance()->createCommand()

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->schtime

Open

        return (new DateTimeField($this->schtime))->getDisplayTime();

• Exclude checks
  • Disable engine
  • Disable check

Saw an @param annotation for schTime, but it was not found in the param list of function getNextTriggerTimeForDaily(mixed $scheduledTime) : \time

Open

     * @param type  $schTime

• Exclude checks
  • Disable engine
  • Disable check

Parameter $scheduledDaysOfWeek has undeclared type \json

Open

    public function getNextTriggerTimeForWeekly($scheduledDaysOfWeek, $scheduledTime)

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \time of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

                        $scheduleWeekDayInTime = strtotime(date('Y-m-d', strtotime($weekDays[$currentWeekDay])) . ' ' . $scheduledTime);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->id

Open

        $this->id = $row['workflow_id'] ?? '';

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->test

Open

        if ('' == $this->test) {

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->conditionStrategy

Open

        return $this->conditionStrategy->evaluate($this->test, $recordModel);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->executionCondition

Open

        $this->executionCondition = $arr[$label];

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->nexttrigger_time

Open

            $this->nexttrigger_time = $time;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->executionCondition

Open

        return 6 == $this->executionCondition ? $this->schtypeid : 0;

• Exclude checks
  • Disable engine
  • Disable check

Return type of getNextTriggerTimeForDaily() is undeclared type \time

Open

    public function getNextTriggerTimeForDaily($scheduledTime)

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

        $isExistsActivateDonce = (new \App\Db\Query())->from('com_vtiger_workflow_activatedonce')->where(['entity_id' => $recordId, 'workflow_id' => $this->id])->exists();

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->nexttrigger_time

Open

        return $this->nexttrigger_time;

• Exclude checks
  • Disable engine
  • Disable check

Return type of getNextTriggerTimeForMonthlyByDate() is undeclared type \time

Open

    public function getNextTriggerTimeForMonthlyByDate($scheduledDayOfMonth, $scheduledTime)

• Exclude checks
  • Disable engine
  • Disable check

Parameter $annualDates has undeclared type \json

Open

    public function getNextTriggerTimeForAnnualDates($annualDates, $scheduledTime)

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \timestamp of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

                    $schTime = strtotime($day . ' ' . $scheduledTime);

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \timestamp of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

                $nextTime = date('Y:m:d H:i:s', strtotime($nextTriggerDay . ' ' . $scheduledTime));

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->schannualdates

Open

        $this->schannualdates = $row['schannualdates'] ?? '';

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->id

Open

            ->where(['entity_id' => $recordId, 'workflow_id' => $this->id]);

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (scheduledDaysOfWeek) is int but \Workflow::getNextTriggerTimeForWeekly() takes \json defined at /code/modules/com_vtiger_workflow/Workflow.php:433

Open

                    $nextTime = $this->getNextTriggerTimeForWeekly($this->getWFScheduleWeek(), $this->getWFScheduleTime());

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (scheduledTime) is \timestamp but \Workflow::getNextTriggerTimeForWeekly() takes \time defined at /code/modules/com_vtiger_workflow/Workflow.php:433

Open

                    $nextTime = $this->getNextTriggerTimeForWeekly($this->getWFScheduleWeek(), $this->getWFScheduleTime());

• Exclude checks
  • Disable engine
  • Disable check

Returning type string but getNextTriggerTimeForDaily() is declared to return \time

Open

        return $nextTime;

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \timestamp of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

            $nextTime = date('Y-m-d H:i:s', strtotime($scheduledWeekDayOfMonth . ' ' . $monthInFullText . ' ' . $yearFullNumberic . ' ' . $scheduledTime));

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->schtime

Open

        $this->schtime = $row['schtime'] ?? '';

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->params

Open

        $this->params = $row['params'] ?? '';

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->id

Open

                'workflow_id' => $this->id,

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->schdayofmonth

Open

        return $this->schdayofmonth;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Workflow->schannualdates

Open

        return $this->schannualdates;

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \timestamp of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

                    $nextTime = \App\Fields\Date::getWorkingDayFromDate($firstDayNextWeek, '+0 day') . ' ' . $this->getWFScheduleTime();

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \time of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

                                $nextTime = date('Y-m-d', strtotime('next ' . $weekDays[$nextWeekDay])) . ' ' . $scheduledTime;

• Exclude checks
  • Disable engine
  • Disable check

Parameter $scheduledTime has undeclared type \timestamp

Open

    public function getNextTriggerTimeForMonthlyByWeekDay($scheduledWeekDayOfMonth, $scheduledTime)

• Exclude checks
  • Disable engine
  • Disable check

When fetching an array index from a value of type array{1:'Monday',2:'Tuesday',3:'Wednesday',4:'Thursday',5:'Friday',6:'Saturday',7:'Sunday'}, found an array index of type string, but expected the index to be of type int

Open

                        $scheduleWeekDayInTime = strtotime(date('Y-m-d', strtotime($weekDays[$currentWeekDay])) . ' ' . $scheduledTime);

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (encodedValue) is int but \App\Json::decode() takes string defined at /code/app/Json.php:37

Open

            $scheduledDaysOfMonth = \App\Json::decode($scheduledDayOfMonth);

• Exclude checks
  • Disable engine
  • Disable check

Returning type null|string but getNextTriggerTimeForMonthlyByDate() is declared to return \time

Open

        return $nextTime;

• Exclude checks
  • Disable engine
  • Disable check

Return type of getNextTriggerTimeForMonthlyByWeekDay() is undeclared type \time

Open

    public function getNextTriggerTimeForMonthlyByWeekDay($scheduledWeekDayOfMonth, $scheduledTime)

• Exclude checks
  • Disable engine
  • Disable check

Avoid excessively long variable names like $SCHEDULED_MONTHLY_BY_DATE. Keep variable name length under 20.

Open

    public static $SCHEDULED_MONTHLY_BY_DATE = 5;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $isExistsActivateDonce. Keep variable name length under 20.

Open

        $isExistsActivateDonce = (new \App\Db\Query())->from('com_vtiger_workflow_activatedonce')->where(['entity_id' => $recordId, 'workflow_id' => $this->id])->exists();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $SCHEDULED_WORKINGDAY_DAY. Keep variable name length under 20.

Open

    public static $SCHEDULED_WORKINGDAY_DAY = 11;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $SCHEDULED_WORKINGDAY_WEEK. Keep variable name length under 20.

Open

    public static $SCHEDULED_WORKINGDAY_WEEK = 12;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $SCHEDULED_WORKINGDAY_MONTH. Keep variable name length under 20.

Open

    public static $SCHEDULED_WORKINGDAY_MONTH = 13;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $SCHEDULED_ON_SPECIFIC_DATE. Keep variable name length under 20.

Open

    public static $SCHEDULED_ON_SPECIFIC_DATE = 4;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $SCHEDULED_MONTHLY_BY_WEEKDAY. Keep variable name length under 20.

Open

    public static $SCHEDULED_MONTHLY_BY_WEEKDAY = 6;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $scheduleWeekDayInTime. Keep variable name length under 20.

Open

                        $scheduleWeekDayInTime = strtotime(date('Y-m-d', strtotime($weekDays[$currentWeekDay])) . ' ' . $scheduledTime);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $scheduledWeekDayOfMonth. Keep variable name length under 20.

Open

    public function getNextTriggerTimeForMonthlyByWeekDay($scheduledWeekDayOfMonth, $scheduledTime)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class Workflow

• Exclude checks
  • Disable engine
  • Disable check

The property $SCHEDULED_WEEKLY is not named in camelCase.

Open

class Workflow
{
    /**
     * Scheduled hourly.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

The property $SCHEDULED_MONTHLY_BY_WEEKDAY is not named in camelCase.

Open

class Workflow
{
    /**
     * Scheduled hourly.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

The property $SCHEDULED_ANNUALLY is not named in camelCase.

Open

class Workflow
{
    /**
     * Scheduled hourly.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

The property $SCHEDULED_HOURLY is not named in camelCase.

Open

class Workflow
{
    /**
     * Scheduled hourly.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

The property $SCHEDULED_15_MINUTES is not named in camelCase.

Open

class Workflow
{
    /**
     * Scheduled hourly.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

The property $SCHEDULED_WORKINGDAY_DAY is not named in camelCase.

Open

class Workflow
{
    /**
     * Scheduled hourly.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

The property $SCHEDULED_WORKINGDAY_MONTH is not named in camelCase.

Open

class Workflow
{
    /**
     * Scheduled hourly.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

The property $SCHEDULED_MONTHLY_BY_DATE is not named in camelCase.

Open

class Workflow
{
    /**
     * Scheduled hourly.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

The property $SCHEDULED_WORKINGDAY_WEEK is not named in camelCase.

Open

class Workflow
{
    /**
     * Scheduled hourly.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

The property $SCHEDULED_ON_SPECIFIC_DATE is not named in camelCase.

Open

class Workflow
{
    /**
     * Scheduled hourly.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

The property $SCHEDULED_LIST is not named in camelCase.

Open

class Workflow
{
    /**
     * Scheduled hourly.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

The property $SCHEDULED_30_MINUTES is not named in camelCase.

Open

class Workflow
{
    /**
     * Scheduled hourly.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

The property $SCHEDULED_5_MINUTES is not named in camelCase.

Open

class Workflow
{
    /**
     * Scheduled hourly.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

The property $SCHEDULED_DAILY is not named in camelCase.

Open

class Workflow
{
    /**
     * Scheduled hourly.
     *

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

Avoid variables with short names like $tm. Configured minimum length is 3.

Open

        $tm = new VTTaskManager();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Terminating statement must be indented to the same level as the CASE body

Open

            break;

• Exclude checks
  • Disable engine
  • Disable check

Terminating statement must be indented to the same level as the CASE body

Open

            break;

• Exclude checks
  • Disable engine
  • Disable check

The 'getWFScheduleAnnualDates()' method which returns a boolean should be named 'is...()' or 'has...()'

Open

    public function getWFScheduleAnnualDates()
    {
        return $this->schannualdates;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Scheduled annually.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Scheduled weekly.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Scheduled on specific date.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var int

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var int

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static $SCHEDULED_30_MINUTES = 8;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static $SCHEDULED_WORKINGDAY_DAY = 11;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static $SCHEDULED_WEEKLY = 3;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Scheduled monthly by weekday.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Scheduled first working day in week.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Scheduled first working day in month.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Scheduled hourly.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var int

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static $SCHEDULED_ON_SPECIFIC_DATE = 4;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Scheduled closest working day.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static $SCHEDULED_DAILY = 2;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var int

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var int

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Scheduled list.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Scheduled hourly.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static $SCHEDULED_MONTHLY_BY_DATE = 5;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Scheduled hourly.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static $SCHEDULED_15_MINUTES = 9;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var int

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var int

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static $SCHEDULED_WORKINGDAY_WEEK = 12;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static $SCHEDULED_WORKINGDAY_MONTH = 13;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Scheduled monthly by date.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static $SCHEDULED_ANNUALLY = 7;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Scheduled daily.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var int

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var int

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Scheduled hourly.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var int

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static $SCHEDULED_HOURLY = 1;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var int

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var int

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static $SCHEDULED_MONTHLY_BY_WEEKDAY = 6;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @var int

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static $SCHEDULED_5_MINUTES = 10;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        11 => 'LBL_WORKINGDAY_DAY',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        13 => 'LBL_WORKINGDAY_MONTH',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Constructor.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->schtime = $row['schtime'] ?? '';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        return !(!$isExistsActivateDonce && !$queryWorkflowTasks->exists());

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            return $arr[$this->executionCondition - 1];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static $SCHEDULED_LIST = [

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->params = $row['params'] ?? '';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Setup workflow.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (isset($row['defaultworkflow'])) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function isCompletedForRecord($recordId)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ])->execute();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->executionCondition = $arr[$label];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        9 => 'LBL_15_MINUTES',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->conditionStrategy = new VTJsonCondition();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->schannualdates = $row['schannualdates'] ?? '';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->nexttrigger_time = $row['nexttrigger_time'] ?? '';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @return bool

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function performTasks(Vtiger_Record_Model $recordModel, ?array $tasks = null)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        foreach ($tm->getTasksForWorkflow($this->id) as $task) {

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 122 characters

Open

                        $taskQueue->queueTask($task->id, $recordModel->getId(), $delay, $task->getContents($recordModel));

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 152 characters

Open

            $arr = ['ON_FIRST_SAVE', 'ONCE', 'ON_EVERY_SAVE', 'ON_MODIFY', 'ON_DELETE', 'ON_SCHEDULE', 'MANUAL', 'TRIGGER', 'BLOCK_EDIT', 'ON_RELATED'];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $this->schtypeid = $row['schtypeid'] ?? '';

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ('' == $this->test) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $isExistsActivateDonce = (new \App\Db\Query())->from('com_vtiger_workflow_activatedonce')->where(['entity_id' => $recordId, 'workflow_id' => $this->id])->exists();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 122 characters

Open

            'ON_DELETE' => 5, 'ON_SCHEDULE' => 6, 'MANUAL' => 7, 'TRIGGER' => 8, 'BLOCK_EDIT' => 9, 'ON_RELATED' => 10, ];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $tm = new VTTaskManager();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    if ($hasContents) {

• Exclude checks
  • Disable engine
  • Disable check