Function doTask has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.

Open

    public function doTask($recordModel)
    {
        if (!\App\Module::isModuleActive('Calendar')) {
            return;
        }

• Read up
  Read up

Method doTask has 152 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function doTask($recordModel)
    {
        if (!\App\Module::isModuleActive('Calendar')) {
            return;
        }

The method doTask() has an NPath complexity of 2446080. The configured NPath complexity threshold is 200.

Open

    public function doTask($recordModel)
    {
        if (!\App\Module::isModuleActive('Calendar')) {
            return;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    function bar() {
        // lots of complicated code
    }
}

The method doTask() has 163 lines of code. Current threshold is set to 100. Avoid really long methods.

Open

    public function doTask($recordModel)
    {
        if (!\App\Module::isModuleActive('Calendar')) {
            return;
        }

• Exclude checks
  • Disable engine
  • Disable check

The method doTask() has a Cyclomatic Complexity of 31. The configured cyclomatic complexity threshold is 10.

Open

    public function doTask($recordModel)
    {
        if (!\App\Module::isModuleActive('Calendar')) {
            return;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

This function "doTask" has 162 lines, which is greater than the 150 lines authorized. Split it into smaller functions.

Open

    public function doTask($recordModel)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Refactor this function to reduce its Cognitive Complexity from 53 to the 15 allowed.

Open

    public function doTask($recordModel)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

The class VTCreateTodoTask has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.

Open

class VTCreateTodoTask extends VTTask
{
    public $executeImmediately = true;

    public function getFieldNames()

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Missing class import via use statement (line '70', column '23').

Open

            $userExists = (new App\Db\Query())->from('vtiger_users')

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '76', column '24').

Open

                $groupExist = (new App\Db\Query())->from('vtiger_groups')

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '43', column '18').

Open

            $query = (new App\Db\Query())->from('vtiger_activity')

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid using static access to class 'vtlib\Functions' in method 'doTask'.

Open

            $status = vtlib\Functions::getArrayFromValue($this->duplicateStatus);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'DateTimeField' in method 'doTask'.

Open

                $dbInsertDateTime = DateTimeField::convertToDBTimeZone($baseDateEnd . ' ' . $timeWithSec);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method doTask uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $dueDateTime = date('Y-m-d H:i:s', strtotime($date_start . ' ' . $time) + $endIncrement);
            $dueDateTime = explode(' ', $dueDateTime);
            $due_date = $dueDateTime[0];
            $timeEnd = $dueDateTime[1];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class 'Vtiger_Record_Model' in method 'doTask'.

Open

        $newRecordModel = Vtiger_Record_Model::getCleanInstance('Calendar');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'DateTimeField' in method 'doTask'.

Open

            $dbInsertDateTime = DateTimeField::convertToDBTimeZone($baseDateStart . ' ' . $timeWithSec);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method doTask uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $baseDateEnd = $recordModel->get($this->datefield_end);
                if ('' == $baseDateEnd) {
                    $baseDateEnd = date('Y-m-d');
                }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method doTask uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $groupExist = (new App\Db\Query())->from('vtiger_groups')
                    ->where(['groupid' => $this->assigned_user_id])
                    ->exists();
                if ($groupExist) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid assigning values to variables in if clauses and the like (line '166', column '8').

Open

    public function doTask($recordModel)
    {
        if (!\App\Module::isModuleActive('Calendar')) {
            return;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

The method doTask uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $baseDateStart = $recordModel->get($this->datefield_start);
            if ('' == $baseDateStart) {
                $baseDateStart = date('Y-m-d');
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\App\Record' in method 'doTask'.

Open

            if ($parentRecord = \App\Record::getParentRecord($parentRecord)) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Vtiger_Relation_Model' in method 'doTask'.

Open

        $relationModel = \Vtiger_Relation_Model::getInstance($recordModel->getModule(), $newRecordModel->getModule());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\ModuleHierarchy' in method 'doTask'.

Open

                $field = \App\ModuleHierarchy::getMappingRelatedField($parentModuleName);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid assigning values to variables in if clauses and the like (line '160', column '7').

Open

    public function doTask($recordModel)
    {
        if (!\App\Module::isModuleActive('Calendar')) {
            return;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Avoid using static access to class '\App\Log' in method 'doTask'.

Open

        \App\Log::trace('Start ' . __CLASS__ . ':' . __FUNCTION__);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Fields\Double' in method 'doTask'.

Open

        $endIncrement = \App\Fields\Double::formatToDb($this->days_end) * 24 * 60 * 60 * ('before' == strtolower($this->direction_end) ? -1 : 1);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\PrivilegeUtil' in method 'doTask'.

Open

                } elseif ($userIdFromGroup = current(\App\PrivilegeUtil::getUsersByGroup($userId))) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\ModuleHierarchy' in method 'doTask'.

Open

            $field = \App\ModuleHierarchy::getMappingRelatedField($parentModuleName);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Log' in method 'doTask'.

Open

        \App\Log::trace('End ' . __CLASS__ . ':' . __FUNCTION__);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\User' in method 'doTask'.

Open

                    $timeEnd = \App\User::getUserModel(\App\User::getActiveAdminId())->getDetail('end_hour');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Module' in method 'doTask'.

Open

        if (!\App\Module::isModuleActive('Calendar')) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method doTask uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

                } else {
                    $timeEnd = \App\User::getUserModel(\App\User::getActiveAdminId())->getDetail('end_hour');
                }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid assigning values to variables in if clauses and the like (line '120', column '15').

Open

    public function doTask($recordModel)
    {
        if (!\App\Module::isModuleActive('Calendar')) {
            return;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Avoid using static access to class '\App\Fields\Time' in method 'doTask'.

Open

            $timeWithSec = \App\Fields\Time::sanitizeDbFormat($this->time);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Fields\Time' in method 'doTask'.

Open

                $timeWithSec = \App\Fields\Time::sanitizeDbFormat($timeEnd);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\User' in method 'doTask'.

Open

                if (\App\User::isExists($userId)) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\ModuleHierarchy' in method 'doTask'.

Open

        $field = \App\ModuleHierarchy::getMappingRelatedField($moduleName);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\User' in method 'doTask'.

Open

            $userId = \App\User::getCurrentUserId();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Record' in method 'doTask'.

Open

        if ($parentRecord = \App\Record::getParentRecord($recordModel->getId())) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class 'Users' in method 'doTask'.

Open

            $userId = Users::getActiveAdminUser();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\TextParser' in method 'doTask'.

Open

        $textParser = \App\TextParser::getInstanceByModel($recordModel);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Record' in method 'doTask'.

Open

            $parentModuleName = \App\Record::getType($parentRecord);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method conv12to24hour uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $hours = ((int) $arr[1]) % 12 + 12;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid using static access to class '\App\Record' in method 'doTask'.

Open

                $parentModuleName = \App\Record::getType($parentRecord);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\App\Log' in method 'doTask'.

Open

                \App\Log::warning(__CLASS__ . '::' . __METHOD__ . ': To Do was ignored because a duplicate was found.' . $this->todo);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The method doTask uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $time = $time[1];
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method doTask uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $timeEnd = $timeEnd[1];
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Define a constant instead of duplicating this literal "end_hour" 3 times.

Open

                    $timeEnd = \App\User::getUserModel($userId)->getDetail('end_hour');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "assigned_user_id" 4 times.

Open

        return ['todo', 'description', 'time', 'days_start', 'days_end', 'status', 'priority', 'days', 'direction_start', 'datefield_start', 'direction_end', 'datefield_end', 'sendNotification', 'assigned_user_id', 'days', 'doNotDuplicate', 'duplicateStatus', 'updateDates'];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Define a constant instead of duplicating this literal "Y-m-d H:i:s" 3 times.

Open

            $baseDateStart = date('Y-m-d H:i:s');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Reference to undeclared property \VTCreateTodoTask->duplicateStatus

Open

            $status = vtlib\Functions::getArrayFromValue($this->duplicateStatus);

• Exclude checks
  • Disable engine
  • Disable check

Call to method warning from undeclared class \App\Log

Open

                \App\Log::warning(__CLASS__ . '::' . __METHOD__ . ': To Do was ignored because a duplicate was found.' . $this->todo);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

                $groupExist = (new App\Db\Query())->from('vtiger_groups')

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->assigned_user_id

Open

        if ('currentUser' === $this->assigned_user_id) {

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->assigned_user_id

Open

        } elseif ('copyParentOwner' === $this->assigned_user_id) {

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

            $userExists = (new App\Db\Query())->from('vtiger_users')

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->todo

Open

                \App\Log::warning(__CLASS__ . '::' . __METHOD__ . ': To Do was ignored because a duplicate was found.' . $this->todo);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db\Query::from

Open

            $query = (new App\Db\Query())->from('vtiger_activity')

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->assigned_user_id

Open

                $userId = $this->assigned_user_id;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->datefield_start

Open

            $baseDateStart = $recordModel->get($this->datefield_start);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->direction_start

Open

        $date_start = strftime('%Y-%m-%d', $baseDateStart + (int) $this->days_start * 24 * 60 * 60 * ('before' == strtolower($this->direction_start) ? -1 : 1));

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->datefield_end

Open

        if ('fromDateStart' !== $this->datefield_end) {

• Exclude checks
  • Disable engine
  • Disable check

Call to method isExists from undeclared class \App\User (Did you mean class \Tests\App\User)

Open

                if (\App\User::isExists($userId)) {

• Exclude checks
  • Disable engine
  • Disable check

Call to method getActiveAdminId from undeclared class \App\User (Did you mean class \Tests\App\User)

Open

                    $timeEnd = \App\User::getUserModel(\App\User::getActiveAdminId())->getDetail('end_hour');

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->todo

Open

                    ['vtiger_activity.subject' => $this->todo],

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \Vtiger_Record_Model->executeUser

Open

            $userId = $recordModel->executeUser;

• Exclude checks
  • Disable engine
  • Disable check

Call to method getUserModel from undeclared class \App\User (Did you mean class \Tests\App\User)

Open

                    $timeEnd = \App\User::getUserModel($userIdFromGroup)->getDetail('end_hour');

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \App\Db::createCommand

Open

            App\Db::getInstance()->createCommand()->insert('vtiger_activity_update_dates', [

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (input) is int but \str_pad() takes string

Open

        return str_pad($hours, 2, '0', STR_PAD_LEFT) . ':' . str_pad($arr[2], 2, '0', STR_PAD_LEFT);

• Exclude checks
  • Disable engine
  • Disable check

Call to method trace from undeclared class \App\Log

Open

        \App\Log::trace('Start ' . __CLASS__ . ':' . __FUNCTION__);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->assigned_user_id

Open

                ->where(['id' => $this->assigned_user_id, 'status' => 'Active'])

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->assigned_user_id

Open

                    ->where(['groupid' => $this->assigned_user_id])

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->assigned_user_id

Open

                    $userId = $this->assigned_user_id;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->priority

Open

            'taskpriority' => $this->priority,

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->sendNotification

Open

            'sendnotification' => ('' != $this->sendNotification && 'N' != $this->sendNotification),

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->days_end

Open

        $endIncrement = \App\Fields\Double::formatToDb($this->days_end) * 24 * 60 * 60 * ('before' == strtolower($this->direction_end) ? -1 : 1);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->assigned_user_id

Open

        } elseif (!empty($this->assigned_user_id)) { // Added to check if the user/group is active

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->assigned_user_id

Open

        } elseif ('triggerUser' === $this->assigned_user_id) {

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->datefield_end

Open

            if ('wfRunTime' == $this->datefield_end) {

• Exclude checks
  • Disable engine
  • Disable check

Call to method getCurrentUserId from undeclared class \App\User (Did you mean class \Tests\App\User)

Open

            $userId = \App\User::getCurrentUserId();

• Exclude checks
  • Disable engine
  • Disable check

Call to method getInstanceByModel from undeclared class \App\TextParser (Did you mean class \Tests\App\TextParser)

Open

        $textParser = \App\TextParser::getInstanceByModel($recordModel);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->status (Did you mean $status)

Open

            'activitystatus' => $this->status,

• Exclude checks
  • Disable engine
  • Disable check

Call to method trace from undeclared class \App\Log

Open

        \App\Log::trace('End ' . __CLASS__ . ':' . __FUNCTION__);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->time (Did you mean $time)

Open

            $timeWithSec = \App\Fields\Time::sanitizeDbFormat($this->time);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->days_start

Open

        $date_start = strftime('%Y-%m-%d', $baseDateStart + (int) $this->days_start * 24 * 60 * 60 * ('before' == strtolower($this->direction_start) ? -1 : 1));

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->datefield_end

Open

                $baseDateEnd = $recordModel->get($this->datefield_end);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->direction_end

Open

        $endIncrement = \App\Fields\Double::formatToDb($this->days_end) * 24 * 60 * 60 * ('before' == strtolower($this->direction_end) ? -1 : 1);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->description

Open

            'description' => $textParser->setContent($this->description)->parse()->getContent(),

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->doNotDuplicate

Open

        if ('true' == $this->doNotDuplicate) {

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->datefield_start

Open

        if ('wfRunTime' == $this->datefield_start) {

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->id

Open

                'task_id' => $this->id,

• Exclude checks
  • Disable engine
  • Disable check

Call to method getUserModel from undeclared class \App\User (Did you mean class \Tests\App\User)

Open

                    $timeEnd = \App\User::getUserModel($userId)->getDetail('end_hour');

• Exclude checks
  • Disable engine
  • Disable check

Call to method getUserModel from undeclared class \App\User (Did you mean class \Tests\App\User)

Open

                    $timeEnd = \App\User::getUserModel(\App\User::getActiveAdminId())->getDetail('end_hour');

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->updateDates

Open

        if ('true' == $this->updateDates) {

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \VTCreateTodoTask->todo

Open

            'subject' => $textParser->setContent($this->todo)->parse()->getContent(),

• Exclude checks
  • Disable engine
  • Disable check

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if ('currentUser' === $this->assigned_user_id) {
            $userId = \App\User::getCurrentUserId();
        } elseif ('triggerUser' === $this->assigned_user_id) {
            $userId = $recordModel->executeUser;
        } elseif ('copyParentOwner' === $this->assigned_user_id) {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    public static function conv12to24hour($timeStr)
    {
        $arr = [];
        preg_match('/(\d{1,2}):(\d{1,2})(am|pm)/', $timeStr, $arr);
        if ('am' == $arr[3]) {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if ($parentRecord = \App\Record::getParentRecord($recordModel->getId())) {
            $parentModuleName = \App\Record::getType($parentRecord);
            $field = \App\ModuleHierarchy::getMappingRelatedField($parentModuleName);
            if ($field) {
                $fields[$field] = $parentRecord;

• Read up
  Read up

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class VTCreateTodoTask extends VTTask

• Exclude checks
  • Disable engine
  • Disable check

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 15 and the first side effect is on line 11.

Open

<?php

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 275 characters

Open

        return ['todo', 'description', 'time', 'days_start', 'days_end', 'status', 'priority', 'days', 'direction_start', 'datefield_start', 'direction_end', 'datefield_end', 'sendNotification', 'assigned_user_id', 'days', 'doNotDuplicate', 'duplicateStatus', 'updateDates'];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (null === $userId) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $entityId = $recordModel->getId();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $status = vtlib\Functions::getArrayFromValue($this->duplicateStatus);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if ($query->count() > 0) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $time = explode(' ', $baseDateStart);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $time = $time[1];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                return;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (\count($time) < 2) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $timeEnd = \App\User::getUserModel(\App\User::getActiveAdminId())->getDetail('end_hour');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'taskpriority' => $this->priority,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        } elseif ('triggerUser' === $this->assigned_user_id) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $groupExist = (new App\Db\Query())->from('vtiger_groups')

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    ->where(['groupid' => $this->assigned_user_id])

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $baseDateStart = strtotime($match[0]);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                if (\App\User::isExists($userId)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            preg_match('/\d\d\d\d-\d\d-\d\d/', $baseDateEnd, $match);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $userId = $recordModel->executeUser;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        } elseif ('copyParentOwner' === $this->assigned_user_id) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $baseDateEnd = date('Y-m-d');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'subject' => $textParser->setContent($this->todo)->parse()->getContent(),

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $userId = $recordModel->get('assigned_user_id');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $due_date = strftime('%Y-%m-%d ', $baseDateEnd + $endIncrement);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $textParser = \App\TextParser::getInstanceByModel($recordModel);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     *

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function doTask($recordModel)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $userId = Users::getActiveAdminUser();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    'and',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $baseDateEnd = $recordModel->get($this->datefield_end);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $timeEnd = \App\User::getUserModel($userIdFromGroup)->getDetail('end_hour');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $timeEnd = $timeEnd[1];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'description' => $textParser->setContent($this->description)->parse()->getContent(),

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ('currentUser' === $this->assigned_user_id) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $dueDateTime = date('Y-m-d H:i:s', strtotime($date_start . ' ' . $time) + $endIncrement);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $due_date = $dueDateTime[0];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function getFieldNames()

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    ['or', ['vtiger_activity.link' => $entityId], ['vtiger_activity.process' => $entityId]],

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                \App\Log::warning(__CLASS__ . '::' . __METHOD__ . ': To Do was ignored because a duplicate was found.' . $this->todo);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                ->exists();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $baseDateStart = $recordModel->get($this->datefield_start);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $timeWithSec = \App\Fields\Time::sanitizeDbFormat($timeEnd);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public $executeImmediately = true;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $userId = $recordModel->get('assigned_user_id');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                ->where([

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    ['vtiger_activity.subject' => $this->todo],

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                ]);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $userId = \App\User::getCurrentUserId();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if ($userExists) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if ('' == $baseDateStart) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if ('wfRunTime' == $this->datefield_end) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $fields = [

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ('true' == $this->doNotDuplicate) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    ['vtiger_crmentity.deleted' => 0],

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 134 characters

Open

                \App\Log::warning(__CLASS__ . '::' . __METHOD__ . ': To Do was ignored because a duplicate was found.' . $this->todo);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                ->where(['id' => $this->assigned_user_id, 'status' => 'Active'])

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $userId = $this->assigned_user_id;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        preg_match('/\d\d\d\d-\d\d-\d\d/', $baseDateStart, $match);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $timeEnd = \App\User::getUserModel($userId)->getDetail('end_hour');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * Execute task.

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!\App\Module::isModuleActive('Calendar')) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        \App\Log::trace('Start ' . __CLASS__ . ':' . __FUNCTION__);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                ->innerJoin('vtiger_crmentity', 'vtiger_crmentity.crmid = vtiger_activity.activityid')

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if (\count($status) > 0) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $dbInsertDateTime = DateTimeField::convertToDBTimeZone($baseDateStart . ' ' . $timeWithSec);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $time = $dbInsertDateTime->format('H:i:s');

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 145 characters

Open

        $endIncrement = \App\Fields\Double::formatToDb($this->days_end) * 24 * 60 * 60 * ('before' == strtolower($this->direction_end) ? -1 : 1);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $timeEnd = explode(' ', $baseDateEnd);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $dbInsertDateTime = DateTimeField::convertToDBTimeZone($baseDateEnd . ' ' . $timeWithSec);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     * @param Vtiger_Record_Model $recordModel

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $moduleName = $recordModel->getModuleName();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $query = (new App\Db\Query())->from('vtiger_activity')

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $baseDateEnd = strtotime($match[0]);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $dueDateTime = explode(' ', $dueDateTime);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $timeEnd = $dueDateTime[1];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        return ['todo', 'description', 'time', 'days_start', 'days_end', 'status', 'priority', 'days', 'direction_start', 'datefield_start', 'direction_end', 'datefield_end', 'sendNotification', 'assigned_user_id', 'days', 'doNotDuplicate', 'duplicateStatus', 'updateDates'];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $userId = $this->assigned_user_id;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $date_start = strftime('%Y-%m-%d', $baseDateStart + (int) $this->days_start * 24 * 60 * 60 * ('before' == strtolower($this->direction_start) ? -1 : 1));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ('fromDateStart' !== $this->datefield_end) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $timeEnd = $dbInsertDateTime->format('H:i:s');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'parent' => $recordModel->getId(),

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $field = \App\ModuleHierarchy::getMappingRelatedField($moduleName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        \App\Log::trace('End ' . __CLASS__ . ':' . __FUNCTION__);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

     */

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $baseDateStart = date('Y-m-d H:i:s');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $timeWithSec = \App\Fields\Time::sanitizeDbFormat($this->time);

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 160 characters

Open

        $date_start = strftime('%Y-%m-%d', $baseDateStart + (int) $this->days_start * 24 * 60 * 60 * ('before' == strtolower($this->direction_start) ? -1 : 1));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $baseDateEnd = date('Y-m-d H:i:s');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                } elseif ($userIdFromGroup = current(\App\PrivilegeUtil::getUsersByGroup($userId))) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'activitystatus' => $this->status,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $newRecordModel->setData($fields);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            App\Db::getInstance()->createCommand()->insert('vtiger_activity_update_dates', [

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ])->execute();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    /**

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        } elseif (!empty($this->assigned_user_id)) { // Added to check if the user/group is active

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    ->exists();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                if ($groupExist) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ('wfRunTime' == $this->datefield_start) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $endIncrement = \App\Fields\Double::formatToDb($this->days_end) * 24 * 60 * 60 * ('before' == strtolower($this->direction_end) ? -1 : 1);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $parentModuleName = \App\Record::getType($parentRecord);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $field = \App\ModuleHierarchy::getMappingRelatedField($parentModuleName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $newRecordModel->save();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        preg_match('/(\d{1,2}):(\d{1,2})(am|pm)/', $timeStr, $arr);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        return ['time'];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        ];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            return;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    ['vtiger_activity.activitytype' => 'Task'],

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $query->andWhere(['not in', 'vtiger_activity.status', $status]);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $userExists = (new App\Db\Query())->from('vtiger_users')

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $baseDateStart = date('Y-m-d');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                if ('' == $baseDateEnd) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if (\count($timeEnd) < 2) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'activitytype' => 'Task',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $newRecordModel->setHandlerExceptions(['disableHandlerClasses' => ['Vtiger_Workflow_Handler']]);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $relationModel->addRelation($recordModel->getId(), $newRecordModel->getId());

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'due_date' => $due_date,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        return str_pad($hours, 2, '0', STR_PAD_LEFT) . ':' . str_pad($arr[2], 2, '0', STR_PAD_LEFT);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'assigned_user_id' => $userId,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $newRecordModel = Vtiger_Record_Model::getCleanInstance('Calendar');

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ($relationModel) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $arr = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'time_end' => $timeEnd,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'visibility' => 'Private',

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $fields[$field] = $parentRecord;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if ($parentRecord = \App\Record::getParentRecord($parentRecord)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'time_start' => $time,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ($field) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public static function conv12to24hour($timeStr)

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function getTimeFieldList()

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $parentModuleName = \App\Record::getType($parentRecord);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                $field = \App\ModuleHierarchy::getMappingRelatedField($parentModuleName);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                    $fields[$field] = $parentRecord;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ('true' == $this->updateDates) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $relationModel = \Vtiger_Relation_Model::getInstance($recordModel->getModule(), $newRecordModel->getModule());

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'activityid' => $newRecordModel->getId(),

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ('am' == $arr[3]) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'sendnotification' => ('' != $this->sendNotification && 'N' != $this->sendNotification),

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                'task_id' => $this->id,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $fields[$field] = $recordModel->getId();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $hours = ((int) $arr[1]) % 12 + 12;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            'date_start' => $date_start,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if ($parentRecord = \App\Record::getParentRecord($recordModel->getId())) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            if ($field) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                if ($field) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $hours = ((int) $arr[1]) % 12;

• Exclude checks
  • Disable engine
  • Disable check

The variable $date_start is not named in camelCase.

Open

    public function doTask($recordModel)
    {
        if (!\App\Module::isModuleActive('Calendar')) {
            return;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $date_start is not named in camelCase.

Open

    public function doTask($recordModel)
    {
        if (!\App\Module::isModuleActive('Calendar')) {
            return;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $due_date is not named in camelCase.

Open

    public function doTask($recordModel)
    {
        if (!\App\Module::isModuleActive('Calendar')) {
            return;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $due_date is not named in camelCase.

Open

    public function doTask($recordModel)
    {
        if (!\App\Module::isModuleActive('Calendar')) {
            return;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check