YetiForceCompany/YetiForceCRM

View on GitHub
public_html/layouts/basic/modules/Calendar/resources/CalendarView.js

Summary

Maintainability
C
1 day
Test Coverage

File CalendarView.js has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* {[The file is published on the basis of YetiForce Public License 6.5 that can be found in the following directory: licenses/LicenseEN.txt or yetiforce.com]} */
'use strict';
/**
 *  Class representing an extended calendar.
 * @extends Calendar_Calendar_Js
Severity: Minor
Found in public_html/layouts/basic/modules/Calendar/resources/CalendarView.js - About 2 hrs to fix

    Function showSidebarEvent has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        showSidebarEvent(params) {
            const self = this,
                aDeferred = $.Deferred();
            const progressInstance = $.progressIndicator({ blockInfo: { enabled: true } });
            if (typeof params == 'number') {

      Function setCalendarModuleOptions has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          setCalendarModuleOptions() {
              const self = this;
              return {
                  allDaySlot: app.getMainParams('allDaySlot'),
                  dateClick: (args) => {

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function registerCacheSettings has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          registerCacheSettings() {
              const self = this;
              $('.siteBarRight .filterField').each(function (index) {
                  let name = $(this).attr('id');
                  let value = app.moduleCacheGet(name);

        Function loadCalendarData has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            loadCalendarData() {
                const self = this,
                    progressInstance = $.progressIndicator({ blockInfo: { enabled: true } });
                let options = this.getDefaultParams();
                self.fullCalendar.removeAllEvents();

          Function setCalendarModuleOptions has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              setCalendarModuleOptions() {
                  const self = this;
                  return {
                      allDaySlot: app.getMainParams('allDaySlot'),
                      dateClick: (args) => {

            Function showCalendarPopoverLinkInSidebar has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                showCalendarPopoverLinkInSidebar(e) {
                    let href = e.currentTarget.href;
                    const hrefObject = app.convertUrlToObject(href);
                    if (hrefObject.module !== 'Calendar' || (hrefObject.view !== 'Edit' && hrefObject.view !== 'Detail')) {
                        return true;
            Severity: Minor
            Found in public_html/layouts/basic/modules/Calendar/resources/CalendarView.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    connectorMethod(options).done((events) => {
                        self.fullCalendar.removeAllEvents();
                        self.fullCalendar.addEventSource(events.result);
                        progressInstance.progressIndicator({ mode: 'hide' });
                    });
            public_html/layouts/basic/modules/Vtiger/resources/CalendarView.js on lines 88..92

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status