YetiForceCompany/YetiForceCRM

View on GitHub
public_html/layouts/basic/modules/Settings/MailRbl/resources/Index.js

Summary

Maintainability
F
5 days
Test Coverage

File Index.js has 401 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* {[The file is published on the basis of YetiForce Public License 6.5 that can be found in the following directory: licenses/LicenseEN.txt or yetiforce.com]} */
'use strict';

jQuery.Class(
    'Settings_MailRbl_Index_Js',
Severity: Minor
Found in public_html/layouts/basic/modules/Settings/MailRbl/resources/Index.js - About 5 hrs to fix

    Function registerTabEvents has 84 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            registerTabEvents: function (contentContainer = $('.js-tab.active')) {
                const self = this;
                let mode = contentContainer.attr('id');
                let table = this.registerDataTable(contentContainer);
                table.off('click', '.js-details').on('click', '.js-details', function () {
    Severity: Major
    Found in public_html/layouts/basic/modules/Settings/MailRbl/resources/Index.js - About 3 hrs to fix

      Function data has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                              data: function (row) {
                                  let action = '';
                                  action += '<div class="o-tab__container--action">';
                                  action += `<button type="button" class="btn btn-secondary btn-xs js-details" data-id="${
                                      row['id']

        Function registerDataTable has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                registerDataTable: function (container) {
                    const self = this;
                    let form = container.find('.js-filter-form');
                    App.Fields.Date.registerRange(form);
                    let table = container.find('.js-data-table');

          Function data has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                                  data: function (row) {
                                      let action = '';
                                      action += '<div class="o-tab__container--action">';
                                      if (row['statusId'] !== 1) {
                                          action += `<button type="button" class="btn btn-success btn-xs js-update" data-id="${

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        blackList: {
                            columns: [
                                { data: 'ip' },
                                { data: 'status' },
                                {
            public_html/layouts/basic/modules/Settings/MailRbl/resources/Index.js on lines 194..239

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 265.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        whiteList: {
                            columns: [
                                { data: 'ip' },
                                { data: 'status' },
                                {
            public_html/layouts/basic/modules/Settings/MailRbl/resources/Index.js on lines 148..193

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 265.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            AppConnector.request({
                                module: app.getModuleName(),
                                parent: app.getParentModuleName(),
                                action: 'SaveAjax',
                                mode: 'update',
            public_html/layouts/basic/modules/Settings/MailRbl/resources/Index.js on lines 350..369

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                AppConnector.request({
                                    module: app.getModuleName(),
                                    parent: app.getParentModuleName(),
                                    action: 'SendReport',
                                    id: this.dataset.id
            public_html/layouts/basic/modules/Settings/MailRbl/resources/Index.js on lines 322..344

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status