Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
public_html/layouts/basic/modules/Settings/MappedFields/resources/Edit.js

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        back: function () {
            var step = this.getStepValue();
            var prevStep = parseInt(step) - 1;
            this.currentInstance.initialize();
            var container = this.currentInstance.getContainer();
Severity: Major
Found in public_html/layouts/basic/modules/Settings/MappedFields/resources/Edit.js and 1 other location - About 6 hrs to fix
public_html/layouts/basic/modules/Settings/PDF/resources/Edit.js on lines 113..125

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 162.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        initiate: function (container) {
            if (typeof container === 'undefined') {
                container = jQuery('.mfTemplateContents');
            }
            if (container.is('.mfTemplateContents')) {
Severity: Major
Found in public_html/layouts/basic/modules/Settings/MappedFields/resources/Edit.js and 2 other locations - About 3 hrs to fix
public_html/layouts/basic/modules/Settings/PDF/resources/Edit.js on lines 54..65
public_html/layouts/basic/modules/Settings/Workflows/resources/Edit.js on lines 62..73

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        getInstance: function (step) {
            if (step in Settings_MappedFields_Edit_Js.instance) {
                return Settings_MappedFields_Edit_Js.instance[step];
            } else {
                var moduleClassName = 'Settings_MappedFields_Edit' + step + '_Js';
Severity: Major
Found in public_html/layouts/basic/modules/Settings/MappedFields/resources/Edit.js and 2 other locations - About 2 hrs to fix
public_html/layouts/basic/modules/Settings/PDF/resources/Edit.js on lines 34..42
public_html/layouts/basic/modules/Settings/Workflows/resources/Edit.js on lines 42..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

        activateHeader: function (step) {
            var headersContainer = jQuery('.crumbs ');
            headersContainer.find('.active').removeClass('active');
            jQuery('#' + step, headersContainer).addClass('active');
        },
Severity: Major
Found in public_html/layouts/basic/modules/Settings/MappedFields/resources/Edit.js and 2 other locations - About 1 hr to fix
public_html/layouts/basic/modules/Settings/PDF/resources/Edit.js on lines 79..83
public_html/layouts/basic/modules/Settings/Workflows/resources/Edit.js on lines 88..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

        registerBackStepClickEvent: function () {
            var thisInstance = this;
            var container = this.getContainer();
            container.on('click', '.backStep', function (e) {
                thisInstance.back();
Severity: Major
Found in public_html/layouts/basic/modules/Settings/MappedFields/resources/Edit.js and 2 other locations - About 1 hr to fix
public_html/layouts/basic/modules/Settings/PDF/resources/Edit.js on lines 134..140
public_html/layouts/basic/modules/Settings/Workflows/resources/Edit.js on lines 332..338

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        initiateStep: function (stepVal) {
            var step = 'step' + stepVal;
            this.activateHeader(step);
            this.currentInstance = this.getInstance(stepVal);
        },
Severity: Minor
Found in public_html/layouts/basic/modules/Settings/MappedFields/resources/Edit.js and 1 other location - About 55 mins to fix
public_html/layouts/basic/modules/Settings/PDF/resources/Edit.js on lines 70..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

        registerCancelStepClickEvent: function (form) {
            jQuery('button.cancelLink', form).on('click', function () {
                window.history.back();
            });
        },
Severity: Major
Found in public_html/layouts/basic/modules/Settings/MappedFields/resources/Edit.js and 8 other locations - About 35 mins to fix
public_html/layouts/basic/modules/Settings/MappedFields/resources/Edit1.js on lines 90..94
public_html/layouts/basic/modules/Settings/MappedFields/resources/Edit2.js on lines 104..108
public_html/layouts/basic/modules/Settings/MappedFields/resources/Edit3.js on lines 92..96
public_html/layouts/basic/modules/Settings/MappedFields/resources/Edit4.js on lines 73..77
public_html/layouts/basic/modules/Settings/PDF/resources/Edit.js on lines 126..130
public_html/layouts/basic/modules/Settings/PDF/resources/Edit1.js on lines 107..111
public_html/layouts/basic/modules/Settings/PDF/resources/Edit2.js on lines 78..82
public_html/layouts/basic/modules/Settings/PDF/resources/Edit3.js on lines 74..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

        getStepValue: function () {
            var container = this.currentInstance.getContainer();
            return jQuery('.step', container).val();
        },
Severity: Minor
Found in public_html/layouts/basic/modules/Settings/MappedFields/resources/Edit.js and 2 other locations - About 30 mins to fix
public_html/layouts/basic/modules/Settings/PDF/resources/Edit.js on lines 47..50
public_html/layouts/basic/modules/Settings/Workflows/resources/Edit.js on lines 55..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status