Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
public_html/layouts/basic/modules/Settings/Menu/resources/Menu.js

Summary

Maintainability
D
2 days
Test Coverage

File Menu.js has 369 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* {[The file is published on the basis of YetiForce Public License 6.5 that can be found in the following directory: licenses/LicenseEN.txt or yetiforce.com]} */
'use strict';

jQuery.Class(
    'Settings_Menu_Index_Js',
Severity: Minor
Found in public_html/layouts/basic/modules/Settings/Menu/resources/Menu.js - About 4 hrs to fix

    Function loadMenuTree has 68 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            loadMenuTree: function () {
            var thisInstance = this;
            if (thisInstance.treeInstance == false) {
                var data = JSON.parse($('#treeValues').val());
                if (data.length == 0) {
    Severity: Major
    Found in public_html/layouts/basic/modules/Settings/Menu/resources/Menu.js - About 2 hrs to fix

      Function loadMenuTree has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

              loadMenuTree: function () {
            var thisInstance = this;
            if (thisInstance.treeInstance == false) {
                var data = JSON.parse($('#treeValues').val());
                if (data.length == 0) {
      Severity: Minor
      Found in public_html/layouts/basic/modules/Settings/Menu/resources/Menu.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function copyMenu has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              copyMenu: function (fromRole) {
            var thisInstance = this;
            var aDeferred = jQuery.Deferred();
            var progressIndicatorElement = jQuery.progressIndicator({
                position: 'html',
      Severity: Minor
      Found in public_html/layouts/basic/modules/Settings/Menu/resources/Menu.js - About 1 hr to fix

        Function action has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                                        action: function (data) {
                                    var inst = $.jstree.reference(data.reference);
                                    var ids = inst.get_selected();
                                    var showInfo = false;
                                    for (var i in ids) {
        Severity: Minor
        Found in public_html/layouts/basic/modules/Settings/Menu/resources/Menu.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          if (errorExists != false) {
                    var progress = jQuery.progressIndicator();
                    thisInstance.save('createMenu', form).done(function (data) {
                        Settings_Vtiger_Index_Js.showMessage({ type: 'success', text: data.result.message });
                        app.hideModalWindow();
          Severity: Major
          Found in public_html/layouts/basic/modules/Settings/Menu/resources/Menu.js and 1 other location - About 4 hrs to fix
          public_html/layouts/basic/modules/Settings/Menu/resources/Menu.js on lines 167..175

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          if (errorExists != false) {
                    var progress = jQuery.progressIndicator();
                    thisInstance.save('updateMenu', form).done(function (data) {
                        Settings_Vtiger_Index_Js.showMessage({ type: 'success', text: data.result.message });
                        app.hideModalWindow();
          Severity: Major
          Found in public_html/layouts/basic/modules/Settings/Menu/resources/Menu.js and 1 other location - About 4 hrs to fix
          public_html/layouts/basic/modules/Settings/Menu/resources/Menu.js on lines 217..225

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 7 locations. Consider refactoring.
          Open

                      AppConnector.request(params)
                .done(function (data) {
                    aDeferred.resolve(data);
                })
                .fail(function (textStatus, errorThrown) {
          Severity: Major
          Found in public_html/layouts/basic/modules/Settings/Menu/resources/Menu.js and 6 other locations - About 1 hr to fix
          public_html/layouts/basic/modules/Documents/resources/Edit.js on lines 131..137
          public_html/layouts/basic/modules/Documents/resources/List.js on lines 79..85
          public_html/layouts/basic/modules/Settings/Currency/resources/Currency.js on lines 271..277
          public_html/layouts/basic/modules/Settings/MappedFields/resources/List.js on lines 102..108
          public_html/layouts/basic/modules/Vtiger/resources/Detail.js on lines 927..934
          public_html/layouts/resources/app.js on lines 2534..2540

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      AppConnector.requestPjax(params)
                .done(function (data) {
                    aDeferred.resolve(data);
                })
                .fail(function (error) {
          Severity: Major
          Found in public_html/layouts/basic/modules/Settings/Menu/resources/Menu.js and 1 other location - About 1 hr to fix
          public_html/layouts/basic/modules/Vtiger/resources/Edit.js on lines 435..441

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status