YetiForceCompany/YetiForceCRM

View on GitHub
public_html/layouts/basic/modules/Settings/ModuleManager/resources/ModuleManager.js

Summary

Maintainability
C
1 day
Test Coverage

Function registerEvents has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        registerEvents: function (e) {
            var thisInstance = this;
            var container = jQuery('#moduleManagerContents');
            container.find('.createModule').on('click', thisInstance.createModule);
            var scrollbar = container.find('.js-scrollbar');

    Function deleteModule has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            deleteModule: function (container) {
                const self = this;
                container.on('click', '.deleteModule', function () {
                    let forModule = $(this).attr('name');
                    app.showConfirmModal({

      Function validateModuleName has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              validateModuleName(field, rules, i, options) {
                  let returnVal = false;
                  const progressIndicatorElement = jQuery.progressIndicator();
                  AppConnector.request({
                      async: false,

        Function updateModuleStatus has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                updateModuleStatus: function (currentTarget) {
                    var aDeferred = jQuery.Deferred();
                    var forModule = currentTarget.data('module');
                    var status = currentTarget.is(':checked');
        
        

          Identical blocks of code found in 4 locations. Consider refactoring.
          Open

                      AppConnector.request(params)
                          .done(function (data) {
                              progressIndicatorElement.progressIndicator({ mode: 'hide' });
                              aDeferred.resolve(data);
                          })
          public_html/layouts/basic/modules/Settings/ModuleManager/resources/ModuleImport.js on lines 39..47
          public_html/layouts/basic/modules/Settings/WidgetsManagement/resources/WidgetsManagement.js on lines 151..159
          public_html/layouts/basic/modules/Vtiger/resources/DashBoard.js on lines 501..509

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 8 locations. Consider refactoring.
          Open

                      AppConnector.request({
                          module: app.getModuleName(),
                          parent: app.getParentModuleName(),
                          action: 'Basic',
                          mode: 'createModule',
          public_html/layouts/basic/modules/CustomView/resources/CustomView.js on lines 334..347
          public_html/layouts/basic/modules/Settings/Countries/resources/Index.js on lines 109..134
          public_html/layouts/basic/modules/Settings/InterestsConflict/resources/Index.js on lines 51..63
          public_html/layouts/basic/modules/Settings/Mail/resources/List.js on lines 14..25
          public_html/layouts/basic/modules/Settings/PublicHoliday/resources/PublicHoliday.js on lines 271..285
          public_html/layouts/basic/modules/Settings/RecordNumbering/resources/Index.js on lines 110..127
          public_html/layouts/basic/modules/Vtiger/resources/Detail.js on lines 156..165

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status