Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
public_html/layouts/basic/modules/Settings/Profiles/resources/Profiles.js

Summary

Maintainability
F
6 days
Test Coverage

File Profiles.js has 354 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*+*******************************************************************************
 * The contents of this file are subject to the vtiger CRM Public License Version 1.0
 * ("License"); You may not use this file except in compliance with the License
 * The Original Code is:  vtiger CRM Open Source
 * The Initial Developer of the Original Code is vtiger.
Severity: Minor
Found in public_html/layouts/basic/modules/Settings/Profiles/resources/Profiles.js - About 4 hrs to fix

    Function initEditView has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

        initEditView: function () {
        function toggleEditViewTableRow(e) {
            var target = jQuery(e.currentTarget);
            var container = jQuery('[data-togglecontent="' + target.data('togglehandler') + '"]');
            var closestTrElement = container.closest('tr');
    Severity: Minor
    Found in public_html/layouts/basic/modules/Settings/Profiles/resources/Profiles.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function initEditView has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        initEditView: function () {
        function toggleEditViewTableRow(e) {
            var target = jQuery(e.currentTarget);
            var container = jQuery('[data-togglecontent="' + target.data('togglehandler') + '"]');
            var closestTrElement = container.closest('tr');
    Severity: Major
    Found in public_html/layouts/basic/modules/Settings/Profiles/resources/Profiles.js - About 3 hrs to fix

      Function registerSubmitEvent has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          registerSubmitEvent: function () {
        var thisInstance = this;
        var form = jQuery('[name="EditProfile"]');
        form.on('submit', function (e) {
            let button = form.find('button[type="submit"]'),
      Severity: Minor
      Found in public_html/layouts/basic/modules/Settings/Profiles/resources/Profiles.js - About 1 hr to fix

        Function registerSelectAllModulesEvent has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            registerSelectAllModulesEvent: function () {
        var moduleCheckBoxes = jQuery('.modulesCheckBox');
        var viewAction = jQuery('#mainAction4CheckBox');
        var editAction = jQuery('#mainAction1CheckBox');
        var deleteAction = jQuery('#mainAction2CheckBox');
        Severity: Minor
        Found in public_html/layouts/basic/modules/Settings/Profiles/resources/Profiles.js - About 1 hr to fix

          Function registerGlobalPermissionActionsEvent has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              registerGlobalPermissionActionsEvent: function () {
        var editAllAction = jQuery('[name="editall"]').filter(':checkbox');
        var viewAllAction = jQuery('[name="viewall"]').filter(':checkbox');

        if (editAllAction.is(':checked')) {
          Severity: Minor
          Found in public_html/layouts/basic/modules/Settings/Profiles/resources/Profiles.js - About 1 hr to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                registerSelectAllDeleteActionsEvent: function () {
        var modulesMainCheckBox = jQuery('#mainModulesCheckBox');
        var mainViewActionCheckBox = jQuery('#mainAction4CheckBox');
        var deleteActionCheckBoxes = jQuery('.action2CheckBox');
        var mainDeleteActionCheckBox = jQuery('#mainAction2CheckBox');
            Severity: Major
            Found in public_html/layouts/basic/modules/Settings/Profiles/resources/Profiles.js and 2 other locations - About 7 hrs to fix
            public_html/layouts/basic/modules/Settings/Profiles/resources/Profiles.js on lines 172..190
            public_html/layouts/basic/modules/Settings/Profiles/resources/Profiles.js on lines 212..230

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 191.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                registerSelectAllEditActionsEvent: function () {
        var modulesMainCheckBox = jQuery('#mainModulesCheckBox');
        var mainViewActionCheckBox = jQuery('#mainAction4CheckBox');
        var editActionCheckBoxes = jQuery('.action1CheckBox');
        var mainEditActionCheckBox = jQuery('#mainAction1CheckBox');
            Severity: Major
            Found in public_html/layouts/basic/modules/Settings/Profiles/resources/Profiles.js and 2 other locations - About 7 hrs to fix
            public_html/layouts/basic/modules/Settings/Profiles/resources/Profiles.js on lines 192..210
            public_html/layouts/basic/modules/Settings/Profiles/resources/Profiles.js on lines 212..230

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 191.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                registerSelectAllCreateActionsEvent: function () {
        var modulesMainCheckBox = jQuery('#mainModulesCheckBox');
        var mainViewActionCheckBox = jQuery('#mainAction4CheckBox');
        var createActionCheckBoxes = jQuery('.action7CheckBox');
        var mainCreateActionCheckBox = jQuery('#mainAction7CheckBox');
            Severity: Major
            Found in public_html/layouts/basic/modules/Settings/Profiles/resources/Profiles.js and 2 other locations - About 7 hrs to fix
            public_html/layouts/basic/modules/Settings/Profiles/resources/Profiles.js on lines 172..190
            public_html/layouts/basic/modules/Settings/Profiles/resources/Profiles.js on lines 192..210

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 191.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    viewAllAction.on('change', function (e) {
            var currentTarget = jQuery(e.currentTarget);
            if (currentTarget.attr('readonly') == 'readonly') {
                var status = jQuery(e.currentTarget).is(':checked');
                if (!status) {
            Severity: Major
            Found in public_html/layouts/basic/modules/Settings/Profiles/resources/Profiles.js and 1 other location - About 4 hrs to fix
            public_html/layouts/basic/modules/Settings/LayoutEditor/resources/LayoutEditor.js on lines 1707..1718

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 129.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    AppConnector.request(params)
            .done(function (data) {
                var response = data['result'];
                var result = response['success'];
                if (result == true) {
            Severity: Major
            Found in public_html/layouts/basic/modules/Settings/Profiles/resources/Profiles.js and 2 other locations - About 3 hrs to fix
            public_html/layouts/basic/modules/Settings/Roles/resources/Roles.js on lines 228..240
            public_html/layouts/basic/modules/Settings/Vtiger/resources/Tax.js on lines 215..227

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 111.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    var params = {
            module: app.getModuleName(),
            parent: app.getParentModuleName(),
            action: 'EditAjax',
            mode: 'checkDuplicate',
            Severity: Minor
            Found in public_html/layouts/basic/modules/Settings/Profiles/resources/Profiles.js and 1 other location - About 50 mins to fix
            public_html/layouts/basic/modules/Settings/Password/resources/Password.js on lines 17..24

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    checkBoxElement.each(function (index, element) {
            if (jQuery(element).is(':checked')) {
                state = true;
            } else {
                state = false;
            Severity: Minor
            Found in public_html/layouts/basic/modules/Settings/Profiles/resources/Profiles.js and 1 other location - About 40 mins to fix
            public_html/layouts/basic/modules/Vtiger/resources/List.js on lines 750..757

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status