Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
public_html/layouts/basic/modules/Settings/TreesManager/resources/Edit.js

Summary

Maintainability
D
1 day
Test Coverage

Function createTree has 118 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        createTree: function () {
            const self = this;
            if (!this.jstreeInstance) {
                self.jstreeLastID = parseInt($('#treeLastID').val());
                let treeValues = $('#treeValues').val(),
Severity: Major
Found in public_html/layouts/basic/modules/Settings/TreesManager/resources/Edit.js - About 4 hrs to fix

    Function deleteItemEvent has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            deleteItemEvent: function (id, inst) {
            let self = this,
                aDeferred = jQuery.Deferred(),
                data = inst.get_json();
            $.each(id, function (_index, e) {
    Severity: Major
    Found in public_html/layouts/basic/modules/Settings/TreesManager/resources/Edit.js - About 2 hrs to fix

      Function registerEvents has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              registerEvents: function () {
            const self = this,
                editContainer = $('#EditView'),
                jstreeInstance = self.createTree();
            editContainer.validationEngine();
      Severity: Minor
      Found in public_html/layouts/basic/modules/Settings/TreesManager/resources/Edit.js - About 1 hr to fix

        Function createTree has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

                createTree: function () {
            const self = this;
            if (!this.jstreeInstance) {
                self.jstreeLastID = parseInt($('#treeLastID').val());
                let treeValues = $('#treeValues').val(),
        Severity: Minor
        Found in public_html/layouts/basic/modules/Settings/TreesManager/resources/Edit.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function checkChildren has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

                checkChildren: function (id, data) {
            let self = this,
                dataNew = [];
            for (let key in data) {
                if (data[key].id != id) {
        Severity: Minor
        Found in public_html/layouts/basic/modules/Settings/TreesManager/resources/Edit.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                    rename: {
                                label: app.vtranslate('JS_JSTREE_RENAME'),
                                action: function (data) {
                                    let treeInstance = $.jstree.reference(data.reference),
                                        selectedNode = treeInstance.get_node(data.reference);
        Severity: Major
        Found in public_html/layouts/basic/modules/Settings/TreesManager/resources/Edit.js and 1 other location - About 2 hrs to fix
        public_html/layouts/basic/modules/Settings/TreesManager/resources/Edit.js on lines 159..166

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 81.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                            paste: {
                                        label: app.vtranslate('JS_JSTREE_PASTE'),
                                        action: function (data) {
                                            let treeInstance = $.jstree.reference(data.reference),
                                                selectedNode = treeInstance.get_node(data.reference);
        Severity: Major
        Found in public_html/layouts/basic/modules/Settings/TreesManager/resources/Edit.js and 1 other location - About 2 hrs to fix
        public_html/layouts/basic/modules/Settings/TreesManager/resources/Edit.js on lines 95..102

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 81.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (data.length == 0) {
                Settings_Vtiger_Index_Js.showMessage({
                    text: app.vtranslate('JS_YOU_CANNOT_DELETE_ALL_THE_ITEMS'),
                    type: 'error'
                });
        Severity: Minor
        Found in public_html/layouts/basic/modules/Settings/TreesManager/resources/Edit.js and 1 other location - About 55 mins to fix
        public_html/layouts/resources/libraries/ckeditor/base64image/dialogs/dialog.js on lines 114..121

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status