Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
public_html/layouts/basic/modules/Vtiger/resources/ChangesJsonModal.js

Summary

Maintainability
D
2 days
Test Coverage

Function registerSelectField has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        registerSelectField: function () {
            let editInstance = Vtiger_Edit_Js.getInstance(this.module);
            let form = this.container.find('form');
            this.container.find('.js-changesjson-select').on('change', (e) => {
                let element = $(e.currentTarget);
Severity: Minor
Found in public_html/layouts/basic/modules/Vtiger/resources/ChangesJsonModal.js - About 1 hr to fix

    Function inactiveFieldsValidation has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

            inactiveFieldsValidation: function () {
            let editFieldList = this.container.find('.js-edit-field-list').data('value');
            let form = this.container.find('form');
            for (let fieldName in editFieldList) {
                let fieldInfo = editFieldList[fieldName];
    Severity: Minor
    Found in public_html/layouts/basic/modules/Vtiger/resources/ChangesJsonModal.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            inactiveFieldValidation: function (field) {
            field.validationEngine('hide');
            let form = field.closest('form');
            let invalidFields = form.data('jqv').InvalidFields;
            let fields = [field.get(0)];
    Severity: Major
    Found in public_html/layouts/basic/modules/Vtiger/resources/ChangesJsonModal.js and 1 other location - About 1 day to fix
    public_html/layouts/basic/modules/Vtiger/resources/List.js on lines 875..894

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 229.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    if (fieldInfo !== undefined && fieldInfo.type === 'reference') {
                    let mapFields = editInstance.getMappingRelatedField(
                        fieldInfo.name,
                        editInstance.getReferencedModuleName(blockElement),
                        form
    Severity: Major
    Found in public_html/layouts/basic/modules/Vtiger/resources/ChangesJsonModal.js and 1 other location - About 5 hrs to fix
    public_html/layouts/basic/modules/Vtiger/resources/List.js on lines 914..928

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 152.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                this.container.on('click', 'a[data-toggle="tab"]', function (e) {
                form.validationEngine('validate');
                let invalidFields = form.data('jqv').InvalidFields;
                if (invalidFields.length > 0) {
                    e.stopPropagation();
    Severity: Major
    Found in public_html/layouts/basic/modules/Vtiger/resources/ChangesJsonModal.js and 1 other location - About 1 hr to fix
    public_html/layouts/basic/modules/Vtiger/resources/List.js on lines 1719..1725

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            activeFieldValidation: function (field) {
            let validationVal = field.attr('data-invalid-validation-engine');
            if (typeof validationVal === 'undefined') return;
            field.attr('data-validation-engine', validationVal);
            field.removeAttr('data-invalid-validation-engine');
    Severity: Major
    Found in public_html/layouts/basic/modules/Vtiger/resources/ChangesJsonModal.js and 1 other location - About 1 hr to fix
    public_html/layouts/basic/modules/Vtiger/resources/List.js on lines 895..900

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                    if (fieldInfo.type == 'reference') {
                    fieldElement = form.find('[name="' + fieldInfo.name + '_display"]');
                } else if (fieldInfo.type == 'multipicklist' || fieldInfo.type == 'sharedOwner') {
                    fieldElement = form.find('[name="' + fieldInfo.name + '[]"]');
                }
    Severity: Major
    Found in public_html/layouts/basic/modules/Vtiger/resources/ChangesJsonModal.js and 1 other location - About 1 hr to fix
    public_html/layouts/basic/modules/Vtiger/resources/List.js on lines 1696..1701

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status