Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
public_html/layouts/resources/Calendar.js

Summary

Maintainability
F
6 days
Test Coverage

File Calendar.js has 745 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* {[The file is published on the basis of YetiForce Public License 6.5 that can be found in the following directory: licenses/LicenseEN.txt or yetiforce.com]} */
'use strict';

/** Class representing a calendar. */
window.Calendar_Js = class {
Severity: Major
Found in public_html/layouts/resources/Calendar.js - About 1 day to fix

    Calendar_Js has 32 functions (exceeds 20 allowed). Consider refactoring.
    Open

    window.Calendar_Js = class {
    static monthFormat = {
        'yyyy-mm-dd': 'YYYY-MMMM',
        'mm-dd-yyyy': 'MMMM-YYYY',
        'dd-mm-yyyy': 'MMMM-YYYY',
    Severity: Minor
    Found in public_html/layouts/resources/Calendar.js - About 4 hrs to fix

      Function selectCallbackCreateModal has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          selectCallbackCreateModal(modal, info) {
        let startDate = info.start,
            endDate = info.end;
        if (info['allDay']) {
            endDate.setDate(endDate.getDate() - 1);
      Severity: Minor
      Found in public_html/layouts/resources/Calendar.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function setCalendarBasicOptions has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          setCalendarBasicOptions() {
        let eventLimit = app.getMainParams('eventLimit'),
            userView = app.getMainParams('activity_view'),
            defaultView = app.moduleCacheGet('defaultView'),
            userTimeFormat = CONFIG.hourFormat;
      Severity: Major
      Found in public_html/layouts/resources/Calendar.js - About 2 hrs to fix

        Function getDefaultParams has 59 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            getDefaultParams() {
        const users = app.moduleCacheGet('calendar-users') || CONFIG.userId,
            sideBar = this.getSidebarView();
        let filters = [],
            params = {
        Severity: Major
        Found in public_html/layouts/resources/Calendar.js - About 2 hrs to fix

          Function setCalendarAdvancedOptions has 53 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              setCalendarAdvancedOptions() {
        const self = this;
        return {
            editable: !this.readonly && this.eventEdit == 1,
            selectable: !this.readonly && this.eventCreate == 1,
          Severity: Major
          Found in public_html/layouts/resources/Calendar.js - About 2 hrs to fix

            Function selectCallbackCreateModal has 49 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                selectCallbackCreateModal(modal, info) {
        let startDate = info.start,
            endDate = info.end;
        if (info['allDay']) {
            endDate.setDate(endDate.getDate() - 1);
            Severity: Minor
            Found in public_html/layouts/resources/Calendar.js - About 1 hr to fix

              Function setCalendarBasicOptions has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
              Open

                  setCalendarBasicOptions() {
        let eventLimit = app.getMainParams('eventLimit'),
            userView = app.getMainParams('activity_view'),
            defaultView = app.moduleCacheGet('defaultView'),
            userTimeFormat = CONFIG.hourFormat;
              Severity: Minor
              Found in public_html/layouts/resources/Calendar.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function registerFilterForm has 47 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  registerFilterForm(container) {
        const self = this;
        if (container.find('.js-filter__search').length) {
            container.find('.js-filter__search').on('keyup', this.findElementOnList.bind(self));
        }
              Severity: Minor
              Found in public_html/layouts/resources/Calendar.js - About 1 hr to fix

                Function setCalendarMinimalOptions has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    setCalendarMinimalOptions() {
        let hiddenDays = [];
        if (app.getMainParams('switchingDays') === 'workDays') {
            hiddenDays = app.getMainParams('hiddenDays', true);
        }
                Severity: Minor
                Found in public_html/layouts/resources/Calendar.js - About 1 hr to fix

                  Function setBrowserHistoryOptions has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      setBrowserHistoryOptions() {
        const historyParams = app.getMainParams('historyParams', true);
        let options = {};
        if (historyParams && (historyParams.length || Object.keys(historyParams).length)) {
            let s = App.Fields.Date.getDateInstance(historyParams.start);
                  Severity: Minor
                  Found in public_html/layouts/resources/Calendar.js - About 1 hr to fix

                    Function registerSelect2Event has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        registerSelect2Event() {
        const self = this;
        $('.siteBarRight .js-calendar__filter__select').each(function () {
            let element = $(this);
            let name = element.data('cache');
                    Severity: Minor
                    Found in public_html/layouts/resources/Calendar.js - About 1 hr to fix

                      Function formatDate has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          formatDate(startDate, endDate, type) {
        switch (type) {
            case 'month':
                return Calendar_Js.monthFormat[CONFIG.dateFormat]
                    .replace('YYYY', startDate['year'])
                      Severity: Minor
                      Found in public_html/layouts/resources/Calendar.js - About 1 hr to fix

                        Function updateEvent has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            updateEvent(info) {
        const progressInstance = jQuery.progressIndicator({ blockInfo: { enabled: true } });
        AppConnector.request({
            module: this.module ? this.module : CONFIG.module,
            action: 'Calendar',
                        Severity: Minor
                        Found in public_html/layouts/resources/Calendar.js - About 1 hr to fix

                          Function constructor has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              constructor(container = $('.js-base-container'), readonly = false, browserHistory = true) {
        this.calendarCreateView = false;
        this.container = container;
        this.calendarView = container.find('.js-calendar__container');
        this.readonly = readonly;
                          Severity: Minor
                          Found in public_html/layouts/resources/Calendar.js - About 1 hr to fix

                            Function setBrowserHistoryOptions has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                            Open

                                setBrowserHistoryOptions() {
        const historyParams = app.getMainParams('historyParams', true);
        let options = {};
        if (historyParams && (historyParams.length || Object.keys(historyParams).length)) {
            let s = App.Fields.Date.getDateInstance(historyParams.start);
                            Severity: Minor
                            Found in public_html/layouts/resources/Calendar.js - About 55 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                        } else if (element.length > 0 && cachedValue === undefined && !element.find(':selected').length) {
                let allOptions = [];
                element.find('option').each((_i, option) => {
                    allOptions.push($(option).val());
                });
                            Severity: Major
                            Found in public_html/layouts/resources/Calendar.js and 1 other location - About 2 hrs to fix
                            public_html/layouts/resources/Calendar.js on lines 577..590

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 83.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                        } else if (
                name &&
                element.length > 0 &&
                cachedValue === undefined &&
                !element.find(':selected').length &&
                            Severity: Major
                            Found in public_html/layouts/resources/Calendar.js and 1 other location - About 2 hrs to fix
                            public_html/layouts/resources/Calendar.js on lines 698..705

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 83.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                        .fail(function () {
                progressInstance.progressIndicator({ mode: 'hide' });
                app.showNotify({
                    text: app.vtranslate('JS_NO_EDIT_PERMISSION'),
                    type: 'error'
                            Severity: Major
                            Found in public_html/layouts/resources/Calendar.js and 1 other location - About 1 hr to fix
                            public_html/layouts/basic/modules/Vtiger/resources/Detail.js on lines 1907..1914

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 61.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                            for (let i in activityDurations) {
                    if (activityDurations[i].activitytype === activityType) {
                        minutes = parseInt(activityDurations[i].duration);
                        break;
                    }
                            Severity: Minor
                            Found in public_html/layouts/resources/Calendar.js and 1 other location - About 50 mins to fix
                            public_html/layouts/basic/modules/Calendar/resources/Edit.js on lines 129..134

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 52.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 8 locations. Consider refactoring.
                            Open

                                        element.find('.js-filter__item__val:checked').each(function () {
                filters.push($(this).val());
            });
                            Severity: Major
                            Found in public_html/layouts/resources/Calendar.js and 7 other locations - About 35 mins to fix
                            public_html/layouts/basic/modules/Settings/TwoFactorAuthentication/resources/Index.js on lines 57..59
                            public_html/layouts/basic/modules/Settings/Wapro/resources/List.js on lines 51..53
                            public_html/layouts/basic/modules/Settings/WidgetsManagement/resources/WidgetsManagement.js on lines 206..208
                            public_html/layouts/basic/modules/Vtiger/resources/Detail.js on lines 2101..2103
                            public_html/layouts/basic/modules/Vtiger/resources/Detail.js on lines 2139..2141
                            public_html/layouts/basic/modules/Vtiger/resources/Detail.js on lines 2143..2145
                            public_html/layouts/basic/modules/Vtiger/resources/PDF.js on lines 64..66

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 46.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status