Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
public_html/layouts/resources/libraries/jstree.edit.js

Summary

Maintainability
C
1 day
Test Coverage

Function edit has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    $.jstree.plugins.edit = function (options, parent) {
        this.bind = function () {
            parent.bind.call(this);
            this.element.on(
                'select_node.jstree',
Severity: Major
Found in public_html/layouts/resources/libraries/jstree.edit.js - About 3 hrs to fix

    Function bind has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            this.bind = function () {
            parent.bind.call(this);
            this.element.on(
                'select_node.jstree',
                $.proxy(function (obj, data) {
    Severity: Minor
    Found in public_html/layouts/resources/libraries/jstree.edit.js - About 1 hr to fix

      Function redraw_node has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              this.redraw_node = function (obj, deep, is_callback, force_render) {
            obj = parent.redraw_node.apply(this, arguments);
            if (obj) {
                var i,
                    j,
      Severity: Minor
      Found in public_html/layouts/resources/libraries/jstree.edit.js - About 1 hr to fix

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

                        for (i = 0, j = obj.childNodes.length; i < j; i++) {
                    if (
                        obj.childNodes[i] &&
                        obj.childNodes[i].className &&
                        obj.childNodes[i].className.indexOf('jstree-anchor') !== -1
        Severity: Major
        Found in public_html/layouts/resources/libraries/jstree.edit.js and 2 other locations - About 3 hrs to fix
        public_html/layouts/resources/libraries/jstree.category.js on lines 58..67
        public_html/layouts/resources/libraries/jstree.checkbox.js on lines 521..530

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        (function (factory) {
    'use strict';
    if (typeof define === 'function' && define.amd) {
        define('jstree.edit', ['jquery', 'jstree'], factory);
    } else if (typeof exports === 'object') {
        Severity: Major
        Found in public_html/layouts/resources/libraries/jstree.edit.js and 2 other locations - About 2 hrs to fix
        public_html/layouts/resources/libraries/jstree.category.js on lines 3..298
        public_html/layouts/resources/libraries/jstree.checkbox.js on lines 3..1023

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 86.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status