YiiRocks/svg-inline-fontawesome

View on GitHub

Showing 1 of 1 total issue

The method __construct has a boolean flag argument $registerAssets, which is a certain sign of a Single Responsibility Principle violation.
Open

        bool $registerAssets = false
Severity: Minor
Found in src/SvgInlineFontAwesome.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Severity
Category
Status
Source
Language